Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-28 Thread Russell King - ARM Linux
On Tue, May 19, 2009 at 11:55:41AM -0700, Kevin Hilman wrote: > Russell King - ARM Linux writes: > > > On Mon, May 18, 2009 at 10:00:44AM -0700, Kevin Hilman wrote: > >> Russell King - ARM Linux writes: > >> > >> > On Fri, May 15, 2009 at 11:40:41AM -0700, Kevin Hilman wrote: > >> >> This patch

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-19 Thread Kevin Hilman
Russell King - ARM Linux writes: > On Mon, May 18, 2009 at 10:00:44AM -0700, Kevin Hilman wrote: >> Russell King - ARM Linux writes: >> >> > On Fri, May 15, 2009 at 11:40:41AM -0700, Kevin Hilman wrote: >> >> This patch is to sync the core linux-omap PM code with mainline. This >> >> code has

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-19 Thread Kevin Hilman
Artem Bityutskiy writes: > Kevin Hilman wrote: >>> The problem here is that such an interface is extremely fragile. Consider >>> what happens if a program disables HLT, and then gets killed off for some >>> reason. How does this reference get balanced again? >>> >>> I think a better solution wo

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Artem Bityutskiy
Kevin Hilman wrote: The problem here is that such an interface is extremely fragile. Consider what happens if a program disables HLT, and then gets killed off for some reason. How does this reference get balanced again? I think a better solution would be a char device driver which has to be ke

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Kevin Hilman
Russell King - ARM Linux writes: > On Mon, May 18, 2009 at 02:04:19PM -0500, Woodruff, Richard wrote: >> cpu_init() is not yet accessible at the point this code is running. > > Not at that _exact_ point, but there's no need what so ever for it > to be at that exact point. There's nothing stoppin

RE: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Woodruff, Richard
> From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] > Sent: Monday, May 18, 2009 4:11 PM > On Mon, May 18, 2009 at 03:47:31PM -0500, Woodruff, Richard wrote: > > The code flow is: > > - Wakeup event > > - ARM reboots and uses SOC mask ROM context restore helper > >

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Russell King - ARM Linux
On Mon, May 18, 2009 at 03:47:31PM -0500, Woodruff, Richard wrote: > The code flow is: > - Wakeup event > - ARM reboots and uses SOC mask ROM context restore helper > - Mask ROM code jump to restore pointers with MMU OFF. > - Restore code resets ARM CortexA8 state >

RE: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Woodruff, Richard
> From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] > Sent: Monday, May 18, 2009 3:25 PM > The call to the enter method essentially calls the core specific suspend > function (eg, pxa25x_cpu_suspend()), which is an assembly function which > ultimately ends up powering down the core r

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Russell King - ARM Linux
On Mon, May 18, 2009 at 02:04:19PM -0500, Woodruff, Richard wrote: > cpu_init() is not yet accessible at the point this code is running. Not at that _exact_ point, but there's no need what so ever for it to be at that exact point. There's nothing stopping a call to cpu_init() happening later. Mu

RE: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Woodruff, Richard
> From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Monday, May 18, 2009 12:09 PM > To: Russell King - ARM Linux; Woodruff, Richard > > There is a function which re-initializes the abort mode registers already - > > cpu_init(). Please use that if possible instead. > > Upon a quick

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Russell King - ARM Linux
On Mon, May 18, 2009 at 10:08:36AM -0700, Kevin Hilman wrote: > [ adding Richard W. to To: since he can probably shed some light here ] > > Russell King - ARM Linux writes: > > > On Fri, May 15, 2009 at 11:40:41AM -0700, Kevin Hilman wrote: > >> This patch is to sync the core linux-omap PM code

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Kevin Hilman
Russell King - ARM Linux writes: > On Mon, May 18, 2009 at 10:00:44AM -0700, Kevin Hilman wrote: >> Russell King - ARM Linux writes: >> >> > On Fri, May 15, 2009 at 11:40:41AM -0700, Kevin Hilman wrote: >> >> This patch is to sync the core linux-omap PM code with mainline. This >> >> code has

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Kevin Hilman
[ adding Richard W. to To: since he can probably shed some light here ] Russell King - ARM Linux writes: > On Fri, May 15, 2009 at 11:40:41AM -0700, Kevin Hilman wrote: >> This patch is to sync the core linux-omap PM code with mainline. This >> code has evolved and been used for a while the lin

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Russell King - ARM Linux
On Mon, May 18, 2009 at 10:00:44AM -0700, Kevin Hilman wrote: > Russell King - ARM Linux writes: > > > On Fri, May 15, 2009 at 11:40:41AM -0700, Kevin Hilman wrote: > >> This patch is to sync the core linux-omap PM code with mainline. This > >> code has evolved and been used for a while the linu

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Kevin Hilman
Russell King - ARM Linux writes: > On Fri, May 15, 2009 at 11:40:41AM -0700, Kevin Hilman wrote: >> This patch is to sync the core linux-omap PM code with mainline. This >> code has evolved and been used for a while the linux-omap tree, but >> the attempt here is to finally get this into mainlin

Re: [PATCH 01/11] OMAP2/3: PM: push core PM code from linux-omap

2009-05-18 Thread Russell King - ARM Linux
On Fri, May 15, 2009 at 11:40:41AM -0700, Kevin Hilman wrote: > This patch is to sync the core linux-omap PM code with mainline. This > code has evolved and been used for a while the linux-omap tree, but > the attempt here is to finally get this into mainline. > > Following this will be a series