Re: [PATCH 2/4] ARM: OMAP5: clockdomain data: add init file for omap54xx

2013-07-08 Thread Tero Kristo
On 06/29/2013 12:03 AM, Mike Turquette wrote: Quoting Tero Kristo (2013-06-27 01:38:17) cclock54xx_data.c now contains only init function and the clkdev mapping that is still needed by some drivers. Eventually most of this file can be removed, once a common location for the clk init can be found

Re: [PATCH 2/4] ARM: OMAP5: clockdomain data: add init file for omap54xx

2013-06-28 Thread Mike Turquette
Quoting Tero Kristo (2013-06-27 01:38:17) > cclock54xx_data.c now contains only init function and the clkdev mapping > that is still needed by some drivers. Eventually most of this file can > be removed, once a common location for the clk init can be found, and > the clkdev mapping is no longer nee

Re: [PATCH 2/4] ARM: OMAP5: clockdomain data: add init file for omap54xx

2013-06-27 Thread Felipe Balbi
HI, On Thu, Jun 27, 2013 at 12:24:25PM +0300, Tero Kristo wrote: > On 06/27/2013 11:44 AM, Felipe Balbi wrote: > >Hi, > > > >On Thu, Jun 27, 2013 at 11:38:17AM +0300, Tero Kristo wrote: > >>+ rc = clk_set_parent(abe_dpll_ref, sys_32k_ck); > >>+ abe_dpll = clk_get_sys(NULL, "dpll_abe_ck"); > >

Re: [PATCH 2/4] ARM: OMAP5: clockdomain data: add init file for omap54xx

2013-06-27 Thread Tero Kristo
On 06/27/2013 11:44 AM, Felipe Balbi wrote: Hi, On Thu, Jun 27, 2013 at 11:38:17AM +0300, Tero Kristo wrote: + rc = clk_set_parent(abe_dpll_ref, sys_32k_ck); + abe_dpll = clk_get_sys(NULL, "dpll_abe_ck"); should these two lines be swaped ? No, its a different clock. clk_set_pare

Re: [PATCH 2/4] ARM: OMAP5: clockdomain data: add init file for omap54xx

2013-06-27 Thread Felipe Balbi
Hi, On Thu, Jun 27, 2013 at 11:38:17AM +0300, Tero Kristo wrote: > + rc = clk_set_parent(abe_dpll_ref, sys_32k_ck); > + abe_dpll = clk_get_sys(NULL, "dpll_abe_ck"); should these two lines be swaped ? > + if (!rc) > + rc = clk_set_rate(abe_dpll, OMAP5_DPLL_ABE_DEFFREQ); >

[PATCH 2/4] ARM: OMAP5: clockdomain data: add init file for omap54xx

2013-06-27 Thread Tero Kristo
cclock54xx_data.c now contains only init function and the clkdev mapping that is still needed by some drivers. Eventually most of this file can be removed, once a common location for the clk init can be found, and the clkdev mapping is no longer needed. Signed-off-by: Tero Kristo --- arch/arm/ma