RE: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-10 Thread Shilimkar, Santosh
> -Original Message- > From: Balbi, Felipe > Sent: Friday, September 10, 2010 6:04 PM > To: Shilimkar, Santosh > Cc: linux-omap@vger.kernel.org; Cousson, Benoit; t...@atomide.com; > khil...@deeprootsystems.com; Balbi, Felipe > Subject: Re: [PATCH 2/7] omap4: Temporar

Re: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-10 Thread Felipe Balbi
Hi, On Thu, Sep 09, 2010 at 08:24:12AM -0500, Shilimkar, Santosh wrote: Updated version attached. attaching is generally not a good idea, but if you do so, at least use .diff as extension (or .patch or .txt) so that most mutt users will see it dumped onto the messaged. I think that if you att

Re: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Jon Hunter
On 9/9/2010 7:47 AM, Cousson, Benoit wrote: On 9/9/2010 2:07 PM, Balbi, Felipe wrote: Hi Santosh, On Thu, Sep 09, 2010 at 07:02:46AM -0500, Shilimkar, Santosh wrote: Felipe is suggesting not to add this support where as you want to have this support. Sorry if I haven't understood the comment

RE: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Shilimkar, Santosh
tomide.com; > khil...@deeprootsystems.com > Subject: RE: [PATCH 2/7] omap4: Temporary fix silicon version detection > > > -Original Message- > > From: Balbi, Felipe > > Sent: Thursday, September 09, 2010 5:38 PM > > To: Shilimkar, Santosh > > Cc: Cousson,

RE: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Shilimkar, Santosh
> -Original Message- > From: Balbi, Felipe > Sent: Thursday, September 09, 2010 5:38 PM > To: Shilimkar, Santosh > Cc: Cousson, Benoit; Balbi, Felipe; linux-omap@vger.kernel.org; > t...@atomide.com; khil...@deeprootsystems.com > Subject: Re: [PATCH 2/7] omap4: Temporar

Re: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Cousson, Benoit
On 9/9/2010 2:07 PM, Balbi, Felipe wrote: Hi Santosh, On Thu, Sep 09, 2010 at 07:02:46AM -0500, Shilimkar, Santosh wrote: Felipe is suggesting not to add this support where as you want to have this support. Sorry if I haven't understood the comment. Care to clarify no, I suggested not to rev

Re: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Felipe Balbi
Hi Santosh, On Thu, Sep 09, 2010 at 07:02:46AM -0500, Shilimkar, Santosh wrote: Felipe is suggesting not to add this support where as you want to have this support. Sorry if I haven't understood the comment. Care to clarify no, I suggested not to revert :-) So, just change the comment saying

RE: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Shilimkar, Santosh
> -Original Message- > From: Cousson, Benoit > Sent: Thursday, September 09, 2010 5:17 PM > To: Balbi, Felipe > Cc: Shilimkar, Santosh; linux-omap@vger.kernel.org; t...@atomide.com; > khil...@deeprootsystems.com > Subject: Re: [PATCH 2/7] omap4: Temporary fix sili

Re: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Cousson, Benoit
Hi Santosh, On 9/9/2010 1:42 PM, Felipe Balbi wrote: Hi, On Thu, Sep 09, 2010 at 06:23:10AM -0500, Santosh Shilimkar wrote: @@ -308,6 +308,16 @@ static void __init omap4_check_revision(void) hawkeye = (idcode>> 12)& 0x; rev = (idcode>> 28)& 0xff; + /* +*

Re: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Felipe Balbi
Hi, On Thu, Sep 09, 2010 at 06:23:10AM -0500, Santosh Shilimkar wrote: @@ -308,6 +308,16 @@ static void __init omap4_check_revision(void) hawkeye = (idcode >> 12) & 0x; rev = (idcode >> 28) & 0xff; + /* +* FIXME: This patch should be reverted later. +*

[PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Santosh Shilimkar
Few initial omap4 es2 samples IDCODE is same as es1. This patch uses ARM cpuid register to detect the ES version for such samples This patch can be reverted once all the samples gets replaced with new lot. Signed-off-by: Santosh Shilimkar --- arch/arm/mach-omap2/id.c | 10 ++ 1 files