From: ext Russell King - ARM Linux
Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
Date: Sat, 16 May 2009 11:55:14 +0200
> On Sat, May 16, 2009 at 10:20:36AM +0100, Russell King - ARM Linux wrote:
> > This looks all very convoluted. Why not do somet
From: ext Russell King - ARM Linux
Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
Date: Sat, 16 May 2009 11:55:14 +0200
> On Sat, May 16, 2009 at 10:20:36AM +0100, Russell King - ARM Linux wrote:
> > This looks all very convoluted. Why not do somet
From: ext Russell King - ARM Linux
Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
Date: Sat, 16 May 2009 11:55:14 +0200
> On Sat, May 16, 2009 at 10:20:36AM +0100, Russell King - ARM Linux wrote:
> > This looks all very convoluted. Why not do somet
Hi Russell,
From: ext Russell King - ARM Linux
Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
Date: Sat, 16 May 2009 11:20:36 +0200
> On Tue, May 05, 2009 at 03:47:00PM +0300, Hiroshi DOYU wrote:
> > +static struct resource omap3_iommu_res[] = {
> > + { /*
On Sat, May 16, 2009 at 12:54 PM, Russell King - ARM Linux
wrote:
> On Sat, May 16, 2009 at 12:38:23PM +0300, Felipe Contreras wrote:
>> On Sat, May 16, 2009 at 12:20 PM, Russell King - ARM Linux
>> wrote:
>> > On Tue, May 05, 2009 at 03:47:00PM +0300, Hiroshi DOYU wrote:
>> >> +static struct res
On Sat, May 16, 2009 at 10:20:36AM +0100, Russell King - ARM Linux wrote:
> This looks all very convoluted. Why not do something like:
>
> static unsigned long iommu_base[] = {
> OMAP3_MMU1_BASE,
> OMAP3_MMU2_BASE,
> };
>
> static int iommu_irq[] = {
> OMAP3_MMU1_IRQ,
> O
On Sat, May 16, 2009 at 12:38:23PM +0300, Felipe Contreras wrote:
> On Sat, May 16, 2009 at 12:20 PM, Russell King - ARM Linux
> wrote:
> > On Tue, May 05, 2009 at 03:47:00PM +0300, Hiroshi DOYU wrote:
> >> +static struct resource omap3_iommu_res[] = {
> >> + { /* Camera ISP MMU */
> >> +
On Sat, May 16, 2009 at 12:20 PM, Russell King - ARM Linux
wrote:
> On Tue, May 05, 2009 at 03:47:00PM +0300, Hiroshi DOYU wrote:
>> +static struct resource omap3_iommu_res[] = {
>> + { /* Camera ISP MMU */
>> + .start = OMAP3_MMU1_BASE,
>> + .end =
On Tue, May 05, 2009 at 03:47:00PM +0300, Hiroshi DOYU wrote:
> +static struct resource omap3_iommu_res[] = {
> + { /* Camera ISP MMU */
> + .start = OMAP3_MMU1_BASE,
> + .end= OMAP3_MMU1_BASE + MMU_REG_SIZE - 1,
> + .flags = IOR
On Fri, May 8, 2009 at 8:21 PM, Aguirre Rodriguez, Sergio Alberto
wrote:
> Hi,
>
> Just one comment below:
>
>> > Does the following make sense?
>> >
>> > +#define NR_IOMMU_RES 2
>> >
>> >
>> >
>> > + err = platform_device_add_resources(pdev,
>> > +
Hi,
Just one comment below:
> > Does the following make sense?
> >
> > +#define NR_IOMMU_RES 2
> >
> >
> >
> > + err = platform_device_add_resources(pdev,
> > + omap3_iommu_res + i * NR_IOMMU_RES,
> NR_IOMMU_RES);
>
> Yeap, also:
>
> > +
On Fri, May 8, 2009 at 7:10 AM, Hiroshi DOYU wrote:
> Hi Felipe,
>
> From: ext Felipe Contreras
> Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
> Date: Thu, 7 May 2009 22:05:00 +0200
>
>> On Tue, May 5, 2009 at 3:47 PM, Hiroshi DOYU wrote:
>>
Hi Felipe,
From: ext Felipe Contreras
Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
Date: Thu, 7 May 2009 22:05:00 +0200
> On Tue, May 5, 2009 at 3:47 PM, Hiroshi DOYU wrote:
> > Signed-off-by: Hiroshi DOYU
> > ---
> >
> > arch/arm/mach
On Tue, May 5, 2009 at 3:47 PM, Hiroshi DOYU wrote:
> Signed-off-by: Hiroshi DOYU
> ---
>
> arch/arm/mach-omap2/omap3-iommu.c | 105
> +
> 1 files changed, 105 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-omap2/omap3-iommu.c
>
> diff --g
On Wed, May 6, 2009 at 9:00 AM, Hiroshi DOYU wrote:
> From: ext Felipe Contreras
> Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
> Date: Tue, 5 May 2009 21:32:34 +0200
>
>> On Tue, May 5, 2009 at 3:47 PM, Hiroshi DOYU wrote:
>> >
From: ext Felipe Contreras
Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
Date: Tue, 5 May 2009 21:32:34 +0200
> On Tue, May 5, 2009 at 3:47 PM, Hiroshi DOYU wrote:
> > Signed-off-by: Hiroshi DOYU
> > ---
> >
> > arch/arm/mach
On Tue, May 5, 2009 at 3:47 PM, Hiroshi DOYU wrote:
> Signed-off-by: Hiroshi DOYU
> ---
>
> arch/arm/mach-omap2/omap3-iommu.c | 105
> +
> 1 files changed, 105 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-omap2/omap3-iommu.c
>
> diff --g
Signed-off-by: Hiroshi DOYU
---
arch/arm/mach-omap2/omap3-iommu.c | 105 +
1 files changed, 105 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/mach-omap2/omap3-iommu.c
diff --git a/arch/arm/mach-omap2/omap3-iommu.c
b/arch/arm/mach-omap2/omap3-io
From: ext Russell King - ARM Linux
Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
Date: Wed, 28 Jan 2009 11:41:57 +0100
> On Tue, Jan 27, 2009 at 11:29:35PM +0200, Hiroshi DOYU wrote:
> > I attached the update one.
>
> Thanks. I want to hold off on taki
On Tue, Jan 27, 2009 at 11:29:35PM +0200, Hiroshi DOYU wrote:
> I attached the update one.
Thanks. I want to hold off on taking these just a little bit longer.
> +static const struct iommu_platform_data omap3_iommu_pdata[] __initconst = {
> + {
> + .name = "isp",
> +
Hi Russell,
I attached the update one.
From: ext Russell King - ARM Linux
Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration
Date: Sat, 17 Jan 2009 17:21:39 +0100
> On Fri, Jan 16, 2009 at 10:37:20AM +0200, Hiroshi DOYU wrote:
> > +#include
>
> Is linux/io.h
On Fri, Jan 16, 2009 at 10:37:20AM +0200, Hiroshi DOYU wrote:
> +#include
Is linux/io.h needed, or will a more specific include be better?
> +#include
> +
> +#include
> +
> +#define DEVNAME "omap-iommu"
I'm not sure this DEVNAME definition really helps anything.
> +static void omap3_iommu_re
Signed-off-by: Hiroshi DOYU
---
arch/arm/mach-omap2/omap3-iommu.c | 111 +
1 files changed, 111 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/mach-omap2/omap3-iommu.c
diff --git a/arch/arm/mach-omap2/omap3-iommu.c
b/arch/arm/mach-omap2/omap3-io
23 matches
Mail list logo
