Re: [PATCH v3 11/14] omap: mailbox: only compile for configured archs

2010-05-24 Thread Felipe Contreras
On Mon, May 24, 2010 at 5:42 PM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Felipe Contreras felipe.contre...@gmail.com + if (false); nitpcik: The above may look better as below:        if (false)                ; checkpatch.pl also doesn't complain. Personally I think it

Re: [PATCH v3 11/14] omap: mailbox: only compile for configured archs

2010-05-24 Thread Russell King - ARM Linux
On Mon, May 24, 2010 at 10:29:01PM +0300, Felipe Contreras wrote: On Mon, May 24, 2010 at 5:42 PM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Felipe Contreras felipe.contre...@gmail.com + if (false); nitpcik: The above may look better as below:        if (false)    

[PATCH v3 11/14] omap: mailbox: only compile for configured archs

2010-05-22 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- arch/arm/mach-omap2/mailbox.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c index f55fa84..1f0c5cd 100644 ---