* Mohammed, Afzal af...@ti.com [120613 06:56]:
Hi Tony,
On Wed, Jun 13, 2012 at 19:20:35, Mohammed, Afzal wrote:
Hi Tony,
On Wed, Jun 13, 2012 at 19:14:08, Tony Lindgren wrote:
Actually why do you even need to store the revision? You can
just read it from the hardware as
Hi Tony,
On Thu, Jun 14, 2012 at 12:05:25, Tony Lindgren wrote:
* Mohammed, Afzal af...@ti.com [120613 06:56]:
Or you meant, even there read revision register ?
Yeah that should be fine as this really should only happen
during init and whatever revision specific features can
be
* Mohammed, Afzal af...@ti.com [120613 23:44]:
Hi Tony,
On Thu, Jun 14, 2012 at 12:05:25, Tony Lindgren wrote:
* Mohammed, Afzal af...@ti.com [120613 06:56]:
Or you meant, even there read revision register ?
Yeah that should be fine as this really should only happen
during init
Hi Tony,
On Thu, Jun 14, 2012 at 14:09:58, Tony Lindgren wrote:
* Mohammed, Afzal af...@ti.com [120613 23:44]:
Sorry, I got confused, we need revision to be available while setting
time also, so you meant to store it as a variable or read revision
at probe as well as during setting time ?
Hi Jon,
On Wed, Jun 13, 2012 at 00:49:22, Hunter, Jon wrote:
On 06/11/2012 09:26 AM, Afzal Mohammed wrote:
clk_enable(gpmc_l3_clk);
We should be able to get rid of the clk_enable() here and use ...
pm_runtime_enable(pdev-dev);
pm_runtime_get(pdev-dev);
The
* Jon Hunter jon-hun...@ti.com [120612 11:01]:
On 06/12/2012 02:16 AM, Mohammed, Afzal wrote:
Hi Jon,
On Tue, Jun 12, 2012 at 02:13:22, Hunter, Jon wrote:
+ gpmc_revision = (l 4) 0xf;
Why are you only storing the major part of the rev? Why not keep both
parts?
Does
Hi Tony,
On Wed, Jun 13, 2012 at 17:37:17, Tony Lindgren wrote:
* Jon Hunter jon-hun...@ti.com [120612 11:01]:
On 06/12/2012 02:16 AM, Mohammed, Afzal wrote:
Does having minor revision add any value ?, at least as of now,
I do not see any.
May be not but it does not hurt either.
* Mohammed, Afzal af...@ti.com [120613 06:16]:
Hi Tony,
On Wed, Jun 13, 2012 at 17:37:17, Tony Lindgren wrote:
* Jon Hunter jon-hun...@ti.com [120612 11:01]:
On 06/12/2012 02:16 AM, Mohammed, Afzal wrote:
Does having minor revision add any value ?, at least as of now,
I do
* Tony Lindgren t...@atomide.com [120613 06:45]:
* Mohammed, Afzal af...@ti.com [120613 06:16]:
Hi Tony,
On Wed, Jun 13, 2012 at 17:37:17, Tony Lindgren wrote:
* Jon Hunter jon-hun...@ti.com [120612 11:01]:
On 06/12/2012 02:16 AM, Mohammed, Afzal wrote:
Does having
Hi Tony,
On Wed, Jun 13, 2012 at 19:14:08, Tony Lindgren wrote:
Actually why do you even need to store the revision? You can
just read it from the hardware as needed.
Earlier for wr_access wr_data_mux_bus, we were checking,
cpu_is_34xx, but I feel it should instead be based on
IP revision as
Hi Tony,
On Wed, Jun 13, 2012 at 19:20:35, Mohammed, Afzal wrote:
Hi Tony,
On Wed, Jun 13, 2012 at 19:14:08, Tony Lindgren wrote:
Actually why do you even need to store the revision? You can
just read it from the hardware as needed.
Earlier for wr_access wr_data_mux_bus, we were
On 06/13/2012 08:40 AM, Tony Lindgren wrote:
* Mohammed, Afzal af...@ti.com [120613 06:16]:
Hi Tony,
On Wed, Jun 13, 2012 at 17:37:17, Tony Lindgren wrote:
* Jon Hunter jon-hun...@ti.com [120612 11:01]:
On 06/12/2012 02:16 AM, Mohammed, Afzal wrote:
Does having minor revision add any
Hi Jon,
On Tue, Jun 12, 2012 at 02:13:22, Hunter, Jon wrote:
+ gpmc_revision = (l 4) 0xf;
Why are you only storing the major part of the rev? Why not keep both parts?
Does having minor revision add any value ?, at least as of now,
I do not see any.
+ dev_info(gpmc_dev, GPMC
On 06/12/2012 02:16 AM, Mohammed, Afzal wrote:
Hi Jon,
On Tue, Jun 12, 2012 at 02:13:22, Hunter, Jon wrote:
+ gpmc_revision = (l 4) 0xf;
Why are you only storing the major part of the rev? Why not keep both parts?
Does having minor revision add any value ?, at least as of now,
I
On 06/11/2012 09:26 AM, Afzal Mohammed wrote:
Create a minimal driver out of gpmc code.
Responsibilities handled by earlier gpmc
initialization is now achieved in probe.
Signed-off-by: Afzal Mohammed af...@ti.com
---
arch/arm/mach-omap2/gpmc.c | 170
Create a minimal driver out of gpmc code.
Responsibilities handled by earlier gpmc
initialization is now achieved in probe.
Signed-off-by: Afzal Mohammed af...@ti.com
---
arch/arm/mach-omap2/gpmc.c | 170
1 file changed, 123 insertions(+), 47
On 06/11/2012 09:26 AM, Afzal Mohammed wrote:
Create a minimal driver out of gpmc code.
Responsibilities handled by earlier gpmc
initialization is now achieved in probe.
Signed-off-by: Afzal Mohammed af...@ti.com
---
arch/arm/mach-omap2/gpmc.c | 170
17 matches
Mail list logo
