RE: [PATCH v5 07/14] ARM: OMAP2+: gpmc: time setting (register#) helper

2012-06-12 Thread Mohammed, Afzal
Hi Jon, On Wed, Jun 13, 2012 at 00:25:23, Hunter, Jon wrote: > When are the timings calculated? Why not just use the existing > gpmc_cs_set_timings()? > > I guess I am not convinced that we need to have multiple formats to pass > timings such as clock, period, etc. > > I think that it is suffic

Re: [PATCH v5 07/14] ARM: OMAP2+: gpmc: time setting (register#) helper

2012-06-12 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Helper for setting GPMC timing by taking input as register values. When are the timings calculated? Why not just use the existing gpmc_cs_set_timings()? I guess I am not convinced that we need to have multiple formats to pass timings such as clock,

[PATCH v5 07/14] ARM: OMAP2+: gpmc: time setting (register#) helper

2012-06-11 Thread Afzal Mohammed
Helper for setting GPMC timing by taking input as register values. Signed-off-by: Afzal Mohammed --- arch/arm/mach-omap2/gpmc.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index 4e19010