Re: [PATCH v5 3/5] OMAP4: hwmod data: add mailbox data

2011-02-17 Thread Tony Lindgren
* Ramirez Luna, Omar omar.rami...@ti.com [110215 16:11]: If you have to do several platform_get_irq_byname to get this one, I'd prefer to get rid of that name for OMAP4. It will make mailbox irq consistent with the other hwmods. I was thinking to standardize the names to be mbox0..mboxN

Re: [PATCH v5 3/5] OMAP4: hwmod data: add mailbox data

2011-02-17 Thread Ramirez Luna, Omar
Hi Tony, On Thu, Feb 17, 2011 at 5:39 PM, Tony Lindgren t...@atomide.com wrote: * Ramirez Luna, Omar omar.rami...@ti.com [110215 16:11]: If you have to do several platform_get_irq_byname to get this one, I'd prefer to get rid of that name for OMAP4. It will make mailbox irq consistent

Re: [PATCH v5 3/5] OMAP4: hwmod data: add mailbox data

2011-02-15 Thread Ramirez Luna, Omar
Hi Benoit, On Mon, Feb 14, 2011 at 9:00 AM, Cousson, Benoit b-cous...@ti.com wrote: +static struct omap_hwmod_irq_info omap44xx_mailbox_irqs[] = { +       { .name = mbox, .irq = 26 + OMAP44XX_IRQ_GIC_START, }, The original entry was unnamed since it is an unique entry and thus does not need

Re: [PATCH v5 3/5] OMAP4: hwmod data: add mailbox data

2011-02-15 Thread Cousson, Benoit
Hi Omar, On 2/15/2011 10:55 PM, Ramirez Luna, Omar wrote: Hi Benoit, On Mon, Feb 14, 2011 at 9:00 AM, Cousson, Benoitb-cous...@ti.com wrote: +static struct omap_hwmod_irq_info omap44xx_mailbox_irqs[] = { + { .name = mbox, .irq = 26 + OMAP44XX_IRQ_GIC_START, }, The original entry was

Re: [PATCH v5 3/5] OMAP4: hwmod data: add mailbox data

2011-02-15 Thread Ramirez Luna, Omar
Hi, On Tue, Feb 15, 2011 at 4:05 PM, Cousson, Benoit b-cous...@ti.com wrote: It is this way instead of plain platform_get_irq because omap2420 has two interrupt sources to MPU and mailbox driver uses platform_get_irq_byname to get the irq number. This is what I was thinking, except that on

Re: [PATCH v5 3/5] OMAP4: hwmod data: add mailbox data

2011-02-14 Thread Cousson, Benoit
Hi Omar, I found one minor change wrt to the original that I'd like to understand better. On 2/2/2011 8:27 PM, Ramirez Luna, Omar wrote: From: Benoit Coussonb-cous...@ti.com Mailbox hwmod data for omap4. Signed-off-by: Benoit Coussonb-cous...@ti.com Signed-off-by: Omar Ramirez

[PATCH v5 3/5] OMAP4: hwmod data: add mailbox data

2011-02-02 Thread Omar Ramirez Luna
From: Benoit Cousson b-cous...@ti.com Mailbox hwmod data for omap4. Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 67 1 files changed, 67 insertions(+), 0