Re: [PATCHv7 2/3] OMAP: I2C: Remove the reset in the init path

2011-12-03 Thread Shubhrajyoti
On Saturday 03 December 2011 03:07 AM, Jon Hunter wrote: > Hi Shubhrajyoti, > > On 12/2/2011 3:21, Shubhrajyoti D wrote: >> - The reset in the driver at init is not needed anymore as the >> hwmod framework takes care of reseting it. >> - Reset is removed from omap_i2c_init, which was called >

Re: [PATCHv7 2/3] OMAP: I2C: Remove the reset in the init path

2011-12-02 Thread Jon Hunter
Hi Shubhrajyoti, On 12/2/2011 15:37, Jon Hunter wrote: [snip] @@ -594,6 +545,11 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap, return r; if (r == 0) { dev_err(dev->dev, "controller timed out\n"); + if (dev->device_reset) { + r = dev->device_reset(dev->dev); + if (r< 0) + dev_err(dev-

Re: [PATCHv7 2/3] OMAP: I2C: Remove the reset in the init path

2011-12-02 Thread Jon Hunter
Hi Shubhrajyoti, On 12/2/2011 3:21, Shubhrajyoti D wrote: - The reset in the driver at init is not needed anymore as the hwmod framework takes care of reseting it. - Reset is removed from omap_i2c_init, which was called not only during probe, but also after time out and error handling.

[PATCHv7 2/3] OMAP: I2C: Remove the reset in the init path

2011-12-02 Thread Shubhrajyoti D
- The reset in the driver at init is not needed anymore as the hwmod framework takes care of reseting it. - Reset is removed from omap_i2c_init, which was called not only during probe, but also after time out and error handling. device_reset were added in those places to effect the reset