Kevin Hilman had written, on 03/18/2010 05:49 PM, the following:
Nishanth Menon n...@ti.com writes:
BUG_ON should not ideally contain a functional code. Remove it out.
True. But this code should not be using BUG_ON() in the first place.
We should not crash the whole kernel in this case,
On Fri, Mar 19, 2010 at 03:21:34PM +0100, ext Nishanth Menon wrote:
Kevin Hilman had written, on 03/18/2010 05:49 PM, the following:
Nishanth Menon n...@ti.com writes:
BUG_ON should not ideally contain a functional code. Remove it out.
True. But this code should not be using BUG_ON() in
Nishanth Menon n...@ti.com writes:
Kevin Hilman had written, on 03/18/2010 05:49 PM, the following:
Nishanth Menon n...@ti.com writes:
BUG_ON should not ideally contain a functional code. Remove it out.
True. But this code should not be using BUG_ON() in the first place.
We should not
On Fri, Mar 19, 2010 at 10:46:54AM -0700, Kevin Hilman wrote:
IMO, Using BUG* macros usually indicates improper or incomplete error
handling rather than a real catastrophic system failure.
on the other hand a kernel oops and system hang will always get noted. Rather
than a WARN() which simply
Felipe Balbi m...@felipebalbi.com writes:
On Fri, Mar 19, 2010 at 10:46:54AM -0700, Kevin Hilman wrote:
IMO, Using BUG* macros usually indicates improper or incomplete error
handling rather than a real catastrophic system failure.
on the other hand a kernel oops and system hang will always
Kevin Hilman had written, on 03/19/2010 01:42 PM, the following:
Felipe Balbi m...@felipebalbi.com writes:
On Fri, Mar 19, 2010 at 10:46:54AM -0700, Kevin Hilman wrote:
IMO, Using BUG* macros usually indicates improper or incomplete error
handling rather than a real catastrophic system
Nishanth Menon n...@ti.com writes:
Kevin Hilman had written, on 03/19/2010 01:42 PM, the following:
Felipe Balbi m...@felipebalbi.com writes:
On Fri, Mar 19, 2010 at 10:46:54AM -0700, Kevin Hilman wrote:
IMO, Using BUG* macros usually indicates improper or incomplete error
handling rather
Kevin Hilman had written, on 03/19/2010 03:49 PM, the following:
Nishanth Menon n...@ti.com writes:
Kevin Hilman had written, on 03/19/2010 01:42 PM, the following:
Felipe Balbi m...@felipebalbi.com writes:
On Fri, Mar 19, 2010 at 10:46:54AM -0700, Kevin Hilman wrote:
IMO, Using BUG*
BUG_ON should not ideally contain a functional code. Remove it out.
Ref: http://marc.info/?l=linux-kernelm=109391212925546w=2
Cc: Ambresh K ambr...@ti.com
Cc: Benoit Cousson b-cous...@ti.com
Cc: Eduardo Valentin eduardo.valen...@nokia.com
Cc: Kevin Hilman khil...@deeprootsystems.com
Cc: Phil
Nishanth Menon n...@ti.com writes:
BUG_ON should not ideally contain a functional code. Remove it out.
True. But this code should not be using BUG_ON() in the first place.
We should not crash the whole kernel in this case, just fail
with a warning.
If you're cleaning this up, can you make it
10 matches
Mail list logo
