Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged

2009-02-27 Thread Liam Girdwood
On Fri, 2009-02-27 at 08:19 +0200, Kalle Jokiniemi wrote: > On Thu, 2009-02-26 at 14:40 -0800, David Brownell wrote: > > On Thursday 26 February 2009, Liam Girdwood wrote: > > > On Sun, 2009-02-08 at 10:52 -0800, David Brownell wrote: > > > > From: Kalle Jokiniemi > > > > > > > > This patch disab

Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged

2009-02-26 Thread Kalle Jokiniemi
On Thu, 2009-02-26 at 14:40 -0800, David Brownell wrote: > On Thursday 26 February 2009, Liam Girdwood wrote: > > On Sun, 2009-02-08 at 10:52 -0800, David Brownell wrote: > > > From: Kalle Jokiniemi > > > > > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1 > > > when the USB ca

Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged

2009-02-26 Thread David Brownell
On Thursday 26 February 2009, Liam Girdwood wrote: > On Sun, 2009-02-08 at 10:52 -0800, David Brownell wrote: > > From: Kalle Jokiniemi > > > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1 > > when the USB cable is unplugged, to eliminate that source of power > > waste. (Enab

Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged

2009-02-26 Thread Liam Girdwood
On Sun, 2009-02-08 at 10:52 -0800, David Brownell wrote: > From: Kalle Jokiniemi > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1 > when the USB cable is unplugged, to eliminate that source of power > waste. (Enabled LDOs consume power at all times.) > > Signed-off-by: Kalle

Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged

2009-02-10 Thread Kalle Jokiniemi
On Tue, 2009-02-10 at 11:52 -0800, David Brownell wrote: > On Tuesday 10 February 2009, Kalle Jokiniemi wrote: > > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1 > > > when the USB cable is unplugged, to eliminate that source of power > > > waste. (Enabled LDOs consume power at

Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged

2009-02-10 Thread David Brownell
On Tuesday 10 February 2009, Kalle Jokiniemi wrote: > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1 > > when the USB cable is unplugged, to eliminate that source of power > > waste. (Enabled LDOs consume power at all times.) > > Please put this on hold for a while. This won't

Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged

2009-02-10 Thread Mark Brown
On Tue, Feb 10, 2009 at 03:08:14PM +0200, Kalle Jokiniemi wrote: > A bug has been discovered here. If the twl-regulator is not compiled in, > the twl4030-usb fails while trying to access the reg-fw interfaces (and reg-fw is the regulator framework? > not checking error values). Also it's bit con

Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged

2009-02-10 Thread Kalle Jokiniemi
On Sun, 2009-02-08 at 10:52 -0800, David Brownell wrote: > From: Kalle Jokiniemi > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1 > when the USB cable is unplugged, to eliminate that source of power > waste. (Enabled LDOs consume power at all times.) Please put this on hold

Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged

2009-02-10 Thread Kalle Jokiniemi
On Sun, 2009-02-08 at 10:52 -0800, David Brownell wrote: > From: Kalle Jokiniemi > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1 > when the USB cable is unplugged, to eliminate that source of power > waste. (Enabled LDOs consume power at all times.) Please put this one on h

[patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged

2009-02-08 Thread David Brownell
From: Kalle Jokiniemi This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1 when the USB cable is unplugged, to eliminate that source of power waste. (Enabled LDOs consume power at all times.) Signed-off-by: Kalle Jokiniemi Signed-off-by: David Brownell --- Depends on the twl4030 r