Re: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-02 Thread Venkatraman S
On Tue, Mar 2, 2010 at 12:22 PM, Tony Lindgren t...@atomide.com wrote: * G, Manjunath Kondaiah manj...@ti.com [100301 22:24]: +     up-uart_dma.prev_rx_dma_pos = up-uart_dma.rx_buf_dma_phys; +     if (cpu_is_omap44xx()) +             omap_writel(0, OMAP44XX_DMA4_BASE +    

RE: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-02 Thread G, Manjunath Kondaiah
...@vger.kernel.org; Kevin Hilman; Olof Johansson Subject: Re: [PATCH] serial: Add OMAP high-speed UART driver. On Tue, Mar 2, 2010 at 12:22 PM, Tony Lindgren t...@atomide.com wrote: * G, Manjunath Kondaiah manj...@ti.com [100301 22:24]: +     up-uart_dma.prev_rx_dma_pos = up

RE: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-02 Thread Shilimkar, Santosh
snip snip -- CDAC is a shadow register used for monitoring the DMA channel. I think it would be a lot simpler if omap_start_dma() always resets CDAC to 0, and the UART driver just not set it explicitly. This seems to be better option than exposing CDAC read/write API to other

RE: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-02 Thread G, Manjunath Kondaiah
; Olof Johansson Subject: RE: [PATCH] serial: Add OMAP high-speed UART driver. snip snip -- CDAC is a shadow register used for monitoring the DMA channel. I think it would be a lot simpler if omap_start_dma() always resets CDAC to 0, and the UART driver just not set

RE: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-02 Thread Shilimkar, Santosh
Johansson Subject: RE: [PATCH] serial: Add OMAP high-speed UART driver. Santosh, -Original Message- From: Shilimkar, Santosh Sent: Tuesday, March 02, 2010 7:34 PM To: G, Manjunath Kondaiah; S, Venkatraman; Tony Lindgren; Raja, Govindraj; Greg KH; linux-ser...@vger.kernel.org

RE: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-02 Thread G, Manjunath Kondaiah
Johansson Subject: RE: [PATCH] serial: Add OMAP high-speed UART driver. -Original Message- From: G, Manjunath Kondaiah Sent: Tuesday, March 02, 2010 8:34 PM To: Shilimkar, Santosh; S, Venkatraman; Tony Lindgren; Raja, Govindraj; Greg KH; linux- ser...@vger.kernel.org; linux-omap

Re: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-01 Thread Alan Cox
+ 213 = /dev/ttyO0 OMAP serial port 0 + 214 = /dev/ttyO1 OMAP serial port 1 + 215 = /dev/ttyO2 OMAP serial port 2 + 216 = /dev/ttyO3 OMAP serial port 3 I think it might be best to

Re: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-01 Thread Tony Lindgren
* Govindraj.R govindraj.r...@ti.com [100301 06:40]: --- /dev/null +++ b/drivers/serial/omap-serial.c + +static void serial_omap_stop_tx(struct uart_port *port) +{ + struct uart_omap_port *up = (struct uart_omap_port *)port; + + if (up-use_dma +

RE: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-01 Thread G, Manjunath Kondaiah
...@vger.kernel.org; Kevin Hilman; Olof Johansson Subject: Re: [PATCH] serial: Add OMAP high-speed UART driver. * Govindraj.R govindraj.r...@ti.com [100301 06:40]: --- /dev/null +++ b/drivers/serial/omap-serial.c + +static void serial_omap_stop_tx(struct uart_port *port) +{ + struct

Re: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-01 Thread Tony Lindgren
...@vger.kernel.org; linux-omap@vger.kernel.org; linux-ker...@vger.kernel.org; Kevin Hilman; Olof Johansson Subject: Re: [PATCH] serial: Add OMAP high-speed UART driver. * Govindraj.R govindraj.r...@ti.com [100301 06:40]: --- /dev/null +++ b/drivers/serial/omap-serial.c + +static

RE: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-01 Thread G, Manjunath Kondaiah
+ up-uart_dma.prev_rx_dma_pos = up-uart_dma.rx_buf_dma_phys; + if (cpu_is_omap44xx()) + omap_writel(0, OMAP44XX_DMA4_BASE + + OMAP_DMA4_CDAC(up-uart_dma.rx_dma_channel)); + else + omap_writel(0,

Re: [PATCH] serial: Add OMAP high-speed UART driver.

2010-03-01 Thread Tony Lindgren
* G, Manjunath Kondaiah manj...@ti.com [100301 22:24]: + up-uart_dma.prev_rx_dma_pos = up-uart_dma.rx_buf_dma_phys; + if (cpu_is_omap44xx()) + omap_writel(0, OMAP44XX_DMA4_BASE + + OMAP_DMA4_CDAC(up-uart_dma.rx_dma_channel));