RE: [PATCH 02/14] dspbridge: deh: trivial cleanups

2010-05-17 Thread Liu, Stanley
4:53 PM To: Felipe Contreras Cc: Guzman Lugo, Fernando; linux-omap; Liu, Stanley; Ramirez Luna, Omar Subject: RE: [PATCH 02/14] dspbridge: deh: trivial cleanups The safe thing to do is disable the timer after the DSP has completed the dump. During the dump processing, the DSP will clear the timer in

RE: [PATCH 02/14] dspbridge: deh: trivial cleanups

2010-05-17 Thread Jansson, Cris
reras [mailto:felipe.contre...@gmail.com] Sent: Monday, May 17, 2010 4:14 PM To: Jansson, Cris Cc: Guzman Lugo, Fernando; linux-omap; Liu, Stanley; Ramirez Luna, Omar Subject: Re: [PATCH 02/14] dspbridge: deh: trivial cleanups Hi Cris, On Mon, May 17, 2010 at 10:39 PM, Jansson, Cris wrote: > Th

Re: [PATCH 02/14] dspbridge: deh: trivial cleanups

2010-05-17 Thread Felipe Contreras
Hi Cris, On Mon, May 17, 2010 at 10:39 PM, Jansson, Cris wrote: > Thanks for forwarding the thread. > > In wait_for_timer(), should return be used inside the loop?  It will result > in omap_dm_timer_disable(timer) not being called.  I believe it should be > called in all outcomes. Yes, that's

RE: [PATCH 02/14] dspbridge: deh: trivial cleanups

2010-05-17 Thread Jansson, Cris
zman Lugo, Fernando Sent: Monday, May 17, 2010 2:09 PM To: Felipe Contreras; linux-omap; Liu, Stanley; Jansson, Cris Cc: Ramirez Luna, Omar Subject: RE: [PATCH 02/14] dspbridge: deh: trivial cleanups +Cris +Stanley Loop in DSP guys in case they would have something to add. > -Or

RE: [PATCH 02/14] dspbridge: deh: trivial cleanups

2010-05-17 Thread Guzman Lugo, Fernando
+Cris +Stanley Loop in DSP guys in case they would have something to add. > -Original Message- > From: Felipe Contreras [mailto:felipe.contre...@gmail.com] > Sent: Sunday, May 16, 2010 10:46 AM > To: linux-omap > Cc: Ramirez Luna, Omar; Guzman Lugo, Fernando; Felipe Contreras > Subject:

RE: [PATCH 02/14] dspbridge: deh: trivial cleanups

2010-05-16 Thread Guzman Lugo, Fernando
Hi, > -Original Message- > From: Felipe Contreras [mailto:felipe.contre...@gmail.com] > Sent: Sunday, May 16, 2010 5:13 PM > To: Guzman Lugo, Fernando > Cc: linux-omap; Ramirez Luna, Omar > Subject: Re: [PATCH 02/14] dspbridge: deh: trivial cleanups > > On Mon,

Re: [PATCH 02/14] dspbridge: deh: trivial cleanups

2010-05-16 Thread Felipe Contreras
On Mon, May 17, 2010 at 1:02 AM, Guzman Lugo, Fernando wrote: >> +     for (c = 0; c < GPTIMER_IRQ_WAIT_MAX_CNT; c++) >> +             if ((omap_dm_timer_read_status(timer) & GPTIMER_IRQ_OVERFLOW)) >> +                     return; >> + >> +     pr_err("%s: GPTimer interrupt failed\n", __func__);

RE: [PATCH 02/14] dspbridge: deh: trivial cleanups

2010-05-16 Thread Guzman Lugo, Fernando
Hi, > -Original Message- > From: Felipe Contreras [mailto:felipe.contre...@gmail.com] > Sent: Sunday, May 16, 2010 10:46 AM > To: linux-omap > Cc: Ramirez Luna, Omar; Guzman Lugo, Fernando; Felipe Contreras > Subject: [PATCH 02/14] dspbridge: deh: trivial cleanups > > No functional chan