RE: [PATCH 3/3] V4L2 Driver for OMAP3/3 DSS.

2009-04-06 Thread Shah, Hardik
Hi Hans, Please find my comments inline. Most of the comments are taken care of. Regards, Hardik Shah static struct twl4030_hsmmc_info mmc[] __initdata = { diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig index 19cf3b8..91e4529 100644 ---

RE: [PATCH 3/3] V4L2 Driver for OMAP3/3 DSS.

2009-04-06 Thread Hans Verkuil
Hi Hans, Please find my comments inline. Most of the comments are taken care of. 2. In DSS rotation is accomplished by some memory algorithm but its quite costly so -1 is essentially same as 0 degree but with out the overhead. But if mirroring is on then we have to do the 0 degree rotation

Re: [PATCH 3/3] V4L2 Driver for OMAP3/3 DSS.

2009-03-20 Thread Koen Kooi
Op 20 mrt 2009, om 06:20 heeft Hardik Shah het volgende geschreven: --- a/drivers/media/video/Kconfig +++ b/drivers/media/video/Kconfig @@ -711,6 +711,26 @@ config VIDEO_CAFE_CCIC CMOS camera controller. This is the controller found on first- generation OLPC systems.

RE: [PATCH 3/3] V4L2 Driver for OMAP3/3 DSS.

2009-03-20 Thread Shah, Hardik
-Original Message- From: Koen Kooi [mailto:k.k...@student.utwente.nl] Sent: Friday, March 20, 2009 2:34 PM To: Shah, Hardik Cc: linux-me...@vger.kernel.org; linux-omap@vger.kernel.org; Jadav, Brijesh R; Hiremath, Vaibhav Subject: Re: [PATCH 3/3] V4L2 Driver for OMAP3/3 DSS

RE: [PATCH 3/3] V4L2 Driver for OMAP3/3 DSS.

2009-03-20 Thread Shah, Hardik
-Original Message- From: Alexey Klimov [mailto:klimov.li...@gmail.com] Sent: Friday, March 20, 2009 6:02 PM To: Shah, Hardik Cc: linux-me...@vger.kernel.org; linux-omap@vger.kernel.org; Jadav, Brijesh R; Hiremath, Vaibhav Subject: Re: [PATCH 3/3] V4L2 Driver for OMAP3/3 DSS

Re: [PATCH 3/3] V4L2 Driver for OMAP3/3 DSS.

2009-03-20 Thread Alexey Klimov
snip Hello again, my previous message due to bad connection was send with no end. Sorry about that. +               vout-vid = k; +               vid_dev-vouts[k] = vout; +               vout-vid_info.vid_dev = vid_dev; +               vout-vid_info.overlays[0] = vid_dev-overlays[k + 1]; +