> -Original Message-
> From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
> Sent: Wednesday, May 12, 2010 12:05 PM
> To: Shilimkar, Santosh
> Cc: Arce, Abraham; linux-in...@vger.kernel.org; linux-omap@vger.kernel.org
> Subject: Re: [RFC] [PATCH 1/3] OMAP4: Keyboard
..@vger.kernel.org; linux-omap@vger.kernel.org
> > Subject: Re: [RFC] [PATCH 1/3] OMAP4: Keyboard Controller Support
> >
> > On Wed, May 12, 2010 at 11:15:11AM +0530, Shilimkar, Santosh wrote:
> > > > -Original Message-
> > > > From: linux-omap-ow...@vger
> > Sorry for jumping into the comments late. Thought this was sorted out. Key
> scanning
> > and debounce timeouts etc still there. Having all these things in ISR itself
> isn't good
> > idea.
> >
> > Dmitry,
> > Don't you think its optimal to push the key-scanning and debounce timeout
> code
> >
> -Original Message-
> From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
> Sent: Wednesday, May 12, 2010 11:33 AM
> To: Shilimkar, Santosh
> Cc: Arce, Abraham; linux-in...@vger.kernel.org; linux-omap@vger.kernel.org
> Subject: Re: [RFC] [PATCH 1/3] OMAP4: Keyboard
> > To: Dmitry Torokhov
> > Cc: linux-in...@vger.kernel.org; linux-omap@vger.kernel.org
> > Subject: RE: [RFC] [PATCH 1/3] OMAP4: Keyboard Controller Support
> >
> > Dmitry,
> >
> > 2 comments + one question before sending next version...
> >
>
ject: RE: [RFC] [PATCH 1/3] OMAP4: Keyboard Controller Support
>
> Dmitry,
>
> 2 comments + one question before sending next version...
>
> [...]
>
> > > > > > +static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
> > > > > >
Dmitry,
2 comments + one question before sending next version...
[...]
> > > > > +static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
> > > > > +{
> > > >
> > > > Why is iti threaded? I fo not see anything that will sleep.
> >
> >
> > It was implemented based on previous comments...
>
nel.org
> Subject: Re: [RFC] [PATCH 1/3] OMAP4: Keyboard Controller Support
>
> Dmitry Torokhov writes:
>
> > On Tue, May 11, 2010 at 07:53:23AM -0700, Kevin Hilman wrote:
> >> Dmitry Torokhov writes:
> >>
> >> > On Tue, May 11, 2
Dmitry Torokhov writes:
> On Tue, May 11, 2010 at 07:53:23AM -0700, Kevin Hilman wrote:
>> Dmitry Torokhov writes:
>>
>> > On Tue, May 11, 2010 at 12:03:44AM -0500, Arce, Abraham wrote:
>> >> Hi again Dmitry,
>> >>
>> >> > No worries, although at first I was surprised that Trilok spoke exactly
On Tue, May 11, 2010 at 07:53:23AM -0700, Kevin Hilman wrote:
> Dmitry Torokhov writes:
>
> > On Tue, May 11, 2010 at 12:03:44AM -0500, Arce, Abraham wrote:
> >> Hi again Dmitry,
> >>
> >> > No worries, although at first I was surprised that Trilok spoke exactly
> >> > the same words I did ;)
>
Dmitry Torokhov writes:
> On Tue, May 11, 2010 at 12:03:44AM -0500, Arce, Abraham wrote:
>> Hi again Dmitry,
>>
>> > No worries, although at first I was surprised that Trilok spoke exactly
>> > the same words I did ;)
>> >
>>
>> :)
>>
>> > > > > > +
>> > > > > > +/* Interrupt thread handler t
On Tue, May 11, 2010 at 12:03:44AM -0500, Arce, Abraham wrote:
> Hi again Dmitry,
>
> > No worries, although at first I was surprised that Trilok spoke exactly
> > the same words I did ;)
> >
>
> :)
>
> > > > > > +
> > > > > > +/* Interrupt thread handler thread */
> > > > > > +
> > > > > > +st
Hi again Dmitry,
> No worries, although at first I was surprised that Trilok spoke exactly
> the same words I did ;)
>
:)
> > > > > +
> > > > > +/* Interrupt thread handler thread */
> > > > > +
> > > > > +static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
> > > > > +{
> > > >
> > >
On Mon, May 10, 2010 at 11:17:50PM -0500, Arce, Abraham wrote:
> Sorry for the confusion in your name Dmitry...
>
No worries, although at first I was surprised that Trilok spoke exactly
the same words I did ;)
> Thanks for your comments...
>
> [snip]
>
> > > > +
> > > > +/* Interrupt thread ha
Sorry for the confusion in your name Dmitry...
Thanks for your comments...
[snip]
> > > +
> > > +/* Interrupt thread handler thread */
> > > +
> > > +static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
> > > +{
> >
> > Why is iti threaded? I fo not see anything that will sleep.
It w
Hi Trilok,
Thanks for your comments...
[snip]
> > +
> > +/* Interrupt thread handler thread */
> > +
> > +static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
> > +{
>
> Why is iti threaded? I fo not see anything that will sleep.
It was implemented based on previous comments...
>
Thanks Kevin,
> > Keyboard controller for OMAP4 with built-in scanning algorithm.
> > The following implementations are used:
> >
> > - matrix_keypac.c logic
> > - hwmod framework
> > - threaded irq
> >
> > Signed-off-by: Syed Rafiuddin
> > Signed-off-by: Abraham Arce
>
> Some general com
Felipe,
Thanks for your comments...
[..]
> >+#include
> >+#include
>
> should the platform_driver know about hwmod and omap_device ? Paul ?
> Kevin ?
Working on these changes...
>
> >+struct omap_keypad {
> >+
>
> unnecessary blank line.
Removed
>
> >+ struct platform_device *pde
Hi Abraham,
On Tue, Apr 13, 2010 at 08:10:48PM -0500, Arce, Abraham wrote:
> Keyboard controller for OMAP4 with built-in scanning algorithm.
> The following implementations are used:
>
> - matrix_keypac.c logic
> - hwmod framework
> - threaded irq
>
> Signed-off-by: Syed Rafiuddin
> Signe
"Arce, Abraham" writes:
> Keyboard controller for OMAP4 with built-in scanning algorithm.
> The following implementations are used:
>
> - matrix_keypac.c logic
> - hwmod framework
> - threaded irq
>
> Signed-off-by: Syed Rafiuddin
> Signed-off-by: Abraham Arce
Some general comments...
W
"Arce, Abraham" writes:
> Hi Trilok!
>
>> > - matrix_keypac.c logic
>> > - hwmod framework
>>
>> Do we have hwmod framework mainlined in the kernel?
>
> Not yet but wanted to gather initial comments to be ready once framework is
> pushed
Just to clarify, hwmod framework is already in mainlin
Hi,
On Wed, Apr 14, 2010 at 03:10:48AM +0200, ext Arce, Abraham wrote:
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
should the platform_driver know about hwmod and omap_device ? Paul ?
Kevin ?
+struct omap_keypad {
+
unnece
Hi Trilok!
> > - matrix_keypac.c logic
> > - hwmod framework
>
> Do we have hwmod framework mainlined in the kernel?
Not yet but wanted to gather initial comments to be ready once framework is
pushed
>
> >
> > +config KEYBOARD_OMAP4
> > + tristate "TI OMAP4 keypad support"
> > +
Hi Abraham,
On Wed, Apr 14, 2010 at 6:40 AM, Arce, Abraham wrote:
> Keyboard controller for OMAP4 with built-in scanning algorithm.
> The following implementations are used:
>
> - matrix_keypac.c logic
> - hwmod framework
Do we have hwmod framework mainlined in the kernel?
>
> +config KEYBOAR
24 matches
Mail list logo
