Re: [RFC] omap: mailbox: fix detection for previously supported chips

2010-09-24 Thread Felipe Contreras
On Thu, Sep 23, 2010 at 7:11 PM, Ramirez Luna, Omar omar.rami...@ti.com wrote: Code is not the same, it is 2 line which apply for both but couldn't find an easy way of making them share the request for dsp mailbox without changing more code, perhaps a macro to detect if omap2 and then a

RE: [RFC] omap: mailbox: fix detection for previously supported chips

2010-09-24 Thread Ramirez Luna, Omar
Felipe Contreras wrote: On Thu, Sep 23, 2010 at 7:11 PM, Ramirez Luna, Omar omar.rami...@ti.com wrote: Code is not the same, it is 2 line which apply for both but couldn't find an easy way of making them share the request for dsp mailbox without changing more code, perhaps a macro to detect

RE: [RFC] omap: mailbox: fix detection for previously supported chips

2010-09-23 Thread Aguirre, Sergio
Hi Omar, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Omar Ramirez Luna Sent: Wednesday, September 22, 2010 7:22 PM To: Tony Lindgren; Hiroshi DOYU; Felipe Contreras; Anna, Suman; linux- o...@vger.kernel.org Cc:

RE: [RFC] omap: mailbox: fix detection for previously supported chips

2010-09-23 Thread Ramirez Luna, Omar
Hi Sergio, Aguirre, Sergio wrote: Hi Omar, ... +#if defined(CONFIG_ARCH_OMAP2) +else if (cpu_is_omap2430()) { +list = omap2_mboxes; + +list[0]-irq = platform_get_irq_byname(pdev, dsp); +} else if (cpu_is_omap2420()) { Isn't both 2430 and 2420 doing the

RE: [RFC] omap: mailbox: fix detection for previously supported chips

2010-09-23 Thread Aguirre, Sergio
Hi Omar, -Original Message- From: Ramirez Luna, Omar Sent: Thursday, September 23, 2010 11:12 AM To: Aguirre, Sergio; Tony Lindgren; Hiroshi DOYU; Felipe Contreras; Anna, Suman; linux-omap@vger.kernel.org Subject: RE: [RFC] omap: mailbox: fix detection for previously supported

RE: [RFC] omap: mailbox: fix detection for previously supported chips

2010-09-23 Thread Ramirez Luna, Omar
Ramirez Luna, Omar wrote: Fix the mailbox support detection for OMAP3630, 3530/25 and 2430. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- - Testing was made under 3630 and 3430 boards. - Given that 2430 uses similar initialization than OMAP3, changes to handle this case was

Re: [RFC] omap: mailbox: fix detection for previously supported chips

2010-09-23 Thread Kevin Hilman
Ramirez Luna, Omar omar.rami...@ti.com writes: Ramirez Luna, Omar wrote: Fix the mailbox support detection for OMAP3630, 3530/25 and 2430. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- - Testing was made under 3630 and 3430 boards. - Given that 2430 uses similar initialization

RE: [RFC] omap: mailbox: fix detection for previously supported chips

2010-09-23 Thread Ramirez Luna, Omar
Kevin Hilman wrote: Ramirez Luna, Omar omar.rami...@ti.com writes: Ramirez Luna, Omar wrote: Fix the mailbox support detection for OMAP3630, 3530/25 and 2430. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- - Testing was made under 3630 and 3430 boards. - Given that 2430 uses