Re: [PATCH 6/6] usb: musb: Add support for ti81xx platform

2011-08-26 Thread Felipe Balbi
Hi, On Fri, Aug 26, 2011 at 04:41:48PM +0530, Ajay Kumar Gupta wrote: > @@ -57,6 +58,10 @@ config USB_MUSB_AM35X > tristate "AM35x" > depends on ARCH_OMAP > > +config USB_MUSB_TI81XX > + bool "TI81XX" > + depends on SOC_OMAPTI81XX this *must* be tristate. I can't emphasize e

RE: [PATCH 6/6] usb: musb: Add support for ti81xx platform

2011-08-28 Thread Gupta, Ajay Kumar
Hi, > On Fri, Aug 26, 2011 at 04:41:48PM +0530, Ajay Kumar Gupta wrote: > > @@ -57,6 +58,10 @@ config USB_MUSB_AM35X > > tristate "AM35x" > > depends on ARCH_OMAP > > > > +config USB_MUSB_TI81XX > > + bool "TI81XX" > > + depends on SOC_OMAPTI81XX > > this *must* be tristate. I can't em

Re: [PATCH 6/6] usb: musb: Add support for ti81xx platform

2011-08-29 Thread Felipe Balbi
Hi, On Mon, Aug 29, 2011 at 11:01:54AM +0530, Gupta, Ajay Kumar wrote: > > > diff --git a/drivers/usb/musb/musb_core.c > > > b/drivers/usb/musb/musb_core.c index 20a2873..07f3faf 100644 > > > --- a/drivers/usb/musb/musb_core.c > > > +++ b/drivers/usb/musb/musb_core.c > > > @@ -1014,7 +1014,9 @@ st

RE: [PATCH 6/6] usb: musb: Add support for ti81xx platform

2011-08-29 Thread Gupta, Ajay Kumar
Hi, > > > we really need to find a better way to handle this :-( > > > > How about passing the mode info from musb_config (musb->config- > >fifo_mode), > > same way as musb->config->fifo_cfg > > not sure... Ideally we wouldn't really need those fifo tables, Yes, if all the board files provide the

Re: [PATCH 6/6] usb: musb: Add support for ti81xx platform

2011-09-02 Thread Felipe Balbi
Hi, On Mon, Aug 29, 2011 at 03:16:55PM +0530, Gupta, Ajay Kumar wrote: > I have compiled the differences in the register map between am35x and > ti81xx and they are listed below. > > === > Register am35x

RE: [PATCH 6/6] usb: musb: Add support for ti81xx platform

2011-09-02 Thread Gupta, Ajay Kumar
Hi, > > If you compare am35x and da8x then you would find that they are > mostly > > same and so should be merged. They both have one musb instances. > > > > Ti81xx has two musb interface and huge differences in register map as > > listed Above so ti81xx should be in a separate file. > > > > Apart

RE: [PATCH 6/6] usb: musb: Add support for ti81xx platform

2011-09-06 Thread Gupta, Ajay Kumar
Hi, > > diff --git a/drivers/usb/musb/musb_core.c > > b/drivers/usb/musb/musb_core.c index 20a2873..07f3faf 100644 > > --- a/drivers/usb/musb/musb_core.c > > +++ b/drivers/usb/musb/musb_core.c > > @@ -1014,7 +1014,9 @@ static void musb_shutdown(struct > platform_device *pdev) > > || defined(CON

Re: [PATCH 6/6] usb: musb: Add support for ti81xx platform

2011-09-06 Thread Felipe Balbi
Hi, On Tue, Sep 06, 2011 at 12:30:15PM +0530, Gupta, Ajay Kumar wrote: > > > diff --git a/drivers/usb/musb/musb_core.c > > > b/drivers/usb/musb/musb_core.c index 20a2873..07f3faf 100644 > > > --- a/drivers/usb/musb/musb_core.c > > > +++ b/drivers/usb/musb/musb_core.c > > > @@ -1014,7 +1014,9 @@ st