[PATCH V3 11/12] ARM: OMAP2+: Move dmtimer clock set function to dmtimer driver

2012-06-04 Thread Jon Hunter
uld specify an architecture specific function for setting the clock source via the platform data set_dmtimer_src() function pointer. Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/timer.c | 56 - arch/arm/plat-omap/dmtimer.c |

[PATCH V3 12/12] ARM: OMAP2+: Simplify dmtimer clock aliases

2012-06-04 Thread Jon Hunter
2 only) an external clock. By defining a unique con-id name for each of these (timer_32k_ck, timer_sys_ck and timer_ext_ck) we can eliminate a lot of the clock aliases for timers. This reduces code, speeds-up searches and clock initialisation time. Signed-off-by: Jon Hunter --- arch/arm/

Re: [PATCH V3 06/12] ARM: OMAP1: Fix dmtimer support

2012-06-04 Thread Jon Hunter
On 06/04/2012 02:41 PM, Jon Hunter wrote: > OMAP1 dmtimer support is currently broken. When a dmtimer is requested by the > omap_dm_timer_request() function fails to allocate a dmtimer because the call > to clk_get() inside omap_dm_timer_prepare fails. The clk_get() fails simply >

Re: [PATCH 4/6] ARM: OMAP4: PMU: Add runtime PM support

2012-06-04 Thread Jon Hunter
Hi Will, On 06/02/2012 11:42 AM, Will Deacon wrote: > Hi Jon, Kevin, > > I've been between timezones, so sorry for the slow response. No problem. I was expecting you guys in the UK to be out of office for the next couple days :-) > On Fri, Jun 01, 2012 at 03:42:56PM +0100,

Re: [RFC 13/24] ARM: omap4: clk: Add 44xx data using common struct clk

2012-06-04 Thread Jon Hunter
Hi Rajendra, On 06/01/2012 07:07 AM, Rajendra Nayak wrote: > The data is autogenerated using the OMAP autogeneration scripts (python > scripts). Thanks to Mike Turquette for the initial efforts in updating > the script which was later updated by me. > All data is added into a new cclock44xx_data.c

Re: [RFC 05/24] ARM: omap: clk: Nuke plat clock.c & clock.h if CONFIG_COMMON_CLK

2012-06-05 Thread Jon Hunter
Hi Rajendra, On 06/04/2012 11:58 PM, Rajendra Nayak wrote: > Hi Jon, > >> On 06/04/2012 09:16 AM, Rajendra Nayak wrote: >>> > +/* struct clksel_rate.flags possibilities */ > +#define RATE_IN_242X(1<< 0) > +#define RATE_IN_243X(1<< 1) > +#define RATE_IN_3430ES1

Re: [PATCH 4/6] ARM: OMAP4: PMU: Add runtime PM support

2012-06-05 Thread Jon Hunter
Hi Will, On 06/04/2012 04:44 PM, Jon Hunter wrote: [...] > diff --git a/arch/arm/kernel/pmu.c b/arch/arm/kernel/pmu.c > index 2334bf8..8ffbb09 100644 > --- a/arch/arm/kernel/pmu.c > +++ b/arch/arm/kernel/pmu.c > @@ -13,6 +13,8 @@ > #include > #include > #include

[PATCH V4 00/12] ARM: OMAP: DMTIMER clean-up and fixes in preparation for device-tree

2012-06-05 Thread Jon Hunter
is called and this is not support for OMAP1 devices. - Only use "set_timer_src" function pointer for OMAP1 devices. Jon Hunter (12): ARM: OMAP: Remove unnecessary clk structure ARM: OMAP2+: Remove unused max number of timers definition ARM: OMAP2+: Add dmtimer platform function

[PATCH V4 09/12] ARM: OMAP: Add flag to indicate if a timer needs a manual reset

2012-06-05 Thread Jon Hunter
remove the "needs_manual_reset" member from the platform data. Signed-off-by: Jon Hunter --- arch/arm/mach-omap1/timer.c |4 ++-- arch/arm/plat-omap/dmtimer.c |9 +++-- arch/arm/plat-omap/include/plat/dmtimer.h |2 +- 3 files changed, 6 insertions(+),

[PATCH V4 10/12] ARM: OMAP1: Fix dmtimer support

2012-06-05 Thread Jon Hunter
se for the same purpose in omap_dm_timer_stop(). Signed-off-by: Jon Hunter --- arch/arm/plat-omap/dmtimer.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c index e3e22b3..6510e5e 100644 --- a/arch/arm

[PATCH V4 03/12] ARM: OMAP2+: Add dmtimer platform function to reserve systimers

2012-06-05 Thread Jon Hunter
remove the "reserved" member from the timer platform data. This seemed like the simpler approach and so was implemented here. Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/timer.c |9 ++--- arch/arm/plat-omap/dmtimer.c | 18 +- arc

[PATCH V4 07/12] ARM: OMAP: Remove loses_context variable from timer platform data

2012-06-05 Thread Jon Hunter
timer will not lose context. So use the HWMOD device attributes to determine this. For OMAP1 devices, loses_context is never set and so set the OMAP_TIMER_ALWON flag for OMAP1 timers to ensure that code is equivalent. Signed-off-by: Jon Hunter --- arch/arm/mach-omap1/timer.c |1

[PATCH V4 06/12] ARM: OMAP2+: Fix external clock support for dmtimers

2012-06-05 Thread Jon Hunter
minate the "timer_ip_version" variable passed as part of the platform data and simplify the code. We can also remove the timer IP version from the HWMOD data because the dmtimer driver uses the TIDR register to determine the IP version. Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/omap_hwmod

[PATCH V4 11/12] ARM: OMAP2+: Move dmtimer clock set function to dmtimer driver

2012-06-05 Thread Jon Hunter
uld specify an architecture specific function for setting the clock source via the platform data set_dmtimer_src() function pointer. Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/timer.c | 55 - arch/arm/plat-omap/dmtimer.c |

[PATCH V4 08/12] ARM: OMAP: Remove timer function pointer for context loss counter

2012-06-05 Thread Jon Hunter
simplifies the dmtimer migration to device-tree. Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/timer.c |3 --- arch/arm/plat-omap/dmtimer.c | 17 +++-- arch/arm/plat-omap/include/plat/dmtimer.h |3 --- 3 files changed, 7 insertions(+), 16 deletions

[PATCH V4 12/12] ARM: OMAP2+: Simplify dmtimer clock aliases

2012-06-05 Thread Jon Hunter
2 only) an external clock. By defining a unique con-id name for each of these (timer_32k_ck, timer_sys_ck and timer_ext_ck) we can eliminate a lot of the clock aliases for timers. This reduces code, speeds-up searches and clock initialisation time. Signed-off-by: Jon Hunter --- arch/arm/

[PATCH V4 02/12] ARM: OMAP2+: Remove unused max number of timers definition

2012-06-05 Thread Jon Hunter
reserved as a secure timer and for OMAP3 devices the 12th timer is not available on secure devices. Therefore, remove this definition. Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/timer.c |3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach

[PATCH V4 01/12] ARM: OMAP: Remove unnecessary clk structure

2012-06-05 Thread Jon Hunter
In the plat/dmtimer.h there is a structure named "clk" declared. This structure is not used and appears to be left over from previous code. Hence, remove this unused structure. Verified that both omap1 and omap2plus kernel configurations build with this change. Signed-off-by:

[PATCH V4 05/12] ARM: OMAP2+: HWMOD: Correct timer device attributes

2012-06-05 Thread Jon Hunter
domain. Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c |7 --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |8 +--- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |6 -- 3 files changed, 1 insertion(+), 20 deletions(-) diff --git

[PATCH V4 04/12] ARM: OMAP: Add DMTIMER capability variable to represent timer features

2012-06-05 Thread Jon Hunter
ever, such attributes do not need to be queried at runtime and we can look up the attributes via HWMOD or device-tree. This changes a new "capability" variable to the platform data and timer structure so we can start removing and simplifying the platform data structure. Signed-off-by: Jon H

Re: [PATCH 4/6] ARM: OMAP4: PMU: Add runtime PM support

2012-06-06 Thread Jon Hunter
Hi Will, On 06/06/2012 12:33 PM, Will Deacon wrote: > On Tue, Jun 05, 2012 at 02:19:02PM +0100, Jon Hunter wrote: >> Hi Will, > > Hi Jon, > >> On 06/04/2012 04:44 PM, Jon Hunter wrote: >> Anyway, let me know what you think of this approach. An alternative is >

[PATCH V2 01/10] ARM: PMU: Add runtime PM Support

2012-06-07 Thread Jon Hunter
off-by: Jon Hunter --- arch/arm/include/asm/pmu.h | 20 arch/arm/kernel/perf_event.c | 41 + 2 files changed, 45 insertions(+), 16 deletions(-) diff --git a/arch/arm/include/asm/pmu.h b/arch/arm/include/asm/pmu.h index 9011

[PATCH V2 07/10] ARM: OMAP4: CLKDM: Update supported transition modes

2012-06-07 Thread Jon Hunter
--> NO_SLEEP CLKDM_CAN_ENABLE_AUTO --> HW_AUTO CLKDM_CAN_FORCE_SLEEP --> HW_AUTO CLKDM_CAN_FORCE_WAKEUP --> SW_WKUP Cc: Ming Lei Cc: Will Deacon Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Reviewed-by: Benoit Cousson Reviewed-by: Santosh Shilimkar Signed-off-by: Jon Hu

[PATCH V2 08/10] ARM: OMAP4: Prevent EMU power domain transitioning to OFF when in-use

2012-06-07 Thread Jon Hunter
: Jon Hunter --- arch/arm/mach-omap2/clockdomains44xx_data.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/clockdomains44xx_data.c b/arch/arm/mach-omap2/clockdomains44xx_data.c index c534258..ba74006 100644 --- a/arch/arm/mach-omap2

[PATCH V2 03/10] ARM: OMAP4: Re-map the CTIs IRQs from MPU to DEBUGSS

2012-06-07 Thread Jon Hunter
upon Benoit Cousson's patch [1]. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/073319.html Cc: Ming Lei Cc: Will Deacon Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Reviewed-by: Santosh Shilimkar Signed-off-by: Jon Hunter --- arch/arm/mach-

[PATCH V2 05/10] ARM: OMAP2+: PMU: Add runtime PM support

2012-06-07 Thread Jon Hunter
/074153.html Cc: Ming Lei Cc: Will Deacon Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/pmu.c |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/mach-omap2/pmu.c b/arch/arm/mach-omap2/pmu.c index b3b9306..1b36eda

[PATCH V2 06/10] ARM: OMAP4: Route PMU IRQs to CTI IRQs

2012-06-07 Thread Jon Hunter
on pandabo...@googlegroups.com. Ming's original patch was called "arm: omap4: support pmu" [1] and has been renamed and modified by Jon Hunter. There main differences from the original patch are ... 1. Instead of only configuring the CTI interrupt once during boot, the interrupts are

[PATCH V2 04/10] ARM: OMAP4430: Create PMU device via HWMOD

2012-06-07 Thread Jon Hunter
-pmu device via these three HWMODs. Cc: Ming Lei Cc: Will Deacon Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Signed-off-by: Ming Lei Signed-off-by: Will Deacon Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/pmu.c | 46 + 1 file

[PATCH V2 09/10] ARM: OMAP4: Enable PMU for OMAP4460/70

2012-06-07 Thread Jon Hunter
can use the same function to create the PMU device that is using by OMAP2/3. Cc: Ming Lei Cc: Will Deacon Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |2 ++ arch/arm/mach-omap2/pmu.c

[PATCH V2 00/10] ARM: OMAP4: Add PMU Support

2012-06-07 Thread Jon Hunter
Cc: Ming Lei Cc: Will Deacon Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Jon Hunter (8): ARM: PMU: Add runtime PM Support ARM: OMAP2+: PMU: Convert OMAP2/3 devices to use HWMOD ARM: OMAP4: Re-map the CTIs IRQs from MPU to DEBUGSS ARM: OMAP2+: PMU: Add runtime PM support AR

[PATCH V2 10/10] ARM: OMAP2+: PMU: Add QoS constraint

2012-06-07 Thread Jon Hunter
: Will Deacon Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Signed-off-by: Jon Hunter --- arch/arm/mach-omap2/pmu.c | 52 ++--- 1 file changed, 49 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/pmu.c b/arch/arm/mach-omap2/pmu.c

[PATCH V2 02/10] ARM: OMAP2+: PMU: Convert OMAP2/3 devices to use HWMOD

2012-06-07 Thread Jon Hunter
2/pmu.c + * + * OMAP2 ARM Performance Monitoring Unit (PMU) Support + * + * Copyright (C) 2012 Texas Instruments, Inc. + * + * Contacts: + * Jon Hunter + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the

[PATCH 0/2] arm/dts: Add OMAP2420 SDP support

2012-06-07 Thread Jon Hunter
This series fixes the OMAP2 interrupt controller binding and adds support for the OMAP2420 SDP board. I have verified that the kernel boots with device-tree on this board. This series is based upon the linux-omap master branch (3.5-rc1). Jon Hunter (2): arm/dts: OMAP2: Add support for OMAP2420

[PATCH 0/2] arm/dts: Add OMAP2420 SDP support

2012-06-07 Thread Jon Hunter
This series fixes the OMAP2 interrupt controller binding and adds support for the OMAP2420 SDP board. I have verified that the kernel boots with device-tree on this board. This series is based upon the linux-omap master branch (3.5-rc1). Jon Hunter (2): arm/dts: OMAP2: Add support for OMAP2420

[PATCH 1/2] arm/dts: OMAP2: Add support for OMAP2420 SDP

2012-06-07 Thread Jon Hunter
Simple DTS file for OMAP2420 SDP adding memory information to allow device-tree testing on an OMAP2420 SDP. Verified that kernel boots with DT using a simple RAMDISK file-system on OMAP2420 SDP. Signed-off-by: Jon Hunter --- arch/arm/boot/dts/omap2420-sdp.dts | 20 1

[PATCH 2/2] arm/dts: OMAP2: Fix interrupt controller binding

2012-06-07 Thread Jon Hunter
roblem. This is based upon latest linux-omap master (3.5-rc1) git tree. Signed-off-by: Jon Hunter --- arch/arm/boot/dts/omap2.dtsi |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/omap2.dtsi b/arch/arm/boot/dts/omap2.dtsi index f2ab4ea..581cb08 100644 --- a/arch/arm/bo

Re: [PATCH 1/2] arm/dts: OMAP2: Add support for OMAP2420 SDP

2012-06-07 Thread Jon Hunter
On 06/07/2012 05:06 PM, Jon Hunter wrote: > Simple DTS file for OMAP2420 SDP adding memory information to allow > device-tree > testing on an OMAP2420 SDP. > > Verified that kernel boots with DT using a simple RAMDISK file-system on > OMAP2420 SDP. > > Signed-off-by: J

[PATCH V2 0/2] arm/dts: Add OMAP2420 SDP support

2012-06-07 Thread Jon Hunter
This series fixes the OMAP2 interrupt controller binding and adds support for the OMAP2420 SDP board. I have verified that the kernel boots with device-tree on this board. This series is based upon the linux-omap master branch (3.5-rc1). Jon Hunter (2): arm/dts: OMAP2: Add support for OMAP2420

[PATCH V2 1/2] arm/dts: OMAP2: Add support for OMAP2420 SDP

2012-06-07 Thread Jon Hunter
Simple DTS file for OMAP2420 SDP adding memory information to allow device-tree testing on an OMAP2420 SDP. Verified that kernel boots with DT using a simple RAMDISK file-system on OMAP2420 SDP. Signed-off-by: Jon Hunter --- arch/arm/boot/dts/omap2420-sdp.dts | 20 1

[PATCH V2 2/2] arm/dts: OMAP2: Fix interrupt controller binding

2012-06-07 Thread Jon Hunter
roblem. This is based upon latest linux-omap master (3.5-rc1) git tree. Signed-off-by: Jon Hunter --- arch/arm/boot/dts/omap2.dtsi |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/omap2.dtsi b/arch/arm/boot/dts/omap2.dtsi index f2ab4ea..581cb08 100644 --- a/arch/arm/bo

[RFC] ARM: OMAP4470: Fix OMAP4470 boot failure

2012-06-07 Thread Jon Hunter
the clocks are being registered for OMAP4470 devices and so on boot-up no clocks can be found and the kernel panics. This fix always the kernel to boot without failure using a simple RAMDISK file system. However, I need some inputs from the clock guru's if this is the correct fix :-) Si

Re: [RFC] ARM: OMAP4470: Fix OMAP4470 boot failure

2012-06-07 Thread Jon Hunter
On 06/07/2012 06:00 PM, Jon Hunter wrote: > OMAP4470 currently fails to boot, printing various messages such as ... > > omap_hwmod: mpu: cannot clk_get main_clk dpll_mpu_m2_ck > omap_hwmod: mpu: cannot _init_clocks > [ cut here ] > WARNING: at a

Re: [PATCH V2 00/10] ARM: OMAP4: Add PMU Support

2012-06-07 Thread Jon Hunter
On 06/07/2012 04:22 PM, Jon Hunter wrote: > This series adds PMU support for OMAP4 devices. This is based upon Will > Deacons > series [1]. This series fixes the management of the EMU power domain so that > PMU can be enabled at runtime and low-power states are not prevented when PMU

Re: [PATCH V2 01/10] ARM: PMU: Add runtime PM Support

2012-06-08 Thread Jon Hunter
Hi Will, On 06/08/2012 04:47 AM, Will Deacon wrote: > Hi Jon, > > On Thu, Jun 07, 2012 at 10:22:03PM +0100, Jon Hunter wrote: >> diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c >> index 186c8cb..00adb98 100644 >> --- a/arch/arm/kernel/per

Re: [PATCH V2 01/10] ARM: PMU: Add runtime PM Support

2012-06-08 Thread Jon Hunter
Hi Will, On 06/08/2012 04:47 AM, Will Deacon wrote: > Hi Jon, > > On Thu, Jun 07, 2012 at 10:22:03PM +0100, Jon Hunter wrote: >> diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c >> index 186c8cb..00adb98 100644 >> --- a/arch/arm/kernel/per

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-08 Thread Jon Hunter
Hi Stephen, Arnd, Been a while ;-) On 05/21/2012 03:32 PM, Stephen Warren wrote: > On 05/21/2012 12:18 PM, Arnd Bergmann wrote: >> On Monday 21 May 2012, Stephen Warren wrote: The point with the direction was that it covers most cases and makes them rather simple, while for the rar

Re: [PATCH 0/5] OMAP3530evm misc fixes for linux-omap

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:00 AM, Zumeng Chen wrote: > These patches fix misc problems when reflash ti-omap3530evm for > master branch on Linux-omap. Currently they have been tested on > 3530evm but were not ack'ed. > > Most of them are the leftovers from the great original developers > with my the latest

Re: [PATCH 1/5] ARM: OMAP3EVM: Add NAND flash definition

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:00 AM, Zumeng Chen wrote: > Signed-off-by: Vaibhav Hiremath > Tested-by: Zumeng Chen I think that you need to have something in the changelog above, even if this is a trivial change. > --- > arch/arm/mach-omap2/board-omap3evm.c | 39 > ++ >

Re: [PATCH 4/5] MFD: OMAP3EVM: USB: cosmetic fix to failed parent clk set

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:00 AM, Zumeng Chen wrote: > A typo fix for this cosmetic change and mute a failed message from > a unnecessary setting of some parent clk for usbhs_omap on OMAP3EVM. > > Signed-off-by: Zumeng Chen > --- > drivers/mfd/omap-usb-host.c |4 +++- > 1 files changed, 3 insertions(

Re: [PATCH 1/3] ARM: OMAP2+: nand: unify init functions

2012-06-11 Thread Jon Hunter
change? Otherwise, looks good. Reviewed-by: Jon Hunter Cheers Jon [1] http://www.alwaysinnovating.com/wiki/index.php/Booting -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] ARM: OMAP2+: onenand: cleanup for gpmc driver conversion

2012-06-11 Thread Jon Hunter
Hi Afzal, On 06/11/2012 09:01 AM, Afzal Mohammed wrote: > Reorganize gpmc-onenand initialization so that changes > required for gpmc driver migration can be made smooth. > > Ensuring sync read/write are disabled in onenand cannot be > expect to work properly unless GPMC is setup, this has been >

Re: [PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings

2012-06-11 Thread Jon Hunter
Hi Afzal, On 06/11/2012 09:02 AM, Afzal Mohammed wrote: > Configure busturnaround, cycle2cycledelay, waitmonitoringtime, > clkactivationtime in gpmc_cs_set_timings(). This is done so > that boards can configure these parameters of gpmc in Kernel > instead of relying on bootloader. What boards hav

Re: [PATCH V2 01/10] ARM: PMU: Add runtime PM Support

2012-06-11 Thread Jon Hunter
Hi Will, On 06/11/2012 12:39 PM, Will Deacon wrote: > On Fri, Jun 08, 2012 at 04:24:32PM +0100, Jon Hunter wrote: >> Hi Will, > > Hi Jon, > >> Here is an updated version. I was going to send out a V3, but I wanted >> to wait to see if others had more comments first

Re: [PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-06-11 Thread Jon Hunter
Hi Afzal, On 06/11/2012 09:26 AM, Afzal Mohammed wrote: > Create API for platforms to adapt gpmc to HWMOD > > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc.c | 31 +++ > arch/arm/plat-omap/include/plat/gpmc.h |2 ++ > 2 files change

Re: [PATCH v5 03/14] ARM: OMAP2+: gpmc: driver migration helper

2012-06-11 Thread Jon Hunter
Hi Afzal, On 06/11/2012 09:26 AM, Afzal Mohammed wrote: > A driver is being created out of GPMC code. This is being > attempted to acheive by not breaking existing interface, > necessitating requirement of GPMC peripherals being able > to work with as well as without the help of driver. To not > b

Re: [PATCH v5 04/14] ARM: OMAP2+: gpmc: minimal driver support

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:26 AM, Afzal Mohammed wrote: > Create a minimal driver out of gpmc code. > Responsibilities handled by earlier gpmc > initialization is now achieved in probe. > > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc.c | 170 >

Re: [PATCH v5 05/14] ARM: OMAP2+: gpmc: resource creation helpers

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:26 AM, Afzal Mohammed wrote: > Helpers for propulating given resource structure > with memory & interrupt information. > > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc.c | 45 > > 1 file changed, 45 insertions(+)

Re: [PATCH v5 06/14] ARM: OMAP2+: gpmc: CS configuration helper

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:26 AM, Afzal Mohammed wrote: > Helper for configuring given CS based on flags. > > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc.c | 33 > > arch/arm/plat-omap/include/plat/gpmc.h |5 + > 2 files changed,

Re: [PATCH v5 08/14] ARM: OMAP2+: gpmc: bool type timing helper

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Some of the timing configuration like extra delay > has bool type configurations. Provide a helper so > that these too can be configured in Kernel. > > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc.c | 55 >

Re: [PATCH v5 09/14] ARM: OMAP2+: gpmc: holler if no configuration

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Some of the GPMC peripherals depend on bootloader to do the > configuration. This facility is deprecated, notify user > about the present GPMC settings & inform that that relying > on bootloader for GPMC setting is deprecated. Nit, "holler" is slang

Re: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Helper for configuring waitpin. There are two parts to it; > configuring at CS level and the other at device level. > A device embedding multiple CS has been provided the > capability to use same waitpin (different waitpins has not > been supported a

Re: [PATCH v5 12/14] ARM: OMAP2+: gpmc: cs reconfigure helper

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Helper for reconfiguring CS, peripheral that necessitated > it was OneNAND. Why? I think you need to add more about why this was needed. Jon > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc.c | 32 > +++

Re: [PATCH 4/5] MFD: OMAP3EVM: USB: cosmetic fix to failed parent clk set

2012-06-12 Thread Jon Hunter
On 06/11/2012 09:30 PM, Zumeng Chen wrote: > > > 2012/6/11 Jon Hunter mailto:jon-hun...@ti.com>> > > > On 06/11/2012 09:00 AM, Zumeng Chen wrote: > > A typo fix for this cosmetic change and mute a failed message from > > a unnecessary setting

Re: [PATCH V2 1/2] arm/dts: OMAP2: Add support for OMAP2420 SDP

2012-06-12 Thread Jon Hunter
On 06/12/2012 02:20 AM, Tony Lindgren wrote: > * Jon Hunter [120607 15:15]: >> Simple DTS file for OMAP2420 SDP adding memory information to allow >> device-tree >> testing on an OMAP2420 SDP. >> >> Verified that kernel boots with DT using a simple RAMDISK file-

Re: [PATCH 2/3] ARM: OMAP2+: onenand: cleanup for gpmc driver conversion

2012-06-12 Thread Jon Hunter
On 06/12/2012 01:16 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 00:06:30, Hunter, Jon wrote: > >> I agree with getting rid of the first instance at the beginning of >> _set_async_mode, but why get rid of the above one? Are you assuming that >> by default it is in async mode

Re: [PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings

2012-06-12 Thread Jon Hunter
On 06/12/2012 01:37 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 00:19:35, Hunter, Jon wrote: > >> What boards have been tested with this change? > > Beagle board, after applying all 5 series of patches, without all > patch series it can't be tested for beagle board as it d

Re: [PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-06-12 Thread Jon Hunter
On 06/12/2012 01:53 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 01:26:29, Hunter, Jon wrote: > >>> + pdev = omap_device_build(name, -1, oh, pdata, >>> + sizeof(*pdata), NULL, 0, 0); >>> + if (IS_ERR(pdev)) { >>> + WARN(1, "Can'

Re: [PATCH v5 03/14] ARM: OMAP2+: gpmc: driver migration helper

2012-06-12 Thread Jon Hunter
On 06/12/2012 02:09 AM, Mohammed, Afzal wrote: > Hi Jon, > > This change is required only till driver migration of all platforms > are done, after it, this hackish patch has to be reverted. This has > been done so that existing interface will work for each patch of > this series as well as till a

Re: [PATCH v5 04/14] ARM: OMAP2+: gpmc: minimal driver support

2012-06-12 Thread Jon Hunter
On 06/12/2012 02:16 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 02:13:22, Hunter, Jon wrote: > >>> + gpmc_revision = (l >> 4) & 0xf; >> >> Why are you only storing the major part of the rev? Why not keep both parts? > > Does having minor revision add any value ?, at least

Re: [PATCH v5 05/14] ARM: OMAP2+: gpmc: resource creation helpers

2012-06-12 Thread Jon Hunter
On 06/12/2012 03:30 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 02:27:09, Hunter, Jon wrote: > >>> +static __devinit int gpmc_setup_cs_mem(struct gpmc_cs_data *cs, >>> + struct resource *res) > >>> + return 1; >>> +} >> >> Nit-pic

Re: [PATCH v5 06/14] ARM: OMAP2+: gpmc: CS configuration helper

2012-06-12 Thread Jon Hunter
On 06/12/2012 03:40 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 03:13:02, Hunter, Jon wrote: > >>> +static void gpmc_setup_cs_config(unsigned cs, unsigned conf) >>> +{ >>> + u32 l = gpmc_cs_read_reg(cs, GPMC_CS_CONFIG1); >> >> Why is it necessary to read the register first

Re: [PATCH v5 06/14] ARM: OMAP2+: gpmc: CS configuration helper

2012-06-12 Thread Jon Hunter
On 06/12/2012 07:58 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 14:10:08, Mohammed, Afzal wrote: > + l |= conf & GPMC_CONFIG1_DEVICETYPE_NAND; + l |= conf & GPMC_CONFIG1_DEVICESIZE_16; >>> >>> I can see that it works to use the above definitions as masks because

Re: [PATCH v5 09/14] ARM: OMAP2+: gpmc: holler if no configuration

2012-06-12 Thread Jon Hunter
On 06/12/2012 03:44 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 04:00:20, Hunter, Jon wrote: > >> Nit, "holler" is slang. Just say WARN. > > It was a deliberate attempt to add human (or read humorous) touch I like that, but I wonder if it could confuse some :-) Jon -- To

Re: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-12 Thread Jon Hunter
On 06/12/2012 04:00 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 04:29:09, Hunter, Jon wrote: > >>> +enum { >>> + GPMC_WAITPIN_IDX0, >>> + GPMC_WAITPIN_IDX1, >>> + GPMC_WAITPIN_IDX2, >>> + GPMC_WAITPIN_IDX3, >>> + GPMC_NR_WAITPIN >>> +}; >> >> Max number of wait pi

Re: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-12 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Helper for configuring waitpin. There are two parts to it; > configuring at CS level and the other at device level. > A device embedding multiple CS has been provided the > capability to use same waitpin (different waitpins has not > been supported a

Re: [PATCH v5 14/14] ARM: OMAP2+: gpmc: writeprotect helper

2012-06-12 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > GPMC has a writeprotect pin that can be connected to > peripherals. If any CS wants to enable writeprotect, > writeprotect will be enabled, once CS configurations > are finished. I am still wondering if we should warn against multiple devices using

Re: [PATCH v5 07/14] ARM: OMAP2+: gpmc: time setting (register#) helper

2012-06-12 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Helper for setting GPMC timing by taking input as register values. When are the timings calculated? Why not just use the existing gpmc_cs_set_timings()? I guess I am not convinced that we need to have multiple formats to pass timings such as clock,

Re: [PATCH v5 01/14] ARM: OMAP2+: gpmc: platform definitions

2012-06-12 Thread Jon Hunter
On 06/11/2012 09:26 AM, Afzal Mohammed wrote: > gpmc driver platform definitions > > Signed-off-by: Afzal Mohammed > --- > arch/arm/plat-omap/include/plat/gpmc.h | 49 > > 1 file changed, 49 insertions(+) > > diff --git a/arch/arm/plat-omap/include/plat/gpmc

Re: [PATCH v5 04/14] ARM: OMAP2+: gpmc: minimal driver support

2012-06-12 Thread Jon Hunter
On 06/11/2012 09:26 AM, Afzal Mohammed wrote: > Create a minimal driver out of gpmc code. > Responsibilities handled by earlier gpmc > initialization is now achieved in probe. > > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc.c | 170 >

Re: [PATCH V2 01/10] ARM: PMU: Add runtime PM Support

2012-06-12 Thread Jon Hunter
Hi Will, On 06/12/2012 04:28 AM, Will Deacon wrote: > On Mon, Jun 11, 2012 at 08:01:23PM +0100, Jon Hunter wrote: >> Hi Will, > > Hello, > >> On 06/11/2012 12:39 PM, Will Deacon wrote: >>> This looks better to me, so I took it for a spin on my 4460 (thanks &

Re: [PATCH V2 01/10] ARM: PMU: Add runtime PM Support

2012-06-12 Thread Jon Hunter
On 06/12/2012 04:31 PM, Will Deacon wrote: > On Tue, Jun 12, 2012 at 10:17:16PM +0100, Jon Hunter wrote: >> Hi Will, > > Hi Jon, > >> On 06/12/2012 04:28 AM, Will Deacon wrote: >>> >>> Well, I tried that and the results are pretty whacky: the event

[PATCH V3 0/2] arm/dts: Add OMAP2420 SDP support

2012-06-12 Thread Jon Hunter
copyright date Jon Hunter (2): arm/dts: OMAP2: Add support for OMAP2420H4 Board arm/dts: OMAP2: Fix interrupt controller binding arch/arm/boot/dts/omap2.dtsi |2 ++ arch/arm/boot/dts/omap2420-sdp.dts | 20 2 files changed, 22 insertions(+) create mode 100644

[PATCH V3 2/2] arm/dts: OMAP2: Fix interrupt controller binding

2012-06-12 Thread Jon Hunter
roblem. This is based upon latest linux-omap master (3.5-rc1) git tree. Signed-off-by: Jon Hunter --- arch/arm/boot/dts/omap2.dtsi |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/omap2.dtsi b/arch/arm/boot/dts/omap2.dtsi index f2ab4ea..581cb08 100644 --- a/arch/arm/bo

[PATCH V3 1/2] arm/dts: OMAP2: Add support for OMAP2420H4 Board

2012-06-12 Thread Jon Hunter
Simple DTS file for OMAP2420H4 board adding memory information to allow device-tree testing on an OMAP2420. OMAP2420H4 board has 64MB of RAM. Verified that kernel boots with DT using a simple RAMDISK file-system on OMAP2420H4. Signed-off-by: Jon Hunter --- arch/arm/boot/dts/omap2420-sdp.dts

Re: [PATCH V3 0/2] arm/dts: Add OMAP2420 SDP support

2012-06-12 Thread Jon Hunter
On 06/12/2012 07:10 PM, Jon Hunter wrote: > This series fixes the OMAP2 interrupt controller binding and adds support for > the OMAP2420H4 board. I have verified that the kernel boots with device-tree > on this board. Oops! Forgot to change SDP to H4 in the $SUBJECT. However, should b

Re: [PATCH V3 0/2] arm/dts: Add OMAP2420 SDP support

2012-06-12 Thread Jon Hunter
On 06/12/2012 07:13 PM, Jon Hunter wrote: > > On 06/12/2012 07:10 PM, Jon Hunter wrote: >> This series fixes the OMAP2 interrupt controller binding and adds support for >> the OMAP2420H4 board. I have verified that the kernel boots with device-tree >> on this board. >

[RESEND PATCH V3 0/2] arm/dts: Add OMAP2420 H4 support

2012-06-12 Thread Jon Hunter
copyright date Jon Hunter (2): arm/dts: OMAP2: Add support for OMAP2420H4 Board arm/dts: OMAP2: Fix interrupt controller binding arch/arm/boot/dts/omap2.dtsi |2 ++ arch/arm/boot/dts/omap2420-h4.dts | 20 2 files changed, 22 insertions(+) create mode 100644

[RESEND PATCH V3 2/2] arm/dts: OMAP2: Fix interrupt controller binding

2012-06-12 Thread Jon Hunter
roblem. This is based upon latest linux-omap master (3.5-rc1) git tree. Signed-off-by: Jon Hunter --- arch/arm/boot/dts/omap2.dtsi |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/omap2.dtsi b/arch/arm/boot/dts/omap2.dtsi index f2ab4ea..581cb08 100644 --- a/arch/arm/bo

[RESEND PATCH V3 1/2] arm/dts: OMAP2: Add support for OMAP2420H4 Board

2012-06-12 Thread Jon Hunter
Simple DTS file for OMAP2420H4 board adding memory information to allow device-tree testing on an OMAP2420. OMAP2420H4 board has 64MB of RAM. Verified that kernel boots with DT using a simple RAMDISK file-system on OMAP2420H4. Signed-off-by: Jon Hunter --- arch/arm/boot/dts/omap2420-h4.dts

Re: [PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-06-13 Thread Jon Hunter
Hi Afzal, On 06/13/2012 12:20 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 23:10:01, Hunter, Jon wrote: >> On 06/12/2012 01:53 AM, Mohammed, Afzal wrote: >>> On Tue, Jun 12, 2012 at 01:26:29, Hunter, Jon wrote: > My preference would be to store gpmc_l3_clk in the pdata a

Re: [PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-06-13 Thread Jon Hunter
Hi Afzal, On 06/13/2012 08:05 AM, Mohammed, Afzal wrote: > Hi Tony, > > On Wed, Jun 13, 2012 at 17:32:09, Tony Lindgren wrote: >> * Mohammed, Afzal [120612 22:24]: >>> Hi Jon, >>> >>> On Tue, Jun 12, 2012 at 23:10:01, Hunter, Jon wrote: > Right but potentially, this could be done by the dr

Re: [PATCH v5 11/14] ARM: OMAP2+: gpmc: handle connected peripherals

2012-06-13 Thread Jon Hunter
Hi Afzal, On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Platform will provide driver with configuration details for > each CS like configuration, timing, interrupts. Setup GPMC > based on it. Platform data also provides platform data & > resources used for connected peripheral (eg. gpio irq). >

Re: [PATCH v5 05/14] ARM: OMAP2+: gpmc: resource creation helpers

2012-06-13 Thread Jon Hunter
Hi Afzal, On 06/13/2012 12:29 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 23:32:05, Hunter, Jon wrote: > >> Well looking at the function it seems that you either return an error >> code or 1. So if you are never going to return anything other than 1 on >> success it may as w

Re: [PATCH v5 06/14] ARM: OMAP2+: gpmc: CS configuration helper

2012-06-13 Thread Jon Hunter
Hi Afzal, On 06/13/2012 12:50 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 23:39:32, Hunter, Jon wrote: >> On 06/12/2012 07:58 AM, Mohammed, Afzal wrote: > >>> Thinking again over it, I am feeling above is sufficient, reason same as >>> said earlier, to keep code simple & cur

Re: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-13 Thread Jon Hunter
Hi Afzal, On 06/13/2012 02:37 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 23:45:36, Hunter, Jon wrote: > >> GPMC_WAITPIN_IDX0 = 0 >> GPMC_WAITPIN_0 = 1 >> >> So, GPMC_WAITPIN_IDX0 = GPMC_WAITPIN_0 - 1, assuming that you want idx = >> 0 and not 1. Or you could change you shif

Re: [PATCH v5 14/14] ARM: OMAP2+: gpmc: writeprotect helper

2012-06-13 Thread Jon Hunter
Hi Afzal, On 06/13/2012 01:10 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Wed, Jun 13, 2012 at 00:12:27, Hunter, Jon wrote: > >> I am still wondering if we should warn against multiple devices using >> the wait pin. I see that if could be valid to have multiple memory >> devices of the same type

Re: [PATCH 2/3] ARM: OMAP2+: onenand: cleanup for gpmc driver conversion

2012-06-13 Thread Jon Hunter
Hi Afzal, On 06/13/2012 12:03 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 23:00:48, Hunter, Jon wrote: > >> On 06/12/2012 01:16 AM, Mohammed, Afzal wrote: >>> With the existing code, set_async was done as part of set_sync, hence >>> requiring GPMC to be configured twice afte

Re: [PATCH 0/3] Prepare for GPMC driver conversion

2012-06-13 Thread Jon Hunter
Hi Tony, Afzal, On 06/13/2012 07:40 AM, Mohammed, Afzal wrote: > Hi Tony, > > On Wed, Jun 13, 2012 at 17:03:59, Tony Lindgren wrote: > >> NAND for untested boards if timings change. Are Jon's comments all handled? > > I have explained the justification, why those changes were done so, > waiting

Re: [PATCH v5 04/14] ARM: OMAP2+: gpmc: minimal driver support

2012-06-13 Thread Jon Hunter
On 06/13/2012 08:40 AM, Tony Lindgren wrote: > * Mohammed, Afzal [120613 06:16]: >> Hi Tony, >> >> On Wed, Jun 13, 2012 at 17:37:17, Tony Lindgren wrote: >>> * Jon Hunter [120612 11:01]: >>>> >>>> On 06/12/2012 02:16 AM, Mohammed, Afzal wr

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-13 Thread Jon Hunter
Hi Arnd, On 06/08/2012 07:04 PM, Arnd Bergmann wrote: > On Friday 08 June 2012, Jon Hunter wrote: >> On 05/21/2012 03:32 PM, Stephen Warren wrote: >>> On 05/21/2012 12:18 PM, Arnd Bergmann wrote: >>>> On Monday 21 May 2012, Stephen Warren wrote: >>>>&

<    1   2   3   4   5   6   7   8   9   10   >