Re: [PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count

2012-07-19 Thread Menon, Nishanth
Minor nitpick: On Mon, Jun 11, 2012 at 10:26 AM, Tero Kristo t-kri...@ti.com wrote: +/** + * _omap4_get_context_lost - get context loss counter for a hwmod Documentation missing for oh btw, you might be interested in using http://www.omappedia.org/wiki/Kmake to provide list of kerneldoc errors

Re: [PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count

2012-07-19 Thread Tero Kristo
On Thu, 2012-07-19 at 00:55 -0500, Menon, Nishanth wrote: On Wed, Jul 18, 2012 at 4:15 AM, Tero Kristo t-kri...@ti.com wrote: On Tue, 2012-07-17 at 02:59 -0500, Menon, Nishanth wrote: Couple of minor comments: On Mon, Jun 11, 2012 at 10:26 AM, Tero Kristo t-kri...@ti.com wrote: [...]

Re: [PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count

2012-07-19 Thread Menon, Nishanth
On Thu, Jul 19, 2012 at 4:49 AM, Tero Kristo t-kri...@ti.com wrote: Zero doesn't mean no context loss. If counter was previous MAX_INT, if it goes to zero it is still a context loss, as the counter value differs. Drivers do check against diff in the context loss counter, and if there is one,

Re: [PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count

2012-07-19 Thread Shilimkar, Santosh
On Thu, Jul 19, 2012 at 3:19 PM, Tero Kristo t-kri...@ti.com wrote: On Thu, 2012-07-19 at 00:55 -0500, Menon, Nishanth wrote: On Wed, Jul 18, 2012 at 4:15 AM, Tero Kristo t-kri...@ti.com wrote: On Tue, 2012-07-17 at 02:59 -0500, Menon, Nishanth wrote: Couple of minor comments: On

Re: [PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count

2012-07-19 Thread Tero Kristo
On Thu, 2012-07-19 at 16:05 +0530, Shilimkar, Santosh wrote: On Thu, Jul 19, 2012 at 3:19 PM, Tero Kristo t-kri...@ti.com wrote: On Thu, 2012-07-19 at 00:55 -0500, Menon, Nishanth wrote: On Wed, Jul 18, 2012 at 4:15 AM, Tero Kristo t-kri...@ti.com wrote: On Tue, 2012-07-17 at 02:59

Re: [PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count

2012-07-19 Thread Tero Kristo
On Thu, 2012-07-19 at 05:27 -0500, Menon, Nishanth wrote: On Thu, Jul 19, 2012 at 4:49 AM, Tero Kristo t-kri...@ti.com wrote: Zero doesn't mean no context loss. If counter was previous MAX_INT, if it goes to zero it is still a context loss, as the counter value differs. Drivers do check

Re: [PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count

2012-07-18 Thread Tero Kristo
On Tue, 2012-07-17 at 02:59 -0500, Menon, Nishanth wrote: Couple of minor comments: On Mon, Jun 11, 2012 at 10:26 AM, Tero Kristo t-kri...@ti.com wrote: [...] /** + * _omap4_update_context_lost - increment hwmod context loss counter if + * hwmod context was lost, and clear hardware

Re: [PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count

2012-07-18 Thread Menon, Nishanth
On Wed, Jul 18, 2012 at 4:15 AM, Tero Kristo t-kri...@ti.com wrote: On Tue, 2012-07-17 at 02:59 -0500, Menon, Nishanth wrote: Couple of minor comments: On Mon, Jun 11, 2012 at 10:26 AM, Tero Kristo t-kri...@ti.com wrote: [...] /** + * _omap4_update_context_lost - increment hwmod

Re: [PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count

2012-07-17 Thread Menon, Nishanth
Couple of minor comments: On Mon, Jun 11, 2012 at 10:26 AM, Tero Kristo t-kri...@ti.com wrote: [...] /** + * _omap4_update_context_lost - increment hwmod context loss counter if + * hwmod context was lost, and clear hardware context loss reg + * @oh: hwmod to check for context loss + * + *

[PATCHv6 4/7] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count

2012-06-11 Thread Tero Kristo
From: Rajendra Nayak rna...@ti.com OMAP4 has module specific context lost registers which makes it now possible to have module level context loss count, instead of relying on the powerdomain level context count. Add 2 private hwmod api's to update/clear the hwmod/module specific context lost