serial_cs bug (serial subsystem, not pcmcia subsystem)

2010-09-19 Thread Dominik Brodowski
Hey Pavel, thanks for testing! On Sun, Sep 19, 2010 at 12:04:36PM +0200, Pavel Machek wrote: > No, I still have the problem in -rc4. > > I did a quick test, and 2.6.35+your bigdiff works ok. so we now have two indepenent indications something is broken in the serial subsystem -- the other bein

Re: [PATCH 07/14] pcmcia: ds: fix device_register() error handling

2010-09-19 Thread Dominik Brodowski
On Sun, Sep 19, 2010 at 04:54:58PM +0400, Vasiliy Kulikov wrote: > If device_register() fails then call put_device(). > See comment to device_register. > > Signed-off-by: Vasiliy Kulikov Acked-by: Dominik Brodowski Thanks, Dominik ___ Linux P

Re: [PATCH 06/14] pcmcia: cs: fix device_register() error handling

2010-09-19 Thread Dominik Brodowski
On Sun, Sep 19, 2010 at 04:54:55PM +0400, Vasiliy Kulikov wrote: > If device_register() fails then call put_device(). > See comment to device_register. > > Signed-off-by: Vasiliy Kulikov Acked-by: Dominik Brodowski Thanks, Dominik ___ Linux P

[PATCH 07/14] pcmcia: ds: fix device_register() error handling

2010-09-19 Thread Vasiliy Kulikov
If device_register() fails then call put_device(). See comment to device_register. Signed-off-by: Vasiliy Kulikov --- compile tested. drivers/pcmcia/ds.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c index 100c441..b56f5a6

[PATCH 06/14] pcmcia: cs: fix device_register() error handling

2010-09-19 Thread Vasiliy Kulikov
If device_register() fails then call put_device(). See comment to device_register. Signed-off-by: Vasiliy Kulikov --- compile tested. drivers/pcmcia/cs.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c index d8189d4..9e8ab51 10

Re: Re: Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-19 Thread Pavel Machek
Hi! > > Nothing relating to setting CISREG_COR (at least on pcnet_cs) changed, and > serial_cs does not modify CISREG_COR on such pseudo-multifunction devices. > > Would it be possible for you to re-check plain 2.6.35 and 2.6.35 with the > pcmcia patchset availble at > http://userweb.kerne

serial_cs bug (serial subsystem, not pcmcia subsystem)

2010-09-19 Thread Dominik Brodowski
Hey, On Sun, Sep 19, 2010 at 04:39:23PM +0900, Komuro wrote: > Hi, > > > http://userweb.kernel.org/~brodo/pcmcia-2.6.35.diff > > Serial part of Xircom card works with pcmcia-2.6.35.diff. thanks for testing. This means that some non-PCMCIA change since 2.6.35 broke the serial part of Xircom

Re: Re: Re: Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-19 Thread Komuro
Hi, > http://userweb.kernel.org/~brodo/pcmcia-2.6.35.diff Serial part of Xircom card works with pcmcia-2.6.35.diff. - Original Message - >Date: Sat, 18 Sep 2010 15:32:12 +0200 >From: Dominik Brodowski >To: Komuro , pa...@ucw.cz >Cc: linux-pcmcia@lists.infradead.org >Subject: Re: