On Wed, May 30, 2012 at 2:25 AM, Hefty, Sean wrote:
>> Did you try out the patches? was it helpful to address the problem
>> you're facing?
> I have not had time to test it yet
so whenever you do have that time...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the b
Thanks for the feedback.
> 1. netperf: get_transport_info: getsockopt: errno 95
> This failure is due to the missing TCP_MAXSEG socket option support. May
> be this is OK as this option
> doesn't make much sense when using RDMA. Or we could return a reasonable
> value.
Missing socket options are
On 5/30/2012 12:10 PM, Pradeep Satyanarayana wrote:
On 05/30/2012 10:21 AM, Hefty, Sean wrote:
If a user calls rrecv() after a blocking rsocket has been disconnected,
it will hang. This problem and the cause was reported by Sridhar
Samudrala
. It can be reproduced by running netserver -f -D
Signed-off-by: Ilya Nelkenbaum
Reviewed-by: Hal Rosenstock
---
diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
index 7dcde87..04c7b18 100644
--- a/opensm/osm_subnet.c
+++ b/opensm/osm_subnet.c
@@ -1315,6 +1315,17 @@ int osm_subn_verify_config(IN osm_subn_opt_t * p_opts)
}
#endif
On 5/30/2012 7:03 PM, Ira Weiny wrote:
> On Wed, 30 May 2012 17:30:50 -0400
> Hal Rosenstock wrote:
>
>>
>> Add _v2 APIs for osm_log, osm_log_is_active, and osm_log_msg_box
>> Also, add these to libopensm.map
>> Add _V2 forms of the various OSM_LOG macros
>>
>> All of above pass additional parame
On Wed, 30 May 2012 17:30:50 -0400
Hal Rosenstock wrote:
>
> Add _v2 APIs for osm_log, osm_log_is_active, and osm_log_msg_box
> Also, add these to libopensm.map
> Add _V2 forms of the various OSM_LOG macros
>
> All of above pass additional parameter to identify module.
> Each module defines a u
An osm_file_ids_enum was added to the SM header and
a FILE_ID const definition to each source file.
This patch follows patch to add per module logging.
Signed-off-by: Ilya Nelkenbaum
Signed-off-by: Hal Rosenstock
---
diff --git a/include/opensm/osm_sm.h b/include/opensm/osm_sm.h
index 4c7b120.
I just posted a "V3.1" for patches 7 and 8, which converts variable
ibd_sa_smkey to ibd_sakey and config parameter sa_smkey to sa_key.
Jim
On Wed, 2012-05-30 at 11:43 -0700, Jim Foraker wrote:
> On Wed, 2012-05-30 at 11:06 -0700, Hal Rosenstock wrote:
> > On 5/30/2012 1:21 PM, Jim Forak
Defines a default for the smkey used in SA requests
Signed-off-by: Jim Foraker
---
etc/ibdiag.conf |3 +++
src/ibdiag_common.c |3 +++
2 files changed, 6 insertions(+)
diff --git a/etc/ibdiag.conf b/etc/ibdiag.conf
index 2a2334f..9686d14 100644
--- a/etc/ibdiag.conf
+++ b/etc/ibdiag
smkey is already defined as a global inside saquery.c, so remove
broken support for passing it around as a function parameter
Signed-off-by: Jim Foraker
---
include/ibdiag_common.h |1 +
src/ibdiag_common.c |1 +
src/saquery.c | 60 +++-
Signed-off-by: Hal Rosenstock
---
diff --git a/src/acme.c b/src/acme.c
index d3f8174..533588c 100644
--- a/src/acme.c
+++ b/src/acme.c
@@ -618,12 +618,18 @@ static void resolve(char *svc)
ret = resolve_name(&path);
break;
in acm_port_up
Signed-off-by: Hal Rosenstock
---
diff --git a/src/acm.c b/src/acm.c
index b47ee8a..c40f079 100644
--- a/src/acm.c
+++ b/src/acm.c
@@ -2794,7 +2794,8 @@ static void acm_port_up(struct acm_port *port)
port->mtu = attr.active_mtu;
port->rate = acm_get_rate(attr.act
Add _v2 APIs for osm_log, osm_log_is_active, and osm_log_msg_box
Also, add these to libopensm.map
Add _V2 forms of the various OSM_LOG macros
All of above pass additional parameter to identify module.
Each module defines a unique FILE_ID from 0-254.
255 is reserved to indicate "name not found".
F
On 05/30/2012 10:21 AM, Hefty, Sean wrote:
If a user calls rrecv() after a blocking rsocket has been disconnected,
it will hang. This problem and the cause was reported by Sridhar Samudrala
. It can be reproduced by running netserver -f -D
using the rs-preload library. A similar issue exists w
On Wed, 2012-05-30 at 11:06 -0700, Hal Rosenstock wrote:
> On 5/30/2012 1:21 PM, Jim Foraker wrote:
> > Defines a default for the smkey used in SA requests
> >
> > Signed-off-by: Jim Foraker
> > ---
> > etc/ibdiag.conf |3 +++
> > src/ibdiag_common.c |3 +++
> > 2 files changed, 6 i
On 5/30/2012 1:21 PM, Jim Foraker wrote:
> Defines a default for the smkey used in SA requests
>
> Signed-off-by: Jim Foraker
> ---
> etc/ibdiag.conf |3 +++
> src/ibdiag_common.c |3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/etc/ibdiag.conf b/etc/ibdiag.conf
> index 2
On Wed, 30 May 2012 10:09:02 -0700
Jim Foraker wrote:
> Alphabetize for standardization and greater clarity
Good idea, thanks applied,
Ira
>
> Signed-off-by: Jim Foraker
> ---
> src/ibcacheedit.c |2 +-
> src/iblinkinfo.c|2 +-
> src/ibnetdiscover.c |2 +-
> src/ibqueryerro
Signed-off-by: Jim Foraker
---
doc/rst/ibportstate.8.in.rst |6
src/ibportstate.c| 72 ++
2 files changed, 65 insertions(+), 13 deletions(-)
diff --git a/doc/rst/ibportstate.8.in.rst b/doc/rst/ibportstate.8.in.rst
index fca3f7a..052
smkey is already defined as a global inside saquery.c, so remove
broken support for passing it around as a function parameter
Signed-off-by: Jim Foraker
---
include/ibdiag_common.h |1 +
src/ibdiag_common.c |1 +
src/saquery.c | 60 +++-
Defines a default for the smkey used in SA requests
Signed-off-by: Jim Foraker
---
etc/ibdiag.conf |3 +++
src/ibdiag_common.c |3 +++
2 files changed, 6 insertions(+)
diff --git a/etc/ibdiag.conf b/etc/ibdiag.conf
index 2a2334f..1e6149d 100644
--- a/etc/ibdiag.conf
+++ b/etc/ibdiag
Signed-off-by: Jim Foraker
---
doc/rst/common/opt_m.rst|6 ++
doc/rst/ibaddr.8.in.rst |1 +
doc/rst/ibccconfig.8.in.rst |1 +
doc/rst/ibccquery.8.in.rst |1 +
doc/rst/iblinkinfo.8.in.rst
Signed-off-by: Jim Foraker
---
etc/ibdiag.conf |2 ++
src/ibdiag_common.c |2 ++
2 files changed, 4 insertions(+)
diff --git a/etc/ibdiag.conf b/etc/ibdiag.conf
index 77f3ce9..2a2334f 100644
--- a/etc/ibdiag.conf
+++ b/etc/ibdiag.conf
@@ -15,3 +15,5 @@
# Default = true
#MLX_EPI=fa
By default, display mkey lease and protection bits.
With a flag, also display mkey itself
Signed-off-by: Jim Foraker
---
doc/rst/ibportstate.8.in.rst |1 +
src/ibportstate.c| 30 --
2 files changed, 25 insertions(+), 6 deletions(-)
diff --git a/doc/
Necessary so that we may add credentials (ie, mkey) to it
Signed-off-by: Jim Foraker
---
Makefile.am |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index f861000..33b5f90 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -148,4 +148,4 @@ install-data
Cause security credentials to not be displayed by default. Instead,
the "-K" flag is supported, which must be passed to the command
to display valid results.
Signed-off-by: Jim Foraker
---
doc/rst/common/opt_K.rst |4 +++
doc/rst/saquery.8.in.rst |2 ++
doc/rst/smpquery.8.in.rst |2
Add setsockopt options that allow the user to specify the desired
size of the underlying QP. The provided sizes are used as the
maximum size when creating the QP. The actual sizes of the QP
are the smaller of the user provided maximum and the maximum
sizes supported by the underlying hardware.
A
Allow a user to control some of the RDMA related attributes
of an rsocket through setsockopt/getsockopt. A user specifies
that the rsocket should be modified through SOL_RDMA level.
This patch provides the initial framework. Subsequent patches
will add the configurable parameters.
Signed-off-by
Allow the user to override the default inline data size.
We still require a minimum size in order to transfer receive
buffer update message.
Signed-off-by: Sean Hefty
---
We can eliminate the need for inline entirely by reserving some of the
send buffer space for control messages, but that work i
Allow the user to specify the size of the send/receive queues
and inline data size through environment variables:
RS_SQ_SIZE, RS_RQ_SIZE, and RS_INLINE.
Signed-off-by: Sean Hefty
---
src/preload.c | 39 +++
1 files changed, 39 insertions(+), 0 deletions(-)
Signed-off-by: Sean Hefty
---
src/rsocket.c | 26 +++---
1 files changed, 11 insertions(+), 15 deletions(-)
diff --git a/src/rsocket.c b/src/rsocket.c
index ef070a8..b89ef42 100644
--- a/src/rsocket.c
+++ b/src/rsocket.c
@@ -126,6 +126,9 @@ union rs_wr_id {
};
};
Avoid possible buffer overrun.
Signed-off-by: Sean Hefty
---
examples/rstream.c | 38 +-
1 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/examples/rstream.c b/examples/rstream.c
index df36e34..054d11e 100644
--- a/examples/rstream.c
+++ b/exa
Simple latency/bandwidth tests using rstream showed minimal
difference in performance between using a QP sized to 384
entries versus 512. Reduce the overhead of a default rsocket
by using 384 entries. A user can request a larger size by
calling rsetsockopt.
Signed-off-by: Sean Hefty
---
src/rs
Signed-off-by: Sean Hefty
---
examples/rstream.c | 34 +-
man/rstream.1 |5 -
2 files changed, 17 insertions(+), 22 deletions(-)
diff --git a/examples/rstream.c b/examples/rstream.c
index c440f04..df36e34 100644
--- a/examples/rstream.c
+++ b/exampl
When ACM support is enabled in the librdmacm, it will attempt to
establish a socket connection to the ACM daemon. When the rsocket
preload library is in use, this can result in a recursive call
to socket() that results in the library hanging. The resulting
call stack is:
socket() -> rsocket() ->
When porting rsockets to iwarp, it was discovered that the default
QP size (512) was larger than that supported by the hardware.
Decrease the size of the QP if the default size is larger than
the maximum supported by the hardware.
Signed-off-by: Sean Hefty
---
src/cma.c | 10
src/
socket() can return 0 as a valid socket. This can happen
when using a daemon that closes stdin/out/err.
Signed-off-by: Sean Hefty
---
src/acm.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/acm.c b/src/acm.c
index bcf11da..9c65919 100755
--- a/src/acm.c
+++
Avoid creating a connection to the ACM service when
it's not needed. For example, if the user of the librdmacm
is a server application, it will not use ACM services.
Signed-off-by: Sean Hefty
---
src/acm.c | 22 +-
src/cma.c |2 --
src/cma.h |2 --
3 files changed,
If a user calls rrecv() after a blocking rsocket has been disconnected,
it will hang. This problem and the cause was reported by Sridhar Samudrala
. It can be reproduced by running netserver -f -D
using the rs-preload library. A similar issue exists with rsend().
Fix this by not blocking on a C
Optimize each connection for either latency or bandwidth
results. This improves small message latency under 384
bytes by .5 - 1 us, while increasing bandwidth by
1 - 1.5 Gbps.
Signed-off-by: Sean Hefty
---
examples/rstream.c | 146 ++--
1 files c
Signed-off-by: Sean Hefty
---
examples/rstream.c | 14 +-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/examples/rstream.c b/examples/rstream.c
index 104b318..c440f04 100644
--- a/examples/rstream.c
+++ b/examples/rstream.c
@@ -448,7 +448,8 @@ static int client_co
The following patch set provides fixes, adds user configurability,
and optimizes rsockets based on the needs and results of performance analysis
and wider testing.
Additional optimizations will follow, but I wanted to go ahead and
push these changes out.
Signed-off-by: Sean Hefty
--
To unsubscr
ucma_destroy_cqs() destroys both the send and recv CQs if they
are non-null. If the two CQs are actually the same one, this
results in a crash when trying to destroy the second CQ. Check
that the CQs are different before destroying the second CQ.
This fixes a crash when using rsockets, which set
I am about to send V3 of the patch set. Changes include:
. There is now a common "-K" option which must be passed in order to
view "sensitive" credentials. Data is shown as "" rather
than as invalid/all zeros, as an indication to the user that they should
pass -K in order to see it.
. Docu
Alphabetize for standardization and greater clarity
Signed-off-by: Jim Foraker
---
src/ibcacheedit.c |2 +-
src/iblinkinfo.c|2 +-
src/ibnetdiscover.c |2 +-
src/ibqueryerrors.c |2 +-
src/ibsendtrap.c|2 +-
src/ibstat.c|2 +-
src/saquery.c |2
GUIDInfo is now supported (alias GUID support)
Signed-off-by: Hal Rosenstock
---
diff --git a/doc/opensm_release_notes-3.3.txt b/doc/opensm_release_notes-3.3.txt
index 888485e..19e6bc6 100644
--- a/doc/opensm_release_notes-3.3.txt
+++ b/doc/opensm_release_notes-3.3.txt
@@ -295,9 +295,6 @@ inform
rather than osm_log_get_level to determine whether log level is active.
Log level is bit mask so >= doesn't always work properly.
Signed-off-by: Hal Rosenstock
---
diff --git a/opensm/osm_ucast_dfsssp.c b/opensm/osm_ucast_dfsssp.c
index 1e3ade1..3b7b83a 100644
--- a/opensm/osm_ucast_dfsssp.c
+++
per C15-0.2-1.16
Compile tested only
Also, fixed one error number (so not duplicated)
Signed-off-by: Hal Rosenstock
---
Change since v1:
Rebased against latest upstream master
diff --git a/opensm/osm_sa_informinfo.c b/opensm/osm_sa_informinfo.c
index e3f6ffa..772a293 100644
--- a/opensm/osm_s
rather than osm_log_get_level to determine whether log level is active.
Log level is bit mask so >= doesn't always work properly.
Signed-off-by: Hal Rosenstock
---
diff --git a/opensm/osm_ucast_dfsssp.c b/opensm/osm_ucast_dfsssp.c
index 1e3ade1..3b7b83a 100644
--- a/opensm/osm_ucast_dfsssp.c
+++
Fix typo and some formatting changes
Signed-off-by: Hal Rosenstock
---
diff --git a/include/complib/cl_fleximap.h b/include/complib/cl_fleximap.h
index 7390a14..89bc7c0 100644
--- a/include/complib/cl_fleximap.h
+++ b/include/complib/cl_fleximap.h
@@ -462,8 +462,8 @@ static inline cl_fmap_item_t
Signed-off-by: Hal Rosenstock
---
diff --git a/include/opensm/osm_log.h b/include/opensm/osm_log.h
index b2f105a..4214cd4 100644
--- a/include/opensm/osm_log.h
+++ b/include/opensm/osm_log.h
@@ -102,7 +102,7 @@ typedef uint8_t osm_log_level_t;
*/
#define OSM_LOG_DEFAULT_LEVEL OSM_LOG_E
Hi Dave,
As long as we get faster failover I am happy with Bart's patch.
Currently when I run IO to several luns over multipath and the preferred
path goes down, the system hangs until the IO fails over. Even ssh'ing
into the systems take 20-30 seconds. I *suspect* that is because IO is
being
Also, fix some commentary typos
Signed-off-by: Hal Rosenstock
---
diff --git a/opensm/osm_ucast_ftree.c b/opensm/osm_ucast_ftree.c
index ee4c34b..1233310 100644
--- a/opensm/osm_ucast_ftree.c
+++ b/opensm/osm_ucast_ftree.c
@@ -519,6 +519,7 @@ static void port_group_add_port(IN ftree_port_group_t
For siw, the dma_device->bus is currently not set, which will cause
the crash.
As we were testing NFS/RDMA we just disabled that fix for some Mellanox
device.
I agree I probably have to find a more consistent way to fake real dma
hardware. Any suggestions?
Thanks,
Bernard.
linux-rdma-ow...@vge
Hi,
Well don't mind me, it was soft-iwarp related afterall.
It would look like siw doesn't like 2K MTU like a few other devices,
adding it in the list in net/sunrpc/xprtrdma/verbs.c around line 880
made the crash just disappear.
It's not something easy to patch though given siw is out of tree, wh
Hi,
I'm currently trying to setup a NFS/RDMA server/client pair. base system
is CentOS release 6.2
I tried both the provided kernel 2.6.32-220.el6.x86_64 and a
custom-built 3.4.0 (x86_64), and the result is exactly the same.
Both server and client use nfs-utils version 1.2.3.
Hardware-wise, both
55 matches
Mail list logo
