RE: [PATCH for-next 00/17] ocrdma driver code sync-up

2014-02-24 Thread Devesh Sharma
Hi Roland, Do you have plans to pull-in these set of patches in the next merge cycle? -Regards Devesh -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Devesh Sharma Sent: Tuesday, February 04, 2014 11:57 AM To: linux-rdma@

Re: [PATCH 3/6] IB/srp: Fail SCSI commands silently

2014-02-24 Thread David Dillow
On Mon, 2014-02-24 at 20:58 +0100, Bart Van Assche wrote: > On 02/22/14 06:41, David Dillow wrote: > > I didn't suggest that -- I'm saying add a common functionality to turn > > on/off the message printing for commands that failed due to a dead > > transport. If it is useful for SRP initiators, it

Re: [PATCH 3/6] IB/srp: Fail SCSI commands silently

2014-02-24 Thread Bart Van Assche
On 02/22/14 06:41, David Dillow wrote: > I didn't suggest that -- I'm saying add a common functionality to turn > on/off the message printing for commands that failed due to a dead > transport. If it is useful for SRP initiators, it is probably useful for > SAS and iSCSI imitators as well. > > At

Re: [PATCH 05/11] IB/iser: Replace fastreg descriptor valid bool with indicators container

2014-02-24 Thread Nicholas A. Bellinger
On Mon, 2014-02-24 at 10:27 +0200, Sagi Grimberg wrote: > On 2/24/2014 9:30 AM, Nicholas A. Bellinger wrote: > > On Sun, 2014-02-23 at 22:53 -0800, Nicholas A. Bellinger wrote: > >> On Sun, 2014-02-23 at 14:19 +0200, Sagi Grimberg wrote: > >>> In T10-PI support we will have memory keys for protecti

RE: [patch] IB/qib: cleanup qib_register_observer()

2014-02-24 Thread Marciniszyn, Mike
> Subject: [patch] IB/qib: cleanup qib_register_observer() > > Returning directly is easier to read than do-nothing gotos. Remove the > duplicative check on "olp" and pulled the code in one indent level. > > Signed-off-by: Dan Carpenter Thanks for the patch! Acked-by: Mike Marciniszyn -- To

Re: [PATCH v1 3/3] IB/srp: Protect free_tx iu list from concurrent flows

2014-02-24 Thread Bart Van Assche
On 02/24/14 15:30, Sagi Grimberg wrote: > From: Vu Pham > > srp_reconnect_rport() serializes calls of srp_rport_reconnect() > with srp_queuecommand(), srp_abort(), srp_reset_device(), > srp_reset_host() via rport->mutex and also blocks srp_queuecommand(); > however, it cannot block scsi error han

Re: [PATCH v1 2/3] IB/srp: Check ib_query_gid return value

2014-02-24 Thread Bart Van Assche
On 02/24/14 15:30, Sagi Grimberg wrote: > Detected by Coverity. > > Signed-off-by: Sagi Grimberg > --- > drivers/infiniband/ulp/srp/ib_srp.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c > b/drivers/infiniband/ulp/srp/ib_sr

Re: [PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-02-24 Thread Bart Van Assche
On 02/24/14 15:30, Sagi Grimberg wrote: > When unmapping request data, it is unsafe automatically > decrement req->nfmr regardless of it's value. This may > happen since IO and reconnect flow may run concurrently > resulting in req->nfmr = -1 and falsely call ib_fmr_pool_unmap. > > Fix the loop co

Re: [PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-02-24 Thread Sebastian Riemer
On 24.02.2014 15:30, Sagi Grimberg wrote: > When unmapping request data, it is unsafe automatically > decrement req->nfmr regardless of it's value. This may > happen since IO and reconnect flow may run concurrently > resulting in req->nfmr = -1 and falsely call ib_fmr_pool_unmap. Something is stil

[PATCH opensm] osm_subnet.c: Fix resource leak neighbor parser ("subn_validate_neighbor" function)

2014-02-24 Thread Hal Rosenstock
From: Dan Ben Yosef Fix resource leak after neighbor validation Signed-off-by: Dan Ben Yosef Reviewed-by: Vladimir Koushnir --- opensm/osm_subnet.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c index 77e486a..e9024ac 100644

[PATCH opensm] osm_subnet.c: Fix resource leak guid2mkey parser (guid validation function)

2014-02-24 Thread Hal Rosenstock
From: Dan Ben Yosef Fix resource leak after guid validation ("subn_validate_g2m") Signed-off-by: Dan Ben Yosef Reviewed-by: Vladimir Koushnir --- opensm/osm_subnet.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c index db8c2a

[PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-02-24 Thread Sagi Grimberg
When unmapping request data, it is unsafe automatically decrement req->nfmr regardless of it's value. This may happen since IO and reconnect flow may run concurrently resulting in req->nfmr = -1 and falsely call ib_fmr_pool_unmap. Fix the loop condition to be greater than zero (which explicitly me

[PATCH v1 2/3] IB/srp: Check ib_query_gid return value

2014-02-24 Thread Sagi Grimberg
Detected by Coverity. Signed-off-by: Sagi Grimberg --- drivers/infiniband/ulp/srp/ib_srp.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 0e20bfb..b615135 100644 --- a/drivers/infiniband

[PATCH v1 3/3] IB/srp: Protect free_tx iu list from concurrent flows

2014-02-24 Thread Sagi Grimberg
From: Vu Pham srp_reconnect_rport() serializes calls of srp_rport_reconnect() with srp_queuecommand(), srp_abort(), srp_reset_device(), srp_reset_host() via rport->mutex and also blocks srp_queuecommand(); however, it cannot block scsi error handler commands (stu, tur). This may introduces corrup

[PATCH v1 0/3] SRP initiator fixes for kernel 3.15

2014-02-24 Thread Sagi Grimberg
Hey Bart, Here are three more fixes for kernel 3.15. These are the patches Sebastian was referring to. Changes from v0: - Fix typos in commit message Sagi Grimberg (2): IB/srp: Fix crash when unmapping data loop IB/srp: Check ib_query_gid return value Vu Pham (1): IB/srp: Protect free_tx

RE: [PATCH] infiniband, ocrdma, Fix compiler warning

2014-02-24 Thread Devesh Sharma
Acked-by: Devesh Sharma (devesh.sha...@emulex.com) -Regards Devesh -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Prarit Bhargava Sent: Wednesday, February 19, 2014 8:25 PM To: linux-rdma@vger.kernel.org Cc: Prarit Bharga

[PATCH opensm] osm_ucast_ftree.c: Fix memory leak in ftree fabric_rank

2014-02-24 Thread Hal Rosenstock
From: Rafi Wiener Memory leak is due to double cl_list_init calls. It happens when OpenSM cannot parse root guids file. Also, cosmetic formatting change Signed-off-by: Rafi Wiener --- opensm/osm_ucast_ftree.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/opensm/

Re: [PATCH 05/11] IB/iser: Replace fastreg descriptor valid bool with indicators container

2014-02-24 Thread Sagi Grimberg
On 2/24/2014 9:30 AM, Nicholas A. Bellinger wrote: On Sun, 2014-02-23 at 22:53 -0800, Nicholas A. Bellinger wrote: On Sun, 2014-02-23 at 14:19 +0200, Sagi Grimberg wrote: In T10-PI support we will have memory keys for protection buffers and signature transactions. We prefer to compact indicator

Re: [PATCH v5 00/10] Introduce Signature feature

2014-02-24 Thread Sagi Grimberg
On 2/24/2014 9:01 AM, Nicholas A. Bellinger wrote: On Sun, 2014-02-23 at 14:19 +0200, Sagi Grimberg wrote: This patchset Introduces Verbs level support for signature handover feature. Siganture is intended to implement end-to-end data integrity on a transactional basis in a completely offloaded

Re: [PATCH v5 04/10] IB/mlx5: Initialize mlx5_ib_qp signature related

2014-02-24 Thread Sagi Grimberg
On 2/24/2014 8:46 AM, Nicholas A. Bellinger wrote: On Sun, 2014-02-23 at 14:19 +0200, Sagi Grimberg wrote: If user requested signature enable we Initialize relevant mlx5_ib_qp members. we mark the qp as sig_enable and we increase the effective SQ size, but still limit the user max_send_wr to ori