[PATCH V2] svcrdma: Advertise the correct max payload

2014-09-22 Thread Steve Wise
Svcrdma currently advertises 1MB, which is too large. The correct value is the minimum of RPCSVC_MAXPAYLOAD and the max scatter-gather allowed in an NFSRDMA IO chunk * the host page size. This bug is usually benign because the Linux X64 NFSRDMA client correctly limits the payload size to the corre

Re: ib_ipoib: CSUM support in connected mode

2014-09-22 Thread Yuval Shaia
On Tue, Sep 16, 2014 at 09:47:43AM +0300, Or Gerlitz wrote: > > On 9/15/2014 9:55 PM, Yuval Shaia wrote: > >On Mon, Sep 15, 2014 at 05:47:19PM +0300, Or Gerlitz wrote: > >>>On Sun, Sep 14, 2014 at 9:46 PM, Yuval Shaia > >>>wrote: > >By default, IPoIB-CM driver uses 64k MTU. Larger MTU gives

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread Chuck Lever
On Sep 22, 2014, at 11:55 AM, J. Bruce Fields wrote: > On Mon, Sep 22, 2014 at 01:42:07PM -0500, Steve Wise wrote: >> On 9/22/2014 1:39 PM, J. Bruce Fields wrote: >>> On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: Svcrdma currently advertises 1MB, which is too large. The corre

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread Steve Wise
On 9/22/2014 1:55 PM, J. Bruce Fields wrote: On Mon, Sep 22, 2014 at 01:42:07PM -0500, Steve Wise wrote: On 9/22/2014 1:39 PM, J. Bruce Fields wrote: On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: Svcrdma currently advertises 1MB, which is too large. The correct value is the max

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread Steve Wise
On 9/22/2014 1:39 PM, J. Bruce Fields wrote: On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: Svcrdma currently advertises 1MB, which is too large. The correct value is the max scatter-gather allowed in an NFSRDMA IO chunk * the host page size. This bug is usually benign because the

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread J. Bruce Fields
On Mon, Sep 22, 2014 at 01:42:07PM -0500, Steve Wise wrote: > On 9/22/2014 1:39 PM, J. Bruce Fields wrote: > >On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: > >>Svcrdma currently advertises 1MB, which is too large. The correct value > >>is the max scatter-gather allowed in an NFSRDMA

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread Chuck Lever
On Sep 22, 2014, at 11:39 AM, J. Bruce Fields wrote: > On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: >> Svcrdma currently advertises 1MB, which is too large. The correct value >> is the max scatter-gather allowed in an NFSRDMA IO chunk * the host page >> size. This bug is usually

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread J. Bruce Fields
On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: > Svcrdma currently advertises 1MB, which is too large. The correct value > is the max scatter-gather allowed in an NFSRDMA IO chunk * the host page > size. This bug is usually benign because the Linux X64 NFSRDMA client > correctly limit

[PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread Steve Wise
Svcrdma currently advertises 1MB, which is too large. The correct value is the max scatter-gather allowed in an NFSRDMA IO chunk * the host page size. This bug is usually benign because the Linux X64 NFSRDMA client correctly limits the payload size to the correct value (64*4096 = 256KB). But if th

Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-22 Thread Bart Van Assche
On 22/09/2014 8:37, Christoph Hellwig wrote: One thing that is missing is generation multiqueue-aware tags at the blk-mq level, which should be as simple as always adding a queue prefix in the tag allocation code. Hello Christoph, Adding a queue prefix in the tag allocation code is an interest

Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-22 Thread Jens Axboe
On 2014-09-22 10:31, Jens Axboe wrote: On 2014-09-22 10:25, Bart Van Assche wrote: On 22/09/2014 8:37, Christoph Hellwig wrote: One thing that is missing is generation multiqueue-aware tags at the blk-mq level, which should be as simple as always adding a queue prefix in the tag allocation code

Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-22 Thread Jens Axboe
On 2014-09-22 10:25, Bart Van Assche wrote: On 22/09/2014 8:37, Christoph Hellwig wrote: One thing that is missing is generation multiqueue-aware tags at the blk-mq level, which should be as simple as always adding a queue prefix in the tag allocation code. Hello Christoph, Adding a queue pre

Re: [PATCH RFC 0/8] IB/srp: Add multichannel support

2014-09-22 Thread Christoph Hellwig
Hi Bart, I like these changes modulo the minor comments we had. One thing that is missing is generation multiqueue-aware tags at the blk-mq level, which should be as simple as always adding a queue prefix in the tag allocation code. Did you consider switching srp to use the block layer provided