Re: [PATCH FIX For-3.19 v5 00/10] Fix ipoib regressions

2015-01-25 Thread Doug Ledford
On Sun, 2015-01-25 at 14:54 +0200, Erez Shitrit wrote: > On 1/23/2015 6:52 PM, Doug Ledford wrote: > > On Thu, 2015-01-22 at 09:31 -0500, Doug Ledford wrote: > >> My 8 patch set taken into 3.19 caused some regressions. This patch > >> set resolves those issues. > >> > >> These patches are to resol

Re: [PATCH V2 FIX for-3.19] IB/ipoib: Fix broken multicast flow

2015-01-25 Thread Erez Shitrit
On 1/22/2015 10:40 PM, Doug Ledford wrote: On Thu, 2015-01-22 at 15:31 +0200, Or Gerlitz wrote: From: Erez Shitrit Following commit 016d9fb25cd9 "IPoIB: fix MCAST_FLAG_BUSY usage" both IPv6 traffic and for the most cases all IPv4 multicast traffic aren't working. After this change there is no

Re: [PATCH 3/4] IB/uverbs: ex_query_device: check request's comp_mask

2015-01-25 Thread Haggai Eran
On 22/01/2015 15:28, Yann Droneaud wrote: > This patch ensures the extended QUERY_DEVICE uverbs request's > comp_mask has only known values. If userspace returns unknown > features, -EINVAL will be returned, allowing to probe/discover > which features are currently supported by the kernel. This pr

Re: [PATCH 1/4] IB/uverbs: ex_query_device: fail if output buffer size does not match

2015-01-25 Thread Haggai Eran
On 22/01/2015 15:28, Yann Droneaud wrote: > Instead of silently truncating extended QUERY_DEVICE uverb's > response, see commit 5a77abf9a97a ("IB/core: Add support for > extended query device caps")), this patch makes function > ib_uverbs_ex_query_device() check the available space in the > respons

Re: [PATCH FIX For-3.19 v5 00/10] Fix ipoib regressions

2015-01-25 Thread Erez Shitrit
On 1/23/2015 6:52 PM, Doug Ledford wrote: On Thu, 2015-01-22 at 09:31 -0500, Doug Ledford wrote: My 8 patch set taken into 3.19 caused some regressions. This patch set resolves those issues. These patches are to resolve issues created by my previous patch set. While that set worked fine in my

Re: [PATCH ] mlx4_core: Enhance device capabilities flags debug printouts

2015-01-25 Thread Yuval Shaia
> >> >- mlx4_dbg(dev, "%s\n", fname[i]); > >> >+ if (fname[i]) > >> >+ mlx4_dbg(dev, "(%c) %s\n", (flags & (1LL << > >> >i)) ? > >> >+'*' : ' ', fname[i]); > >> > } > >> > >> I think that the strings

Re: [PATCH ] mlx4_core: Enhance device capabilities flags debug printouts

2015-01-25 Thread Yuval Shaia
On Mon, Dec 15, 2014 at 06:14:31PM +0200, Or Gerlitz wrote: > >> >> >+ [52] =RSS on fragmented IP datagram support", > >> >> > >> >> Hi, > >> >> > >> >> Except for Or's comments, [55] exists twice. Furthermore, please > >> >> move [56]-[57] to be after [55] =Port link type sensing sup