[PATCH] IB/hfi1: Remove some sysfs files

2015-08-07 Thread Mike Marciniszyn
From: Sadanand Warrier sadanand.warr...@intel.com Removed version and localbus_info files from the sysfs directory. Change-Id: I128b2e4ceb9440fed9b73a822dd39c44df17e5a5 Reviewed-by: Mike Marciniszyn mike.marcinis...@intel.com Signed-off-by: Sadanand Warrier sadanand.warr...@intel.com ---

[ewg] [ANNOUNCE] Updated PSM library is available

2015-08-07 Thread Marciniszyn, Mike
An updated PSM library is available at: https://www.openfabrics.org/downloads/infinipath-psm/infinipath-psm-3.3-6_gca75825_open.tar.gz The update addresses the following issues: - Adds support for 2^20 MPI ranks, up from 2^16 - Fixes issue with exhaustion of send tid dma descriptors - Fixes

Re: [RFC] split struct ib_send_wr

2015-08-07 Thread Christoph Hellwig
On Thu, Aug 06, 2015 at 01:58:45PM -0400, Chuck Lever wrote: Wondering if this means we'll have to drop ib_reg_phys_mr() removal until Lustre gets around to removing their call sites from the staging tree. Why? Just because the buildbot catches it? -- To unsubscribe from this list: send the

Re: [RFC] split struct ib_send_wr

2015-08-07 Thread 'Christoph Hellwig'
On Thu, Aug 06, 2015 at 12:44:42PM -0500, Steve Wise wrote: Driver/staging isn't considered in tree for global API change perspective, so I didn't bother with all these staging drivers. The kbuild test bot will probably catch this. It already did catch it for my tree, which is expected.

Re: [RFC] split struct ib_send_wr

2015-08-07 Thread Christoph Hellwig
On Thu, Aug 06, 2015 at 11:08:45PM +0530, Parav Pandit wrote: Do you see value in dividing ib_ud _wr into ib_ud_wr and ib_ud_gsi_wr to save 4 bytes? For now I just wanted to split along the lines of the existing unions. From looking at the various drivers splitting the GSI path might not be a

Re: [RFC] split struct ib_send_wr

2015-08-07 Thread Christoph Hellwig
On Thu, Aug 06, 2015 at 07:46:44PM +0300, Sagi Grimberg wrote: I agree that this is a shame to keep in here for everyone to carry... The only driver I've seen supporting XRC is mlx5 with no consumers. If people are reluctant to remove it, you can put it in ib_xrc_send_wr or something...

Re: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread Christoph Hellwig
On Fri, Aug 07, 2015 at 10:06:26AM -0500, Steve Wise wrote: If it is too much of a pain to alter this patch, then I'll just submit the NFSRDMA fix and live with the bisect issue... Doug's tree is still to be rebased. So please submit your NFS fix now as ask Doug to merge it before Sagi's

[PATCH v2] IB/hfi1: remove two files from /sys/class/infiniband

2015-08-07 Thread Mike Marciniszyn
From: Sadanand Warrier sadanand.warr...@intel.com version and localbus_info are removed from the hfi1 sysfs directory. Reviewed-by: Mike Marciniszyn mike.marcinis...@intel.com Signed-off-by: Sadanand Warrier sadanand.warr...@intel.com --- Documentation/infiniband/sysfs.txt |2 --

[PATCH] IB/hfi1: Support ib_alloc_mr verb

2015-08-07 Thread Mike Marciniszyn
Ported from upstream qib commit 68c02e232b8a (qib: Support ib_alloc_mr verb) Tested-by: Jubin John jubin.j...@intel.com Reviewed-by: Jubin John jubin.j...@intel.com Signed-off-by: Mike Marciniszyn mike.marcinis...@intel.com --- drivers/staging/hfi1/mr.c|9 +++--

Re: [RFC] split struct ib_send_wr

2015-08-07 Thread Chuck Lever
On Aug 7, 2015, at 2:36 AM, Christoph Hellwig h...@infradead.org wrote: On Thu, Aug 06, 2015 at 01:58:45PM -0400, Chuck Lever wrote: Wondering if this means we'll have to drop ib_reg_phys_mr() removal until Lustre gets around to removing their call sites from the staging tree. Why? Just

RE: [PATCH for-4.3 14/15] qib: Support ib_alloc_mr verb

2015-08-07 Thread Marciniszyn, Mike
Subject: [PATCH for-4.3 14/15] qib: Support ib_alloc_mr verb Signed-off-by: Sagi Grimberg sa...@mellanox.com This did require repair of the to-be-rebased/for-4.3 branch to revert IB/core: Guarantee that a local_dma_lkey is available and replace with a corrected version. Tested-by: Vinit

Re: [PATCH] IB/hfi1: Remove some sysfs files

2015-08-07 Thread Christoph Lameter
On Fri, 7 Aug 2015, Mike Marciniszyn wrote: { @@ -599,25 +581,21 @@ static ssize_t show_tempsense(struct device *device, /* start of per-unit file structures and support code */ static DEVICE_ATTR(hw_rev, S_IRUGO, show_rev, NULL); static DEVICE_ATTR(board_id, S_IRUGO, show_hfi, NULL);

Re: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread 'Christoph Hellwig'
On Fri, Aug 07, 2015 at 11:29:12AM -0500, Steve Wise wrote: I misspoke. I had the order reversed. The order is such that we can add my new NFS patch after: e20684a xprtrdma, svcrdma: Convert to ib_alloc_mr and before these: af78181 cxgb3: Support ib_alloc_mr verb b7e06cd iw_cxgb4:

Re: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread 'Christoph Hellwig'
On Fri, Aug 07, 2015 at 11:19:59AM -0500, Steve Wise wrote: I guess I'll post two patches, the NFS fix that preceeds af78181/ b7e06cd, and a reworked patch to replace e20684a. Is that the way to go in your opinion? To me this sounds good. We have a couple patches from Jason's series that

Re: [RFC] split struct ib_send_wr

2015-08-07 Thread Christoph Hellwig
On Fri, Aug 07, 2015 at 10:17:18AM -0400, Chuck Lever wrote: If bot barking doesn't bother anyone, then I'll keep the removal patch. For some such a complaint might be grounds for rejecting the patch. If it's (a) in tree proper and (b) not one of the rare false positives I would consider it a

RE: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread Steve Wise
-Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of 'Christoph Hellwig' Sent: Friday, August 07, 2015 11:26 AM To: Steve Wise Cc: 'Christoph Hellwig'; 'Sagi Grimberg'; 'Doug Ledford'; linux-rdma@vger.kernel.org;

[PATCH] svcrdma: limit FRMR page list lengths to device max

2015-08-07 Thread Steve Wise
Svcrdma was incorrectly allocating fastreg MRs and page lists using RPCSVC_MAXPAGES, which can exceed the device capabilities. So limit the depth to the minimum of RPCSVC_MAXPAGES and xprt-sc_frmr_pg_list_len. Signed-off-by: Steve Wise sw...@opengridcomputing.com --- Doug, this patch needs to be

Re: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread Steve Wise
On 8/7/2015 11:19 AM, Steve Wise wrote: -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Christoph Hellwig Sent: Friday, August 07, 2015 10:13 AM To: Steve Wise Cc: 'Sagi Grimberg'; 'Doug Ledford';

RE: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread Steve Wise
-Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Sagi Grimberg Sent: Thursday, July 30, 2015 2:33 AM To: linux-rdma@vger.kernel.org; linux-...@vger.kernel.org; target-de...@vger.kernel.org Subject: [PATCH for-4.3

Re: [RFC] split struct ib_send_wr

2015-08-07 Thread Steve Wise
On 8/6/2015 11:24 AM, Christoph Hellwig wrote: I've pushed out a new version. Updates: - the ib_recv_wr change Bart notices has been fixed. - iser and isert have been converted - the handling of the embedded WR in the qib software queue entry has been fixed. Which means we're

RE: [PATCH] IB/hfi1: Remove some sysfs files

2015-08-07 Thread Marciniszyn, Mike
{ @@ -599,25 +581,21 @@ static ssize_t show_tempsense(struct device *device, /* start of per-unit file structures and support code */ static DEVICE_ATTR(hw_rev, S_IRUGO, show_rev, NULL); static DEVICE_ATTR(board_id, S_IRUGO, show_hfi, NULL); -static DEVICE_ATTR(version, S_IRUGO,

Re: [PATCH] svcrdma: limit FRMR page list lengths to device max

2015-08-07 Thread J. Bruce Fields
On Fri, Aug 07, 2015 at 11:11:20AM -0500, Steve Wise wrote: Svcrdma was incorrectly allocating fastreg MRs and page lists using RPCSVC_MAXPAGES, which can exceed the device capabilities. So limit the depth to the minimum of RPCSVC_MAXPAGES and xprt-sc_frmr_pg_list_len. Signed-off-by: Steve

RE: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread Steve Wise
-Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Christoph Hellwig Sent: Friday, August 07, 2015 10:13 AM To: Steve Wise Cc: 'Sagi Grimberg'; 'Doug Ledford'; linux-rdma@vger.kernel.org; linux-...@vger.kernel.org;

[PATCH for-next V1 07/10] IB/core: Use GID table in AH creation and dmac resolution

2015-08-07 Thread Matan Barak
Previously, vlan id and source MAC were used from QP attributes. Since the net device is now stored in the GID attributes, they could be used instead of getting this information from the QP attributes. IB_QP_SMAC, IB_QP_ALT_SMAC, IB_QP_VID and IB_QP_ALT_VID were removed because there is no known

[PATCH for-next V1 08/10] IB/cm: Remove the usage of smac and vid of qp_attr and cm_av

2015-08-07 Thread Matan Barak
The cm and cma don't need to explicitly handle vlan and smac, as they are resolved from the GID index now. Removing this portion of code. Signed-off-by: Matan Barak mat...@mellanox.com --- drivers/infiniband/core/cm.c | 30 -- drivers/infiniband/core/cma.c | 6

[PATCH for-next V1 05/10] IB/cma: cma_validate_port should verify the port and netdevice

2015-08-07 Thread Matan Barak
Previously, cma_validate_port searched for GIDs in IB cache and then tried to verify the found port. This could fail when there are identical GIDs on both ports. In addition, netdevice should be taken into account when searching the GID table. Fixing cma_validate_port to search only the relevant

[PATCH for-next V1 04/10] IB/cm: cm_init_av_by_path should find a GID by its netdevice

2015-08-07 Thread Matan Barak
Previously, the CM has searched the cache for any sgid_index whose GID matches the path's GID. Since the path record stores the net device, the CM should now search only for GIDs which originated from this net device. Signed-off-by: Matan Barak mat...@mellanox.com ---

[PATCH for-next V1 09/10] IB/core: Remove smac and vlan id from qp_attr and ah_attr

2015-08-07 Thread Matan Barak
Smac and vlan id could be resolved from the GID attribute, and thus these attributes aren't needed anymore. Removing them. Signed-off-by: Matan Barak mat...@mellanox.com --- drivers/infiniband/core/sa_query.c | 4 drivers/infiniband/core/ucma.c | 1 -

[PATCH for-next V1 06/10] IB/cache: Add ib_find_gid_by_filter cache API

2015-08-07 Thread Matan Barak
GID cache API users might want to search for GIDs with specific attributes rather than just specifying GID, net device and port. This is used in a later patch, where we find the sgid index by L2 Ethernet attributes. Signed-off-by: Matan Barak mat...@mellanox.com ---

[PATCH for-next V1 02/10] IB/core: Expose and rename ib_find_cached_gid_by_port cache API

2015-08-07 Thread Matan Barak
Sometime consumers might want to search for a GID in a specific port. For example, when a WC arrives and we want to search the GID that matches that port - it's better to search only the relevant port. Exposing and renaming ib_cache_gid_find_by_port in order to match the naming convention of the

[PATCH for-next V1 01/10] IB/core: Add netdev and gid attributes paramteres to cache

2015-08-07 Thread Matan Barak
Adding an ability to query the IB cache by a netdev and get the attributes of a GID. These parameters are necessary in order to successfully resolve the required GID (when the netdevice is known) and get the Ethernet L2 attributes from a GID. Signed-off-by: Matan Barak mat...@mellanox.com ---

[PATCH for-next V1 03/10] IB/core: Add netdev to path record

2015-08-07 Thread Matan Barak
In order to find the sgid_index, one could just query the IB cache with the correct GID and netdevice. Therefore, instead of storing the L2 attributes directly in the path, we only store the ifindex and net and use them later to get the sgid_index. The vlan_id and smac L2 attributes are removed in

[PATCH for-next V1 00/10] Add RoCE GID cache usage in verbs/cma

2015-08-07 Thread Matan Barak
Hi Doug, This purpose of this series is to add usage of the GID cache to the CMA and IB stack. Instead of passing Ethernet L2 attributes via QP attributes, we could just use the GID cache that's already points to a ndev and thus to all required L2 attributes. The first five patches query the GID