[GIT PULL] pull request: linux-firmware: Add Intel OPA hfi1 firmware

2015-08-11 Thread ira.weiny
Doug, Please Pull: git://github.com/weiny2/linux-firmware.git master-hfi1-firmware This is the first release of the Intel OPA hfi1 firmware required by the hfi1 driver. Thank you, Ira Weiny -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

Re: [PATCH REPOST libibverbs] Add IP and TCP/UDP TX checksum offload support

2015-08-11 Thread Or Gerlitz
On Thu, Jun 18, 2015 at 7:38 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Sun, Jun 14, 2015 at 01:13:04PM +0300, Or Gerlitz wrote: From: Moshe Lazer mos...@mellanox.com Add a device capability flag IB_DEVICE_IP_SUM to denote checksum offload support. Devices should set this

Re: [PATCH for-next V2 4/4] IB/core: RoCE GID management separate cleanup and release

2015-08-11 Thread Jason Gunthorpe
On Thu, Aug 06, 2015 at 08:14:00PM +0300, Matan Barak wrote: Separate the cleanup and release IB cache functions. The cleanup function delete all GIDs and unregister the event channel, while the release function frees all memory. The cleanup function is called after all clients were removed

Re: [PATCH] IB/srp: Fix possible use-after-free

2015-08-11 Thread Sagi Grimberg
With which kernel version has this been observed ? This was actually observed in RHEL 7.1 kernel (I think). But given its not easy to reproduce and the same code path exists in upstream, I thought I'd send it to you for review. scsi_remove_host() waits until all outstanding requests have

Re: [PATCH] IB/core: Make ib_dealloc_pd return void

2015-08-11 Thread Sagi Grimberg
On 8/11/2015 8:57 AM, Jason Gunthorpe wrote: On Thu, Aug 06, 2015 at 08:31:58PM +0300, Sagi Grimberg wrote: This looks generally good. Would it make sense to go the extra mile here and just fixup ocrdma (the only driver that seems to be able to fail) to WARN_ON() instead of propagating an

RE: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-11 Thread Liran Liss
From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] It does if you want a planned 'gental' removal to be possible.. There could be a lot of design options for a 'gentle' removal, such as first sending a 'prepare' event, and only then doing the flow proposed here. I do not want

RE: [PATCH] IB/sa: Restrict SA Netlink to admin users

2015-08-11 Thread Wan, Kaike
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe Sent: Tuesday, August 11, 2015 1:38 AM To: Weiny, Ira Cc: Haggai Eran; dledf...@redhat.com; linux-rdma@vger.kernel.org Subject: Re: [PATCH] IB/sa: Restrict SA Netlink to admin users

Re: [PATCH] IB/srp: Fix possible use-after-free

2015-08-11 Thread Bart Van Assche
On 08/11/2015 07:42 AM, Sagi Grimberg wrote: [PATCH] IB/srp: Fix possible protection fault srp_destroy_qp is designed to indicate we are safe to continue with freeing the channel resources by modifying the qp error state, posting a dummy wr on the queue-pair and waiting for it to flush. This

Re: [PATCH] IB/srp: Fix possible use-after-free

2015-08-11 Thread Sagi Grimberg
With which kernel version has this been observed ? scsi_remove_host() waits until all outstanding requests have finished. srp_free_ch_ib() is called either before a SCSI host is registered with the SCSI core or after scsi_remove_host() has finished. So I don't see how the above call trace could

Re: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support

2015-08-11 Thread Jason Gunthorpe
On Tue, Aug 11, 2015 at 12:47:03PM +, Liran Liss wrote: Still needs to have the locking fixed.. As pointed out (https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg27023.html), this barrier scheme is used in several places including in the RDMA stack. If there is no functional

Re: [PATCH] IB/sa: Restrict SA Netlink to admin users

2015-08-11 Thread ira.weiny
On Mon, Aug 10, 2015 at 11:38:10PM -0600, Jason Gunthorpe wrote: On Mon, Aug 10, 2015 at 05:58:30PM -0400, ira.weiny wrote: Furthermore, the check in netlink_bind also uses the socket namespace to restrict the use of multicast. This plus my checks should allow an admin to place the SA

Re: [PATCH] IB/srp: Fix possible use-after-free

2015-08-11 Thread Bart Van Assche
On 08/11/2015 07:42 AM, Sagi Grimberg wrote: diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 3a1514c..b220856 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -546,6 +546,17 @@ static int

Re: [PATCH] IB/sa: Restrict SA Netlink to admin users

2015-08-11 Thread ira.weiny
On Tue, Aug 11, 2015 at 05:27:17AM -0600, Wan, Kaike wrote: From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe Sent: Tuesday, August 11, 2015 1:38 AM To: Weiny, Ira Cc: Haggai Eran; dledf...@redhat.com;

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd-local_dma_lkey

2015-08-11 Thread Bart Van Assche
On 08/01/2015 01:05 PM, Doug Ledford wrote: On 07/31/2015 07:14 PM, Jason Gunthorpe wrote: On Fri, Jul 31, 2015 at 04:04:35PM -0700, Bart Van Assche wrote: With only patches 1/12 and 8/12 applied my test passes. Thanks Bart! If you like, I can try and work on #9 (no promises :(), but I

Re: [GIT PULL] pull request: linux-firmware: Add Intel OPA hfi1 firmware

2015-08-11 Thread Jason Gunthorpe
On Tue, Aug 11, 2015 at 05:32:06PM -0400, ira.weiny wrote: Doug, Please Pull: git://github.com/weiny2/linux-firmware.git master-hfi1-firmware This is the first release of the Intel OPA hfi1 firmware required by the hfi1 driver. Um, I'm not a lawyer, but that license does not look OK

Re: [GIT PULL] pull request: linux-firmware: Add Intel OPA hfi1 firmware

2015-08-11 Thread Jason Gunthorpe
On Tue, Aug 11, 2015 at 10:47:03PM +, Vogel, Steve wrote: The license terms allow anyone to distribute (but not sell) the firmware but only for use on Intel products. Redistribution alone may be enough to be included in linux-firmware However, most of the additional terms (and there are