RE: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names

2015-08-12 Thread Steve Wise
Hey Sagi, how is this coming along? How can I help? Hi Steve, This is taking longer than I expected, the changes needed seem pretty extensive throughout the IO path. I don't think it will be ready for 4.3 Perhaps then we should go with my version that adds iwarp-only FRMR IO

Re: [RFC] split struct ib_send_wr

2015-08-12 Thread Doug Ledford
On 08/07/2015 10:19 AM, Christoph Hellwig wrote: On Fri, Aug 07, 2015 at 10:17:18AM -0400, Chuck Lever wrote: If bot barking doesn't bother anyone, then I'll keep the removal patch. For some such a complaint might be grounds for rejecting the patch. If it's (a) in tree proper and (b) not one

Re: [RFC] split struct ib_send_wr

2015-08-12 Thread Chuck Lever
On Aug 12, 2015, at 6:45 PM, Doug Ledford dledf...@redhat.com wrote: On 08/07/2015 10:19 AM, Christoph Hellwig wrote: On Fri, Aug 07, 2015 at 10:17:18AM -0400, Chuck Lever wrote: If bot barking doesn't bother anyone, then I'll keep the removal patch. For some such a complaint might be

Re: [RFC] split struct ib_send_wr

2015-08-12 Thread Christoph Hellwig
On Wed, Aug 12, 2015 at 07:24:44PM -0700, Chuck Lever wrote: That makes sense, but you already Acked the change that breaks Lustre, and it's going in through the NFS tree. Are you changing that to a NAK? It seems like Doug was mostly concened about to be removed drivers. I defintively refuse to

Re: [PATCH] IB/srp: Fix possible use-after-free

2015-08-12 Thread Sagi Grimberg
On second thought ... with your patch, if the goto err_qp branch in srp_create_ch_ib() is taken upon return ch-qp, ch-recv_cq and ch-send_cq will be dangling pointers. That will have bad consequences in the subsequent srp_free_ch_ib() call. How about replacing the above patch with the

re: IB/mlx5: Support IB_WR_REG_SIG_MR

2015-08-12 Thread Dan Carpenter
Hello Sagi Grimberg, The patch e6631814fb3a: IB/mlx5: Support IB_WR_REG_SIG_MR from Feb 23, 2014, leads to the following static checker warning: drivers/infiniband/ulp/ipoib/ipoib_cm.c:764 ipoib_cm_send() warn: 'rc' can be either negative or positive

Re: [RFC] split struct ib_send_wr

2015-08-12 Thread Sagi Grimberg
On 8/6/2015 7:24 PM, Christoph Hellwig wrote: I've pushed out a new version. Updates: - the ib_recv_wr change Bart notices has been fixed. - iser and isert have been converted - the handling of the embedded WR in the qib software queue entry has been fixed. Which means we're

Re: IB/mlx5: Support IB_WR_REG_SIG_MR

2015-08-12 Thread Sagi Grimberg
On 8/12/2015 1:36 PM, Dan Carpenter wrote: Hello Sagi Grimberg, The patch e6631814fb3a: IB/mlx5: Support IB_WR_REG_SIG_MR from Feb 23, 2014, leads to the following static checker warning: drivers/infiniband/ulp/ipoib/ipoib_cm.c:764 ipoib_cm_send() warn: 'rc' can be either

Re: [PATCH V2] IB/sa: Restrict SA Netlink to admin users

2015-08-12 Thread ira.weiny
On Mon, Aug 10, 2015 at 10:46:55PM -0400, ira.we...@intel.com wrote: From: Ira Weiny ira.we...@intel.com The recently added SA Netlink service requires admin privileges to receive kernel requests. This is only partially sufficient to protect the kernel from malicious users. This patch

Re: [PATCH V2] IB/sa: Restrict SA Netlink to admin users

2015-08-12 Thread Doug Ledford
On 08/12/2015 03:43 PM, ira.weiny wrote: On Mon, Aug 10, 2015 at 10:46:55PM -0400, ira.we...@intel.com wrote: From: Ira Weiny ira.we...@intel.com The recently added SA Netlink service requires admin privileges to receive kernel requests. This is only partially sufficient to protect the