Re: message size, was Re: merge struct ib_device_attr into struct ib_device

From: "Steve Wise" Date: Tue, 22 Sep 2015 17:15:15 -0500 > How do we change the message size limits? Reviewing w/o it being > inline is painful for the (many) reviewers... I've increased it. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to maj

RE: message size, was Re: merge struct ib_device_attr into struct ib_device

> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of 'Christoph Hellwig' > Sent: Tuesday, September 22, 2015 4:55 PM > To: Steve Wise; postmas...@vger.kernel.org > Cc: linux-rdma@vger.kernel.org > Subject: message size, wa

Re: [PATCH v1 15/24] IB/srp: Convert to new memory registration API

On 09/17/2015 02:42 AM, Sagi Grimberg wrote: Since SRP supports both FMRs and FRWR, the new API conversion includes splitting the sg list mapping routines in srp_map_data to srp_map_sg_fr that works with the new memory registration API, srp_map_sg_fmr which constructs a page vector and calls ib_f

message size, was Re: merge struct ib_device_attr into struct ib_device

On Tue, Sep 22, 2015 at 04:06:17PM -0500, Steve Wise wrote: > Can you create a series of smaller patches that will fit on the list? > That would make it easier for everyone to review/comment. I don't see how that is possible, as it's a flag day change. But maybe we really need to bump up the mes

Re: [PATCH v1 03/24] IB/mlx5: Support the new memory registration API

On 09/17/2015 02:42 AM, Sagi Grimberg wrote: +static int +mlx5_alloc_priv_descs(struct ib_device *device, + struct mlx5_ib_mr *mr, + int ndescs, + int desc_size) +{ + int size = ndescs * desc_size; + + mr->descs = dma_alloc_c

Re: [PATCH v1 02/24] IB/mlx5: Remove dead fmr code

On 09/17/2015 02:42 AM, Sagi Grimberg wrote: Just function declarations - no need for those laying arround. If for some reason someone will want FMR support in mlx5, it should be easy enough to restore a few structs. Signed-off-by: Sagi Grimberg Reviewed-by: Bart Van Assche -- To unsubscribe

Re: [PATCH v1 00/24] New fast registration API

On 09/17/2015 02:42 AM, Sagi Grimberg wrote: came from Bart Van Assache which pointed out that some applications Most people appreciate it if their name is spelled correctly :-) Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord

Re: [PATCH v1 01/24] IB/core: Introduce new fast registration API

On 09/17/2015 02:42 AM, Sagi Grimberg wrote: The new fast registration verg ib_map_mr_sg receives a scatterlist ^ verb ? +/** + * ib_map_mr_sg() - Map a memory region with the largest prefix of + * a dma mapped SG list This description could be made more cl

RE: merge struct ib_device_attr into struct ib_device

> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Tuesday, September 22, 2015 3:32 PM > To: Yann Droneaud > Cc: linux-rdma@vger.kernel.org > Subject: Re: merge struct ib_device_attr into struct

Re: merge struct ib_device_attr into struct ib_device

Hi Yann, looks like the patch was too large and majordomo ate it Here is a link: http://git.infradead.org/users/hch/rdma.git/commitdiff/0e46553467cd01b63ab9c985f87c18c5328880bb -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.ker

[v1 2/2] libmlx4: Add support for TX/RX checksum offload

From: Bodong Wang RX checksum verification status is reported through wc_flag when polling CQ if device supports checksum offload. When IBV_WC_IP_CSUM_OK is set, that means both IPv4 header checksum and TCP/UDP checksum are OK. TX checksum offload will be enabled for TCP/UDP over IPv4 if user se

[v1 1/2] libmlx4: Update ibv_create_flow/ibv_destroy_flow according to change of libibverbs

From: Bodong Wang Signed-off-by: Bodong Wang --- src/mlx4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mlx4.c b/src/mlx4.c index 2999150..9fe8c6a 100644 --- a/src/mlx4.c +++ b/src/mlx4.c @@ -203,8 +203,8 @@ static int mlx4_init_context(struct verbs_device *v_dev

[v1 0/2] libmlx4: Add support for checksum offload

From: Bodong Wang Changes from v1: * Update patches to use the device_cap_flags to get the checksum offload caps Bodong Wang (2): libmlx4: Update ibv_create_flow/ibv_destroy_flow according to change of libibverbs libmlx4: Add support for TX/RX checksum offload src/cq.c| 6

[v1] libibverbs: Add support for checksum offload

From: Bodong Wang Changes from v1: * Use the CSUM caps from device_cap_flags rather than defining new fileds Bodong Wang (1): libibverbs: Report checksum offload capabilities include/infiniband/verbs.h | 14 -- man/ibv_poll_cq.3 | 5 + man/ibv_post_send.3|

[v1] libibverbs: Report checksum offload capabilities

From: Bodong Wang Add IBV_DEVICE_UD_IP_CSUM, IBV_DEVICE_RAW_IP_CSUM and IBV_DEVICE_RC_IP_CSUM to device capability enum field. These enum will denote IPv4 checksum offload support for UD, RAW and RC QPs. Flags IBV_SEND_IP_CSUM and IBV_WC_IP_CSUM_OK are added for utilizing this capability for sen

[v1 1/2] IB/core: Add support of checksum capability reporting for RC and RAW

From: Bodong Wang Two enum members IB_DEVICE_RC_IP_CSUM and IB_DEVICE_RAW_IP_CSUM are added to ib_device_cap_flags. Device should set these two flags if they support insertion of UDP and TCP checksum on outgoing IPv4 messages and can verify the validity of checksum for incoming IPv4 messages, for

[v1 0/2] Checksum offload capability report

From: Bodong Wang This series adds kernel support for checksum offload cap report. The first patch adds reporting for RAW and RC QPs. Patch 2 sets the capability according to hardware. Changes from v1: * The cap is reported through existing device_cap_flags. Only new enum members are added

[v1 2/2] IB/mlx4: Report checksum offload cap for RAW QP when query device

From: Bodong Wang Signed-off-by: Bodong Wang --- drivers/infiniband/hw/mlx4/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index 8be6db8..9e18392 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/inf

Re: [PATCH v1 00/24] New fast registration API

On 9/22/2015 12:56 AM, Sagi Grimberg wrote: On 9/22/2015 10:19 AM, Sagi Grimberg wrote: As mentioned earlier, I have a WIP RDS fastreg branch [3] which is functional (at least I can RDMA messages across nodes ;-)). Nice! So merging [2] and [3], I created [4] and applied a delta change based

Re: [PATCH v1 03/18] xprtrdma: Remove completion polling budgets

On Mon, Sep 21, 2015 at 9:15 PM, Chuck Lever wrote: > >> On Sep 21, 2015, at 1:51 AM, Devesh Sharma >> wrote: >> >> On Sun, Sep 20, 2015 at 4:05 PM, Sagi Grimberg >> wrote: > It is possible that in a given poll_cq > call you end up getting on 1 completion, the other completion is >

Re: merge struct ib_device_attr into struct ib_device

Le lundi 21 septembre 2015 à 13:59 -0700, Christoph Hellwig a écrit : > This patch gets rid of struct ib_device_attr and cleans up drivers > nicely. > > It goes on top of my send_wr cleanups and the memory registration > udpates > from Sagi. > Is the patch missing ? Regards. -- Yann Droneaud

Re: [PATCH 00/38] Fixes related to incorrect usage of unsigned types

On 09/22/2015 11:13 AM, Andrzej Hajda wrote: On 09/21/2015 03:42 PM, David Howells wrote: Andrzej Hajda wrote: Semantic patch finds comparisons of types: unsigned < 0 unsigned >= 0 The former is always false, the latter is always true. Such comparisons are useless, so theoretically

Re: [PATCH 00/38] Fixes related to incorrect usage of unsigned types

On 09/21/2015 03:42 PM, David Howells wrote: > Andrzej Hajda wrote: > >> Semantic patch finds comparisons of types: >> unsigned < 0 >> unsigned >= 0 >> The former is always false, the latter is always true. >> Such comparisons are useless, so theoretically they could be >> safely removed,

Re: [PATCH v1 00/24] New fast registration API

On 9/22/2015 10:19 AM, Sagi Grimberg wrote: As mentioned earlier, I have a WIP RDS fastreg branch [3] which is functional (at least I can RDMA messages across nodes ;-)). Nice! So merging [2] and [3], I created [4] and applied a delta change based on your other patches. I saw ib_post_send fa

[PATCH rdma-next V1 20/32] IB/rxe: Multicast implementation

Multicast groups handling. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_mcast.c | 190 1 file changed, 190 insertions(+) create mode 100644 drivers/staging/rxe/rxe_mcast.c diff --git a/driver

[PATCH rdma-next V1 25/32] IB/rxe: Dummy DMA callbacks for RXE device

Dummy DMA processing for RXE device. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_dma.c | 166 ++ 1 file changed, 166 insertions(+) create mode 100644 drivers/staging/rxe/rxe_dma.c diff --git

[PATCH rdma-next V1 22/32] IB/rxe: Completion handling

Handling of Work Completions. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rxe/rxe_comp.c | 728 + 1 file changed, 728 insertions(+) create mode 100644 drivers/staging/rxe/rxe_comp.c diff --git a/drivers/staging/rxe/rxe_comp.c

[PATCH rdma-next V1 32/32] IB/rxe: TODO file while in staging

From: Amir Vadai Things todo in order to get out of staging subtree. Signed-off-by: Amir Vadai Signed-off-by: Kamal Heib --- drivers/staging/rxe/TODO | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 drivers/staging/rxe/TODO diff --git a/drivers/staging/rxe/TODO b

[PATCH rdma-next V1 23/32] IB/rxe: QP request handling

QP request logic. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rxe/rxe_req.c | 679 ++ 1 file changed, 679 insertions(+) create mode 100644 drivers/staging/rxe/rxe_req.c diff --git a/drivers/staging/rxe/rxe_req.c b/drivers/sta

[PATCH rdma-next V1 26/32] IB/rxe: ICRC calculations

Compute ICRC for UDP/IP/BTH headers Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rxe/rxe_icrc.c | 96 ++ 1 file changed, 96 insertions(+) create mode 100644 drivers/staging/rxe/rxe_icrc.c diff --git a/drivers/staging/rxe/rxe_i

[PATCH rdma-next V1 24/32] IB/rxe: QP response handling

QP response logic. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rxe/rxe_resp.c | 1368 1 file changed, 1368 insertions(+) create mode 100644 drivers/staging/rxe/rxe_resp.c diff --git a/drivers/staging/rxe/rxe_resp.c b/drivers

[PATCH rdma-next V1 27/32] IB/rxe: Module init hooks

Module main for ib_rxe Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe.c | 436 ++ drivers/staging/rxe/rxe.h | 2 + 2 files changed, 438 insertions(+) create mode 100644 drivers/staging/rxe/

[PATCH rdma-next V1 08/32] IB/rxe: Add maintainer for rxe driver

Add maintainer for rxe driver Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7ba7ab7..3805619 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6789,6 +6789,1

[PATCH rdma-next V1 03/32] IB/rxe: IBA header types and methods

Add declarations for data structures used to hold per opcode and per work request opcode tables. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_hdr.h | 950 ++ 1 file changed, 950 insertions(+) c

[PATCH rdma-next V1 31/32] IB/rxe: Add Soft-RoCE to kbuild and makefiles

Kconfig and Makefiles for RXE driver Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/Kconfig | 2 ++ drivers/staging/Makefile | 1 + drivers/staging/rxe/Kconfig | 23 +++ drivers/staging/rxe/Makefile | 24

[PATCH rdma-next V1 15/32] IB/rxe: Address vector manipulation functions

Functions to manipulate Address Vector. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_av.c | 87 1 file changed, 87 insertions(+) create mode 100644 drivers/staging/rxe/rxe_av.c diff --git

[PATCH rdma-next V1 09/32] IB/rxe: Work request's opcode information table

Useful information about work request opcodes and pkt opcodes in table form. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_opcode.c | 961 +++ 1 file changed, 961 insertions(+) create mode 100644 dr

[PATCH rdma-next V1 02/32] IB/core: Add SEND_LAST_INV and SEND_ONLY_INV opcodes

Intorduce Add SEND_LAST_INV and SEND_ONLY_INV opcodes in ib_pack.h to be used by RXE for RC. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- include/rdma/ib_pack.h | 4 1 file changed, 4 insertions(+) diff --git a/include/rdma/ib_pack.h b/include/rdma/ib_

[PATCH rdma-next V1 30/32] IB/rxe: Shared objects between user and kernel

From: Amir Vadai Objects used by the userspace to post work requests. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- include/uapi/rdma/Kbuild | 1 + include/uapi/rdma/ib_rxe.h | 139 + 2 files changed, 140 inse

[PATCH rdma-next V1 04/32] IB/rxe: Bit mask and lengths declaration for different opcodes

header bit mask definitions and header lengths declaration of the rxe_opcode_info struct and rxe_wr_opcode_info struct. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_opcode.h | 128 +++ 1 file change

[PATCH rdma-next V1 05/32] IB/rxe: Default rxe device and port parameters

Default/initial rxe device parameter settings. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_param.h | 177 1 file changed, 177 insertions(+) create mode 100644 drivers/staging/rxe/rxe_param.h

[PATCH rdma-next V1 06/32] IB/rxe: External interface to lower level modules

Functions to be called by the networking layer. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe.h | 70 +++ 1 file changed, 70 insertions(+) create mode 100644 drivers/staging/rxe/rxe.h diff

[PATCH rdma-next V1 18/32] IB/rxe: Queue Pair (QP) handling

Functions to manipulate QP objects. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rxe/rxe_qp.c | 835 +++ 1 file changed, 835 insertions(+) create mode 100644 drivers/staging/rxe/rxe_qp.c diff --git a/drivers/staging/rxe/rxe_qp

[PATCH rdma-next V1 01/32] IB/core: Macro for RoCEv2 UDP port

From: Amir Vadai Adding a macro for RoCEv2 UDP destination port. Signed-off-by: Amir Vadai Signed-off-by: Kamal Heib --- include/rdma/ib_verbs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index dd1d901..ab5a6aa 100644 --- a/include/

[PATCH rdma-next V1 17/32] IB/rxe: Completion Queue (CQ) manipulation functions

Functions to manipulate CQ. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_cq.c | 165 +++ 1 file changed, 165 insertions(+) create mode 100644 drivers/staging/rxe/rxe_cq.c diff --git a/drivers/

[PATCH rdma-next V1 29/32] IB/rxe: sysfs interface to RXE

sysfs interface for ib_rxe Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_sysfs.c | 168 1 file changed, 168 insertions(+) create mode 100644 drivers/staging/rxe/rxe_sysfs.c diff --git a/driver

[PATCH rdma-next V1 10/32] IB/rxe: User/kernel shared queues infrastructure

mmap routines Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_mmap.c | 173 + 1 file changed, 173 insertions(+) create mode 100644 drivers/staging/rxe/rxe_mmap.c diff --git a/drivers/staging/rxe/

Re: [PATCH v1 00/24] New fast registration API

As mentioned earlier, I have a WIP RDS fastreg branch [3] which is functional (at least I can RDMA messages across nodes ;-)). Nice! So merging [2] and [3], I created [4] and applied a delta change based on your other patches. I saw ib_post_send failure with my HCA driver returning '-EINVAL'.

[PATCH rdma-next V1 28/32] IB/rxe: Interface to netdev stack

Linux netdev related code Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rxe/rxe_net.c | 729 ++ drivers/staging/rxe/rxe_net.h | 78 + 2 files changed, 807 insertions(+) create mode 100644 drivers/staging/rxe/rxe_net.c crea

[PATCH rdma-next V1 19/32] IB/rxe: Memory Region (MR) handling

MR objects handling. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rxe/rxe_mr.c | 764 +++ 1 file changed, 764 insertions(+) create mode 100644 drivers/staging/rxe/rxe_mr.c diff --git a/drivers/staging/rxe/rxe_mr.c b/drivers/st

[PATCH rdma-next V1 00/32] Soft-RoCE driver

Doug and list Hi, This patchset introduces Soft RoCE driver. Some background on the driver: The original Soft-RoCE driver was implemented by Bob Pearson from SFW. Bob started the submission process [3], but his work was abandoned after v2. Mellanox decided to pick it up and continue the submissio

[PATCH rdma-next V1 21/32] IB/rxe: Received packets handling

Handles receiving new packets which are sent to either request or response processing. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_recv.c | 371 + 1 file changed, 371 insertions(+) create mode

[PATCH rdma-next V1 14/32] IB/rxe: RXE tasks handling

A 'task' is a short function that returns 0 as long as it needs to be called again. rxe tasks are based on the kernel's tasklet infrastructure. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_task.c | 154

[PATCH rdma-next V1 13/32] IB/rxe: Allocation pool for RDMA objects

Manage and allocate pool of objects with given limit on number of elements. Gets parameters from rxe_type_info. Pool elements are allocated out of a slab cache. Objects that are using this facility are: PD, QP, SRQ, CQ, MR, FMR, MW, etc. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Revi

[PATCH rdma-next V1 11/32] IB/rxe: Common user/kernel queue implementation

A simple circular buffer that can optionally be shared between user space and the kernel and can be resized. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_queue.c | 217 drivers/staging/rxe/rxe_

[PATCH rdma-next V1 16/32] IB/rxe: Shared Receive Queue (SRQ) manipulation functions

Functions to manipulate SRQ. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_srq.c | 195 ++ 1 file changed, 195 insertions(+) create mode 100644 drivers/staging/rxe/rxe_srq.c diff --git a/driver

[PATCH rdma-next V1 12/32] IB/rxe: Interface to ib_core

rxe interface to rdma/core Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_verbs.c | 1461 +++ drivers/staging/rxe/rxe_verbs.h | 497 + 2 files changed, 1958 insertions(+) create mode 100

[PATCH rdma-next V1 07/32] IB/rxe: Misc local interfaces between files in ib_rxe

Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rxe/rxe_loc.h | 291 ++ 1 file changed, 291 insertions(+) create mode 100644 drivers/staging/rxe/rxe_loc.h diff --git a/drivers/staging/rxe/rxe_loc.h b/driv