Re: [PATCH v1 01/24] IB/core: Introduce new fast registration API

2015-09-29 Thread Sagi Grimberg
On 9/28/2015 11:57 PM, Bart Van Assche wrote: On 09/24/2015 12:37 AM, Sagi Grimberg wrote: On 9/23/2015 12:21 AM, Bart Van Assche wrote: On 09/17/2015 02:42 AM, Sagi Grimberg wrote: +} else if (last_page_off + dma_len < mr->page_size) { +/* chunk this fragment with

Re: [PATCH v1 01/24] IB/core: Introduce new fast registration API

2015-09-29 Thread Sagi Grimberg
On 9/29/2015 9:47 AM, Sagi Grimberg wrote: Shouldn't higher layers take care of this? Trying to implement the same coalescing algorithm at various layers isn't very optimal, although we need to decide and document which one is responsible. The block layer can take care of it, but I'm not sure

Re: [PATCH v1 01/24] IB/core: Introduce new fast registration API

2015-09-29 Thread Sagi Grimberg
Shouldn't higher layers take care of this? Trying to implement the same coalescing algorithm at various layers isn't very optimal, although we need to decide and document which one is responsible. The block layer can take care of it, but I'm not sure about NFS/RDS at the moment (IIRC Steve

[PATCH] dapl: Fix segfault while freeing qp

2015-09-29 Thread Bharat Potnuri
In function dapls_ib_qp_free(), pointers qp and cm_ptr->cm_id->qp are pointing to the same qp structure, initialized in function dapls_ib_qp_alloc(). The memory pointed by these pointers are freed twice in function dapls_ib_qp_free(), using rdma_destroy_qp() for the case _OPENIB_CMA defined and

Create a common verbs transport library

2015-09-29 Thread Dennis Dalessandro
Hi All, One of the conditions to move the hfi1 driver from staging into the normal drivers/infiniband/hw directory is to handle the code duplication in our verbs layer. This is going to be done by creating a new kmod which we will call rdmavt, for RDMA verbs transport. This will eventually live

Re: shrink struct ib_send_wr V4

2015-09-29 Thread Haggai Eran
On 13/09/2015 18:13, Christoph Hellwig wrote: > This series shrinks the WR size by splitting out the different WR > types. > > Patch number one is too large for the mailinglist, so if you didn't > get it grab it here: > > >

[PATCH 3.4] IB/qib: Change lkey table allocation to support more MRs

2015-09-29 Thread Mike Marciniszyn
The lkey table is allocated with with a get_user_pages() with an order based on a number of index bits from a module parameter. The underlying kernel code cannot allocate that many contiguous pages. There is no reason the underlying memory needs to be physically contiguous. This patch: -

[PATCH 3.10] IB/qib: Change lkey table allocation to support more MRs

2015-09-29 Thread Mike Marciniszyn
Ported from commit d6f1c17e162b2a11e708f28fa93f2f79c164b442 upstream. The lkey table is allocated with with a get_user_pages() with an order based on a number of index bits from a module parameter. The underlying kernel code cannot allocate that many contiguous pages. There is no reason the

Re: [PATCH 2/3] svcrdma: handle rdma read with a non-zero initial page offset

2015-09-29 Thread 'J. Bruce Fields'
On Mon, Sep 28, 2015 at 04:49:21PM -0500, Steve Wise wrote: > > > > -Original Message- > > From: J. Bruce Fields [mailto:bfie...@fieldses.org] > > Sent: Monday, September 28, 2015 4:05 PM > > To: Steve Wise > > Cc: trond.mykleb...@primarydata.com; linux-...@vger.kernel.org; > >

[PATCH 3.2] IB/qib: Change lkey table allocation to support more MRs

2015-09-29 Thread Mike Marciniszyn
The lkey table is allocated with with a get_user_pages() with an order based on a number of index bits from a module parameter. The underlying kernel code cannot allocate that many contiguous pages. There is no reason the underlying memory needs to be physically contiguous. This patch: -

RE: [PATCH] dapl: Fix segfault while freeing qp

2015-09-29 Thread Davis, Arlin R
Thanks, applied. > -Original Message- > From: Bharat Potnuri [mailto:bha...@chelsio.com] > Sent: Tuesday, September 29, 2015 5:30 AM > To: Davis, Arlin R > Cc: linux-rdma@vger.kernel.org; sw...@opengridcomputing.com; > nirran...@chelsio.com; Bharat Potnuri > Subject: [PATCH] dapl: Fix

Re: [PATCH v1 00/24] New fast registration API

2015-09-29 Thread Sagi Grimberg
On 9/29/2015 10:03 PM, Bart Van Assche wrote: On 09/17/2015 02:42 AM, Sagi Grimberg wrote: - Converted SRP initiator and RDS iwarp ULPs to the new API Hello Sagi, Hi Bart, How has the converted SRP initiator driver been tested ? With the kernel tree that is available on branch reg_api.4

Re: [PATCH] Expire sendonly joins (was Re: [PATCH rdma-rc 0/2] Add mechanism for ipoib neigh state change notifications)

2015-09-29 Thread Doug Ledford
On 09/28/2015 01:10 PM, Jason Gunthorpe wrote: > On Mon, Sep 28, 2015 at 11:36:11AM -0400, Doug Ledford wrote: > >>> Also broadcast could cause a unecessary reception event on the NICs of >>> machines that have no interest in this traffic. >> >> This is true. However, I'm trying to balance

[PULL REQUEST] Please pull rdma.git

2015-09-29 Thread Doug Ledford
Hi Linus, I have a few -rc fixes for you. One fix in particular, for the NFSoRDMA code, relied upon changes that went in during the 4.3 merge window to apply cleanly, but also relied on a group of related commits in this set, making it need to come through my tree. So I merged up to 4.3-rc2,

Re: [PATCH 04/38] IB/ehca: fix handling idr_alloc result

2015-09-29 Thread Doug Ledford
On 09/21/2015 09:33 AM, Andrzej Hajda wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > >

Re: [PATCH v1 00/24] New fast registration API

2015-09-29 Thread Bart Van Assche
On 09/17/2015 02:42 AM, Sagi Grimberg wrote: - Converted SRP initiator and RDS iwarp ULPs to the new API Hello Sagi, How has the converted SRP initiator driver been tested ? With the kernel tree that is available on branch reg_api.4 (427def03e9fa9801efbb27f6c3c6bf7fc0d012e1) I see on the