Re: [PATCH 1/2] iser: Set block queue_virt_boundary and remove bounce buffering code

On 10/10/2015 10:33 PM, Or Gerlitz wrote: On Sat, Oct 10, 2015 at 3:27 AM, Sagi Grimberg wrote: The block layer reliably enforces no SG lists with gaps to a 4k virtual boundary so we can completely remove the entire bounce buffering logic. Hi Sagi, Hey Or, (Very)

Re: libibverbs-1.2.0-rc1 release

On Wed, Sep 23, 2015 at 8:02 PM, Doug Ledford wrote: > I have done a pre-release of the upcoming libibverbs-1.2.0 release. The > code has been pushed to the official git repo and also an -rc1 tarball > uploaded to the https://ww.openfabrics.org/downloads/verbs download >

Re: [PATCH 2/2] IB/iser: Enable SG clustering

but with arbitrary SG list support it will benefit greatly. Y? please put some wording here to clarify. Well, because when a device will accept true SG lists then it would benefit the HCA caching/fetching to have less SG elements. I'll add a sentence to the change log. -- To unsubscribe from

[PATCH v1 1/2] IB/iser: set block queue_virt_boundary

By limiting the sg lists that we are allowing to meet and 4k virtual boundary, we can completely remove the entire bounce buffering logic. Signed-off-by: Sagi Grimberg Reviewed-by: Christoph Hellwig Cc: Jens Axboe Cc: Martin K. Petersen

[PATCH v1 2/2] IB/iser: Enable SG clustering

iser can handle it and it can dramatically reduce the number of SG elements. It doesn't make much of a difference at the moment, but with arbitrary SG list support it will benefit greatly. Signed-off-by: Sagi Grimberg --- drivers/infiniband/ulp/iser/iscsi_iser.c | 2 +- 1

[PATCH v1 0/2] iser bounce buffering cleanup

Now that the block layer reliably takes care that SG lists won't contain gaps if a driver set a virt_boundary we can lose the bounce buffering in iser code. The second patch enables SG clustering as iser fully supports it. This should be applied before the New memory registration API patch set.

[PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and use-after-free

From: Doron Tsur ib_send_cm_sidr_rep could sometimes erase the node from the sidr (depending on errors in the process). Since ib_send_cm_sidr_rep is called both from cm_sidr_req_handler and cm_destroy_id, cm_id_priv could be either erased from the rb_tree twice or not erased

[PATCH rdma-RC] IB/cm: Fix sleeping while atomic when creating AH from WC

When IP based addressing was introduced, ib_create_ah_from_wc was changed in order to support a suitable AH. Since this AH should now contains the DMAC (which isn't a simple derivative of the GID). In order to find the DMAC, an ARP should sometime be sent. This ARP is a sleeping context.

Re: [PATCH for-next 02/10] IB/mlx5: Support IB device's callback for getting its netdev

On 8/20/2015 7:46 PM, Achiad Shochat wrote: For Eth ports only. Maintain a net device pointer in mlx5_ib_device and update it upon NETDEV_REGISTER and NETDEV_UNREGISTER events if the net-device and IB device have the same PCI parent device. Implement the get_netdev callback to return this net

Re: Seeing WARN_ON in ib_dealloc_pd from ipoib in kernel 4.3-rc1-debug

Yes. I'm seeing this too. The last time this popped up I fixed it by adding the code for reaping ahs. I suspect that the new code to timeout sendonly multicast joins combined with us now creating and joining what used to be sendonly groups is the likely culprit here. Is someone looking at

Re: shrink struct ib_send_wr V4

On Sun, Sep 13, 2015 at 05:13:33PM +0200, Christoph Hellwig wrote: > This series shrinks the WR size by splitting out the different WR > types. > > Patch number one is too large for the mailinglist, so if you didn't > get it grab it here: > > >

Re: libibverbs-1.2.0-rc1 release

On 10/11/2015 12:51 PM, Or Gerlitz wrote: On Wed, Sep 23, 2015 at 8:02 PM, Doug Ledford wrote: I have done a pre-release of the upcoming libibverbs-1.2.0 release. The code has been pushed to the official git repo and also an -rc1 tarball uploaded to the

Re: [PATCH for-next 0/9] Add RoCE v2 support

On 8/13/2015 7:03 PM, Matan Barak wrote: Hi Doug, This series adds the support for RoCE v2. In order to support RoCE v2, we add gid_type attribute to every GID. When the RoCE GID management populates the GID table, it duplicates each GID with all supported types. This gives the user the

Re: [PATCH v1 2/2] IB/iser: Enable SG clustering

On 10/11/2015 6:35 PM, Sagi Grimberg wrote: iser can handle it and it can dramatically reduce the number of SG elements. It doesn't make much of a difference at the moment, but with arbitrary SG list support it will benefit greatly. Bahh, I updated the change-log in the previous revision :(

Re: [PATCH rdma-RC] IB/cm: Fix rb-tree duplicate free and use-after-free

> Fixes: a977049dacde ('[PATCH] IB: Add the kernel CM implementation') Please remove the the "[PATCH]" thing from the change-log and respin -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] IB: merge struct ib_device_attr into struct ib_device

On Sun, Oct 11, 2015 at 07:16:27PM +0300, Sagi Grimberg wrote: > Christoph, would you mind rebasing it on top of 4.3-rc4 or so? I > want to develop over it so I can test it on the fly. I can do a rebase to whatever you want. Initially this was over your reg_api branch. Is a rebase to the latest

Re: [PATCH v1 2/2] IB/iser: Enable SG clustering

On Sun, Oct 11, 2015 at 6:38 PM, Sagi Grimberg wrote: > On 10/11/2015 6:35 PM, Sagi Grimberg wrote: >> >> iser can handle it and it can dramatically reduce the >> number of SG elements. It doesn't make much of a difference at >> the moment, but with arbitrary SG list

Re: [PATCH v1 1/2] IB/iser: set block queue_virt_boundary

On Sun, Oct 11, 2015 at 6:35 PM, Sagi Grimberg wrote: > By limiting the sg lists that we are allowing to meet > and 4k virtual boundary, we can completely remove the > entire bounce buffering logic. "limiting the sg lists that we are allowing to meet and 4k virtual boundary"

Re: [PATCH] IB: merge struct ib_device_attr into struct ib_device

On 9/24/2015 4:35 PM, Christoph Hellwig wrote: On Thu, Sep 24, 2015 at 08:41:17AM +0300, Or Gerlitz wrote: We had a smaller volume move to cache the device attributes on the IB device structure, and I just realized it was dropped on the floor. Ira, that was a reviewer comment you got when

4.4's rdma plate

Hi Doug, As we're soon on 4.3-rc5, could you please update how things look for 4.4? The mutlicast loopback prevention patches from Eran were intially posted ~two months ago and went through testing by Christoph and Co. The patches do have one new uverb entry (extended form for

Re: [PATCH v1 1/2] IB/iser: set block queue_virt_boundary

On 10/11/15 12:04, Or Gerlitz wrote: If the 4X assertion made here is correct, why not keeping the current BB logic to come into play for such devices? I know that without the BB code our driver looks much nicer and elegant, but life is sometimes more complex... thoughts? Hello Or, Whether or

Re: Seeing WARN_ON in ib_dealloc_pd from ipoib in kernel 4.3-rc1-debug

On Sun, 11 Oct 2015, Sagi Grimberg wrote: > Is someone looking at this? It really should be fixed before 4.3 > final... The following fixup patch is needed: Subject: ipoib: For sendonly join free the multicast group on leave When we leave the multicast group on expiration of a neighbor we do

Re: [PATCH v1 1/2] IB/iser: set block queue_virt_boundary

On Mon, Oct 12, 2015 at 7:34 AM, Sagi Grimberg wrote: >> What happens now when an app wants to use 1K, 2K, 3K IOs? they can >> only use 1/4, 1/2 or 3/4 of the available memory for these >> transactions? > What? I'm not sure what you are talking about. what available

Re: [PATCH v1 1/2] IB/iser: set block queue_virt_boundary

What happens now when an app wants to use 1K, 2K, 3K IOs? they can only use 1/4, 1/2 or 3/4 of the available memory for these transactions? What? I'm not sure what you are talking about. what available memory? and we are going to fix it with devices like mlx5 over the new API you're

Re: [PATCH] IB: merge struct ib_device_attr into struct ib_device

I can do a rebase to whatever you want. Initially this was over your reg_api branch. Is a rebase to the latest reg_api.6 fine? That would be great. Sagi. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More