Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

On Mon, Dec 21, 2015 at 8:22 AM, ira.weiny wrote: > On Sun, Dec 20, 2015 at 12:16:09PM +0200, Leon Romanovsky wrote: >> From: Leon Romanovsky >> >> Modify enum ib_device_cap_flags such that other patches which add new >> enum values pass strict

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

Greg, Doug, As mentioned below, these patches depend on the new rdmavt library submitted to Doug on linux-rdma. We continue to identify (and rework) patches by our other developers which can be submitted without conflicts with this series. Furthermore, We have, as much as possible, placed fixes

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

On Sun, Dec 20, 2015 at 12:16:09PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Modify enum ib_device_cap_flags such that other patches which add new > enum values pass strict checkpatch.pl checks. > > Reviewed-by: Sagi Grimberg >

Re: [PATCH v2 00/10] iSER support for remote invalidate

Hi Sagi, Jenny & Co, On Wed, 2015-12-09 at 14:11 +0200, Sagi Grimberg wrote: > Changes from v1: > - Fixed change-log typos > > Changes from v0: > - Rebased on top of 4.4-rc2 > - Removed iser_hello messages from the protocol header > - Avoided from further breaking the non-existent bidi support >

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

On Mon, Dec 21, 2015 at 8:37 AM, Leon Romanovsky wrote: > On Mon, Dec 21, 2015 at 8:22 AM, ira.weiny wrote: >> On Sun, Dec 20, 2015 at 12:16:09PM +0200, Leon Romanovsky wrote: >>> From: Leon Romanovsky >>> Modify enum ib_device_cap_flags

Re: ocrdma failure in 4.4.0-rc5

Hi Dough, Thanks for your note. We will root cause the issue asap and get back to you with the fix. -Regards Devesh On Sun, Dec 20, 2015 at 1:41 AM, Doug Ledford wrote: > Hi Devesh, > > Testing 4.4.0-rc5, the ocrdma driver is failing for me (100% reliably). > If you have

[PATCH V1] libmlx5: Add gitignore file to the project

From: Leon Romanovsky Add gitignore file to the libmlx5 project. Changes from v0: * Add temporary files created by etags/ctags/gtags/cscope. * Add Reviewed-by signature Reviewed-by: Sagi Grimberg Signed-off-by: Leon Romanovsky

Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr

However, I think that the patch from Shani 6b52a12bc3fc ("IB/uverbs: Implement memory windows support in uverbs") is wrong. A memory window allocation should really reference the MR and not the PD (which is referenced by the MR). Otherwise the MR deregistration is allowed with windows bound to

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

On Mon, Dec 14, 2015 at 6:06 PM, Christoph Lameter wrote: > On Mon, 14 Dec 2015, Matan Barak wrote: > >> > No idea what the counter is doing. Saw another EXT counter implementation >> > use 0 so I thought that was fine. >> >> It seems like a counter index, but I might be wrong

Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr

On 12/20/2015 11:31 AM, Sagi Grimberg wrote: However, I think that the patch from Shani 6b52a12bc3fc ("IB/uverbs: Implement memory windows support in uverbs") is wrong. A memory window allocation should really reference the MR and not the PD (which is referenced by the MR). Otherwise the MR

Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr

On 20/12/2015 11:31, Sagi Grimberg wrote: > >>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h >>> index 284916d..e45776e 100644 >>> --- a/include/rdma/ib_verbs.h >>> +++ b/include/rdma/ib_verbs.h >>> @@ -1306,7 +1306,6 @@ struct ib_mr { >>> u64 iova; >>> u32

Re: [Cocci] [PATCH] staging/rdma/hfi1: Fix a possible null pointer dereference

Here is my proposition for finding missing NULL tests. I tried to limit it to generic kmalloc like functions. There are of course many other NULL returning functions, but maybe they could be in an other rule, julia --- /// Look for kmalloc etc that are not followed by a NULL check. //# May

Re: [PATCH libibverbs 0/3] Add cross-channel support

On Sun, Dec 20, 2015 at 01:22:41PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > This patchset adds supplementary part of cross-channel support [1] > to libibverbs. All of this needs some kind of man page update And considering this is a non-standard feature it

Re: [PATCH] libmlx5: Add gitignore file to the project

Add gitignore file to the libmlx5 project. I think cscope files will be useful here too, Otherwise looks good, Reviewed-by: Sagi Grimberg -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr

On 12/20/2015 11:31 AM, Sagi Grimberg wrote: However, I think that the patch from Shani 6b52a12bc3fc ("IB/uverbs: Implement memory windows support in uverbs") is wrong. A memory window allocation should really reference the MR and not the PD (which is referenced by the MR). Otherwise the MR

Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr

diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 284916d..e45776e 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1306,7 +1306,6 @@ struct ib_mr { u64 iova; u32 length; unsigned int page_size; -atomic_t

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

On 12/20/2015 5:10 AM, Matan Barak wrote: > On Mon, Dec 14, 2015 at 6:06 PM, Christoph Lameter wrote: >> On Mon, 14 Dec 2015, Matan Barak wrote: >> No idea what the counter is doing. Saw another EXT counter implementation use 0 so I thought that was fine. >>> >>> It

[PATCH libibverbs 2/3] libibverbs: Add cross-channel QP initialization flags

From: Leon Romanovsky The cross-channel feature allows to execute WQEs that involve synchronization of I/O operations' on different QPs. These QPs should be configured to work as a "sync master queue" or “sync slave queues”. The QP property flags to indicate if queues are

[PATCH libibverbs 3/3] libibverbs: Export cross-channel capability flag

From: Leon Romanovsky The device implements capability to execute complex I/O operations across multiple I/O channels - synchronize execution of I/O operations on one I/O channel with execution of I/O operations on another channel(s). Cross-channel operations support is

[PATCH libmlx5 0/2] Add cross-channel support

From: Leon Romanovsky This patchset adds libmlx5 part of cross-channel support. These patches were added on top of "Completion timestamping" [2]. [1] http://thread.gmane.org/gmane.linux.drivers.rdma/31715 [2] http://www.spinics.net/lists/linux-rdma/msg30940.html Leon

[PATCH libmlx5 2/2] libmlx5: Add CQ ignore overrun creation flag

From: Leon Romanovsky In order to use CQ for cross-channel operations, the user needs to configure CQ to ignore overrun creation flag. This patch adds support of it to libmlx5 library. Signed-off-by: Leon Romanovsky --- src/mlx5-abi.h | 14

[PATCH libibverbs 0/3] Add cross-channel support

From: Leon Romanovsky This patchset adds supplementary part of cross-channel support [1] to libibverbs. These patches were added on top of "Completion timestamping" [2] and "Expose QP block self multicast loopback creation flag" [3] series. [1]

[PATCH libmlx5 1/2] libmlx5: Add cross-channel primitives

From: Leon Romanovsky The cross-channel feature relies on special primitives to send and receive work requests. * WAIT on CQ WR - This WR holds execution of subsequent requests on that queue until producer index of a CQ is met. • SEND_EN WR - This WR specifies value of

[PATCH V1 2/3] IB/core: Add cross-channel support

From: Leon Romanovsky The cross-channel feature allows to execute WQEs that involve synchronization of I/O operations’ on different QPs. This capability enables to program complex flows with a single function call, hereby significantly reducing overhead associated with I/O

[PATCH V1 0/3] Add cross-channel support

From: Leon Romanovsky This patchset adds cross-channel support. The cross-channel feature allows to execute WQEs that involve synchronization of I/O operations’ on different QPs. This capability enables to program complex flows with a single function call, hereby

[PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

From: Leon Romanovsky Modify enum ib_device_cap_flags such that other patches which add new enum values pass strict checkpatch.pl checks. Reviewed-by: Sagi Grimberg Signed-off-by: Leon Romanovsky --- include/rdma/ib_verbs.h | 60

[PATCH V1 3/3] IB/mlx5: Add driver cross-channel support

From: Leon Romanovsky Add support of cross-channel functionality to mlx5 driver. This includes ability to ignore overrun for CQ which intended for cross-channel, export device capability and configure the QP to be sync master/slave queues. The cross-channel enabled QP

[PATCH libibverbs 1/3] libibverbs: Add CQ ignore overrun creation flag

From: Leon Romanovsky A CQ overrun is checked while posting a completion, and if encountered, the QP is transferred to the appropriate error state. CQ update (and error discovery) are not synchronized with WQE execution. Thus, a positive acknowledgement can be sent to the

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

On Mon, Dec 21, 2015 at 8:52 AM, Or Gerlitz wrote: > On Mon, Dec 21, 2015 at 8:37 AM, Leon Romanovsky wrote: >> On Mon, Dec 21, 2015 at 8:22 AM, ira.weiny wrote: >>> On Sun, Dec 20, 2015 at 12:16:09PM +0200, Leon Romanovsky wrote:

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

On Mon, Dec 21, 2015 at 9:27 AM, Leon Romanovsky wrote: > On Mon, Dec 21, 2015 at 8:52 AM, Or Gerlitz wrote: >> On Mon, Dec 21, 2015 at 8:37 AM, Leon Romanovsky wrote: >>> On Mon, Dec 21, 2015 at 8:22 AM, ira.weiny wrote:

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

On Mon, Dec 21, 2015 at 9:40 AM, Or Gerlitz wrote: > On Mon, Dec 21, 2015 at 9:27 AM, Leon Romanovsky wrote: >> On Mon, Dec 21, 2015 at 8:52 AM, Or Gerlitz wrote: >>> On Mon, Dec 21, 2015 at 8:37 AM, Leon Romanovsky wrote:

Re: [PATCH 09/10] IB: remove the struct ib_phys_buf definition

On Sun, Dec 20, 2015 at 09:37:38AM +0200, Or Gerlitz wrote: > On 12/18/2015 3:55 PM, Christoph Hellwig wrote: > >> Signed-off-by: Christoph Hellwig >> Reviewed-by: Sagi Grimberg >> Reviewed-by: Jason Gunthorpe [core] >>

Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr

On Fri, Dec 18, 2015 at 03:14:08PM +0100, Bart Van Assche wrote: > On 12/18/2015 02:55 PM, Christoph Hellwig wrote: >> Signed-off-by: Christoph Hellwig > > Shouldn't the description of this patch be changed into something like > "Remove the usecnt field from ib_mr since it is always

Re: [PATCH libibverbs 2/3] libibverbs: Add cross-channel QP initialization flags

On 12/20/2015 1:22 PM, Leon Romanovsky wrote: --- include/infiniband/verbs.h | 3 +++ src/cmd.c | 5 - 2 files changed, 7 insertions(+), 1 deletion(-) You need to document the new creation flags in a man page. If this doesn't exist, this should be added to Eran's

Re: [PATCH rdma-next V1 3/7] IB/ulps: Avoid calling ib_query_device

On 12/18/2015 4:10 PM, Bart Van Assche wrote: Shouldn't this patch be split per ULP driver to make review easier ? The patch is very simple and does the same practice in all ULPs. If it helps I can spit off the srp initiator and target bits into a different patch, let me know. If you

Re: [PATCH 09/10] IB: remove the struct ib_phys_buf definition

On 12/20/2015 5:41 PM, Christoph Hellwig wrote: I can't see a useful explanation for removing an unused structure. But if you really want one and come up with a coherent sentence or two I can add it. patch title - IB/core: Remove struct ib_phys_buf change log: Remove struct ib_phys_buf

Re: [PATCH rdma-next 1/6] IB/core: Save the device attributes on the device structure

On 12/18/2015 6:49 PM, Jason Gunthorpe wrote: On Fri, Dec 18, 2015 at 10:08:41AM +0200, Or Gerlitz wrote: On 12/17/2015 7:41 PM, Jason Gunthorpe wrote: On Thu, Dec 17, 2015 at 03:44:19PM +0200, Sagi Grimberg wrote: + ret = ib_query_device(device, >attrs); + if (ret) { +