[PATCH 1/4] RDMA/ocrdma: Fix vlan-id assignment in qp parameters

2015-12-24 Thread Devesh Sharma
dmac resolution') Cc: Matan Barak Signed-off-by: Devesh Sharma --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c index 30f67be..4fc2bb4 100644 ---

[PATCH 2/4] RDMA/ocrdma: Dispatch only port event when port state changes

2015-12-24 Thread Devesh Sharma
Dispatch only port event to IB stack when port state changes. Don't explicitly modify qps to error. Let application listen to port events on async event queue or let QP fail with retry-exceeded completion error. Signed-off-by: Padmanabh Ratnakar Signed-off-by: Devesh Sharma --- dr

[PATCH 3/4] RDMA/ocrdma: Depend on async link events from CNA

2015-12-24 Thread Devesh Sharma
hold device-list-mutex and thus breaks the busy-wait scenario. Reported-by: Doug Ledford CC: Sathya Perla Signed-off-by: Padmanabh Ratnakar Signed-off-by: Selvin Xavier Signed-off-by: Devesh Sharma --- drivers/infiniband/hw/ocrdma/ocrdma.h | 10 ++ drivers/infiniband/hw/ocrdma/ocr

[PATCH 0/4] ocrdma bug fix for linux-4.4-rc

2015-12-24 Thread Devesh Sharma
under rtnl-lock. Moving from administrative events to CNA async-events does not change the functionality of ocrdma driver in any way. Patch 0004 Removes the dead code from be2net driver. Devesh Sharma (4): RDMA/ocrdma: Fix vlan-id assignment in qp parameters RDMA/ocrdma: Dispatch only port

[PATCH 4/4] RDMA/be2net: Remove open and close entry points

2015-12-24 Thread Devesh Sharma
r Signed-off-by: Selvin Xavier Signed-off-by: Devesh Sharma --- drivers/net/ethernet/emulex/benet/be.h | 2 -- drivers/net/ethernet/emulex/benet/be_main.c | 4 drivers/net/ethernet/emulex/benet/be_roce.c | 36 - drivers/net/ethernet/emulex/benet/be_roce.h |

Re: ocrdma failure in 4.4.0-rc5

2015-12-23 Thread Devesh Sharma
under testing. After 1 round of internal reivew I should be able to post the series in a day or two. -Regards Devesh On Wed, Dec 23, 2015 at 11:29 PM, Doug Ledford wrote: > On 12/20/2015 11:29 PM, Devesh Sharma wrote: >> Hi Dough, >> >> Thanks for your note. >> >>

Re: ocrdma failure in 4.4.0-rc5

2015-12-20 Thread Devesh Sharma
Hi Dough, Thanks for your note. We will root cause the issue asap and get back to you with the fix. -Regards Devesh On Sun, Dec 20, 2015 at 1:41 AM, Doug Ledford wrote: > Hi Devesh, > > Testing 4.4.0-rc5, the ocrdma driver is failing for me (100% reliably). > If you have vlans off of the main

Re: [PATCH v3 00/11] NFS/RDMA client patches for 4.5

2015-12-16 Thread Devesh Sharma
Hi Chuck, iozone passed on ocrdma device. Link bounce fails to recover iozone traffic, however failure is not related to this patch series. I am in processes of finding out the patch which broke it. Tested-By: Devesh Sharma On Wed, Dec 16, 2015 at 1:07 AM, Anna Schumaker wrote: > Tha

Re: [PATCH v4 00/11] NFS/RDMA server patches for v4.5

2015-12-16 Thread Devesh Sharma
iozone passed on ocrdma device. Link bounce fails to recover iozone traffic, however failure is not related to this patch series. I am in processes of finding out the patch which broke it. Tested-By: Devesh Sharma On Tue, Dec 15, 2015 at 3:00 AM, Chuck Lever wrote: > Here are patches

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

2015-12-14 Thread Devesh Sharma
Hello all, On Sat, Dec 12, 2015 at 5:26 AM, ira.weiny wrote: > On Fri, Dec 11, 2015 at 12:25:35PM -0600, Christoph Lameter wrote: >> Display the additional 64 bit counters available through the extended >> set and replace the existing 32 bit counters if there is a 64 bit >> alternative available.

Re: [PATCH 03/11] IB: remove support for phys MRs

2015-11-24 Thread Devesh Sharma
Reviewed-By: Devesh Sharma (ocrdma) On Sun, Nov 22, 2015 at 11:16 PM, Christoph Hellwig wrote: > We have stopped using phys MRs in the kernel a while ago, so let's > remove all the cruft used to implement them. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Steve W

[PATCH 0/4] libocrdma bug-fixes

2015-11-01 Thread Devesh Sharma
Bug fix series of user-space rdma driver for Emulex devices. Devesh Sharma (3): RDMA/libocrdma: set vlan present bit for UD RDMA/libocrdma: Prevent CQ-Doorbell floods RDMA/libocrdma: update libocrdma version string Padmanabh Ratnakar (1): RDMA/libocrdma:sync qp-state with hw state

[PATCH 3/4] RDMA/libocrdma: Prevent CQ-Doorbell floods

2015-11-01 Thread Devesh Sharma
Changing CQ-Doorbell(DB) logic to prevent DB floods, it is supposed to be pressed only if any hw CQE is polled. If cq-arm was requested previously then don't bother about number of hw CQEs polled and arm the CQ. Signed-off-by: Devesh Sharma --- src/ocrdma_verbs.c | 9 +++-- 1 file ch

[PATCH 1/4] RDMA/libocrdma:sync qp-state with hw state

2015-11-01 Thread Devesh Sharma
From: Padmanabh Ratnakar This patch sync up the QP state with the underlying h/w QP state and reports the same to user application. Signed-off-by: Padmanabh Ratnakar Signed-off-by: Devesh Sharma --- src/ocrdma_verbs.c | 33 +++-- 1 file changed, 19 insertions

[PATCH 2/4] RDMA/libocrdma: set vlan present bit for UD

2015-11-01 Thread Devesh Sharma
This patch tells f/w about the presence of VLAN tag in the AH being supplied to the QP. Signed-off-by: Devesh Sharma --- src/ocrdma_abi.h | 7 --- src/ocrdma_main.h | 7 +++ src/ocrdma_verbs.c | 8 ++-- 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src

[PATCH 4/4] RDMA/libocrdma: update libocrdma version string

2015-11-01 Thread Devesh Sharma
version string updated from 1.0.5 to 1.0.6 Signed-off-by: Devesh Sharma --- configure.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.in b/configure.in index 140c07b..653bc43 100644 --- a/configure.in +++ b/configure.in @@ -1,11 +1,11 @@ dnl Process this

Re: [PATCH for-next v2 10/10] IB/core: Remove smac and vlan id from path record

2015-10-18 Thread Devesh Sharma
Looks Good Reviewed-By: Devesh Sharma On Thu, Oct 15, 2015 at 9:08 PM, Matan Barak wrote: > The GID cache accompanies every GID with attributes. > The GID attributes link the GID with its netdevice, which could be > resolved to smac and vlan id easily. Since we've added the netdev

Re: [PATCH for-next v2 09/10] IB/core: Remove smac and vlan id from qp_attr and ah_attr

2015-10-18 Thread Devesh Sharma
Looks Good Reviewed-By: Devesh Sharma On Thu, Oct 15, 2015 at 9:08 PM, Matan Barak wrote: > Smac and vlan id could be resolved from the GID attribute, and thus > these attributes aren't needed anymore. Removing them. > > Signed-off-by: Matan Barak > --- > drivers/inf

Re: [PATCH for-next v2 08/10] IB/cm: Remove the usage of smac and vid of qp_attr and cm_av

2015-10-18 Thread Devesh Sharma
Looks Good Reviewed-By: Devesh Sharma On Thu, Oct 15, 2015 at 9:08 PM, Matan Barak wrote: > The cm and cma don't need to explicitly handle vlan and smac, > as they are resolved from the GID index now. Removing this > portion of code. > > Signed-off-by: Matan Barak > --

Re: [PATCH for-next v2 06/10] IB/cache: Add ib_find_gid_by_filter cache API

2015-10-18 Thread Devesh Sharma
Looks Good Reviewed-By: Devesh Sharma On Thu, Oct 15, 2015 at 9:08 PM, Matan Barak wrote: > GID cache API users might want to search for GIDs with specific > attributes rather than just specifying GID, net device and port. > This is used in a later patch, where we find the sgid inde

Re: [PATCH for-next v2 05/10] IB/cma: cma_validate_port should verify the port and netdevice

2015-10-18 Thread Devesh Sharma
Looks Good Reveiwed-By: Devesh Sharma On Thu, Oct 15, 2015 at 9:08 PM, Matan Barak wrote: > Previously, cma_validate_port searched for GIDs in IB cache and then > tried to verify the found port. This could fail when there are > identical GIDs on both ports. In addition, netdevice

Re: [PATCH for-next v2 04/10] IB/cm: cm_init_av_by_path should find a GID by its netdevice

2015-10-18 Thread Devesh Sharma
Looks Good Reviewed-By: Devesh Sharma On Thu, Oct 15, 2015 at 9:08 PM, Matan Barak wrote: > Previously, the CM has searched the cache for any sgid_index whose > GID matches the path's GID. Since the path record stores the net > device, the CM should now search only for GIDs wh

Re: [PATCH for-next v2 03/10] IB/core: Add netdev to path record

2015-10-18 Thread Devesh Sharma
Looks Good Reviewed-By: Devesh Sharma On Thu, Oct 15, 2015 at 9:08 PM, Matan Barak wrote: > In order to find the sgid_index, one could just query the IB cache > with the correct GID and netdevice. Therefore, instead of storing > the L2 attributes directly in the path, we only

Re: [PATCH for-next v2 01/10] IB/core: Add netdev and gid attributes paramteres to cache

2015-10-18 Thread Devesh Sharma
Looks Good Reviewed-By: Devesh Sharma On Thu, Oct 15, 2015 at 9:08 PM, Matan Barak wrote: > Adding an ability to query the IB cache by a netdev and get the > attributes of a GID. These parameters are necessary in order to > successfully resolve the required GID (when the netdevice

Re: [PATCH for-next v2 02/10] IB/core: Expose and rename ib_find_cached_gid_by_port cache API

2015-10-18 Thread Devesh Sharma
looks good, Reviewed-By: Devesh Sharma On Thu, Oct 15, 2015 at 9:08 PM, Matan Barak wrote: > Sometime consumers might want to search for a GID in a specific port. > For example, when a WC arrives and we want to search the GID > that matches that port - it's better to search onl

Re: [PATCH for-next 2/7] IB: Introduce Work Queue object and its verbs

2015-10-18 Thread Devesh Sharma
Hi All, Will it be a good idea to have ha separate header for this feature. Lets not append to ib_verbs.h? -Regards Devesh On Sun, Oct 18, 2015 at 8:45 PM, Parav Pandit wrote: > On Sun, Oct 18, 2015 at 8:38 PM, Yishai Hadas > wrote: >> On 10/15/2015 7:49 PM, Parav Pandit wrote: >> >>> If there

Re: [PATCH v2 00/16] NFS/RDMA patches for merging into v4.4

2015-10-14 Thread Devesh Sharma
Hi Chuck, With the server crash fix in place, ocrdma is passing iozone on this series. Series Tested-By: Devesh Sharma On Tue, Oct 6, 2015 at 8:28 PM, Chuck Lever wrote: > Introduce client-side support for bi-directional RPC/RDMA. > Bi-directional RPC/RDMA is a pre-requisite for NFSv

Re: [PATCH rdma-RC] IB/cm: Fix sleeping while atomic when creating AH from WC

2015-10-12 Thread Devesh Sharma
Looks good, just one doubt inline: On Sun, Oct 11, 2015 at 6:28 PM, Matan Barak wrote: > When IP based addressing was introduced, ib_create_ah_from_wc was > changed in order to support a suitable AH. Since this AH should > now contains the DMAC (which isn't a simple derivative of the GID). > In o

Re: [PATCH v2 06/16] xprtrdma: Use workqueue to process RPC/RDMA replies

2015-10-06 Thread Devesh Sharma
Looks good! I will send a test report with ocrdma driver. Reviewed-By: Devesh Sharma On Tue, Oct 6, 2015 at 8:29 PM, Chuck Lever wrote: > The reply tasklet is fast, but it's single threaded. After reply > traffic saturates a single CPU, there's no more reply processing > ca

Re: [PATCH v2 05/16] xprtrdma: Replace send and receive arrays

2015-10-06 Thread Devesh Sharma
looks good, Reviewed-By: Devesh Sharma On Tue, Oct 6, 2015 at 8:29 PM, Chuck Lever wrote: > The rb_send_bufs and rb_recv_bufs arrays are used to implement a > pair of stacks for keeping track of free rpcrdma_req and rpcrdma_rep > structs. Replace those arrays with free lists. > >

Re: [PATCH v2 04/16] xprtrdma: Refactor reply handler error handling

2015-10-06 Thread Devesh Sharma
Looks Good, Reviewed-By: Devesh Sharma On Tue, Oct 6, 2015 at 8:29 PM, Chuck Lever wrote: > Clean up: The error cases in rpcrdma_reply_handler() almost never > execute. Ensure the compiler places them out of the hot path. > > No behavior change expected. > > Signed-o

Re: [PATCH v2 02/16] xprtrdma: Re-arm after missed events

2015-10-06 Thread Devesh Sharma
Looks good, Reviewed-By: Devesh Sharma Will send a test-report of this series with ocrdma drivers. On Tue, Oct 6, 2015 at 8:28 PM, Chuck Lever wrote: > ib_req_notify_cq(IB_CQ_REPORT_MISSED_EVENTS) returns a positive > value if WCs were added to a CQ after the last completion upcall

Re: [PATCH v2 03/16] xprtrdma: Prevent loss of completion signals

2015-10-06 Thread Devesh Sharma
Looks good! Reviewed-By: Devesh Sharma On Tue, Oct 6, 2015 at 8:28 PM, Chuck Lever wrote: > Commit 8301a2c047cc ("xprtrdma: Limit work done by completion > handler") was supposed to prevent xprtrdma's upcall handlers from > starving other softIRQ work by letting the

Re: [PATCH v1 03/18] xprtrdma: Remove completion polling budgets

2015-09-22 Thread Devesh Sharma
On Mon, Sep 21, 2015 at 9:15 PM, Chuck Lever wrote: > >> On Sep 21, 2015, at 1:51 AM, Devesh Sharma >> wrote: >> >> On Sun, Sep 20, 2015 at 4:05 PM, Sagi Grimberg >> wrote: >>>>> It is possible that in a given poll_cq >>>>> c

Re: [PATCH v1 08/18] xprtrdma: Pre-allocate Work Requests for backchannel

2015-09-21 Thread Devesh Sharma
On Fri, Sep 18, 2015 at 2:15 AM, Chuck Lever wrote: > Pre-allocate extra send and receive Work Requests needed to handle > backchannel receives and sends. > > The transport doesn't know how many extra WRs to pre-allocate until > the xprt_setup_backchannel() call, but that's long after the WRs are

Re: [PATCH v1 07/18] xprtrdma: Pre-allocate backward rpc_rqst and send/receive buffers

2015-09-21 Thread Devesh Sharma
Looks good. On Fri, Sep 18, 2015 at 2:15 AM, Chuck Lever wrote: > xprtrdma's backward direction send and receive buffers are the same > size as the forechannel's inline threshold, and must be pre- > registered. > > The consumer has no control over which receive buffer the adapter > chooses to cat

Re: [PATCH v1 04/18] xprtrdma: Refactor reply handler error handling

2015-09-21 Thread Devesh Sharma
Looks good. On Fri, Sep 18, 2015 at 2:14 AM, Chuck Lever wrote: > Clean up: The error cases in rpcrdma_reply_handler() almost never > execute. Ensure the compiler places them out of the hot path. > > No behavior change expected. > > Signed-off-by: Chuck Lever > --- > net/sunrpc/xprtrdma/rpc_rdm

Re: [PATCH v1 02/18] xprtrdma: Replace global lkey with lkey local to PD

2015-09-21 Thread Devesh Sharma
Looks good, will test this ocrdma and update you. On Fri, Sep 18, 2015 at 2:14 AM, Chuck Lever wrote: > The core API has changed so that devices that do not have a global > DMA lkey automatically create an mr, per-PD, and make that lkey > available. The global DMA lkey interface is going away in

Re: [PATCH v1 01/18] xprtrdma: Enable swap-on-NFS/RDMA

2015-09-21 Thread Devesh Sharma
Looks Good. On Fri, Sep 18, 2015 at 2:14 AM, Chuck Lever wrote: > After adding a swapfile on an NFS/RDMA mount and removing the > normal swap partition, I was able to push the NFS client well > into swap without any issue. > > I forgot to swapoff the NFS file before rebooting. This pinned > the N

Re: [PATCH v1 03/18] xprtrdma: Remove completion polling budgets

2015-09-21 Thread Devesh Sharma
On Sun, Sep 20, 2015 at 4:05 PM, Sagi Grimberg wrote: >>> It is possible that in a given poll_cq >>> call you end up getting on 1 completion, the other completion is >>> delayed due to some reason. >> >> >> If a CQE is allowed to be delayed, how does polling >> again guarantee that the consumer ca

Re: [PATCH v1 03/18] xprtrdma: Remove completion polling budgets

2015-09-21 Thread Devesh Sharma
On Fri, Sep 18, 2015 at 7:49 PM, Chuck Lever wrote: > Hi Devesh- > > > On Sep 18, 2015, at 2:52 AM, Devesh Sharma > wrote: > >> On Fri, Sep 18, 2015 at 2:14 AM, Chuck Lever wrote: >>> >>> Commit 8301a2c047cc ("xprtrdma: Limit work done by c

Re: [PATCH v1 03/18] xprtrdma: Remove completion polling budgets

2015-09-17 Thread Devesh Sharma
On Fri, Sep 18, 2015 at 2:14 AM, Chuck Lever wrote: > > Commit 8301a2c047cc ("xprtrdma: Limit work done by completion > handler") was supposed to prevent xprtrdma's upcall handlers from > starving other softIRQ work by letting them return to the provider > before all CQEs have been polled. > > The

[PATCH v2] xprtrdma: take HCA driver refcount at client

2015-07-29 Thread Devesh Sharma
count during the mount of a nfs-rdma mount point. Cc: chuck.le...@oracle.com Cc: linux-...@vger.kernel.org Signed-off-by: Devesh Sharma Reviewed-by: Sagi Grimberg --- net/sunrpc/xprtrdma/verbs.c | 38 ++ 1 files changed, 30 insertions(+), 8 deletions(-) diff

Re: [PATCH v1] xprtrdma: take vendor driver refcount at client

2015-07-29 Thread Devesh Sharma
On Wed, Jul 29, 2015 at 1:03 PM, Christoph Hellwig wrote: > Hi Devesh, > > I don't understand your use of "vendor driver" here. It seems your'e > talking about the HCA driver. Yes, I mean to say HCA driver. I will change this in next revision, its confusing rigth now. > -- To unsubscribe from t

[PATCH v1 RESEND] xprtrdma: take vendor driver refcount at client

2015-07-29 Thread Devesh Sharma
ng the mount of a nfs-rdma mount point. Cc: chuck.le...@oracle.com Cc: linux-...@vger.kernel.org Signed-off-by: Devesh Sharma Reviewed-by: Sagi Grimberg --- net/sunrpc/xprtrdma/verbs.c | 38 ++ 1 files changed, 30 insertions(+), 8 deletions(-) diff --git

[PATCH v1] xprtrdma: take vendor driver refcount at client

2015-07-29 Thread Devesh Sharma
ng the mount of a nfs-rdma mount point. CC:chuck.le...@oracle.com CC:linux-...@vger.kernel.org Signed-off-by: Devesh Sharma Reviewed-by: Sagi Grimberg --- net/sunrpc/xprtrdma/verbs.c | 38 ++ 1 files changed, 30 insertions(+), 8 deletions(-) diff --git a/net/

Re: [PATCH] xprtrdma: take vendor driver refcount at client

2015-07-28 Thread Devesh Sharma
On Tue, Jul 28, 2015 at 7:43 PM, Chuck Lever wrote: > > On Jul 28, 2015, at 4:46 AM, Sagi Grimberg wrote: > >> On 7/28/2015 2:01 AM, Devesh Sharma wrote: >>> Thanks Chuck Lever for the valuable feedback and suggestions. >>> >>> This is a rework of t

[PATCH] xprtrdma: take vendor driver refcount at client

2015-07-27 Thread Devesh Sharma
munity decided that preventing the hang right now is more important than waiting for architectural changes. Signed-off-by: Devesh Sharma --- net/sunrpc/xprtrdma/verbs.c | 31 +++ 1 files changed, 23 insertions(+), 8 deletions(-) diff --git a/net/sunrpc/xprtrdma/verbs.c

[PATCH v1 2/2] RDMA/ocrdma: update ocrdma module license srting

2015-07-23 Thread Devesh Sharma
evendra Naga Signed-off-by: Devesh Sharma --- drivers/infiniband/hw/ocrdma/ocrdma_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c index 6ded95a..b119a34 100644 --- a/drivers/

[PATCH v1 1/2] RDMA/ocrdma: update ocrdma license to dual-license

2015-07-23 Thread Devesh Sharma
: Devendra Naga Signed-off-by: Devesh Sharma --- drivers/infiniband/hw/ocrdma/ocrdma.h | 53 +-- drivers/infiniband/hw/ocrdma/ocrdma_abi.h | 53 +-- drivers/infiniband/hw/ocrdma/ocrdma_ah.c| 53 +-- drivers

[PATCH v1 0/2] ocrdma license change

2015-07-23 Thread Devesh Sharma
Doug- Thanks for your help! Resubmitting, per your request Devesh Sharma (2): RDMA/ocrdma: update ocrdma license to dual-license RDMA/ocrdma: update ocrdma module license srting drivers/infiniband/hw/ocrdma/ocrdma.h | 53 - drivers/infiniband/hw/ocrdma

Re: [PATCH 0/2] update ocrdma to dual license

2015-07-16 Thread Devesh Sharma
We have received appropriate permissions from the code authors and would like to resubmit the patches to change to a dual-licensed driver. Thank-you. On Thu, Jul 9, 2015 at 2:38 AM, Doug Ledford wrote: > On 07/08/2015 04:25 PM, Christoph Hellwig wrote: >> On Wed, Jul 08, 2015 at 04:15:00PM -0400

Re: [PATCH v2 07/14] xprtrdma: Remove logic that constructs RDMA_MSGP type calls

2015-07-15 Thread Devesh Sharma
with MAX_IOVS set to 2 iozone passes with ocrdma device. My testing includes both the series of svcrdma and xprtrdma. On Wed, Jul 15, 2015 at 12:31 AM, Chuck Lever wrote: > > On Jul 14, 2015, at 3:00 PM, Tom Talpey wrote: > >> On 7/13/2015 12:30 PM, Chuck Lever wrote: >>> RDMA_MSGP type calls in

Re: How to RoCE v2?

2015-07-14 Thread Devesh Sharma
Those should be avaliable on Marc On Tue, Jul 14, 2015 at 5:45 PM, Ram Amrani wrote: > Thanks Robert, Rupert and Devesh. > > Where can I access the patches under review? > > > > -Original Message- > From: Devesh Sharma [mailto:devesh.sha...@avagotech.com] > Se

Re: How to RoCE v2?

2015-07-13 Thread Devesh Sharma
Hi Ram, RoCE-v2 patch series is still under review, you should see updated patch series soon on this mailing list. -Regards Devesh On Mon, Jul 13, 2015 at 5:56 PM, Rupert Dance wrote: > Hi Ram, > > There were several issues discovered in OFED 3.18 RC3 which have been > resolved in the latest da

Re: [PATCH v1 03/12] xprtrdma: Increase default credit limit

2015-07-10 Thread Devesh Sharma
Yes, we are covered here, I took reference of 4.1-rc4 and that series was pulled in 4.1-rc7. I will update my test-bench and re-validate the numbers. -Regards On Fri, Jul 10, 2015 at 8:03 PM, Chuck Lever wrote: > > On Jul 10, 2015, at 6:45 AM, Devesh Sharma > wrote: > >&

Re: [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls

2015-07-10 Thread Devesh Sharma
On Fri, Jul 10, 2015 at 6:28 PM, Tom Talpey wrote: > On 7/10/2015 7:29 AM, Devesh Sharma wrote: >> >> we need to honor the max limits of device by checking >> dev_attr.max_sge? a vendor may not support 4 sges. > > > iWARP requires a minimum of 4 send SGEs (draft-hi

Re: [PATCH] IB/core: Destroy ocrdma_dev_id IDR on module exit

2015-07-10 Thread Devesh Sharma
We missed to ack this patch. Thanks Dough and Johannes. acked-by: Devesh Sharma On Thu, Jul 9, 2015 at 3:13 AM, Doug Ledford wrote: > On 07/08/2015 11:23 AM, Johannes Thumshirn wrote: >> Destroy ocrdma_dev_id IDR on module exit, reclaiming the allocated memory. >> >

Re: [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls

2015-07-10 Thread Devesh Sharma
we need to honor the max limits of device by checking dev_attr.max_sge? a vendor may not support 4 sges. On Fri, Jul 10, 2015 at 2:13 AM, Chuck Lever wrote: > Only the RPC/RDMA header is sent when making an RDMA_NOMSG call. > That header resides in the first element of the iovec array > passed to

Re: [PATCH v1 06/12] xprtrdma: Always provide a write list when sending NFS READ

2015-07-10 Thread Devesh Sharma
Looks good Reveiwed-By: Devesh Sharma On Fri, Jul 10, 2015 at 2:12 AM, Chuck Lever wrote: > The client has been setting up a reply chunk for NFS READs that are > smaller than the inline threshold. This is not efficient: both the > server and client CPUs have to copy the reply'

Re: [PATCH v1 05/12] xprtrdma: Account for RPC/RDMA header size when deciding to inline

2015-07-10 Thread Devesh Sharma
Looks good Reveiwed-By: Devesh Sharma On Fri, Jul 10, 2015 at 2:12 AM, Chuck Lever wrote: > When marshaling RPC/RDMA requests, ensure the combined size of > RPC/RDMA header and RPC header do not exceed the inline threshold. > Endpoints typically reject RPC/RDMA messages that exceed

Re: [PATCH v1 04/12] xprtrdma: Remove last ib_reg_phys_mr() call site

2015-07-10 Thread Devesh Sharma
Looks good. Reviewed-By: Devesh Sharma On Fri, Jul 10, 2015 at 2:12 AM, Chuck Lever wrote: > All HCA providers have an ib_get_dma_mr() verb. Thus > rpcrdma_ia_open() will either grab the device's local_dma_key if one > is available, or it will call ib_get_dma_mr() which is a 100

Re: [PATCH v1 03/12] xprtrdma: Increase default credit limit

2015-07-10 Thread Devesh Sharma
Increasing the default slot table entries will increase the MR requirements per mount. Currently, with 32 as default Client ends up allocating 2178 frmrs (ref: kernel 4.1-rc4) for a single mount. With 128 frmr requirement for startup would be 8448. 8K+ MRs per mount just for start-up, I am a litt

Re: [PATCH v1 02/12] xprtrdma: Raise maximum payload size to one megabyte

2015-07-10 Thread Devesh Sharma
Looks good Reviewed-By: Devesh Sharma On Fri, Jul 10, 2015 at 2:11 AM, Chuck Lever wrote: > The point of larger rsize and wsize is to reduce the per-byte cost > of memory registration and deregistration. Modern HCAs can typically > handle a megabyte or more with a single registration

Re: [PATCH 0/2] update ocrdma to dual license

2015-07-07 Thread Devesh Sharma
Hi Christoph, On Fri, Jul 3, 2015 at 9:22 PM, Christoph Hellwig wrote: > On Fri, Jul 03, 2015 at 03:38:55PM +, Weiny, Ira wrote: >> > >> > Christoph, >> > >> > >> > Apologies, I misspoke in my response to you. There was a study of the >> > code and >> > we thought it was reasonable to post.

Re: [PATCH 0/2] update ocrdma to dual license

2015-07-07 Thread Devesh Sharma
On Fri, Jul 3, 2015 at 9:08 PM, Weiny, Ira wrote: >> >> Christoph, >> >> >> Apologies, I misspoke in my response to you. There was a study of the code >> and >> we thought it was reasonable to post. However, in retrospect we should have >> used more due diligence. We're going back to seek expl

Re: [PATCH 0/2] update ocrdma to dual license

2015-07-02 Thread Devesh Sharma
Jul 1, 2015 at 12:51 PM, Christoph Hellwig wrote: > On Tue, Jun 30, 2015 at 04:19:43PM +0530, Devesh Sharma wrote: >> Hi Christoph, I really do not have it. >> >> However, this change is initiated with consent of Emulex management. > > Emulex managament can't relicense co

Re: [PATCH 0/2] update ocrdma to dual license

2015-06-30 Thread Devesh Sharma
Hi Christoph, I really do not have it. However, this change is initiated with consent of Emulex management. -Regards Devesh On Tue, Jun 30, 2015 at 11:36 AM, Christoph Hellwig wrote: > On Fri, Jun 12, 2015 at 10:15:03PM +0530, Devesh Sharma wrote: >> A series to update the license fr

Re: [PATCH 0/2] update ocrdma to dual license

2015-06-29 Thread Devesh Sharma
Hi Doug, a gentle reminder to pull this simple patch-set to your tree. -Regards Devesh On Fri, Jun 12, 2015 at 10:15 PM, Devesh Sharma wrote: > A series to update the license from GPL to GPL/Dual-BSD licensing > for ocrdma source. > > Devesh Sharma (2): > RDMA/ocrdma: update l

[PATCH 0/2] update ocrdma to dual license

2015-06-12 Thread Devesh Sharma
A series to update the license from GPL to GPL/Dual-BSD licensing for ocrdma source. Devesh Sharma (2): RDMA/ocrdma: update license from gpl to dual license RDMA/ocrdma: update module license to dual license drivers/infiniband/hw/ocrdma/ocrdma.h | 53

[PATCH 1/2] RDMA/ocrdma: update license from gpl to dual license

2015-06-12 Thread Devesh Sharma
This patch edits the legal statement for ocrdma driver code and moves it to GPL/Dual-BSD license. Signed-off-by: Devesh Sharma --- drivers/infiniband/hw/ocrdma/ocrdma.h | 53 +-- drivers/infiniband/hw/ocrdma/ocrdma_abi.h | 53

[PATCH 2/2] RDMA/ocrdma: update module license to dual license

2015-06-12 Thread Devesh Sharma
This patch updates the ocrdma module license from GPL to Dual BSD/GPL licensing. Signed-off-by: Devesh Sharma --- drivers/infiniband/hw/ocrdma/ocrdma_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband

Re: [PATCH] RDMA/ocrdma: fix double free on pd

2015-06-07 Thread Devesh Sharma
Acked-By: Devesh Sharma On Fri, Jun 5, 2015 at 8:17 PM, Colin King wrote: > From: Colin Ian King > > A reorganisation of the PD allocation and deallocation in commit > 9ba1377daa ("RDMA/ocrdma: Move PD resource management to driver.") > introduced a double free on

Re: [PATCH for-next V2 6/9] IB/core: Pass hardware specific data in query_device

2015-06-01 Thread Devesh Sharma
ocrdma part Looks good. Reviewed-By: Devesh Sharma On Sun, May 31, 2015 at 5:44 PM, Or Gerlitz wrote: > From: Matan Barak > > Vendors should be able to pass vendor specific data to/from > user-space via query_device uverb. In order to do this, > we need to pass the vendors&

Re: [PATCH for-next V2 1/9] IB/core: Change provider's API of create_cq to be extendible

2015-06-01 Thread Devesh Sharma
Looks good. Reviewed-By: Devesh Sharma On Sun, May 31, 2015 at 5:44 PM, Or Gerlitz wrote: > From: Matan Barak > > Add a new ib_cq_init_attr structure which contains the > previous cqe (minimum number of CQ entries) and comp_vector > (completion vector) in addition to a new fla

Re: [PATCH 1/3] RDMA/ocrdma: Fix memory leak in _ocrdma_alloc_pd()

2015-05-31 Thread Devesh Sharma
Acked-By: Devesh Sharma On Sat, May 30, 2015 at 8:56 PM, Doug Ledford wrote: > On Fri, 2015-05-29 at 23:10 -0700, Roland Dreier wrote: >> From: Roland Dreier >> >> If ocrdma_get_pd_num() fails, then we need to free the pd struct we >> allocated. >> >

RE: [PATCH] MAINTAINERS: update Emulex ocrdma email addresses

2015-05-26 Thread Devesh Sharma
Thanks Laurent, My earlier mail bounced back from Linux-kernel mailing list, thus resending. CC'ing Doug. Acked-By: Devesh Sharma > -Original Message- > From: Laurent Navet [mailto:laurent.na...@gmail.com] > Sent: Wednesday, May 27, 2015 12:46 AM > To: a...@linux-fo

RE: [PATCH] RDMA/ocrdma: remove unneeded tests

2015-05-26 Thread Devesh Sharma
Although already applied, Thanks Laurent and Doug. Acked-By: Devesh Sharma > -Original Message- > From: Doug Ledford [mailto:dledf...@redhat.com] > Sent: Tuesday, May 26, 2015 6:15 PM > To: Laurent Navet > Cc: selvin.xav...@emulex.com; devesh.sha...@emulex.com; > mites

RE: [PATCH v2 00/16] NFS/RDMA patches proposed for 4.2

2015-05-20 Thread Devesh Sharma
Medusa test passes with average load. Tested-By: Devesh Sharma > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Chuck Lever > Sent: Monday, May 11, 2015 11:32 PM > To: linux-rdma@vger.ke

RE: [PATCH v1 02/14] xprtrdma: Warn when there are orphaned IB objects

2015-05-07 Thread Devesh Sharma
> -Original Message- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Wednesday, May 06, 2015 10:18 PM > To: Devesh Sharma > Cc: Chuck Lever; linux-rdma@vger.kernel.org; Linux NFS Mailing List > Subject: Re: [PATCH v1 02/14] xprtrdma: Warn when the

RE: [PATCH v6 00/26] IB/Verbs: IB Management Helpers

2015-04-27 Thread Devesh Sharma
Tested-By: Devesh Sharma I am still in process of reviewing the series. Will respond soon. -Regards Devesh > -Original Message- > From: Michael Wang [mailto:yun.w...@profitbricks.com] > Sent: Friday, April 24, 2015 6:43 PM > To: Roland Dreier; Sean Hefty; Hal Rosenstock

RE: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-21 Thread Devesh Sharma
com] > Sent: Tuesday, April 21, 2015 1:17 PM > To: Devesh Sharma; Roland Dreier; Sean Hefty; Hal Rosenstock; linux- > r...@vger.kernel.org; linux-ker...@vger.kernel.org; h...@dev.mellanox.co.il > Cc: Tom Tucker; Steve Wise; Hoang-Nam Nguyen; Christoph Raisch; Mike > Marciniszyn; Eli

RE: [PATCH v5 14/27] IB/Verbs: Reform cma_acquire_dev()

2015-04-20 Thread Devesh Sharma
Looks good, I would like to test with ocrdma before confirming. > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Michael Wang > Sent: Monday, April 20, 2015 2:08 PM > To: Roland Dreier; Sean Hefty; linux-rdma@vger.kerne

RE: [PATCH v5 13/27] IB/Verbs: Reserve legacy transport type in 'dev_addr'

2015-04-20 Thread Devesh Sharma
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Michael Wang > Sent: Monday, April 20, 2015 2:08 PM > To: Roland Dreier; Sean Hefty; linux-rdma@vger.kernel.org; linux- > ker...@vger.kernel.org; h...@dev.mellanox.co.il >

RE: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-20 Thread Devesh Sharma
Hi Michael, is there a specific git branch available to pull out all the patches? -Regards Devesh > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Michael Wang > Sent: Monday, April 20, 2015 1:59 PM > To: Roland Dreie

RE: [PATCH for-next 3/6] IB/ipoib: Handle QP in SQE state

2015-04-16 Thread Devesh Sharma
> -Original Message- > From: Erez Shitrit [mailto:ere...@dev.mellanox.co.il] > Sent: Thursday, April 16, 2015 12:14 PM > To: Devesh Sharma; Or Gerlitz; Roland Dreier; Doug Ledford > Cc: linux-rdma@vger.kernel.org; Erez Shitrit; Tal Alon; Amir Vadai > Subject: Re: [PATC

RE: [PATCH for-next 3/6] IB/ipoib: Handle QP in SQE state

2015-04-15 Thread Devesh Sharma
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Or Gerlitz > Sent: Thursday, April 02, 2015 4:09 PM > To: Roland Dreier; Doug Ledford > Cc: linux-rdma@vger.kernel.org; Erez Shitrit; Tal Alon; Amir Vadai; Or Gerlitz > Su

RE: [PATCH v2 00/15] NFS/RDMA patches proposed for 4.1

2015-03-27 Thread Devesh Sharma
Yes, You can add My and Meghna's name in tested-by tag -Thanks > -Original Message- > From: Chuck Lever [mailto:chuck.le...@oracle.com] > Sent: Friday, March 27, 2015 7:48 PM > To: Devesh Sharma > Cc: Anna Schumaker; linux-rdma@vger.kernel.org; Linux NFS Mailing List;

RE: [PATCH v2 00/15] NFS/RDMA patches proposed for 4.1

2015-03-26 Thread Devesh Sharma
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Devesh Sharma > Sent: Friday, March 27, 2015 11:13 AM > To: Anna Schumaker; Chuck Lever; linux-rdma@vger.kernel.org; linux- > n...@vger.kernel.org >

RE: [PATCH v2 00/15] NFS/RDMA patches proposed for 4.1

2015-03-26 Thread Devesh Sharma
Hi Chuck, I have validated these set of patches with ocrdma device, iozone passes with these. -Regards Devesh > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Anna Schumaker > Sent: Friday, March 27, 2015 12:10 AM >

RE: [PATCH v1 10/16] xprtrdma: Add "open" memreg op

2015-03-24 Thread Devesh Sharma
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Chuck Lever > Sent: Saturday, March 14, 2015 2:58 AM > To: linux-rdma@vger.kernel.org > Subject: [PATCH v1 10/16] xprtrdma: Add "open" memreg op > > The open op determine

RE: [PATCH v1 08/16] xprtrdma: Add "reset MRs" memreg op

2015-03-24 Thread Devesh Sharma
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Chuck Lever > Sent: Saturday, March 14, 2015 2:58 AM > To: linux-rdma@vger.kernel.org > Subject: [PATCH v1 08/16] xprtrdma: Add "reset MRs" memreg op > > This method is i

RE: [PATCH v1 06/16] xprtrdma: Add a "deregister_external" op for each memreg mode

2015-03-24 Thread Devesh Sharma
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Chuck Lever > Sent: Saturday, March 14, 2015 2:57 AM > To: linux-rdma@vger.kernel.org > Subject: [PATCH v1 06/16] xprtrdma: Add a "deregister_external" op for each > memre

RE: [PATCH v1 01/16] xprtrdma: Display IPv6 addresses and port numbers correctly

2015-03-24 Thread Devesh Sharma
I see in the svcrdma code, there is a big check to abort creating listener if AF is not AF_INET, Do we have plans to address this on the server as well? static struct svc_xprt *svc_rdma_create(struct svc_serv *serv, struct net *net,

RE: RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter

2015-02-26 Thread Devesh Sharma
Thanks Dan for pointing out, we will address this issue and send out a patch to fix this. -Regards Devesh > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > Sent: Thursday, February 26, 2015 6:00 PM > To

RE: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-23 Thread Devesh Sharma
> -Original Message- > From: Matan Barak [mailto:mat...@mellanox.com] > Sent: Monday, February 23, 2015 3:47 PM > To: Devesh Sharma; Somnath Kotur; rol...@kernel.org > Cc: linux-rdma@vger.kernel.org > Subject: Re: [PATCH 09/30] IB/core: Modify ib_verbs and c

RE: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-22 Thread Devesh Sharma
Hi Matan, Please find a comment inline below: -Regards Devesh > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Somnath Kotur > Sent: Friday, February 20, 2015 3:32 AM > To: rol...@kernel.org > Cc: linux-rdma@vger.kerne

RE: [PATCH 15/30] RDMA/ocrdma: changes to support RoCE-v2 in UD path

2015-02-21 Thread Devesh Sharma
Hi Som, > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Somnath Kotur > Sent: Friday, February 20, 2015 3:33 AM > To: rol...@kernel.org > Cc: linux-rdma@vger.kernel.org; Devesh Sharma; Somnath Kotur

[PATCH] RDMA/libocrdma: return error if destroy fails

2015-01-17 Thread Devesh Sharma
From: Padmanabh Ratnakar If the destorying of any resource has failed at uverbs command interface libocrdma should return the error code. Signed-off-by: Padmanabh Ratnakar Signed-off-by: Devesh Sharma --- src/ocrdma_verbs.c | 14 +++--- 1 files changed, 11 insertions(+), 3

[PATCH 2/2] RDMA/libocrdma: update libocrdma version string

2015-01-13 Thread Devesh Sharma
version string updated from 1.0.4 to 1.0.5 Signed-off-by: Devesh Sharma --- configure.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.in b/configure.in index 3b0cf21..140c07b 100644 --- a/configure.in +++ b/configure.in @@ -1,11 +1,11 @@ dnl Process this

  1   2   3   >