Re: [PATCH] IPoIB: Fix race in deleting ipoib_neigh entries

2013-08-13 Thread Shlomo Pongratz
On 8/13/2013 11:11 AM, Jack Wang wrote: On 08/13/2013 09:54 AM, Or Gerlitz wrote: On 09/08/2013 03:44, Jim Foraker wrote: In several places, this snippet is used when removing neigh entries: list_del(neigh-list); ipoib_neigh_free(neigh); The list_del() removes neigh from the

Re: list corruption in IPOIB

2013-05-20 Thread Shlomo Pongratz
/0x1b ---[ end trace 66110390802a41db ]--- after apply commit fa16ebed31f336e41970f3f0ea9e8279f6be2d27 Author: Shlomo Pongratz shlo...@mellanox.com mailto:shlo...@mellanox.com Date: Mon Aug 13 14:39:49 2012 + IB/ipoib: Add missing locking when CM object is deleted Above warning

Re: [PATCH V4 for-next 1/5] IB/core: Add RSS and TSS QP groups - suggesting BOF during OFA conf to further discuss that

2013-04-30 Thread Shlomo Pongratz
On 4/29/2013 11:36 PM, Jason Gunthorpe wrote: On Mon, Apr 29, 2013 at 10:52:21PM +0300, Or Gerlitz wrote: On Fri, Apr 26, 2013 at 12:40 AM, Jason Gunthorpe wrote: But I don't follow why the send QPNs have to be sequential for IPoIB. It looks like this is being motivated by RSS and RSS QPNs are

Using XRC between kernel and user space.

2013-04-04 Thread Shlomo Pongratz
Hi, I wonder how a kernel program and a user space one can communicate using XRC. A example for such an application is iSER kernel initiator connected to tgtd target that runs in user space. The XRC domain in the kernel is created with struct ib_xrcd *ib_alloc_xrcd(struct ib_device *device)

Re: Using XRC between kernel and user space.

2013-04-04 Thread Shlomo Pongratz
On 4/4/2013 8:44 PM, Shlomo Pongratz wrote: Hi, I wonder how a kernel program and a user space one can communicate using XRC. A example for such an application is iSER kernel initiator connected to tgtd target that runs in user space. The XRC domain in the kernel is created with struct

Re: XRC and ib_poll_cq

2013-04-03 Thread Shlomo Pongratz
On 4/3/2013 3:35 AM, Hefty, Sean wrote: Thanks, it seems that I asked the question in a wrong way. The context is what I need eventually but in order to find it I first need to recover the QP or the XRC SRQ. Per core there may be several QP and SRQ using the same CQ. When doing ib_poll_cq on the

XRC and ib_poll_cq

2013-04-02 Thread Shlomo Pongratz
Hi From the XRC annex I understand that WQE is obtained by polling the CQ attached to the XRC SRQ. Now in struct ib_wc we have a pointer of type struct ib_qp *, should the pointer be cast to struct ib_srq *? In short how do one gets the qp_context/srq_context? S.P. -- To unsubscribe from

RE: [PATCH libibverbs v5 4/7] libibverbs: Add support for XRC QPs

2013-03-31 Thread Shlomo Pongratz
Hi Sean, Just wonder, the Infiniband Annex for XRC uses the terms XRC INI QP and XRC TGT QP and the kernel include file include/rdma/ib_verbs.h also defines IB_QPT_XRC_INI and IB_QPT_XRC_TGT so why to use in include/infiniband/verbs.h other names i.e. IBV_QPT_XRC_SEND and IBV_QPT_XRC_RECV? I

Re: Notes on XRC

2013-03-26 Thread Shlomo Pongratz
On 3/26/2013 5:55 PM, Hefty, Sean wrote: This is just a workaround I been considering in case using hints and asynchronous connection request can't work together. If I want to have servers and clients that need to be backward compatible with RC servers and clients. And assuming the old ones

Re: Different signatures to ibv_open_xrcd - branch issue?

2013-03-26 Thread Shlomo Pongratz
On 3/26/2013 5:56 PM, Hefty, Sean wrote: I understand that currently I can't do RDMA using XRC, is that the case? How complicated are the required modifications needed to make librdmacm complies to the libibverbs changes? The changes needed for the librdmacm to support XRC aren't huge. The

Notes on XRC

2013-03-25 Thread Shlomo Pongratz
Hi Sean, I'm experimenting XRC with a real application and I want to share my thoughts. A natural way to pass the SRQ's QPN is to use the private_data of the rdma_conn_param, however this area is limited to 56 octets and since each QPN occupies 3 octets that leaves us with 18 SRQ. I suggest

Different signatures to ibv_open_xrcd - branch issue?

2013-03-25 Thread Shlomo Pongratz
Hi Sean, In libibverbs/include/infiniband/verbs.h the API ibv_open_xrcd is defined with the following signature; static inline struct ibv_xrcd * ibv_open_xrcd(struct ibv_context *context, struct ibv_xrcd_init_attr *xrcd_init_attr) And libibverbs/examples/xsrq_pingpong.c the call is O.K.

Re: [PATCH V3 for-next 3/5] IB/ipoib: Move to multi-queue device

2013-03-24 Thread Shlomo Pongratz
, 2013 12:11 PM To: rol...@kernel.org Cc: linux-rdma@vger.kernel.org; Shlomo Pongratz Subject: [PATCH V3 for-next 3/5] IB/ipoib: Move to multi-queue device Hi Mike, You didn't mentioned but you have changed the order of the call to netif_stop_queue and the call to ib_req_notify_cq, by placing

Re: [PATCH V2 for-next 1/6] IB/ipoib: Fix ipoib_neigh hashing to use the correct daddr octets

2013-02-12 Thread Shlomo Pongratz
On 2/11/2013 9:46 PM, Hefty, Sean wrote: --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -844,10 +844,10 @@ static u32 ipoib_addr_hash(struct ipoib_neigh_hash *htbl, u8 *daddr) * different subnets. */ /* qpn octets[1:4) port GUID

[PATCH] ib/ipoib: fix CM crash after commit b13912bbb4a2

2013-02-04 Thread Shlomo Pongratz
. In case error occures than it will be no different than the regular case where dev_free_skb_any in the completion path which is assumed to be after these two routines. Signed-off-by: Shlomo Pongratz shlo...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib_cm.c |6 +++--- drivers

[for-next PATCH] IB/IPoIB: correct typo errors

2012-07-30 Thread Shlomo Pongratz
used 'ntbl-lock' instead of 'ntbl-rwlock'. wrong pointer type in non CM stub 'ipoib_cm_enabled' in function prototype. Reported-by: Fengguang Wu w...@linux.intel.com Signed-off-by: Shlomo Pongratz shlo...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib.h |2 +- drivers/infiniband

[for-next PATCH] IB/IPoIB: typo error

2012-07-30 Thread Shlomo Pongratz
was is_held should be lockdep_is_held Reporetd by: Roland Dreier rol...@kernel.org Signed-off-by: Shlomo Pongratz shlo...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib

RE: [PATCH] IB/ipoib: break linkage to neighbouring system

2012-07-12 Thread Shlomo Pongratz
From: Marciniszyn, Mike [mike.marcinis...@intel.com] Sent: Thursday, July 12, 2012 7:48 PM To: Or Gerlitz; rol...@kernel.org Cc: linux-rdma@vger.kernel.org; da...@davemloft.net; Erez Shitrit; Shlomo Pongratz Subject: RE: [PATCH] IB/ipoib: break linkage to neighbouring system ipoib_path_lookup

RE: [PATCH 2/2] IB/ipoib: fix GRO merge failure for IPoIB originated TCP streams

2012-01-29 Thread Shlomo Pongratz
until the more general fix is integrated. Best regards, S.P. -Original Message- From: rol...@purestorage.com [mailto:rol...@purestorage.com] On Behalf Of Roland Dreier Sent: Monday, January 30, 2012 6:44 AM To: Or Gerlitz Cc: linux-rdma; Shlomo Pongratz; net...@vger.kernel.org Subject