Re: [PATCH] IB/cma: Fix RDMA port validation for iWarp

2016-01-06 Thread Steve Wise
On 1/6/2016 7:06 AM, Matan Barak wrote: cma_validate_port wrongly assumed that Ethernet devices are RoCE devices and thus their ndev should be matched in the GID table. This broke the iWrap support. Fixing that matching the ndev only if Typo "iWrap" Reviewed-by: Steve Wise we

RE: device attr cleanup

2016-01-05 Thread Steve Wise
rpe; > linux-rdma@vger.kernel.org; ira.weiny; Or Gerlitz; Steve Wise; Or Gerlitz; Sagi > Grimberg > Subject: Re: device attr cleanup > > On 12/23/2015 04:31 PM, J. Bruce Fields wrote: > > On Thu, Dec 10, 2015 at 07:49:59PM -0500, Chuck Lever wrote: > >> > >&g

Re: start moving user space visible constants to uapi headers

2016-01-04 Thread Steve Wise
d the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Series looks ok to me. Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in t

Re: [PATCH] svc_rdma: use local_dma_lkey

2016-01-04 Thread Steve Wise
files changed, 10 insertions(+), 40 deletions(-) Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[ANNOUNCE] libcxgb4-1.3.6 release

2015-12-18 Thread Steve Wise
. Change shortlog: Hariprasad Shenai (1): Gracefully handle unknown CQE status errors Steve Wise (6): libcxgb4: remove config/missing libcxgb4: update config.sub and config.guess libcxgb4: add NULL check for wr->sg_list libcxgb4:Eliminate warnings seen with buildall

RE: device attr cleanup (was: Handle mlx4 max_sge_rd correctly)

2015-12-10 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Chuck Lever > Sent: Thursday, December 10, 2015 10:08 AM > To: linux-rdma@vger.kernel.org > Cc: ira.weiny; Christoph Hellwig; Jason Gunthorpe; Or G

RE: warning in ext4 with nfs/rdma server

2015-12-08 Thread Steve Wise
> -Original Message- > From: Chuck Lever [mailto:chuck.le...@oracle.com] > Sent: Monday, December 07, 2015 9:45 AM > To: Steve Wise > Cc: linux-rdma@vger.kernel.org; Veeresh U. Kokatnur; Linux NFS Mailing List > Subject: Re: warning in ext4 with nfs/rdma server >

warning in ext4 with nfs/rdma server

2015-12-07 Thread Steve Wise
Hey Chuck/NFS developers, We're hitting this warning in ext4 on the linux-4.3 nfs server running over RDMA/cxgb4. We're still gathering data, like if it happens with NFS/TCP. But has anyone seen this warning on 4.3? Is it likely to indicate some bug in the xprtrdma transport or above it in NF

RE: [PATCH v1 00/10] iSER support for remote invalidate

2015-11-24 Thread Steve Wise
Or Gerlitz; Jenny Derzhavetz; Steve Wise > Subject: [PATCH v1 00/10] iSER support for remote invalidate > > This patchset adds remote invalidation support to iser initiator and > target. The support negotiation for this feature is based on IBTA > annex 12 "Support for iSCSI E

RE: [PATCH v1 03/10] IB/iser: Don't register memory for all immediatedata writes

2015-11-24 Thread Steve Wise
> -Original Message- > From: Sagi Grimberg [mailto:sa...@mellanox.com] > Sent: Tuesday, November 24, 2015 10:24 AM > To: linux-rdma@vger.kernel.org; target-de...@vger.kernel.org > Cc: Nicholas A. Bellinger; Or Gerlitz; Jenny Derzhavetz; Steve Wise > Subject: [PATCH

Re: memory registration updates

2015-11-23 Thread Steve Wise
" patch to be already applied. Also available as a git tree: http://git.infradead.org/users/hch/rdma.git/shortlog/refs/heads/rdma-mr git://git.infradead.org/users/hch/rdma.git rdma-mr Series looks good. Reviewed-by: Steve Wise -- To unsubscribe from this list

RE: [PATCH 3/9] IB: add a helper to safely drain a QP

2015-11-23 Thread Steve Wise
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Sagi Grimberg > Sent: Monday, November 23, 2015 4:36 AM > To: Steve Wise; 'Christoph Hellwig'; linux-rdma@vger.kernel.org > Cc: ba

RE: [PATCH 3/9] IB: add a helper to safely drain a QP

2015-11-23 Thread Steve Wise
> -Original Message- > From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] > Sent: Monday, November 23, 2015 4:29 AM > To: Steve Wise; 'Christoph Hellwig'; linux-rdma@vger.kernel.org > Cc: bart.vanass...@sandisk.com; ax...@fb.com; linux-s...@vger

Re: [PATCH 3/9] IB: add a helper to safely drain a QP

2015-11-18 Thread Steve Wise
On 11/18/2015 8:06 AM, Christoph Hellwig wrote: On Wed, Nov 18, 2015 at 01:32:19PM +0200, Sagi Grimberg wrote: Christoph, Given the discussion around this patch I think it would be a good idea remove it from the patchset since it's not mandatory for the CQ abstraction. I think that we should ta

RE: [PATCH 3/9] IB: add a helper to safely drain a QP

2015-11-16 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Sagi Grimberg > Sent: Monday, November 16, 2015 12:38 PM > To: Steve Wise; 'Christoph Hellwig'; linux-rdma@vger.kernel.org > Cc: ba

RE: [PATCH 3/9] IB: add a helper to safely drain a QP

2015-11-16 Thread Steve Wise
> -Original Message- > From: Steve Wise [mailto:sw...@opengridcomputing.com] > Sent: Monday, November 16, 2015 10:38 AM > To: Sagi Grimberg; Christoph Hellwig; linux-rdma@vger.kernel.org > Cc: bart.vanass...@sandisk.com; ax...@fb.com; linux-s...@vger.kernel.or

Re: [PATCH 5/9] cxgb3: simplify iwch_get_dma_wr

2015-11-16 Thread Steve Wise
On 11/15/2015 12:05 PM, Christoph Hellwig wrote: Fold simplified versions of build_phys_page_list and iwch_register_phys_mem into iwch_get_dma_wr now that no other callers are left. Signed-off-by: Christoph Hellwig --- drivers/infiniband/hw/cxgb3/iwch_mem.c | 71 -

Re: [PATCH 7/9] amso1100: fold c2_reg_phys_mr into c2_get_dma_mr

2015-11-16 Thread Steve Wise
I think Doug is removing amso1100 now so this patch isn't needed. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/9] IB: remove support for phys MRs

2015-11-16 Thread Steve Wise
On 11/15/2015 12:05 PM, Christoph Hellwig wrote: We have stopped using phys MRs in the kernel a while ago, so let's remove all the cruft used to implement them. Signed-off-by: Christoph Hellwig For the cxgb3/4 parts: Reviewed-by: Steve Wise -- To unsubscribe from this list: send the

Re: [PATCH 3/9] IB: add a helper to safely drain a QP

2015-11-16 Thread Steve Wise
On 11/15/2015 3:34 AM, Sagi Grimberg wrote: + +struct ib_stop_cqe { +struct ib_cqecqe; +struct completion done; +}; + +static void ib_stop_done(struct ib_cq *cq, struct ib_wc *wc) +{ +struct ib_stop_cqe *stop = +container_of(wc->wr_cqe, struct ib_stop_cqe, cqe); + +c

Re: [PATCH 3/9] IB: add a helper to safely drain a QP

2015-11-13 Thread Steve Wise
On 11/13/2015 7:46 AM, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig --- drivers/infiniband/core/cq.c | 46 include/rdma/ib_verbs.h | 2 ++ 2 files changed, 48 insertions(+) diff --git a/drivers/infiniband/core/cq.c b/drivers/in

Re: [PATCH RFC 0/3] Introduce device attribute rdma_read_access_flags

2015-11-10 Thread Steve Wise
that while everyone but Or seemed to be generally fine with it I'd really prefer and actualy revivewed-by or acked-by tag. -- Acked-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kern

Re: [PATCH RFC 2/3] svcrdma: Use device rdma_read_access_flags

2015-11-10 Thread Steve Wise
On 11/10/2015 5:46 AM, Sagi Grimberg wrote: On 10/11/2015 13:41, Christoph Hellwig wrote: Oh, and while we're at it. Can someone explain why we're even using rdma_read_chunk_frmr for IB? It seems to work around the fact tat iWarp only allow a single RDMA READ SGE, but it's used whenever the

RE: [PATCH 0/2] Expose max_sge_rd correctly

2015-10-27 Thread Steve Wise
> -Original Message- > From: Sagi Grimberg [mailto:sa...@mellanox.com] > Sent: Tuesday, October 27, 2015 4:41 AM > To: linux-rdma@vger.kernel.org; target-de...@vger.kernel.org > Cc: Steve Wise; Nicholas A. Bellinger; Or Gerlitz; Doug Ledford > Subject: [PATCH 0/2]

Re: merge struct ib_device_attr into struct ib_device V2

2015-10-21 Thread Steve Wise
On 10/21/2015 11:43 AM, Jason Gunthorpe wrote: On Wed, Oct 21, 2015 at 08:48:10AM -0700, Bart Van Assche wrote: On 10/21/2015 12:11 AM, Or Gerlitz wrote: haven't found any review or ack to your giant patch that touches the whole subsystem (drivers, core and ULPs) expect from Sagi's -- lets hear

RE: [PATCH for-next 0/2] RDMA/cxgb4: Add iWARP support for T6 adapter

2015-10-12 Thread Steve Wise
Kindly review > the change and let us know in case of any review comments. > > Thanks > These look ok to me. Series Reviewed-by: Steve Wise Doug, should these get staged through your tree? Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma&q

RE: [PATCH] svcrdma: Fix NFS server crash triggered by 1MB NFS WRITE

2015-10-05 Thread Steve Wise
(struct svc_rqst *rqstp, > rqstp->rq_arg.page_base = head->arg.page_base; > > /* rq_respages starts after the last arg page */ > - rqstp->rq_respages = &rqstp->rq_arg.pages[page_no]; > + rqstp->rq_respages = &rqstp->rq_pages[page_no]; >

RE: [PATCH 2/3] svcrdma: handle rdma read with a non-zero initial page offset

2015-09-28 Thread Steve Wise
> -Original Message- > From: J. Bruce Fields [mailto:bfie...@fieldses.org] > Sent: Monday, September 28, 2015 4:05 PM > To: Steve Wise > Cc: trond.mykleb...@primarydata.com; linux-...@vger.kernel.org; > linux-rdma@vger.kernel.org > Subject: Re: [PATCH 2/3] svcrdma:

[PATCH RESEND] svcrdma: handle rdma read with a non-zero initial page offset

2015-09-28 Thread Steve Wise
lx4, for instance. Fixes: 0bf4828983df ('svcrdma: refactor marshalling logic') Signed-off-by: Steve Wise Tested-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_recvfrom.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdm

Re: [PATCH v2 00/26] New fast registration API

2015-09-28 Thread Steve Wise
NFSv3 and NFSv4. Looks good. Tested-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: libmlx4 and libmlx5 git trees? Who is handling those?

2015-09-28 Thread Steve Wise
On 9/28/2015 12:39 PM, Jason Gunthorpe wrote: On Mon, Sep 28, 2015 at 05:28:20PM +, Woodruff, Robert J wrote: On Mon, 28 Sep 2015, Christoph Lameter wrote: Right. Its really nasty when you are trying to add features that require libibverbs and libmlx? changes. Plus it may depend on kernel

RE: [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers

2015-09-28 Thread Steve Wise
> -Original Message- > From: Anna Schumaker [mailto:anna.schuma...@netapp.com] > Sent: Monday, September 28, 2015 9:45 AM > To: Steve Wise; trond.mykleb...@primarydata.com; bfie...@fieldses.org > Cc: linux-...@vger.kernel.org; linux-rdma@vger.kernel.org > Subje

Re: [PATCH 2/3] svcrdma: handle rdma read with a non-zero initial page offset

2015-09-28 Thread Steve Wise
On 9/21/2015 12:24 PM, Steve Wise wrote: The server rdma_read_chunk_lcl() and rdma_read_chunk_frmr() functions were not taking into account the initial page_offset when determining the rdma read length. This resulted in a read who's starting address and length exceeded the base/bounds o

Re: [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers

2015-09-28 Thread Steve Wise
On 9/21/2015 12:24 PM, Steve Wise wrote: Otherwise a FRMR completion can cause a touch-after-free crash. In xprt_rdma_destroy(), call rpcrdma_buffer_destroy() only after calling rpcrdma_ep_destroy(). In rpcrdma_ep_destroy(), disconnect the cm_id first which should flush the qp, then drain the

RE: [PATCH for-next 0/2] RDMA/cxgb4: Add iWARP support for T6 adapter

2015-09-25 Thread Steve Wise
Acked-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: message size, was Re: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Steve Wise
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, September 22, 2015 6:08 PM > > > How do we change the message size limits? Reviewing w/o it being > > inline is painful for the (many) reviewers... > > I've increased it. Thanks! -- To unsubscribe

RE: message size, was Re: merge struct ib_device_attr into struct ib_device

2015-09-22 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of 'Christoph Hellwig' > Sent: Tuesday, September 22, 2015 4:55 PM > To: Steve Wise; postmas...@vger.kernel.org > Cc: linux-rdma@vger.kernel

RE: merge struct ib_device_attr into struct ib_device

2015-09-22 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Tuesday, September 22, 2015 3:32 PM > To: Yann Droneaud > Cc: linux-rdma@vger.kernel.org > Subject: Re: merge struct ib_device_attr into struct

[PATCH 3/3] xprtrdma: don't log warnings for flushed completions

2015-09-21 Thread Steve Wise
Unsignaled send WRs can get flushed as part of normal unmount, so don't log them as warnings. Signed-off-by: Steve Wise --- net/sunrpc/xprtrdma/frwr_ops.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xpr

[PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers

2015-09-21 Thread Steve Wise
destroy the cqs. Signed-off-by: Steve Wise Tested-by: Chuck Lever --- net/sunrpc/xprtrdma/transport.c |2 +- net/sunrpc/xprtrdma/verbs.c |9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c index

[PATCH 2/3] svcrdma: handle rdma read with a non-zero initial page offset

2015-09-21 Thread Steve Wise
lx4, for instance. Fixes: 0bf4828983df ('svcrdma: refactor marshalling logic') Signed-off-by: Steve Wise Tested-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_recvfrom.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdm

RE: [PATCH for-next 0/5] set MPA revision to 2 and misc. fixes for iw_cxgb4

2015-09-08 Thread Steve Wise
Signed-off-by: Steve Wise > -Original Message- > From: Hariprasad Shenai [mailto:haripra...@chelsio.com] > Sent: Monday, September 07, 2015 11:27 PM > To: dledf...@redhat.com > Cc: linux-rdma@vger.kernel.org; sw...@opengridcomputing.com; Hariprasad Shenai > Subject: [

RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_destroy_cq

2015-09-01 Thread Steve Wise
> -Original Message- > From: Nicholas Krause [mailto:xerofo...@gmail.com] > Sent: Sunday, August 30, 2015 3:12 PM > To: sw...@chelsio.com > Cc: dledf...@redhat.com; sean.he...@intel.com; hal.rosenst...@gmail.com; > linux-rdma@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [PATC

RE: [PATCH] infiniband:cxgb4:Fix if statement check in the function pick_local_ip6adddrs

2015-08-27 Thread Steve Wise
Acked-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr

2015-08-27 Thread Steve Wise
> -Original Message- > From: Nicholas Krause [mailto:xerofo...@gmail.com] > Sent: Wednesday, August 26, 2015 7:22 PM > To: sw...@chelsio.com > Cc: dledf...@redhat.com; sean.he...@intel.com; hal.rosenst...@gmail.com; > linux-rdma@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [PA

RE: [PATCH for-4.3] iw_cxgb4: Add support for clip

2015-08-25 Thread Steve Wise
Acked-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-20 Thread Steve Wise
On 8/20/2015 3:49 AM, Sagi Grimberg wrote: On 8/19/2015 8:54 PM, Jason Gunthorpe wrote: On Wed, Aug 19, 2015 at 07:48:02PM +0200, Christoph Hellwig wrote: On Wed, Aug 19, 2015 at 11:46:14AM -0600, Jason Gunthorpe wrote: Reviewed-by: Jason Gunthorpe AFAIK, this path is rarely (never?) actuall

RE: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names

2015-08-12 Thread Steve Wise
> Hey Sagi, how is this coming along? How can I help? > > >>> > >>> Hi Steve, > >>> > >>> This is taking longer than I expected, the changes needed seem > >>> pretty extensive throughout the IO path. I don't think it will be ready > >>> for 4.3 > >>> > >> > >> Perhaps then we should go w

Re: [RFC] split struct ib_send_wr

2015-08-07 Thread Steve Wise
mode RDMA apps. Tested-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] svcrdma: limit FRMR page list lengths to device max

2015-08-07 Thread Steve Wise
Svcrdma was incorrectly allocating fastreg MRs and page lists using RPCSVC_MAXPAGES, which can exceed the device capabilities. So limit the depth to the minimum of RPCSVC_MAXPAGES and xprt->sc_frmr_pg_list_len. Signed-off-by: Steve Wise --- Doug, this patch needs to be added after this com

RE: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of 'Christoph Hellwig' > Sent: Friday, August 07, 2015 11:26 AM > To: Steve Wise > Cc: 'Christoph Hellwig'; 'Sagi Grimberg'

Re: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread Steve Wise
On 8/7/2015 11:19 AM, Steve Wise wrote: -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Christoph Hellwig Sent: Friday, August 07, 2015 10:13 AM To: Steve Wise Cc: 'Sagi Grimberg'; 'Doug Ledfo

RE: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Friday, August 07, 2015 10:13 AM > To: Steve Wise > Cc: 'Sagi Grimberg'; 'Doug Ledford'

RE: [PATCH for-4.3 11/15] iw_cxgb4: Support ib_alloc_mr verb

2015-08-07 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Sagi Grimberg > Sent: Thursday, July 30, 2015 2:33 AM > To: linux-rdma@vger.kernel.org; linux-...@vger.kernel.org; > target-de...@vger.kernel.org > Subject: [PATCH for-

RE: [RFC] split struct ib_send_wr

2015-08-06 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Thursday, August 06, 2015 12:32 PM > To: Steve Wise > Cc: Christoph Hellwig; linux-rdma@vger.kernel.org; Sagi Grimberg &

Re: [RFC] split struct ib_send_wr

2015-08-06 Thread Steve Wise
On 8/6/2015 11:24 AM, Christoph Hellwig wrote: I've pushed out a new version. Updates: - the ib_recv_wr change Bart notices has been fixed. - iser and isert have been converted - the handling of the embedded WR in the qib software queue entry has been fixed. Which means we're basical

RE: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names

2015-08-05 Thread Steve Wise
> > > > > Hey Sagi, how is this coming along? How can I help? > > > > > > > Hi Steve, > > > > This is taking longer than I expected, the changes needed seem > > pretty extensive throughout the IO path. I don't think it will be ready > > for 4.3 > > > > Perhaps then we should go with my version t

[PATCH] RDMA/amso1100: Do not build amso1100 without infiniband subsystem

2015-08-04 Thread Steve Wise
Moving the amso1100 driver to staging now requires a guard on the INFINIBAND subsytem in order to prevent the driver from being built without infiniband enabled. This will lead to a broken build. Signed-off-by: Steve Wise --- drivers/staging/amso1100/Kconfig |2 +- 1 files changed, 1

RE: [PATCH] RDMA/amso1100: deprecate the amso1100 provider

2015-08-04 Thread Steve Wise
> > > This might run into the same issue as in > > https://lists.01.org/pipermail/kbuild-all/2015-August/011216.html. > > > > > > > Hey Mike, what is the issue exactly? > > The problem is when CONFIG_INFINIBAND=n and CONFIG_INFINIBAND_HFI1=y. Here is > what I did for ipath which had the same issu

RE: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names

2015-08-04 Thread Steve Wise
> -Original Message- > From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] > Sent: Tuesday, August 04, 2015 12:26 PM > To: Steve Wise; dledf...@redhat.com > Cc: infinip...@intel.com; sa...@mellanox.com; ogerl...@mellanox.com; > r...@mellanox.com; linux-rdma@vg

RE: [PATCH] RDMA/amso1100: deprecate the amso1100 provider

2015-08-04 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Marciniszyn, Mike > Sent: Tuesday, August 04, 2015 11:33 AM > To: Doug Ledford; Steve Wise > Cc: linux-rdma@vger.kernel.org; t...@opengridcomputing

RE: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names

2015-08-03 Thread Steve Wise
> > Steve, > > > > I've given this some thought and I think we should avoid splitting > > logic from PI and iWARP. The reason (other than code duplication) is > > that currently the iser target support only up to 1MB IOs. I have some > > code (not done yet) to support larger IOs by using multiple

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-07-31 Thread Steve Wise
Series looks good. Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 20/22] IB/iser: Support up to 8MB data transfer in a single command

2015-07-30 Thread Steve Wise
On 7/30/2015 3:06 AM, Sagi Grimberg wrote: iser support up to 512KB data transfer in a single scsi command. In order to support up to 8MB, iser needs to pre-allocate larger memory regions and larger page vectors. Given that a few target implementations don't support data transfers of more than 5

Re: [PATCH 12/22] IB/iser: Introduce iser_reg_ops

2015-07-30 Thread Steve Wise
On 7/30/2015 3:06 AM, Sagi Grimberg wrote: Move all the per-device function pointers to an easy extensible iser_reg_ops structure that contains all the iser registration operations. Signed-off-by: Sagi Grimberg --- drivers/infiniband/ulp/iser/iscsi_iser.h | 39 ++--

Re: [PATCH for-4.3 00/15] Modify MR allocation API

2015-07-30 Thread Steve Wise
type (whcih can be IB_MR_TYPE_MEM_REG for normal memory registration, IB_MR_TYPE_SIGNATURE for a data-integrity capable memory region and future arbitrary SG support capable memory region). Series looks good. Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH for-4.3 02/15] IB: Modify ib_create_mr API

2015-07-30 Thread Steve Wise
On 7/30/2015 2:32 AM, Sagi Grimberg wrote: Use ib_alloc_mr with specific parameters. Change the existing callers. Signed-off-by: Sagi Grimberg --- drivers/infiniband/core/verbs.c | 31 -- drivers/infiniband/hw/mlx5/main.c| 2 +- drivers/infiniband/h

[PATCH] RDMA/amso1100: deprecate the amso1100 provider

2015-07-29 Thread Steve Wise
The HW hasn't been sold since 2005, and the SW has definite bit rot. Its time to remove it. So move it to staging for a few releases and then remove it after that. Signed-off-by: Steve Wise --- drivers/infiniband/Kconfig |1 - drivers/infiniband/hw/Mak

RE: deprecating amso1100

2015-07-29 Thread Steve Wise
> -Original Message- > From: Doug Ledford [mailto:dledf...@redhat.com] > Sent: Wednesday, July 29, 2015 9:28 AM > To: Dennis Dalessandro > Cc: Steve Wise; linux-rdma@vger.kernel.org > Subject: Re: deprecating amso1100 > > On 07/21/2015 04:45 PM, Doug Ledford w

[PATCH] RDMA/iser: Limit sgs to the device fastreg depth

2015-07-28 Thread Steve Wise
Currently the sg tablesize, which dictates fast register page list depth to use, does not take into account the limits of the rdma device. So adjust it once we discover the device fastreg max depth limit. Also adjust the max_sectors based on the resulting sg tablesize. Signed-off-by: Steve Wise

[PATCH RESEND 2/4] ipath,qib: Expose max_sge_rd correctly

2015-07-27 Thread Steve Wise
Applications must not assume that max_sge and max_sge_rd are the same, Hence expose max_sge_rd correctly as well. Signed-off-by: Steve Wise Acked-by: Mike Marciniszyn --- drivers/infiniband/hw/ipath/ipath_verbs.c |1 + drivers/infiniband/hw/qib/qib_verbs.c |1 + 2 files changed, 2

[PATCH RESEND 4/4] RDMA/Core: remove rdma_cap_read_multi_sge() helper

2015-07-27 Thread Steve Wise
This functionality already exists via the max_sge_rd device capability. Signed-off-by: Steve Wise --- include/rdma/ib_verbs.h | 28 1 files changed, 0 insertions(+), 28 deletions(-) diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index b0f898e

[PATCH RESEND 0/4] Use max_sge_rd device capability

2015-07-27 Thread Steve Wise
-rdma/msg27436.html They really aren't part of iSER/iWARP at all, so I've split them out. Bruce: This hits svcrdma, but I suggest they get merged via Doug's tree to avoid any merge problems. --- Sagi Grimberg (1): mlx4, mlx5, mthca: Expose max_sge_rd correctly Steve Wise

[PATCH RESEND 1/4] mlx4, mlx5, mthca: Expose max_sge_rd correctly

2015-07-27 Thread Steve Wise
From: Sagi Grimberg Applications must not assume that max_sge and max_sge_rd are the same, Hence expose max_sge_rd correctly as well. Reported-by: Steve Wise Signed-off-by: Sagi Grimberg --- drivers/infiniband/hw/mlx4/main.c|1 + drivers/infiniband/hw/mlx5/main.c

[PATCH RESEND 3/4] svcrdma: Use max_sge_rd for destination read depths

2015-07-27 Thread Steve Wise
Signed-off-by: Steve Wise --- include/linux/sunrpc/svc_rdma.h |1 + net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 12 +--- net/sunrpc/xprtrdma/svc_rdma_transport.c |4 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/include/linux/sunrpc/svc_rdma.h b

RE: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names

2015-07-27 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Steve Wise > Sent: Sunday, July 26, 2015 3:17 PM > To: Sagi Grimberg; dledf...@redhat.com > Cc: infinip...@intel.com; sa...@mellanox.com; ogerl...@

Re: [PATCH WIP 28/43] IB/core: Introduce new fast registration API

2015-07-27 Thread Steve Wise
On 7/27/2015 12:14 PM, Jason Gunthorpe wrote: On Sun, Jul 26, 2015 at 12:45:10PM +0300, Sagi Grimberg wrote: On 7/23/2015 9:51 PM, Jason Gunthorpe wrote: On Thu, Jul 23, 2015 at 07:47:14PM +0300, Sagi Grimberg wrote: So we force ULPs to think about what they are doing properly, and we get a c

Re: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names

2015-07-26 Thread Steve Wise
On 7/26/2015 5:08 AM, Sagi Grimberg wrote: On 7/24/2015 7:18 PM, Steve Wise wrote: This is in preparation for adding new FRMR-only IO handlers for devices that support FRMR and not PI. Steve, I've given this some thought and I think we should avoid splitting logic from PI and iWARP

Re: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names

2015-07-26 Thread Steve Wise
On 7/26/2015 12:40 PM, Sagi Grimberg wrote: Ideally, the post contains a chain of all 4 registrations and the rdma_read (and an opportunistic good scsi response). Just to be clear: This example is for IB only, correct? IW would require rkeys with REMOTE_WRITE and 4 read wrs. My assumption

Re: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names

2015-07-26 Thread Steve Wise
On 7/26/2015 6:00 AM, Sagi Grimberg wrote: On 7/26/2015 1:43 PM, Christoph Hellwig wrote: On Sun, Jul 26, 2015 at 01:08:16PM +0300, Sagi Grimberg wrote: I've given this some thought and I think we should avoid splitting logic from PI and iWARP. The reason (other than code duplication) is that c

RE: [PATCH WIP 38/43] iser-target: Port to new memory registration API

2015-07-24 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe > Sent: Friday, July 24, 2015 3:25 PM > To: Chuck Lever > Cc: Sagi Grimberg; Christoph Hellwig; linux-rdma; Liran Liss; Oren Duer > Subject: Re: [PATCH W

RE: [PATCH V6 9/9] isert: Support iWARP transports using FRMRs

2015-07-24 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Steve Wise > Sent: Friday, July 24, 2015 2:58 PM > To: 'Jason Gunthorpe' > Cc: dledf...@redhat.com; infinip...@intel.com; sa...@mellanox.c

RE: [PATCH V6 9/9] isert: Support iWARP transports using FRMRs

2015-07-24 Thread Steve Wise
> -Original Message- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Friday, July 24, 2015 2:24 PM > To: Steve Wise > Cc: dledf...@redhat.com; infinip...@intel.com; sa...@mellanox.com; > ogerl...@mellanox.com; r...@mellanox.com; linux- > r.

RE: [PATCH V6 4/9] svcrdma: Use max_sge_rd for destination read depths

2015-07-24 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Steve Wise > Sent: Friday, July 24, 2015 11:19 AM > To: dledf...@redhat.com > Cc: infinip...@intel.com; sa...@mellanox.com; ogerl...@mellanox.com; &

RE: [PATCH V6 9/9] isert: Support iWARP transports using FRMRs

2015-07-24 Thread Steve Wise
> -Original Message- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Friday, July 24, 2015 11:57 AM > To: Steve Wise > Cc: dledf...@redhat.com; infinip...@intel.com; sa...@mellanox.com; > ogerl...@mellanox.com; r...@mellanox.com; linux- > r.

RE: [PATCH V6 8/9] isert: Use local_dma_lkey whenever possible.

2015-07-24 Thread Steve Wise
> -Original Message- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Friday, July 24, 2015 11:49 AM > To: Steve Wise > Cc: dledf...@redhat.com; infinip...@intel.com; sa...@mellanox.com; > ogerl...@mellanox.com; r...@mellanox.com; linux- > r.

RE: [PATCH V6 1/9] RDMA/iser: Limit sg tablesize and max_sectors to device fastreg max depth

2015-07-24 Thread Steve Wise
> -Original Message- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Friday, July 24, 2015 11:41 AM > To: Steve Wise > Cc: dledf...@redhat.com; infinip...@intel.com; sa...@mellanox.com; > ogerl...@mellanox.com; r...@mellanox.com; linux- > r.

RE: [PATCH WIP 38/43] iser-target: Port to new memory registration API

2015-07-24 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe > Sent: Friday, July 24, 2015 11:27 AM > To: Chuck Lever > Cc: Sagi Grimberg; Christoph Hellwig; linux-rdma; Liran Liss; Oren Duer > Subject: Re: [PATCH

[PATCH V6 9/9] isert: Support iWARP transports using FRMRs

2015-07-24 Thread Steve Wise
isert_reg_read_frmr(). Otherwise is uses the lkey map service isert_map_lkey() for RDMA WRITEs. isert_reg_read_frmr() will create a linked list of WR triplets of the form: INV->FRWR->READ. The number of these triplets is dependent on the devices fast reg page list length limit. Signed-off-by: Stev

[PATCH V6 7/9] isert: Use the device's max fastreg page list depth

2015-07-24 Thread Steve Wise
Use the device's max_fast_reg_page_list_len attr to size the SQ and FRMR pool. Signed-off-by: Steve Wise --- drivers/infiniband/ulp/isert/ib_isert.c | 28 drivers/infiniband/ulp/isert/ib_isert.h |1 + 2 files changed, 25 insertions(+), 4 deletions(-)

[PATCH V6 8/9] isert: Use local_dma_lkey whenever possible.

2015-07-24 Thread Steve Wise
No need to allocate a dma_mr if the device provides a local_dma_lkey. Signed-off-by: Steve Wise --- drivers/infiniband/ulp/isert/ib_isert.c | 47 ++- drivers/infiniband/ulp/isert/ib_isert.h |1 + 2 files changed, 28 insertions(+), 20 deletions(-) diff --git a

[PATCH V6 3/9] ipath,qib: Expose max_sge_rd correctly

2015-07-24 Thread Steve Wise
Applications must not assume that max_sge and max_sge_rd are the same, Hence expose max_sge_rd correctly as well. Signed-off-by: Steve Wise Acked-by: Mike Marciniszyn --- drivers/infiniband/hw/ipath/ipath_verbs.c |1 + drivers/infiniband/hw/qib/qib_verbs.c |1 + 2 files changed, 2

[PATCH V6 5/9] RDMA/isert: Limit read depth based on the device max_sge_rd capability

2015-07-24 Thread Steve Wise
Use the device's max_sge_rd capability to compute the target's read sge depth. Save both the read and write max_sge values in the isert_conn struct, and use these when creating RDMA_WRITE/READ work requests. Signed-off-by: Steve Wise --- drivers/infiniband/ulp/isert/ib_iser

[PATCH V6 4/9] svcrdma: Use max_sge_rd for destination read depths

2015-07-24 Thread Steve Wise
Signed-off-by: Steve Wise --- include/linux/sunrpc/svc_rdma.h |1 + net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 12 +--- net/sunrpc/xprtrdma/svc_rdma_transport.c |4 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/include/linux/sunrpc/svc_rdma.h b

[PATCH V6 6/9] isert: Rename IO functions to more descriptive names

2015-07-24 Thread Steve Wise
This is in preparation for adding new FRMR-only IO handlers for devices that support FRMR and not PI. Signed-off-by: Steve Wise --- drivers/infiniband/ulp/isert/ib_isert.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/infiniband

[PATCH V6 1/9] RDMA/iser: Limit sg tablesize and max_sectors to device fastreg max depth

2015-07-24 Thread Steve Wise
Currently the sg tablesize, which dictates fast register page list depth to use, does not take into account the limits of the rdma device. So adjust it once we discover the device fastreg max depth limit. Also adjust the max_sectors based on the resulting sg tablesize. Signed-off-by: Steve Wise

[PATCH V6 2/9] mlx4, mlx5, mthca: Expose max_sge_rd correctly

2015-07-24 Thread Steve Wise
From: Sagi Grimberg Applications must not assume that max_sge and max_sge_rd are the same, Hence expose max_sge_rd correctly as well. Reported-by: Steve Wise Signed-off-by: Sagi Grimberg --- drivers/infiniband/hw/mlx4/main.c|1 + drivers/infiniband/hw/mlx5/main.c

[PATCH V6 0/9] iSER support for iWARP

2015-07-24 Thread Steve Wise
vice capability max_sge_rd for the read sge depth. isert: change max_sge to max_write_sge in struct isert_conn. --- Sagi Grimberg (1): mlx4, mlx5, mthca: Expose max_sge_rd correctly Steve Wise (8): isert: Support iWARP transports using FRMRs isert: Use local_dma_lkey wh

RE: [PATCH] RDMA/cxgb3: fail get_dma_mr if the memory footprint can exceed 32b

2015-07-24 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Doug Ledford > Sent: Friday, July 24, 2015 9:45 AM > To: Steve Wise > Cc: linux-rdma@vger.kernel.org > Subject: Re: [PATCH] RDMA/cxgb3: fail get

RE: [PATCH] RDMA/cxgb3: fail get_dma_mr if the memory footprint can exceed 32b

2015-07-23 Thread Steve Wise
> -Original Message- > From: Doug Ledford [mailto:dledf...@redhat.com] > Sent: Thursday, July 23, 2015 4:33 PM > To: Steve Wise > Cc: linux-rdma@vger.kernel.org > Subject: Re: [PATCH] RDMA/cxgb3: fail get_dma_mr if the memory footprint can > exceed 32b > > On

  1   2   3   4   5   6   7   8   9   10   >