RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

2015-12-09 Thread Wan, Kaike
> -Original Message- > From: Hefty, Sean > Sent: Wednesday, December 09, 2015 1:37 PM > To: Jason Gunthorpe > Cc: Hal Rosenstock; Wan, Kaike; linux-rdma@vger.kernel.org > Subject: RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics > > > pkey[0] at l

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

2015-12-09 Thread Wan, Kaike
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Hal Rosenstock > Sent: Wednesday, December 09, 2015 11:49 AM > > When IP addresses are used, the corresponding pkey is used. The issue this > patch is addressing is t

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

2015-12-09 Thread Wan, Kaike
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Hal Rosenstock > Sent: Wednesday, December 09, 2015 9:36 AM > >> Unfortunately not. It comes down to whether the out of box cases > >> outweigh the debug when it's an e

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

2015-12-09 Thread Wan, Kaike
> -Original Message- > From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Wednesday, December 09, 2015 9:06 AM > > This is the best effort and it should work for most common > > configurations, but may not work for more complicated cases. > > Right, there are various scenario

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

2015-12-09 Thread Wan, Kaike
> -Original Message- > From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Wednesday, December 09, 2015 8:46 AM > >>> To solve the problem, this patch introduces the following priority > >>> to interpret default pkey: > >>> 1. Find the first non-management full-member pkey; 2.

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

2015-12-09 Thread Wan, Kaike
> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Wednesday, December 09, 2015 7:50 AM > To: Wan, Kaike; Hefty, Sean > Cc: linux-rdma@vger.kernel.org > Subject: Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics > > On 12/8/2015 12:33 PM, kaike@inte

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

2015-12-09 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Tuesday, December 08, 2015 4:22 PM > To: Wan, Kaike > Cc: Hefty, Sean; linux-rdma@vger.kernel.org > Subject: Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics > > On Tue, Dec 08, 2015 at 12

RE: [PATCH v2 1/1] IB/sa: Put netlink request into the request list before sending

2015-11-13 Thread Wan, Kaike
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of kaike@intel.com > Sent: Friday, October 30, 2015 8:24 AM > To: linux-rdma@vger.kernel.org > Cc: Wan, Kaike > Subject: [PATCH v2 1/1] IB/sa: Put netlink request into the requ

RE: [PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC

2015-11-13 Thread Wan, Kaike
Friday, November 13, 2015 2:42 AM > To: Weiny, Ira; Wan, Kaike > Cc: Hefty, Sean; hal.rosenst...@gmail.com; dledf...@redhat.com; linux- > r...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC > > On Wed, 28 Oct 2015

RE: [PATCH 1/1] IB/sa: Put netlink request into the request list before sending

2015-10-29 Thread Wan, Kaike
> -Original Message- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Wednesday, October 28, 2015 12:47 PM > > > ret = ib_nl_send_msg(query); > > + spin_lock_irqsave(&ib_nl_request_lock, flags); > > Looks like query could be kfree'd before ib_nl_send_msg re

RE: [PATCH 1/1] IB/sa: Put netlink request into the request list before sending

2015-10-28 Thread Wan, Kaike
> -Original Message- > From: Weiny, Ira > Sent: Wednesday, October 28, 2015 11:40 AM > > What about using the gfp_mask through this stack? Can be done. > > I think you need to split ib_nl_send_msg into "create message" and "send > message". Then don't add the message to the list unle

RE: [PATCH v9 0/4] Sending kernel pathrecord query to user cache server

2015-08-24 Thread Wan, Kaike
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe > Sent: Friday, August 21, 2015 7:08 PM > To: Wan, Kaike; Haggai Eran > Cc: linux-rdma@vger.kernel.org > Subject: Re: [PATCH v

RE: [PATCH] IB/sa: Restrict SA Netlink to admin users

2015-08-11 Thread Wan, Kaike
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe > Sent: Tuesday, August 11, 2015 1:38 AM > To: Weiny, Ira > Cc: Haggai Eran; dledf...@redhat.com; linux-rdma@vger.kernel.org > Subject: Re: [PATCH] IB/sa: Restrict SA Netlink to admin

RE: [PATCH v8 4/4] IB/sa: Route SA pathrecord query through netlink

2015-07-23 Thread Wan, Kaike
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe > Sent: Wednesday, July 22, 2015 5:09 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v8 4/4] IB/sa: Route S

RE: [PATCH v8 1/4] IB/netlink: Add defines for local service requests through netlink

2015-07-23 Thread Wan, Kaike
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe > Sent: Wednesday, July 22, 2015 4:56 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v8 1/4] IB/netlink: Add

RE: [PATCH v7 4/4] IB/sa: Route SA pathrecord query through netlink

2015-07-08 Thread Wan, Kaike
> -Original Message- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Friday, July 03, 2015 5:38 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v7 4/4] IB/sa: Route SA pathrecord query through n

RE: [PATCH v7 1/4] IB/netlink: Add defines for local service requests through netlink

2015-07-07 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Monday, July 06, 2015 4:59 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v7 1/4] IB/netlink: Add defines for local service requests > through netlink &g

RE: [PATCH v7 1/4] IB/netlink: Add defines for local service requests through netlink

2015-07-06 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Friday, July 03, 2015 5:16 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v7 1/4] IB/netlink: Add defines for local service requests > through netlink &

RE: [PATCH v7 4/4] IB/sa: Route SA pathrecord query through netlink

2015-07-01 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Tuesday, June 30, 2015 6:25 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v7 4/4] IB/sa: Route SA pathrecord query through netlink > > On Tue, Jun 3

RE: [PATCH v7 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-30 Thread Wan, Kaike
> From: Hefty, Sean > Sent: Tuesday, June 30, 2015 1:17 PM > To: Wan, Kaike; linux-rdma@vger.kernel.org > Cc: Wan, Kaike; Fleck, John; Weiny, Ira > Subject: RE: [PATCH v7 1/4] IB/netlink: Add defines for local service requests > through netlink > > > include/uapi

RE: [PATCH v6 4/4] IB/sa: Route SA pathrecord query through netlink

2015-06-26 Thread Wan, Kaike
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe > Sent: Thursday, June 25, 2015 7:17 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v6 4/4] IB/sa: Route S

RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 8:22 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests > through netlink &

RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 3:52 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests > through netlink &

RE: [PATCH v5 1/1] ibacm: Add support for pathrecord query through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 3:27 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/1] ibacm: Add support for pathrecord query > through netlink > >

RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 2:52 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests > through netlink &

RE: [PATCH v5 1/1] ibacm: Add support for pathrecord query through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 2:47 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/1] ibacm: Add support for pathrecord query > through netlink > >

RE: [PATCH v5 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 1:58 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/4] IB/netlink: Add defines for local service requests > through netlink &

RE: [PATCH v5 1/1] ibacm: Add support for pathrecord query through netlink

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 11, 2015 2:00 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v5 1/1] ibacm: Add support for pathrecord query > through netlink > >

RE: [PATCH v4 1/1] ibacm: Add support for pathrecord query through netlink

2015-06-11 Thread Wan, Kaike
> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Thursday, June 11, 2015 11:53 AM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v4 1/1] ibacm: Add support for pathrecord query > through netlink > > On 6/11/2

RE: [PATCH v4 1/1] ibacm: Add support for pathrecord query through netlink

2015-06-11 Thread Wan, Kaike
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Hal Rosenstock > Sent: Thursday, June 11, 2015 10:15 AM > > On 6/9/2015 10:57 AM, kaike@intel.com wrote: > > From: Kaike Wan > > > > This patch enables ibacm to process pathrecord queries throug

RE: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

2015-06-11 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Wednesday, June 10, 2015 3:15 PM > > On Wed, Jun 10, 2015 at 05:04:55PM +, Hefty, Sean wrote: > > > Not in the patches themselves but in the general issue when a PR changes. > > > > > > Do you think this needs addressing

RE: [PATCH v4 4/4] IB/sa: Route SA pathrecord query through netlink

2015-06-11 Thread Wan, Kaike
> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Thursday, June 11, 2015 8:24 AM > To: Weiny, Ira > Cc: Jason Gunthorpe; Wan, Kaike; linux-rdma@vger.kernel.org; Fleck, John > Subject: Re: [PATCH v4 4/4] IB/sa: Route SA pathrecord query through netlink > >

RE: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

2015-06-11 Thread Wan, Kaike
> -Original Message- > From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Wednesday, June 10, 2015 3:52 PM > > On 6/10/2015 1:04 PM, Hefty, Sean wrote: > >> Not in the patches themselves but in the general issue when a PR changes. > >> > >> Do you think this needs addressing o

RE: [PATCH v4 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Wan, Kaike
> From: Hefty, Sean > Sent: Wednesday, June 10, 2015 4:32 PM > To: Hal Rosenstock; Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: RE: [PATCH v4 1/4] IB/netlink: Add defines for local service requests > through netlink > > > >&

RE: [PATCH v4 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-10 Thread Wan, Kaike
> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Wednesday, June 10, 2015 1:47 PM > > On 6/9/2015 10:57 AM, kaike@intel.com wrote: > > From: Kaike Wan > > > > This patch adds netlink defines for SA client, local service group, > > local service operations, and related attribute

RE: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

2015-06-10 Thread Wan, Kaike
> > A SA cache is undeniably critical for fabric scalability and > > performance. > > In user space, the ibacm application provides a good example of > > pathrecord cache for address and route resolution. With the recent > > implementation of the provider architecture, ibacm of

RE: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

2015-06-10 Thread Wan, Kaike
> -Original Message- > From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Wednesday, June 10, 2015 10:40 AM > > > > > >> -Original Message- > >> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > >> Sent: Wednesday, June 10, 2015 9:37 AM > >> > >>> > >>> A SA cache

RE: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

2015-06-10 Thread Wan, Kaike
> -Original Message- > From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Wednesday, June 10, 2015 9:37 AM > > > > > A SA cache is undeniably critical for fabric scalability and performance. > > In user space, the ibacm application provides a good example of > > pathrecord cac

RE: [PATCH v3 4/4] IB/sa: Route SA pathrecord query through netlink

2015-06-05 Thread Wan, Kaike
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe > Sent: Friday, June 05, 2015 5:00 PM > > On Fri, Jun 05, 2015 at 08:53:01PM +, Hefty, Sean wrote: > > > RDMA_OP_RESOLVE (reply) > > > IB_PATH > > > IB_PATH > > > IB_PATH >

RE: [PATCH v3 4/4] IB/sa: Route SA pathrecord query through netlink

2015-06-05 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Friday, June 05, 2015 1:05 PM > > > > Why doesn't this follow the usual netlink usage idioms? I don't see > > > a single nla_put or nla_nest_start, which, based on the RFC, is what > > > I expect to see. Don't home brew net

RE: [PATCH v3 4/4] IB/sa: Route SA pathrecord query through netlink

2015-06-05 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Thursday, June 04, 2015 4:20 PM > > On Thu, Jun 04, 2015 at 08:26:49AM -0400, kaike@intel.com wrote: > > From: Kaike Wan > > > > This patch routes a SA pathrecord query to netlink first and processes > > the response ap

[PATCH v2 RFC] IB/sa: Route SA pathrecord query through netlink

2015-05-26 Thread Wan, Kaike
I. Introduction After posting our design to the mailing list, we received comments concerning various aspects of the design from Sean Hefty, Ira Weiny, Jason Gunthorpe, and Doug Ledford. Thank you all for the help. The main issues are listed below: 1. Extensibility: the design should be flexibl

RE: [RFC] IB/sa: Route SA pathrecord query through netlink

2015-05-21 Thread Wan, Kaike
> On Thu, May 21, 2015 at 07:52:36AM -0600, Wan, Kaike wrote: > > > > The general format of the request and response will be the same: > > > > -- > > | netlink header | > > -- > > | Data header

RE: [RFC] IB/sa: Route SA pathrecord query through netlink

2015-05-21 Thread Wan, Kaike
> > The general format of the request and response will be the same: > > > > | netlink header | > > | Data header | > > | Data | > > > > The data header contains information about the type of > > request/response, the status (for response), the type (format) of the > > data, the

RE: [RFC] IB/sa: Route SA pathrecord query through netlink

2015-05-21 Thread Wan, Kaike
> On Thu, 2015-05-21 at 13:21 -0400, Doug Ledford wrote: > > The one thing I left out of the above that might be worth changing is the fact > that you bury your sequence number down in your mad header. If there is a > generic mechanism that multiple modules can use to send customized data > via n

RE: [RFC] IB/sa: Route SA pathrecord query through netlink

2015-05-21 Thread Wan, Kaike
> On Thu, 2015-05-21 at 13:52 +0000, Wan, Kaike wrote: > > In our previous posting to the mailing list, we proposed to send a MAD > > request from kernel (more specifically, from ib_sa module) to a user space > application (ibacm in this case) through netlink. > > The use

[RFC] IB/sa: Route SA pathrecord query through netlink

2015-05-21 Thread Wan, Kaike
In our previous posting to the mailing list, we proposed to send a MAD request from kernel (more specifically, from ib_sa module) to a user space application (ibacm in this case) through netlink. The user space application will send back the response. This simple scheme can achieve the goal of

RE: [PATCH 1/1] ibacm: Add support for pathrecord query through netlink

2015-05-19 Thread Wan, Kaike
> > > +static inline int acm_nl_supported_sa_mad(struct ib_sa_mad *sa_mad) { > > + return (sa_mad->rmpp_version == 0 && > > I think you want something like: > > !(rmpp_flags & RMPP_ACTIVE) > > Instead of checking for version = 0. Will be changed to: !(sa_mad->rmpp_flags & UMAD_RMPP_FLAG_AC

RE: [PATCH 3/3] ibacm/ibacmp: fix a crash when SM restarts

2014-12-04 Thread Wan, Kaike
ding any one > > with ep- > > >endpoint > > set to NULL. In this case, it will cause segfault in acm_send_sa_mad(). > > Additional check should be able to avoid the crash. > > I'm having trouble following this. Is the problem that the provider is not > cle