RE: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable

2010-10-22 Thread Ralph Campbell
to load driver if PCI error reporting doesn't enable This seems to be the intention of the code, since the jump to bail is missing. PCI-E advanced error reporting seems optional, but I wonder if pci_set_consistent_dma_mask is also optional? This also fixes one case where the PCI region

Re: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable

2010-10-22 Thread Jason Gunthorpe
On Fri, Oct 22, 2010 at 02:28:54PM -0700, Ralph Campbell wrote: I'm not sure this is the right change. I agree there are a lot of clean up on error bugs. pci_set_consistent_dma_mask() isn't optional because the chip doesn't support 32-bit PCIe addressing. Do you think

RE: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable

2010-10-22 Thread Ralph Campbell
Subject: Re: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable On Fri, Oct 22, 2010 at 02:28:54PM -0700, Ralph Campbell wrote: I'm not sure this is the right change. I agree there are a lot of clean up on error bugs. pci_set_consistent_dma_mask() isn't optional