Re: [PATCH] libibmad: Add ib_resolve_noderecord_via API

2013-02-18 Thread Sarat Kakarla
Ira Hal, I have talked to my management about this wrapper and decided to add it to our code instead of libibmad, so for now I am dropping the merge request. Thanks Sarat On 2/12/2013 3:49 PM, Ira Weiny wrote: On Tue, 12 Feb 2013 15:36:11 -0800 Sarat Kakarla sarat.kaka...@oracle.com wrote:

[PATCH] libibmad: Add ib_resolve_noderecord_via API

2013-02-12 Thread Sarat Kakarla
Add ib_resolve_noderecord_via wrapper similar to ib_resolve_portid_str_via Signed-off-by: Sarat Kakarla sarat.kaka...@oracle.com --- include/infiniband/mad.h 2009-11-01 16:17:12.0 -0800 +++ ../libibmad-1.3.3.wrapper/include/infiniband/mad.h 2013-02-07 10:32:05.0 -0800 @@

Re: [PATCH] libibmad: Add ib_resolve_noderecord_via API

2013-02-12 Thread Hal Rosenstock
On 2/12/2013 3:39 PM, Sarat Kakarla wrote: Add ib_resolve_noderecord_via wrapper similar to ib_resolve_portid_str_via Note that this patch depends on a patch previously submitted on 1/31 but not yet accepted: libibmad: Add NodeRecord query API due to it's use of ib_node_query_via below.

Re: [PATCH] libibmad: Add ib_resolve_noderecord_via API

2013-02-12 Thread Sarat Kakarla
Hal, Thanks for reviewing it. My answers are in-lined with [SK] prefix. Sarat On 2/12/2013 2:21 PM, Hal Rosenstock wrote: On 2/12/2013 3:39 PM, Sarat Kakarla wrote: Add ib_resolve_noderecord_via wrapper similar to ib_resolve_portid_str_via Note that this patch depends on a patch previously

Re: [PATCH] libibmad: Add ib_resolve_noderecord_via API

2013-02-12 Thread Hal Rosenstock
On 2/12/2013 6:03 PM, Sarat Kakarla wrote: [SK] I wanted to make ib_resolve_noderecord_via look like ib_resolve_portid_str_via API which does not take any timeout parameter. I can pass '0' instead of MAD_DEF_TIMEOUT_MS, that's what passed as timeout to ib_resolve_guid_via function

Re: [PATCH] libibmad: Add ib_resolve_noderecord_via API

2013-02-12 Thread Sarat Kakarla
Hal, ib_resolve_guid_via has timeout parameter but when it is getting called from ib_resolve_portid_str_via the value is specified as 0. int ib_resolve_portid_str_via(ib_portid_t * portid, char *addr_str, enum MAD_DEST dest_type, ib_portid_t * sm_id, const struct

Re: [PATCH] libibmad: Add ib_resolve_noderecord_via API

2013-02-12 Thread Ira Weiny
On Tue, 12 Feb 2013 12:39:44 -0800 Sarat Kakarla sarat.kaka...@oracle.com wrote: Add ib_resolve_noderecord_via wrapper similar to ib_resolve_portid_str_via I have a more fundamental question: Do you have a use case for this? Ira Signed-off-by: Sarat Kakarla sarat.kaka...@oracle.com ---

Re: [PATCH] libibmad: Add ib_resolve_noderecord_via API

2013-02-12 Thread Sarat Kakarla
On 2/12/2013 3:28 PM, Ira Weiny wrote: On Tue, 12 Feb 2013 12:39:44 -0800 Sarat Kakarla sarat.kaka...@oracle.com wrote: Add ib_resolve_noderecord_via wrapper similar to ib_resolve_portid_str_via I have a more fundamental question: Do you have a use case for this? Ira The main purpose of

Re: [PATCH] libibmad: Add ib_resolve_noderecord_via API

2013-02-12 Thread Ira Weiny
On Tue, 12 Feb 2013 15:36:11 -0800 Sarat Kakarla sarat.kaka...@oracle.com wrote: On 2/12/2013 3:28 PM, Ira Weiny wrote: On Tue, 12 Feb 2013 12:39:44 -0800 Sarat Kakarla sarat.kaka...@oracle.com wrote: Add ib_resolve_noderecord_via wrapper similar to ib_resolve_portid_str_via I