RE: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable

2010-10-22 Thread Ralph Campbell
I'm not sure this is the right change. I agree there are a lot of clean up on error bugs. pci_set_consistent_dma_mask() isn't optional because the chip doesn't support 32-bit PCIe addressing. I'll look it over and try to come up with something better. I'll submit a patch for the CONFIG_PCI_MSI

Re: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable

2010-10-22 Thread Jason Gunthorpe
On Fri, Oct 22, 2010 at 02:28:54PM -0700, Ralph Campbell wrote: I'm not sure this is the right change. I agree there are a lot of clean up on error bugs. pci_set_consistent_dma_mask() isn't optional because the chip doesn't support 32-bit PCIe addressing. Do you think

RE: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable

2010-10-22 Thread Ralph Campbell
Subject: Re: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable On Fri, Oct 22, 2010 at 02:28:54PM -0700, Ralph Campbell wrote: I'm not sure this is the right change. I agree there are a lot of clean up on error bugs. pci_set_consistent_dma_mask() isn't optional