Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-10 Thread Dennis Dalessandro
On Tue, Dec 08, 2015 at 09:20:27AM +0200, Leon Romanovsky wrote: On Tue, Dec 08, 2015 at 08:28:17AM +0200, Leon Romanovsky wrote: On Mon, Dec 07, 2015 at 03:43:10PM -0500, Dennis Dalessandro wrote: > + > +/* > + * Things that are driver specific, module parameters in hfi1 and qib > + */ >

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-10 Thread ira.weiny
On Thu, Dec 10, 2015 at 11:49:40AM -0500, Dalessandro, Dennis wrote: > On Tue, Dec 08, 2015 at 02:52:36PM -0500, ira. weiny wrote: > >On Tue, Dec 08, 2015 at 01:17:48PM -0600, Sean Hefty wrote: > >>> > > +struct ib_pd *rvt_alloc_pd(struct ib_device *ibdev, > >>> > > +struct

RE: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-10 Thread Hefty, Sean
> > How about I reword the comment to say that while we could continue > > allocating PDs being only constrained by system resources, the spec says > > there is a limit so we enforce that? > > I'm ok with that, Sean? That's fine -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-10 Thread Dennis Dalessandro
On Tue, Dec 08, 2015 at 02:52:36PM -0500, ira. weiny wrote: On Tue, Dec 08, 2015 at 01:17:48PM -0600, Sean Hefty wrote: > > > +struct ib_pd *rvt_alloc_pd(struct ib_device *ibdev, > > > + struct ib_ucontext *context, > > > + struct ib_udata

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-10 Thread Leon Romanovsky
On Thu, Dec 10, 2015 at 11:40:48AM -0500, Dennis Dalessandro wrote: > On Tue, Dec 08, 2015 at 08:28:17AM +0200, Leon Romanovsky wrote: > >On Mon, Dec 07, 2015 at 03:43:10PM -0500, Dennis Dalessandro wrote: > >>+ > >>+/* > >>+ * Things that are driver specific, module parameters in hfi1 and qib >

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-10 Thread Dennis Dalessandro
On Tue, Dec 08, 2015 at 08:28:17AM +0200, Leon Romanovsky wrote: On Mon, Dec 07, 2015 at 03:43:10PM -0500, Dennis Dalessandro wrote: + +/* + * Things that are driver specific, module parameters in hfi1 and qib + */ +struct rvt_driver_params { + int max_pds; Can it be negative value? +};

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-08 Thread ira.weiny
On Mon, Dec 07, 2015 at 03:13:16PM -0600, Sean Hefty wrote: > > +struct ib_pd *rvt_alloc_pd(struct ib_device *ibdev, > > + struct ib_ucontext *context, > > + struct ib_udata *udata) > > +{ > > + struct rvt_dev_info *dev = ib_to_rvt(ibdev); > > + struct

RE: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-08 Thread Hefty, Sean
> > > +struct ib_pd *rvt_alloc_pd(struct ib_device *ibdev, > > > +struct ib_ucontext *context, > > > +struct ib_udata *udata) > > > +{ > > > + struct rvt_dev_info *dev = ib_to_rvt(ibdev); > > > + struct rvt_pd *pd; > > > + struct ib_pd *ret; > > > + > > > +

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-08 Thread ira.weiny
On Tue, Dec 08, 2015 at 01:17:48PM -0600, Sean Hefty wrote: > > > > +struct ib_pd *rvt_alloc_pd(struct ib_device *ibdev, > > > > + struct ib_ucontext *context, > > > > + struct ib_udata *udata) > > > > +{ > > > > + struct rvt_dev_info *dev =

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-07 Thread Leon Romanovsky
On Mon, Dec 07, 2015 at 03:43:10PM -0500, Dennis Dalessandro wrote: > + > +/* > + * Things that are driver specific, module parameters in hfi1 and qib > + */ > +struct rvt_driver_params { > + int max_pds; Can it be negative value? > +}; -- To unsubscribe from this list: send the line

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-07 Thread Leon Romanovsky
On Tue, Dec 08, 2015 at 08:28:17AM +0200, Leon Romanovsky wrote: > On Mon, Dec 07, 2015 at 03:43:10PM -0500, Dennis Dalessandro wrote: > > + > > +/* > > + * Things that are driver specific, module parameters in hfi1 and qib > > + */ > > +struct rvt_driver_params { > > + int max_pds; > Can it be

RE: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

2015-12-07 Thread Hefty, Sean
> +struct ib_pd *rvt_alloc_pd(struct ib_device *ibdev, > +struct ib_ucontext *context, > +struct ib_udata *udata) > +{ > + struct rvt_dev_info *dev = ib_to_rvt(ibdev); > + struct rvt_pd *pd; > + struct ib_pd *ret; > + > + pd =