Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-25 Thread Christoph Hellwig
On Mon, Aug 24, 2015 at 10:59:21AM +0300, Haggai Eran wrote: > > It looks odd to me as well, but it's not really something I want to > > change in this series. Note that sparse annoted types like __be32 > > aren't really common in userspace, but with a bit of effort they can > > be supported. We

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-24 Thread Haggai Eran
On 24/08/2015 09:55, Christoph Hellwig wrote: > On Mon, Aug 24, 2015 at 09:52:14AM +0300, Haggai Eran wrote: >> Okay. Maybe you can just add a case for IB_WR_SEND in this patch to >> avoid hurting bisectability. > > I've done this already, just waiting for more feedback before resending: > > http

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-23 Thread Christoph Hellwig
On Mon, Aug 24, 2015 at 09:52:14AM +0300, Haggai Eran wrote: > Okay. Maybe you can just add a case for IB_WR_SEND in this patch to > avoid hurting bisectability. I've done this already, just waiting for more feedback before resending: http://git.infradead.org/users/hch/rdma.git/commitdiff/20f34ca

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-23 Thread Haggai Eran
On 22/08/2015 11:25, Christoph Hellwig wrote: > On Sat, Aug 22, 2015 at 06:38:47AM +, Haggai Eran wrote: >> It looks like the default case in the non-UD branch is currently used to >> handle plain IB_WR_SEND operations, so the patch would cause these to return >> an error. > > Indeed. It's

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-22 Thread Christoph Hellwig
On Sat, Aug 22, 2015 at 06:38:47AM +, Haggai Eran wrote: > It looks like the default case in the non-UD branch is currently used to > handle plain IB_WR_SEND operations, so the patch would cause these to return > an error. Indeed. It's handled fine in patch 2 which splits up the case, but w

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-21 Thread Haggai Eran
On Thursday, August 20, 2015 11:52 AM, linux-rdma-ow...@vger.kernel.org on behalf of Sagi Grimberg wrote: > On 8/19/2015 7:37 PM, Christoph Hellwig wrote: >> We have many WR opcodes that are only supported in kernel space >> and/or require optional information to be copied into the WR >> struct

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-20 Thread Steve Wise
On 8/20/2015 3:49 AM, Sagi Grimberg wrote: On 8/19/2015 8:54 PM, Jason Gunthorpe wrote: On Wed, Aug 19, 2015 at 07:48:02PM +0200, Christoph Hellwig wrote: On Wed, Aug 19, 2015 at 11:46:14AM -0600, Jason Gunthorpe wrote: Reviewed-by: Jason Gunthorpe AFAIK, this path is rarely (never?) actuall

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-20 Thread Christoph Hellwig
On Wed, Aug 19, 2015 at 07:50:23PM +, Hefty, Sean wrote: > > AFAIK, this path is rarely (never?) actually used. I think all the > > drivers we have can post directly from userspace. > > I didn't think the ipath or qib drivers post from userspace. Makes sense with their software IB stack. Gue

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-20 Thread Sagi Grimberg
On 8/19/2015 7:37 PM, Christoph Hellwig wrote: We have many WR opcodes that are only supported in kernel space and/or require optional information to be copied into the WR structure. Reject all those not explicitly handled so that we can't pass invalid information to drivers. Cc: sta...@vger.ke

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-20 Thread Sagi Grimberg
On 8/19/2015 8:54 PM, Jason Gunthorpe wrote: On Wed, Aug 19, 2015 at 07:48:02PM +0200, Christoph Hellwig wrote: On Wed, Aug 19, 2015 at 11:46:14AM -0600, Jason Gunthorpe wrote: Reviewed-by: Jason Gunthorpe AFAIK, this path is rarely (never?) actually used. I think all the drivers we have can

RE: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-19 Thread Hefty, Sean
> AFAIK, this path is rarely (never?) actually used. I think all the > drivers we have can post directly from userspace. I didn't think the ipath or qib drivers post from userspace. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-19 Thread Jason Gunthorpe
On Wed, Aug 19, 2015 at 07:48:02PM +0200, Christoph Hellwig wrote: > On Wed, Aug 19, 2015 at 11:46:14AM -0600, Jason Gunthorpe wrote: > > Reviewed-by: Jason Gunthorpe > > > > AFAIK, this path is rarely (never?) actually used. I think all the > > drivers we have can post directly from userspace. >

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2015 at 11:46:14AM -0600, Jason Gunthorpe wrote: > Reviewed-by: Jason Gunthorpe > > AFAIK, this path is rarely (never?) actually used. I think all the > drivers we have can post directly from userspace. Oh, interesting. Is there any chance to deprecate it? Not having to care fo

Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes

2015-08-19 Thread Jason Gunthorpe
On Wed, Aug 19, 2015 at 06:37:32PM +0200, Christoph Hellwig wrote: > We have many WR opcodes that are only supported in kernel space > and/or require optional information to be copied into the WR > structure. Reject all those not explicitly handled so that we > can't pass invalid information to dr