On 03/13/13 08:43, David Laight wrote:
From my recollection of the x86 architecture, the memory barriers are
hardly ever needed, certainly not in the places where, for example a
ppc needs them. I'd actually suspect that the normal wmb() for x86
should be a nop. About the only place where any o
> >>> + writel(n, adap->bar2 + q->udb + 8);
> >>> +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64)
> >>> + asm volatile("sfence" : : : "memory");
> >>> +#endif
> >> There is absolutely no way I'm letting anyone put crap like this
> >> into a driver.
> >
On 12-03-2013 20:12, Steve Wise wrote:
> On 3/12/2013 7:19 AM, David Miller wrote:
>> From: Vipul Pandya
>> Date: Tue, 12 Mar 2013 17:16:17 +0530
>>
>>> + writel(n, adap->bar2 + q->udb + 8);
>>> +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64)
>>> +
On 3/12/2013 7:19 AM, David Miller wrote:
From: Vipul Pandya
Date: Tue, 12 Mar 2013 17:16:17 +0530
+ writel(n, adap->bar2 + q->udb + 8);
+#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64)
+ asm volatile("sfence" : : : "memory");
+#endif
From: Vipul Pandya
Date: Tue, 12 Mar 2013 17:16:17 +0530
> + writel(n, adap->bar2 + q->udb + 8);
> +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64)
> + asm volatile("sfence" : : : "memory");
> +#endif
There is absolutely no way I'm letting an
