RE: [PATCH v4 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-11 Thread Wan, Kaike
From: Hefty, Sean Sent: Wednesday, June 10, 2015 4:32 PM To: Hal Rosenstock; Wan, Kaike Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira Subject: RE: [PATCH v4 1/4] IB/netlink: Add defines for local service requests through netlink +/* Local Service Reversible attribute */ struct

RE: [PATCH v4 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-10 Thread Hefty, Sean
+/* Local Service Reversible attribute */ struct +rdma_nla_ls_reversible { + __u32 reversible; +}; Isn't __u8 sufficient for reversible ? Certainly enough. However, reversible is __u32 in struct ib_user_path_rec and int in struct ib_sa_path_rec. OK; I hadn't double

Re: [PATCH v4 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-10 Thread Hal Rosenstock
On 6/10/2015 2:31 PM, Wan, Kaike wrote: From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] Sent: Wednesday, June 10, 2015 1:47 PM On 6/9/2015 10:57 AM, kaike@intel.com wrote: From: Kaike Wan kaike@intel.com This patch adds netlink defines for SA client, local service group,

RE: [PATCH v4 1/4] IB/netlink: Add defines for local service requests through netlink

2015-06-10 Thread Wan, Kaike
From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] Sent: Wednesday, June 10, 2015 1:47 PM On 6/9/2015 10:57 AM, kaike@intel.com wrote: From: Kaike Wan kaike@intel.com This patch adds netlink defines for SA client, local service group, local service operations, and related