[PATCH for-next V1 2/2] IB/mlx4: Fix build warnings

2013-11-03 Thread Or Gerlitz
Fix the below make W=1 build warning we have on the mlx4_ib drivers/infiniband/hw/mlx4/qp.c: In function ‘mlx4_ib_post_send’: drivers/infiniband/hw/mlx4/qp.c:2463: warning: comparison of unsigned expression 0 is always false Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers

Re: [PATCH for-next 1/2] IB/core: Fix build warnings

2013-11-03 Thread Or Gerlitz
On 31/10/2013 21:28, David Dillow wrote: We want to know about those comparisons, because they often indicate a bug -- either in one's thinking, or in the code they've written. Changing attr.state from unsigned to signed is unlikely to ever happen, as a massive audit would be needed -- this is

Re: [PATCH RFC v2 07/10] IB/mlx5: Keep mlx5 MRs in a radix tree under device

2013-11-03 Thread Or Gerlitz
On 03/11/2013 14:16, Sagi Grimberg wrote: mlx5 currently doesn't support 32-bit platforms, I'll take your suggestion. I think 32-bit x86 is supported, but anyway, as we're picking your suggestion, should be fine. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the

Re: AW: AW: AW: IPoIB GRO

2013-11-05 Thread Or Gerlitz
On 05/11/2013 10:25, Markus Stockhausen wrote: Are the TCP Ids in an TSO setup generated through firmware or in the software stack? in HW And if in firmware: How does the card know how to increase them? I would expect that it only works with IB packets and does not know of the IP

Re: [PATCH for-next V1 0/8] uverbs extensions fixes

2013-11-05 Thread Or Gerlitz
On 05/11/2013 11:05, Yann Droneaud wrote: Thanks Matan for carrying on the patchset. I've quite the same patchset, but the other way around, eg. enabling the flow steering verbs after cleanup on the new ABI. I thought it would make more sense this way. Would you like me to send the patchset

Re: IPoIB GRO

2013-11-05 Thread Or Gerlitz
On 05/11/2013 20:08, Markus Stockhausen wrote: Incredible how a card that does not support TSO can bring big packets on the wire that somehow get reassembled on the client side not sure to follow, you have shown they are **not** reassembled, correct? -- To unsubscribe from this list: send the

Re: [PATCH for-next V1 0/8] uverbs extensions fixes

2013-11-06 Thread Or Gerlitz
Roland, no way we can effort to loose another quarter just b/c Yan is slow to send his final proposed patch series. We are already into the 3.13 merge window and time is running out. Not really, you may have noticed Linus is on vacation, and the 3.13 merge window will be a bit delayed (I've

[PATCH for-next 6/6] IB/mlx4_ib: Add support for steer-able IB UD QPs

2013-11-07 Thread Or Gerlitz
. Internal steering rule for those QPs is automatically-generated upon their creation. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c| 106 +- drivers/infiniband/hw/mlx4

[PATCH for-next 5/6] IB/mlx4_ib: Add mechanism to support flow-steering over IB links

2013-11-07 Thread Or Gerlitz
. Furthermore, the device requires the qpn to be put in the rule. Add here specific parsing support for IB empty rules and the ability to self-generate missing specs based on existing ones. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers

[PATCH for-next 2/6] IB/core: Add support for IB L2 device managed steering

2013-11-07 Thread Or Gerlitz
-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- include/rdma/ib_verbs.h | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index bb81c37..887e096 100644 --- a/include/rdma

[PATCH for-next 3/6] net/mlx4_core: Add support for steer-able IB UD QPs

2013-11-07 Thread Or Gerlitz
Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/net/ethernet/mellanox/mlx4/cmd.c |9 + drivers/net/ethernet/mellanox/mlx4/fw.c| 10 ++ drivers/net/ethernet/mellanox/mlx4/mcg.c | 17 + drivers

[PATCH for-next 0/6] Add flow steering support for IPoIB

2013-11-07 Thread Or Gerlitz
Hi Roland, This series adds on the flow-steering patches that were merged in 3.12 Now flow steering rules can be set such that they steer UD traffic targeted to IPoIB netdevice into applications IB UD QP. For that end, IPoIB provides hint to the low-level device through a QP creation flag that

[PATCH for-next 4/6] IB/mlx4_ib: Enable device managed steering support for IB ports too

2013-11-07 Thread Or Gerlitz
...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c| 31 +++ drivers/infiniband/hw/mlx4/mlx4_ib.h |1 + 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers

[PATCH for-next 1/6] IB/core: Add flow-steering support for IPoIB UD traffic

2013-11-07 Thread Or Gerlitz
RAW_PACKET QPs. The hint is provided through new QP creation flag called NETIF_QP. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib_verbs.c |3 +++ include/rdma/ib_verbs.h|1 + 2 files

Re: [PATCH v3 00/10] Introduce Signature feature

2013-11-07 Thread Or Gerlitz
On Thu, Nov 7, 2013 at 5:53 PM, Sagi Grimberg sa...@mellanox.com wrote: This patchset Introduces Verbs level support for signature handover feature. Siganture is intended to implement end-to-end data integrity on a transactional basis in a completely offloaded manner. Hi Roland, The patch

Re: [PATCH for -next v2 6/7] IB/core: extended command: an improved infrastructure for uverbs commands

2013-11-08 Thread Or Gerlitz
On Fri, Nov 8, 2013 at 12:01 PM, Yann Droneaud ydrone...@opteya.com wrote: Hi, It seems that even after so many iterations, I failed to provide a perfect patch. You, that perfect is the biggest enemy of the excellent, it (patches/code) is what it is (human made) and sometimes things need to

Re: failure to get gid with rdma_bind_addr with = 3.10 kernels

2013-11-10 Thread Or Gerlitz
On 10/11/2013 13:10, Or Gerlitz wrote: So somewhere between 3.10 and 3.11 between 3.10 and 3.12 -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH for -next v2 6/7] IB/core: extended command: an improved infrastructure for uverbs commands

2013-11-10 Thread Or Gerlitz
On Sat, Nov 9, 2013 at 12:22 AM, Roland Dreier rol...@purestorage.com wrote: On Fri, Nov 8, 2013 at 2:01 AM, Yann Droneaud ydrone...@opteya.com wrote: Will roll a v3 if Roland have not yet picked the patchset. I'll roll that cleanup into this patch as I apply it (now). Hi Roland, I don't see

Re: failure to get gid with rdma_bind_addr with = 3.10 kernels

2013-11-11 Thread Or Gerlitz
On 11/11/2013 20:46, Hefty, Sean wrote: Yes - something like this patch should help, but I don't think this is the correct behavior when the IP address is 'any' addresss. Retrieve SGID after calling rdma_bind_addr From: Sean Heftysean.he...@intel.com A change was made to rdma_bind_addr when

[PATCH V5 8/8] mlx4_en: Avoid setting netdevice dev_id to port number

2013-11-13 Thread Or Gerlitz
netdevices. Signed-off-by: Narendra K narendr...@dell.com Signed-off-by: Moni Shoua mo...@mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet

[PATCH V5 6/8] IB/ocrdma: Populate GID table with IP based gids

2013-11-13 Thread Or Gerlitz
from the device's gid table. The gid format will be a IPv4 to IPv6 mapped or the IPv6 address. Cc: Naresh Gottumukkala bgottumukk...@emulex.com Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/ocrdma/ocrdma_main.c | 138

[PATCH V5 4/8] IB/mlx4: Handle Ethernet L2 parameters for IP based GID addressing

2013-11-13 Thread Or Gerlitz
, instead of parsing the dgid to get the MAC and VLAN, take them from the address handle attributes. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/ah.c | 40 +++- drivers/infiniband/hw/mlx4/cq.c

[PATCH V5 7/8] IB/uverbs: Resolve Ethernet L2 addresses when modifying QP

2013-11-13 Thread Or Gerlitz
in the user-kernel linking piece - uverbs. Signed-off-by: Moni Shoua mo...@mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/uverbs_cmd.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/core

[PATCH V5 1/8] IB/core: Ethernet L2 attributes in verbs/cm structures

2013-11-13 Thread Or Gerlitz
are modified to support the new function signature. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/addr.c | 97 ++- drivers/infiniband/core/cm.c| 50

[PATCH V5 0/8] IP based RoCE GID Addressing

2013-11-13 Thread Or Gerlitz
changes from V4: - addressed feedback re the need to be compatible with non modified user space applications/libraries, by adding code in uverbs which does address resolution when dealing with Ethernet ports. This is patch #7 - removed the patches that deal with uverbs extended

[PATCH V5 2/8] IB/CMA: IBoE (RoCE) IP based GID addressing

2013-11-13 Thread Or Gerlitz
parameters are not longer encoded within gids, had to extend the Infiniband address structures (e.g. ib_ah_attr) with layer 2 address parameters, namely mac and vlan. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Moni Shoua mo

[PATCH V5 5/8] IB/ocrdma: Handle Ethernet L2 parameters for IP based GID addressing

2013-11-13 Thread Or Gerlitz
the dgid to get the MAC and VLAN, take them from the address handle attributes. Cc: Naresh Gottumukkala bgottumukk...@emulex.com Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/ocrdma/ocrdma.h| 12 drivers

[PATCH V5 3/8] IB/mlx4: Use IBoE (RoCE) IP based GIDs in the port GID table

2013-11-13 Thread Or Gerlitz
on top of that port so this should be considered when building and maintaining the gid table. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c| 474 -- drivers/infiniband/hw/mlx4

Re: failure to get gid with rdma_bind_addr with = 3.10 kernels

2013-11-13 Thread Or Gerlitz
On Wed, Nov 13, 2013 at 10:15 PM, Hefty, Sean sean.he...@intel.com wrote: Sean, how do we continue here? the patch worked for Christoph, so are going to merge it into librdmacm or it needs more work? I will merge it, since it fixes the issue. cool -- To unsubscribe from this list: send the

Re: [PATCH v3 00/10] Introduce Signature feature

2013-11-13 Thread Or Gerlitz
On 14/11/2013 02:19, Hefty, Sean wrote: The patch series is around for couple of weeks already and went through the review of Sean and Bart, with all their feedback being applied. Also Sagi and Co enhanced krping to fully cover (and test...) the proposed API and driver implementation

Re: [PATCH v3 00/10] Introduce Signature feature

2013-11-14 Thread Or Gerlitz
On Thu, Nov 14, 2013 at 9:03 PM, Hefty, Sean sean.he...@intel.com wrote: To begin with T10 DIF **is** industry standard, which is to be used in production storage systems, the feature here is T10 DIF acceleration for upstream kernel storage drivers such as iSER/SRP/FCoE initiator/targets that

Re: [PATCH for -next v2 6/7] IB/core: extended command: an improved infrastructure for uverbs commands

2013-11-16 Thread Or Gerlitz
On Sat, Nov 9, 2013 Roland Dreier rol...@purestorage.com wrote: On Fri, Nov 8, 2013 Yann Droneaud ydrone...@opteya.com wrote: Will roll a v3 if Roland have not yet picked the patchset. I'll roll that cleanup into this patch as I apply it (now). Hi Roland, just to make sure this doesn't fall

Re: [PATCH for-next 0/6] Add flow steering support for IPoIB

2013-11-16 Thread Or Gerlitz
On Thu, Nov 7,Or Gerlitz ogerl...@mellanox.com wrote: This series adds on the flow-steering patches that were merged in 3.12 Now flow steering rules can be set such that they steer UD traffic targeted to IPoIB netdevice into applications IB UD QP. For that end, IPoIB provides hint to the low

Re: [PATCH V5 0/8] IP based RoCE GID Addressing

2013-11-16 Thread Or Gerlitz
On Thu, Nov 14, 2013 at 12:29 AM, Or Gerlitz ogerl...@mellanox.com wrote: changes from V4: - addressed feedback re the need to be compatible with non modified user space applications/libraries, by adding code in uverbs which does address resolution when dealing with Ethernet ports

Re: [PATCH for-next 0/6] Add flow steering support for IPoIB

2013-11-16 Thread Or Gerlitz
On 16/11/2013 21:35, Or Gerlitz wrote: On Thu, Nov 7,Or Gerlitzogerl...@mellanox.com wrote: This series adds on the flow-steering patches that were merged in 3.12 Now flow steering rules can be set such that they steer UD traffic targeted to IPoIB netdevice into applications IB UD QP

Infiniband merge plans for 3.13

2013-11-18 Thread Or Gerlitz
Hi Roland, So it seems your for-next branch gets hot toward pull request to Linus. Can you spare few words on how you see the IP based Addressing V5 series?! we have addressed the concerns you raised re compatibility and also simplified the series to avoid using uverbs extensions @ this point,

Re: [GIT PULL] please pull infiniband.git

2013-11-19 Thread Or Gerlitz
On 18/11/2013 20:40, Roland Dreier wrote: Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus Main batch of InfiniBand/RDMA changes for 3.13: - Re-enable

Re: [PATCH V5 7/8] IB/uverbs: Resolve Ethernet L2 addresses when modifying QP

2013-11-19 Thread Or Gerlitz
On Tue, Nov 19, 2013 at 8:08 PM, Roland Dreier rol...@kernel.org wrote: Existing user space applications provide only IBoE L3 address attributes to the kernel when they issue QP modify. To comply with them and let such apps to keep work transparently under the IBoE GID IP addressing changes,

Re: [PATCH V5 7/8] IB/uverbs: Resolve Ethernet L2 addresses when modifying QP

2013-11-20 Thread Or Gerlitz
On 20/11/2013 09:15, Somnath Kotur wrote: However, in the approach to move address resolution to core verbs i.e. ib_modify_qp() and ib_create_ah(), vendor driver will have freedom to resolve l2 addresses in its own way. This I am not sure if it's a good idea for each vendor driver to implement

Re: [PATCH V5 7/8] IB/uverbs: Resolve Ethernet L2 addresses when modifying QP

2013-11-20 Thread Or Gerlitz
On 20/11/2013 09:15, Somnath Kotur wrote: However, in the approach to move address resolution to core verbs i.e. ib_modify_qp() and ib_create_ah(), vendor driver will have freedom to resolve l2 addresses in its own way. This I am not sure if it's a good idea for each vendor driver to implement

[PATCH librdmacm] Add directives on binding to IPv6 any address to man pages

2013-11-28 Thread Or Gerlitz
Explain how to bind to IPv6 any address in the man pages for the examples Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- man/rping.1|1 + man/ucmatose.1 |1 + man/udaddy.1 |1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/man/rping.1 b/man/rping.1 index

Re: [PATCH librdmacm] Add directives on binding to IPv6 any address to man pages

2013-11-28 Thread Or Gerlitz
On Thu, Nov 28, 2013 at 5:38 PM, Or Gerlitz ogerl...@mellanox.com wrote: Explain how to bind to IPv6 any address in the man pages for the examples Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- man/rping.1|1 + man/ucmatose.1 |1 + man/udaddy.1 |1 + 3 files changed

[PATCH V1 librdmacm] Add directives on binding to IPv6 any address to man pages

2013-11-30 Thread Or Gerlitz
Explain how to bind to IPv6 any address in the man pages for the examples Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- changes from V0: - fixed cut paste error in the bind directive for ucmatose/udaddy man/rping.1|1 + man/ucmatose.1 |1 + man/udaddy.1 |1 + 3 files

[PATCH for-next] mlx4_core: Roll back round robin bitmap allocation commit for CQs, SRQs, and MPTs

2013-12-08 Thread Or Gerlitz
. We therefore roll back the round-robin allocator modification for MPTs, CQs, SRQs. Reported-by: Matthew Finlay m...@mellanox.com Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/net/ethernet/mellanox/mlx4/alloc.c | 12

Re: [PATCH v3 00/10] Introduce Signature feature

2013-12-11 Thread Or Gerlitz
On Thu, Nov 14, 2013 at 10:11 PM, Or Gerlitz or.gerl...@gmail.com wrote: On Thu, Nov 14, 2013 at 9:03 PM, Hefty, Sean sean.he...@intel.com wrote: To begin with T10 DIF **is** industry standard, which is to be used in production storage systems, the feature here is T10 DIF acceleration

Re: [PATCH V5 7/8] IB/uverbs: Resolve Ethernet L2 addresses when modifying QP

2013-12-11 Thread Or Gerlitz
On Tue, Nov 19, 2013 at 10:48 PM, Or Gerlitz or.gerl...@gmail.com wrote: On Tue, Nov 19, 2013 at 8:08 PM, Roland Dreier rol...@kernel.org wrote: Existing user space applications provide only IBoE L3 address attributes to the kernel when they issue QP modify. To comply with them and let

Re: [PATCH V5 7/8] IB/uverbs: Resolve Ethernet L2 addresses when modifying QP

2013-12-11 Thread Or Gerlitz
On Wed, Dec 11, 2013 at 7:59 PM, Roland Dreier rol...@kernel.org wrote: OK, I guess I'm still confused. Do we have two ways of resolving addresses, one way for consumers that use the RDMA CM and another way for consumers that don't? Does that mean we end up having two different paths

[PATCH V6 for-next 6/7] IB/ocrdma: Populate GID table with IP based gids

2013-12-12 Thread Or Gerlitz
from the device's gid table. The gid format will be a IPv4 to IPv6 mapped or the IPv6 address. Cc: Naresh Gottumukkala bgottumukk...@emulex.com Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/ocrdma/ocrdma_main.c | 138

[PATCH V6 for-next 5/7] IB/ocrdma: Handle Ethernet L2 parameters for IP based GID addressing

2013-12-12 Thread Or Gerlitz
the dgid to get the MAC and VLAN, take them from the address handle attributes. Cc: Naresh Gottumukkala bgottumukk...@emulex.com Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/ocrdma/ocrdma.h| 12 drivers

[PATCH V6 for-next 4/7] IB/mlx4: Handle Ethernet L2 parameters for IP based GID addressing

2013-12-12 Thread Or Gerlitz
, instead of parsing the dgid to get the MAC and VLAN, take them from the address handle attributes. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/ah.c | 40 +++- drivers/infiniband/hw/mlx4/cq.c

[PATCH V6 for-next 3/7] IB/mlx4: Use IBoE (RoCE) IP based GIDs in the port GID table

2013-12-12 Thread Or Gerlitz
on top of that port so this should be considered when building and maintaining the gid table. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c| 474 -- drivers/infiniband/hw/mlx4

[PATCH V6 for-next 0/7] IP based RoCE GID Addressing

2013-12-12 Thread Or Gerlitz
/ocrdma: Handle Ethernet L2 parameters for IP based GID addressing IB/ocrdma: Populate GID table with IP based gids Or Gerlitz (1): IB/core: Resolve Ethernet L2 addresses when modifying QP drivers/infiniband/core/addr.c | 97 ++- drivers/infiniband/core/cm.c

[PATCH V6 for-next 2/7] IB/CMA: IBoE (RoCE) IP based GID addressing

2013-12-12 Thread Or Gerlitz
parameters are not longer encoded within gids, had to extend the Infiniband address structures (e.g. ib_ah_attr) with layer 2 address parameters, namely mac and vlan. Signed-off-by: Moni Shoua mo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Moni Shoua mo

[PATCH V6 for-next 1/7] IB/core: Ethernet L2 attributes in verbs/cm structures

2013-12-12 Thread Or Gerlitz
are modified to support the new function signature. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/addr.c | 97 ++- drivers/infiniband/core/cm.c| 50

Re: [PATCH v3 00/10] Introduce Signature feature

2013-12-15 Thread Or Gerlitz
On 11/12/2013 19:26, Or Gerlitz wrote: Hi Roland, these patches are in the air for two months (V0 posted Oct 15th http://marc.info/?l=linux-rdmam=138185152212490w=2) and not a word from you. Sagi will be posting V4 soon with the latest cut of the code, rebased to 3.13-rc and containing some

Re: [PATCH V9 libibverbs 0/7] Add extension and XRC QP support

2013-12-16 Thread Or Gerlitz
On Mon, Dec 16, 2013 at 9:16 PM, Roland Dreier rol...@purestorage.com wrote: OK, I finally got to merge this to libibverbs. Please take a look at my libibverbs git tree and let me know if there is any issue with the verbs extensions or XRC support. Roland, your libibverbs tree which includes

Re: [PATCH V6 for-next 0/7] IP based RoCE GID Addressing

2013-12-16 Thread Or Gerlitz
On Thu, Dec 12, 2013, Or Gerlitz ogerl...@mellanox.com wrote: Changes from V5: - moved the address resolution helper from the uverbs layer to the ib_core module where it belongs. This will also allow to run kernel consumers who don't use the rdma-cm Hi Roland, Anything else, or we

Re: [PATCHv4 for-3.13 00/10] create_flow/destroy_flow fixes for v3.13

2013-12-17 Thread Or Gerlitz
On Tue, Dec 17, 2013 at 11:58 AM, Yann Droneaud ydrone...@opteya.com wrote: Hi Roland, Please find the fourth revision of a patchset against create_flow/destroy_flow and associated extended command scheme. Yann, note that V3 is already applied, so you need to change incremental changes -- To

git tree with pending patch sets

2013-12-19 Thread Or Gerlitz
Hi Everyone, Wanted to let people know that I have set a public git tree with pending patch sets sent by Mellanox over the last months, you can pull git://beany.openfabrics.org/~ogerlitz/linux-2.6.git for-next where this branch is rebased against the for-next branch of Roland's tree

Re: [PATCHv4 for-3.13 00/10] create_flow/destroy_flow fixes for v3.13

2013-12-19 Thread Or Gerlitz
On 19/12/2013 15:21, Yann Droneaud wrote: [...] So I hope the infiniband/for-next branch could be rewrote I am OK with that. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH V6 for-next 0/7] IP based RoCE GID Addressing

2013-12-19 Thread Or Gerlitz
Hi Roland, If it helps, you can pull this series from the git tree I posted earlier today git://beany.openfabrics.org/~ogerlitz/linux-2.6.git for-next -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/4] DAPL: Support for Linux on System z in libibverbs library

2013-12-19 Thread Or Gerlitz
On Thu, Dec 19, 2013, Alexey Ishchuk alexey_ishc...@ru.ibm.com wrote: * new Infiniband verb command identifier. The new Infiniband verb command was added to allow data transfer from user space applications to infiniband devices on System z. and does what? also note that your patches

Re: failure to get gid with rdma_bind_addr with = 3.10 kernels

2014-01-02 Thread Or Gerlitz
Hi Sean, Can you please prepare a fresh (gift to 2014) release of librdmacm, such that distributions people using kernels = 3.11 will be able to have this functionality restored once they upgrade librdmacm. thanks -- Or -- To unsubscribe from this list: send the line unsubscribe linux-rdma

Re: failure to get gid with rdma_bind_addr with = 3.10 kernels

2014-01-04 Thread Or Gerlitz
On 02/01/2014 19:04, Hefty, Sean wrote: Can you please prepare a fresh (gift to 2014) release of librdmacm, such that distributions people using kernels = 3.11 will be able to have this functionality restored once they upgrade librdmacm. There's a 1.0.17.1 release available with this fix.

linux rdma 3.14 merge plans

2014-01-07 Thread Or Gerlitz
Hi Roland, Currently there is single patch for 3.14 on your for-next branch, the usnic driver. With 3.13 being on rc7 and likely to be released next week, are you planning any other merges for 3.14? we have patches waiting for weeks and months without any comment from you. Or. -- To unsubscribe

Re: [PATCH for-next] IB/usnic: Expose flows via debugfs

2014-01-08 Thread Or Gerlitz
for exporting HW dependent attributes to user space -- did you look on that? Also, you should make sure to expose the non HW specific attributes of the sessions through the standard infrastructure. Or. Upinder On Dec 22, 2013, at 2:23 AM, Or Gerlitz ogerl...@mellanox.com wrote: On 20/12

Re: linux rdma 3.14 merge plans

2014-01-08 Thread Or Gerlitz
On 08/01/2014 02:51, Roland Dreier wrote: The data integrity stuff I'm not so sure about. Sean raised some I think legitimate questions about whether all this should be added to the verbs API and I want to see more discussion or at least have a deep think about this myself before comitting.

Re: [PATCH 06/11] IB/isert: Initialize T10-PI resources

2014-01-11 Thread Or Gerlitz
On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg sa...@mellanox.com wrote: @@ -557,8 +629,14 @@ isert_connect_request(struct rdma_cm_id *cma_id, struct rdma_cm_event *event) goto out_mr; } + if (pi_support !device-pi_capable) { + pr_err(Protection

Re: [PATCH 09/11] IB/isert: Accept RDMA_WRITE completions

2014-01-11 Thread Or Gerlitz
On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg sa...@mellanox.com wrote: In case of protected transactions, we will need to check the protection status of the transaction before sending SCSI response. So be ready for RDMA_WRITE completions. currently we don't ask for these completions, but for

Re: [PATCH for-next] IB/usnic: Expose flows via debugfs

2014-01-12 Thread Or Gerlitz
be easily extended and extra effort is required to get to them. Upinder On Jan 8, 2014, at 1:13 AM, Or Gerlitz ogerl...@mellanox.com wrote: On 08/01/2014 00:29, Upinder Malhi (umalhi) wrote: Or, The flows contain Cisco VIC specific stuff - Ex. the hardware flow id; and they will contain more cisco

Re: [PATCH 06/11] IB/isert: Initialize T10-PI resources

2014-01-12 Thread Or Gerlitz
On 12/01/2014 14:41, Sagi Grimberg wrote: --- a/drivers/infiniband/ulp/isert/ib_isert.h +++ b/drivers/infiniband/ulp/isert/ib_isert.h @@ -48,11 +48,21 @@ struct iser_tx_desc { struct ib_send_wr send_wr; } __packed; +struct pi_context { + struct ib_mr *prot_mr;

Re: [PATCH for-next] IB/usnic: Expose flows via debugfs

2014-01-13 Thread Or Gerlitz
On Tue, Jan 14, 2014 at 12:14 AM, Upinder Malhi (umalhi) uma...@cisco.com wrote: We are happy to use netlink if it makes sense. What you are saying is: Netlink is used all over the kernel. Bc it is used all over the kernel, it must be the right answer for all userspace/kernel interactions.

Re: linux rdma 3.14 merge plans

2014-01-16 Thread Or Gerlitz
On Thu, Jan 16, 2014 at 11:37 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jan 16, 2014 at 01:14:12PM -0800, Nicholas A. Bellinger wrote: On Thu, 2014-01-16 at 12:13 -0800, Roland Dreier wrote: On Mon, 2014-01-13 at 12:32 -0800, Nicholas A. Bellinger wrote: Hi Roland

Re: [PATCH for-next] IB/mlx4: Add dependency INET

2014-01-19 Thread Or Gerlitz
On 16/01/2014 17:16, Matan Barak wrote: Since mlx4_ib supports IP based addressing, a dependency on INET should be added. This is mandatory since mlx4_ib registers itself to net device events. Signed-off-by: Matan Barak mat...@mellanox.com --- Hi Roland, The mlx4_ib driver registers itself to

Re: linux rdma 3.14 merge plans

2014-01-20 Thread Or Gerlitz
On Sun, Jan 19, 2014 at 1:20 PM, sagi grimberg sa...@mellanox.com wrote: Thanks Nic, let me elaborate on this, It is true that T10-PI aims for end-to-end data-integrity, the verbs API offer HW offload for protection information processing which is VERY expensive for CPU computation (CRC

Re: linux rdma 3.14 merge plans

2014-01-21 Thread Or Gerlitz
On Mon, Jan 20, 2014, Or Gerlitz or.gerl...@gmail.com wrote: On Sun, Jan 19, 2014, sagi grimberg sa...@mellanox.com wrote: Thanks Nic, let me elaborate on this, [...] Hope this helps, Hi Roland, with Nic's Sagi's answers @ hand, were your questions resolved? Roland, ping! the signature

Re: linux rdma 3.14 merge plans

2014-01-21 Thread Or Gerlitz
On Wed, Jan 22, 2014 at 2:43 AM, Roland Dreier rol...@kernel.org wrote: On Tue, Jan 21, 2014 at 2:00 PM, Or Gerlitz or.gerl...@gmail.com wrote: Roland, ping! the signature patches were posted three months ago. We deserve a response from the maintainer that goes beyond I need to think

Re: [PATCH for-next V1 0/2] Fix build warnings in the IB core and mlx4_ib

2014-01-22 Thread Or Gerlitz
On Sun, Nov 3, 2013 at 10:20 AM, Or Gerlitz ogerl...@mellanox.com wrote: Hi Roland, This little patch set removes the current make W=1 build warnings from the IB core and the mlx4_ib driver, which would help when we examine new patches to make sure they don't add any warnings.. Hi Roland

[PATCH for-next] IB/iser: Suppress completion for fast registration work requests

2014-01-23 Thread Or Gerlitz
...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |2 ++ drivers/infiniband/ulp/iser/iser_memory.c | 15 --- drivers/infiniband/ulp/iser/iser_verbs.c | 14 ++ 3 files changed, 12 insertions(+), 19 deletions

Re: [PATCH for-next V1 1/2] IB/core: Fix build warnings

2014-01-23 Thread Or Gerlitz
On 23/01/2014 11:47, Yann Droneaud wrote: Hi, Le dimanche 03 novembre 2013 à 10:20 +0200, Or Gerlitz a écrit : Fix the below few make W=1 build warnings we have on the IB core. drivers/infiniband/core/sysfs.c: In function ‘state_show’: drivers/infiniband/core/sysfs.c:107: warning: comparison

Re: How to find what's holding uverbs from detaching an Infiniband SR-IOV VF?

2014-01-23 Thread Or Gerlitz
On Thu, Jan 23, 2014 at 3:25 PM, Vangelis Tasoulas vange...@simula.no wrote: I am trying to detach an Infiniband SR-IOV Virtual Function with active communication (perftest ib_send_bw --rdma_cm is running) from a Virtual Machine, with the intention to eventually migrate it. The problem in

[PATCH] IB: Refactor umem to use linear SG table

2014-01-28 Thread Or Gerlitz
From: Yishai Hadas yish...@mellanox.com This patch does refactoring of the IB core umem code and vendor drivers to use linear SG table instead of chunk list. With this change the relevant code becomes more clear, no need for nested loops to build and use umem. The patch includes: umem changes

Re: [PATCH] IB: Refactor umem to use linear SG table

2014-01-28 Thread Or Gerlitz
On 28/01/2014 13:40, Or Gerlitz wrote: From: Yishai Hadasyish...@mellanox.com This patch does refactoring of the IB core umem code and vendor drivers to use linear SG table instead of chunk list. With this change the relevant code becomes more clear, no need for nested loops to build and use

Re: linux rdma 3.14 merge plans

2014-01-28 Thread Or Gerlitz
On Wed, Jan 22, 2014, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 1/22/2014 2:43 AM, Roland Dreier wrote: On Tue, Jan 21, 2014, Or Gerlitz or.gerl...@gmail.com wrote: Roland, ping! the signature patches were posted three months ago. We deserve a response from the maintainer that goes

Re: linux rdma 3.14 merge plans

2014-01-29 Thread Or Gerlitz
On 29/01/2014 17:06, Sagi Grimberg wrote: Non-contiguous buffers are a well known problem/challenge for RDMA transports, each handles them differently: iSER uses bounce buffers, SRP registers multiple contiguous regions. To be precise, we do it only on very special cases, normally the payload

Re: linux rdma 3.14 merge plans

2014-01-30 Thread Or Gerlitz
On 29/01/2014 19:56, Bart Van Assche wrote: On 01/29/14 16:06, Sagi Grimberg wrote: Didn't understand why should it matter where the copy is done (iser/block)? In the Linux kernel community it is considered important to avoid code duplication. Hence the proposal to keep code that copies data

Re: linux rdma 3.14 merge plans

2014-01-30 Thread Or Gerlitz
On 30/01/2014 12:07, Bart Van Assche wrote: On 01/30/14 09:19, Or Gerlitz wrote: Thanks for narrowing this down, I see your point, however the solution I propose if to remove this copy altogether... for those rare cases where fast-registration can't be done -- in SRP I think the code goes

Re: [patch] IB/iser: use after free in iser_snd_completion()

2014-01-30 Thread Or Gerlitz
On Wed, Jan 29, 2014, Dan Carpenter dan.carpen...@oracle.com wrote: We use tx_desc again after we free it. yep, this is legacy code which isn't much of use over the last years and hence the bug went in unnoticed Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git

Re: [patch] IB/iser: use after free in iser_snd_completion()

2014-01-30 Thread Or Gerlitz
On Thu, Jan 30, 2014 at 11:04 PM, Or Gerlitz or.gerl...@gmail.com wrote: On Wed, Jan 29, 2014, Dan Carpenter dan.carpen...@oracle.com wrote: We use tx_desc again after we free it. yep, this is legacy code which isn't much of use over the last years and hence the bug went in unnoticed Acked

Re: [ewg] [ANNOUNCE] opensm 3.3.17 release

2014-01-31 Thread Or Gerlitz
On Thu, Jan 30, 2014 , Hal Rosenstock h...@dev.mellanox.co.il wrote: There is a new 3.3.17 release of OpenSM. Tarball is available in: http://www.openfabrics.org/downloads/management/ (listed in http://www.openfabrics.org/downloads/management/latest.txt) md5sum:

librdmacm 1.0.18 + more

2014-02-01 Thread Or Gerlitz
Hi Sean, I just noted you've tagged librdmacm 1.0.18 last week, but there was no announce email, was it just forgotten or something is stillmissing there? Also, on a related note, I saw there a commit saying that udaddy will not support the IB port space anymore. Does rpingsupport native IB

[PATCH for-3.14] IB/mlx4: Don't allocate range of steerable UD QPs for Ethernet-only device

2014-02-02 Thread Or Gerlitz
for steerable IB UD QPs') Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw

[PATCH for-3.14] IB/mlx4: Report using RoCE IP based gids in port caps

2014-02-02 Thread Or Gerlitz
...@mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c |2 +- include/rdma/ib_verbs.h |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index c2702f5

[PATCH libibverbs 3/3] Add ibv_query_port_ex support

2014-02-02 Thread Or Gerlitz
. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- include/infiniband/verbs.h | 102 src/device.c |2 + src/verbs.c|7 ++- 3 files changed, 109 insertions(+), 2 deletions

[PATCH libibverbs 0/3] Add support for UD QPs under RoCE IP addressing

2014-02-02 Thread Or Gerlitz
Hi Roland, This series adds support for Ethernet L2 address resolution for UD QPs, whose L2 address-handles, unlike RC/UC/XRC/etc QPs are set from user space without going through uverbs and the kernel IB core. Matan and Or. Matan Barak (3): Add ibv_port_cap_flags Use neighbour lookup for

[PATCH libibverbs 1/3] Add ibv_port_cap_flags

2014-02-02 Thread Or Gerlitz
...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- include/infiniband/verbs.h | 24 +++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/include/infiniband/verbs.h b/include/infiniband/verbs.h index 5064636..ba29919 100644 --- a/include/infiniband

[PATCH libibverbs 2/3] Use neighbour lookup for RoCE UD QPs Eth L2 resolution

2014-02-02 Thread Or Gerlitz
the neigh table c. query neigh table in order to know if the neigh has shown up between query until we started monitoring it 6. query vlan id from the interface This solution depends on libnl v1. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com

[PATCH libmlx4 0/2] Add support for UD QPs under RoCE IP addressing

2014-02-02 Thread Or Gerlitz
Hi Roland and Yishai This series adds support for Ethernet L2 address resolution for UD QPs, whose L2 address-handles, unlike RC/UC/XRC/etc QPs are set from user space without going through uverbs and the kernel IB core. Matan and Or. Matan Barak (2): Add RoCE IP based addressing support for

[PATCH libmlx4 1/2] Add RoCE IP based addressing support for UD QPs

2014-02-02 Thread Or Gerlitz
and vlan-id params from libibverbs and sets the mlx4_ah relevant attributes. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- src/mlx4.c |3 ++ src/mlx4.h |2 + src/verbs.c | 68 +- 3

[PATCH libmlx4 2/2] Add ibv_query_port_ex support

2014-02-02 Thread Or Gerlitz
for optimizations. Also, it adds caching of link layer's type and the port caps. Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- src/mlx4.c |4 +++ src/mlx4.h |9 +++ src/verbs.c | 78

<    8   9   10   11   12   13   14   15   16   17   >