Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-27 Thread Or Gerlitz
On Tue, Nov 27, 2012 at 6:34 PM, Bart Van Assche wrote: > Thanks Dave for doing all this work. A reworked and retested patch series > that should address all comments that have been posted so far can be found > here: http://github.com/bvanassche/linux/srp-ha. I can repost the entire > patch series

Re: Updated Debian packages?

2012-11-28 Thread Or Gerlitz
On 28/11/2012 11:46, Roland Dreier wrote: On Tue, Nov 27, 2012 at 12:35 PM, Christoph Lameter wrote: Roland, we need the raw eth qp patches in the git trees for the libraries. Could you please bring the trees up to date so that the userspace raw eth support is in sync with the kernel? Do you

Re: rsockets and fork

2012-11-29 Thread Or Gerlitz
On Fri, Aug 24, 2012 at 8:35 PM, Hefty, Sean wrote: >> I don't think those mmap()s should be an issue with fork they are >> mapping adapter PCI space into userspace, but it should work across fork. > makes sense > Do you have any ideas on ways to identify what in the initialization paths > m

[PATCH librdmacm] Fixed build problem due to missing macro

2012-12-02 Thread Or Gerlitz
rsocket.c wasn't passing compilation as of missing definition for the container_of macro, fix it. Reported-by: Eyal Salamon Signed-off-by: Or Gerlitz --- src/cma.c |5 - src/cma.h |6 ++ src/rsocket.c |1 + 3 files changed, 7 insertions(+), 5 deletions(-)

Re: rsockets and fork

2012-12-02 Thread Or Gerlitz
On 29/11/2012 18:27, Hefty, Sean wrote: Fork support in rsockets is available now, and netperf should work. Sean, Trying the latest librdamcm git (+ the patch I sent to have it build OK), we weren't able to run netperf here's the server output starting netserver with host '192.168.20.126'

Re: rsockets and fork

2012-12-02 Thread Or Gerlitz
On 29/11/2012 18:27, Hefty, Sean wrote: Fork support in rsockets is available now, and netperf should work. Sean, Trying the latest librdamcm git (+ the patch I sent to have it build OK), we weren't able to run netperf here's the server output starting netserver with host '192.168.20.126'

Re: [PATCH librdmacm] Fixed build problem due to missing macro

2012-12-03 Thread Or Gerlitz
On Mon, Dec 3, 2012 at 9:35 PM, Hefty, Sean wrote: > I'm using a locally modified version of verbs, so I don't end up seeing this > error. could this be related to different results while running netperf .w fork in our setup vs. yours? Or. -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH librdmacm] Fixed build problem due to missing macro

2012-12-04 Thread Or Gerlitz
On Mon, Dec 3, 2012 at 9:48 PM, Hefty, Sean wrote: > > According to my notes, I ran netperf with fork support using this: yep, works just fine with this directive - we got 46Gbs, impressive! Or. > server > -- > export RDMAV_FORK_SAFE=1 > LD_PRELOAD=/usr/local/lib/rsocket/librspreload.so ne

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Or Gerlitz
On Fri, Nov 30, 2012 at 4:21 AM, David Dillow wrote: [...] > Modulo a few style issues (braces around one line if branches, etc.) and > having three state variables vs one, I can live with everything up to > aabfa852acd27962 at git://github.com/bvanassche/linux.git#srp-ha. Those > two are small th

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Or Gerlitz
On Wed, Dec 5, 2012 at 8:50 PM, Bart Van Assche wrote: [...] > The only way to make I/O work reliably if a failure can occur at the > transport layer is to use multipathd on top of ib_srp. If a connection fails > for some reason, then the SRP SCSI host will be removed after the SCSI error > handle

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-06 Thread Or Gerlitz
On 06/12/2012 16:10, Bart Van Assche wrote: On 12/05/12 22:32, Or Gerlitz wrote: On Wed, Dec 5, 2012 at 8:50 PM, Bart Van Assche wrote: [...] The only way to make I/O work reliably if a failure can occur at the transport layer is to use multipathd on top of ib_srp. If a connection fails for

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-06 Thread Or Gerlitz
On 06/12/2012 17:04, Bart Van Assche wrote: On 12/06/12 15:27, Or Gerlitz wrote: The core problem here seems to be that scsi_remove_host simply never ends. Hello Or, The later patches in the srp-ha patch series avoided such behavior by checking whether the connection between SRP initiator

[FIXES for-next 4/4] mlx4_core: Allow choosing flow steering mode

2012-12-06 Thread Or Gerlitz
river will use the value of log_num_mgm_entry_size and B0 steering. Signed-off-by: Jack Morgenstein Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx4/main.c | 52 drivers/net/ethernet/mellanox/mlx4/mcg.c |7 +--- drivers/net/ethernet/mellanox/mlx4/m

[FIXES for-next 2/4] mlx4_core: Fix wrong error flow in the flow steering wrapper

2012-12-06 Thread Or Gerlitz
From: Hadar Hen Zion The error flow of the flow steering wrapper had a typo which caused the wrong firmware command to be called, fix it. Signed-off-by: Hadar Hen Zion Signed-off-by: Or Gerlitz --- .../net/ethernet/mellanox/mlx4/resource_tracker.c |2 +- 1 files changed, 1 insertions

[FIXES for-next 1/4] mlx4_core: Add QPN enforcement for flow steering rules set by VFs

2012-12-06 Thread Or Gerlitz
ation from the resource tracker point of view. Signed-off-by: Hadar Hen Zion Signed-off-by: Or Gerlitz --- .../net/ethernet/mellanox/mlx4/resource_tracker.c | 26 +++ 1 files changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox

[FIXES for-next 0/4] mlx4_core SRIOV and Flow-Steering adjustments and fixes

2012-12-06 Thread Or Gerlitz
Hi Roland, The patch set fixes few issues we've identified and fixed in the mlx4_core driver around SRIOV and device managed flow steering. This includes adding QPN enforcement in the resource tracker for flow-steering rules set by VFs, and a fix to wrong error flow in the very same area in pa

[FIXES for-next 3/4] mlx4_core: Adjustments to Flow Steering activation logic for SRIOV

2012-12-06 Thread Or Gerlitz
: Jack Morgenstein Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx4/fw.c | 15 +- drivers/net/ethernet/mellanox/mlx4/fw.h |1 + drivers/net/ethernet/mellanox/mlx4/main.c | 71 - 3 files changed, 62 insertions(+), 25 deletions(-) diff --git a

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-07 Thread Or Gerlitz
On Thu, Dec 6, 2012 at 4:27 PM, Or Gerlitz wrote: [...] > looking on the current locks in the system, we see that this kworker task > holds four locks, but none of them seems to be mutually held by another task, That was ofcourse a wrong assertion, as a lock can't be mutually held b

Re: [FIXES for-next 0/4] mlx4_core SRIOV and Flow-Steering adjustments and fixes

2012-12-08 Thread Or Gerlitz
On Thu, Dec 6, 2012 at 7:11 PM, Or Gerlitz wrote: >> The patch set fixes few issues we've identified and fixed in the >> mlx4_core driver around SRIOV and device managed flow steering. >> This includes adding QPN enforcement in the resource tracker for >> flow-ste

Re: [FIXES for-next 3/4] mlx4_core: Adjustments to Flow Steering activation logic for SRIOV

2012-12-08 Thread Or Gerlitz
On Thu, Dec 6, 2012 at 7:11 PM, Or Gerlitz wrote: > From: Jack Morgenstein > > Separate flow steering capability detection from the decision to activate. > > For the master (and for native), detect flow steering capability in > mlx4_dev_cap, but activate the appropriate stee

Re: ib/roce VLAN ibv_rc_pingpong test

2012-12-10 Thread Or Gerlitz
On Mon, Dec 10, 2012 at 3:14 PM, Klaus Wacker wrote: > 2. The switch (BNT virt. fabric 10GB) has configured all ports as "vlan > tagging=enabled" (trunk-mode) [...] > Failed status transport retry counter exceeded (12) for wr_id 2 [...] > Now my questions are: Any ideas what causes the "ibv_rc_pin

Re: [GIT PULL] please pull infiniband.git

2012-12-10 Thread Or Gerlitz
On Tue, Dec 11, 2012 at 7:59 AM, Roland Dreier wrote: > First batch of InfiniBand/RDMA changes for the 3.8 merge window: > - A good chunk of Bart Van Assche's SRP fixes > - UAPI disintegration from David Howells > - mlx4 support for "64-byte CQE" hardware feature

Re: [PATCH v3 0/3] IB/SRP patches for kernel 3.8

2012-12-20 Thread Or Gerlitz
On 19/12/2012 16:20, Bart Van Assche wrote: This patch series avoids that SCSI error handling triggers an endless loop and also restores reporting of QP errors in the kernel log. Changes between v3 and v2: - As proposed by Dave, added a patch that prevents sending of a task management functio

Re: [PATCH v3 0/3] IB/SRP patches for kernel 3.8

2012-12-20 Thread Or Gerlitz
On 20/12/2012 15:19, Bart Van Assche wrote: On 12/20/12 13:38, Or Gerlitz wrote: I think few days ago you had a patch on your tree named "Save and restore host_scribble during error handling", is it possible we need this here for happy removal of the scsi host? No. Host removal

Re: [PATCH v3 1/3] IB/srp: Track connection state properly

2012-12-20 Thread Or Gerlitz
On 20/12/2012 17:10, David Dillow wrote: Works for me, ship it! Dave, did you gave the patches a try? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH v3 1/3] IB/srp: Track connection state properly

2012-12-20 Thread Or Gerlitz
On Thu, Dec 20, 2012 at 6:27 PM, David Dillow wrote: > On Thu, 2012-12-20 at 17:27 +0200, Or Gerlitz wrote: >> Dave, did you gave the patches a try? > This one looks to be an obvious fix, but I have not tested the others; I > have been relying on Bart, Alex, and yourself for

[PATCH FIXES for 3.8] mlx4: Fix advertizement of wrong PF context behaviour

2013-01-10 Thread Or Gerlitz
p->flags holds the firmware capabilities. Reported-by: Alex Williamson Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx4/main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4

Re: [PATCH FIXES for 3.8] mlx4: Fix advertizement of wrong PF context behaviour

2013-01-10 Thread Or Gerlitz
On 10/01/2013 17:18, Or Gerlitz wrote: Commit 08ff32352 "mlx4: 64-byte CQE/EQE support" introduced a regression under which older guest VF drivers failed to load even when 64-byte EQEs/CQEs are disabled, since the PF wrongly advertizes the new context behaviour anyway, Roland, wh

Re: Error message when trying to use Infiniband virtual functions in virtual machine

2013-01-24 Thread Or Gerlitz
On Wed, Jan 23, 2013 at 5:29 PM, Mathis GAVILLON wrote: > I'm working on a project in which I try to virtualize Infiniband. I use > ConnectX3 Infiniband cards with FW 2.9.1200. > I've installed a Fedora 18 OS with 3.8.0rc2 recompiled kernel. I use KVM 1.2 > to run virtual machines. Your firmwa

Re: Intermitted "Failed to obtain HW semaphore, aborting" error

2013-02-02 Thread Or Gerlitz
On 03/02/2013 07:14, Bharath Ramesh wrote: Intermittently a couple of nodes in our cluster throw the error "Failed to obtain HW semaphore, aborting" on boot. When this error occurs we are unable to use IB on those nodes, unloading and reloading the module doesnt help. load mlx4_core with deb

Re: [PATCH] librdmacm: Work-around kernel bug returning uid = 0

2013-02-02 Thread Or Gerlitz
On 02/02/2013 09:16, sean.he...@intel.com wrote: Older kernels have a bug where it can report an event with the uid set to 0. The librdmacm crashes when casting the uid to an rdma_cm_id and dereferencing the NULL pointer. There are a limited number of events where this can occur and in most cas

Re: Intermitted "Failed to obtain HW semaphore, aborting" error

2013-02-03 Thread Or Gerlitz
On Sun, Feb 3, 2013 at 5:18 PM, Bharath Ramesh wrote: [...] > I am unable to run ibv_devinfo on the bad node, here is an output from a > good node > $ ibv_devinfo > hca_id: mlx4_0 > transport: InfiniBand (0) > fw_ver: 2.10.2370 [...] sh

RE: Fwd: Error message when trying to use Infiniband virtual functions in virtual machine

2013-02-04 Thread Or Gerlitz
ex, what stable branch/release would you recommend to use? Or. From: Mathis GAVILLON [jbibo...@gmail.com] Sent: 04 February 2013 11:42 To: Jack Morgenstein Cc: Or Gerlitz Subject: Re: Fwd: Error message when trying to use Infiniband virtual functions i

Re: [PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

2013-02-04 Thread Or Gerlitz
On Fri, Feb 1, 2013 at 5:18 PM, Bart Van Assche wrote: > This patch series avoids that SCSI error handling triggers an endless loop > and also restores reporting of QP errors in the kernel log. Bart, You wrote "resend" in the subject line, anything new, in these patches OR in other patches merge

Re: [PATCH] librdmacm: Work-around kernel bug returning uid = 0

2013-02-04 Thread Or Gerlitz
On 04/02/2013 16:11, Bernd Schubert wrote: On 02/03/2013 08:24 AM, Or Gerlitz wrote: It would be also worthwhile to nail the fix to the root cause little further, e.g push kernel commit 418edaaba96 to -stable Agreed, I opened RHEL bugzilla #719749 (somehow marked as private, no idea why

Re: Fwd: Error message when trying to use Infiniband virtual functions in virtual machine

2013-02-05 Thread Or Gerlitz
On 04/02/2013 17:24, Alex Williamson wrote: These are available in the qemu 1.3.1 stable release http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg05403.html And they're in the current development tree which is stabilizing for the 1.4.0 release thanks Alex! Mathis, does this helps? Or

Re: Fwd: Error message when trying to use Infiniband virtual functions in virtual machine

2013-02-05 Thread Or Gerlitz
On 05/02/2013 12:32, Mathis GAVILLON wrote: I've just finished to install qemu 1.3.1 and all is working well. IRQ error has disappeared and an IB interface is know available in the virtual machine. nice! could you say again what distribution provided you with the "problematic" kvm-qemu and wh

[PATCH V2 for-next 0/6] IB/IPoIB: Add multi-queue TSS and RSS support

2013-02-05 Thread Or Gerlitz
From: Shlomo Pongratz Here's V2 of the IPoIB TSS/RSS patch series, basically its very similar to V1, with fixes to for issues we stepped over while testing since the V1 submission and an addtional capability to change the number of TX and RX rings at run time via ethtool. The concept of QP gr

[PATCH V2 for-next 3/6] IB/mlx4: Add support for RSS and TSS QP groups

2013-02-05 Thread Or Gerlitz
Signed-off-by: Or Gerlitz --- drivers/infiniband/hw/mlx4/main.c|5 + drivers/infiniband/hw/mlx4/mlx4_ib.h | 13 ++ drivers/infiniband/hw/mlx4/qp.c | 345 - 3 files changed, 352 insertions(+), 11 deletions(-) diff --git a/drivers/infiniband/hw/mlx4

[PATCH V2 for-next 2/6] IB/core: Add RSS and TSS QP groups

2013-02-05 Thread Or Gerlitz
ned-off-by: Shlomo Pongratz Signed-off-by: Or Gerlitz --- drivers/infiniband/core/uverbs_cmd.c |1 + drivers/infiniband/core/verbs.c |3 +++ drivers/infiniband/hw/amso1100/c2_provider.c |3 +++ drivers/infiniband/hw/cxgb3/iwch_provider.c |2 ++ drivers/infiniba

[PATCH V2 for-next 6/6] IB/ipoib: Support changing the number of RX/TX rings with ethtool

2013-02-05 Thread Or Gerlitz
called by the core networking code without rtnl locking. To protect against such a call being made in parallel with an ethtool call to change the number of rings -- added rwlock on the rings. Signed-off-by: Shlomo Pongratz Signed-off-by: Or Gerlitz --- drivers/infiniband/ulp/ipoib/ipoib.h

[PATCH V2 for-next 1/6] IB/ipoib: Fix ipoib_neigh hashing to use the correct daddr octets

2013-02-05 Thread Or Gerlitz
machines as the code there uses the flags part (octet[0]) and not the last octet of the QPN (octet[3]), fix that. The fix caused a checkpatch warning on line over 80 characters, to solve that changed the name of the temp variable that holds the daddr. Signed-off-by: Shlomo Pongratz Signed-off

Re: "Virtual" ibnetdiscover command fails

2013-02-05 Thread Or Gerlitz
On 05/02/2013 17:41, Mathis GAVILLON wrote: All is working well except VM is not listed when I launched ibnetdiscover on the host. Yep, this is limitation of the current implementation Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to ma

[PATCH V2 for-next 5/6] IB/ipoib: Add RSS and TSS support for datagram mode

2013-02-05 Thread Or Gerlitz
to accept TSS frames is done using a dedicated bit in the reserved byte of the IPoIB HW address (e.g similar to CM). Signed-off-by: Shlomo Pongratz Signed-off-by: Or Gerlitz --- drivers/infiniband/ulp/ipoib/ipoib.h | 15 +- drivers/infiniband/ulp/ipoib/ipoib_ib.c| 10 + driver

Re: [PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

2013-02-05 Thread Or Gerlitz
On Tue, Feb 5, 2013 at 6:25 PM, Bart Van Assche wrote: > On 02/04/13 22:11, Or Gerlitz wrote: >> You wrote "resend" in the subject line, anything new, in these patches >> OR in other patches merged through the SCSI tree for 3.8 vs. what you >> had posted earlier on

Re: [PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

2013-02-05 Thread Or Gerlitz
On 06/02/2013 09:22, Bart Van Assche wrote: A huge number of patches have been taken upstream between 3.8-rc1 and 3.8-rc6. I have retested these three patches with 3.8-rc6 and would appreciate if you would also repeat your tests. not really... this is what I see on Linus tree for the relevan

Re: [PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

2013-02-06 Thread Or Gerlitz
On 06/02/2013 09:59, Bart Van Assche wrote: On 02/06/13 08:44, Or Gerlitz wrote: On 06/02/2013 09:22, Bart Van Assche wrote: A huge number of patches have been taken upstream between 3.8-rc1 and 3.8-rc6. I have retested these three patches with 3.8-rc6 and would appreciate if you would also

Re: "Virtual" ibnetdiscover command fails

2013-02-06 Thread Or Gerlitz
On 06/02/2013 11:17, Mathis GAVILLON wrote: Ok. But what is it possible to do with Infiniband VFs if QP0 is not available ? EVERYTHING, e.g run IPoIB, iSER, RDS, MPI, etc, etc - except for what requires QP0, such as running SM or issuing SMPs for discovery/diagnostics purposes 2013/2/5

Re: "Virtual" ibnetdiscover command fails

2013-02-06 Thread Or Gerlitz
On 06/02/2013 12:04, Mathis GAVILLON wrote: Just a last question : is that possible VFs lid to be different from PF one ? NO, we've implemented a "shared port" model, so all functions on the same IB port use the same lid, each function has its own virtual GUID though. Or. Thanks 2013/2/

Re: "Virtual" ibnetdiscover command fails

2013-02-06 Thread Or Gerlitz
On 06/02/2013 12:40, Sebastian Riemer wrote: So if I don't use the unmaintained srptools to get the SRP connection strings but instead send them directly to the initiator to connect to the SRP target, then also SRP should be possible with the virtual GUID. Am I right? Basically YES, you can u

[PATCH for-next 01/10] IB/mlx4_ib: Remove local invalidate segment unused fields

2013-02-06 Thread Or Gerlitz
From: Shani Michaeli Remove unused fields from the local invalidate WQE segment structure. Signed-off-by: Haggai Eran Signed-off-by: Shani Michaeli Signed-off-by: Or Gerlitz --- drivers/infiniband/hw/mlx4/qp.c |6 ++ include/linux/mlx4/qp.h |8 +++- 2 files changed

[PATCH for-next 00/10] mlx4: Add Memory Windows support

2013-02-06 Thread Or Gerlitz
Hi Roland, Here's a series from Shani Michaeli and Haggai Eran adds mlx4 driver support for Memory Windows. The first entries in this set are "pre patches" preparing the grounds for the actual implementation of MWs. Later there're two core patches, one to ib_verbs.h adding support for type 2 M

[PATCH for-next 03/10] net/mlx4_core: Propogate MR deregistration failure

2013-02-06 Thread Or Gerlitz
From: Shani Michaeli MR deregistration fails when memory windows are bound to it. Handle such failures by propagating it to the caller ULP. Signed-off-by: Haggai Eran Signed-off-by: Shani Michaeli Signed-off-by: Or Gerlitz --- drivers/infiniband/hw/mlx4/mr.c | 13

[PATCH for-next 04/10] net/mlx4_core: Disable memory windows for VFs

2013-02-06 Thread Or Gerlitz
elves. Signed-off-by: Haggai Eran Signed-off-by: Shani Michaeli Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx4/fw.c| 11 - drivers/net/ethernet/mellanox/mlx4/mlx4.h | 16 ++ drivers/net/ethernet/mellanox/mlx4/mr.c| 14 -- ..

[PATCH for-next 07/10] IB/uverbs: Implement memory windows support in uverbs

2013-02-06 Thread Or Gerlitz
From: Shani Michaeli The existing user/kernel uverbs API has IB_USER_VERBS_CMD_ALLOC/DEALLOC_MW, implement these calls, along with destroying user memory windows during process cleanup. Signed-off-by: Haggai Eran Signed-off-by: Shani Michaeli Signed-off-by: Or Gerlitz --- drivers/infiniband

[PATCH for-next 09/10] IB/mlx4_ib: Support memory window binding

2013-02-06 Thread Or Gerlitz
memory window bind work requests. Signed-off-by: Haggai Eran Signed-off-by: Shani Michaeli Signed-off-by: Or Gerlitz --- drivers/infiniband/hw/mlx4/mlx4_ib.h |2 + drivers/infiniband/hw/mlx4/mr.c | 22 + drivers/infiniband/hw/mlx4/qp.c | 35

[PATCH for-next 08/10] mlx4: Implement memory windows allocation and deallocation

2013-02-06 Thread Or Gerlitz
From: Shani Michaeli Implement MW allocation and deallocation in mlx4_core and mlx4_ib. Pass down the enable bind flag when registering memory regions. Signed-off-by: Haggai Eran Signed-off-by: Shani Michaeli Signed-off-by: Or Gerlitz --- drivers/infiniband/hw/mlx4/mlx4_ib.h| 12

[PATCH for-next 10/10] IB/mlx4_ib: Advertize MW support

2013-02-06 Thread Or Gerlitz
From: Shani Michaeli Indicate memory windows support through device capabilities, kernel verb entries and the relevant uverbs command mask entries. Signed-off-by: Haggai Eran Signed-off-by: Shani Michaeli Signed-off-by: Or Gerlitz --- drivers/infiniband/hw/mlx4/main.c | 19

[PATCH for-next 02/10] net/mlx4_core: Rename MPT related service routines to have mpt_ prefix

2013-02-06 Thread Or Gerlitz
Signed-off-by: Shani Michaeli Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx4/mlx4.h | 16 +++--- drivers/net/ethernet/mellanox/mlx4/mr.c| 48 ++-- .../net/ethernet/mellanox/mlx4/resource_tracker.c | 14 +++--- 3 files changed, 39

[PATCH for-next 06/10] IB/core: Enhance memory windows support

2013-02-06 Thread Or Gerlitz
2 windows at all. * modify existing provides and consumers code to the new param of ib_alloc_mw and the ib_mw_bind_info structure Signed-off-by: Haggai Eran Signed-off-by: Shani Michaeli Signed-off-by: Or Gerlitz --- drivers/infiniband/core/verbs.c |5 +- drivers/infiniban

[PATCH for-next 05/10] net/mlx4_core: Enable memory windows in {INIT,QUERY}_HCA

2013-02-06 Thread Or Gerlitz
From: Shani Michaeli Add memory windows related code to INIT_HCA and QUERY_HCA Signed-off-by: Haggai Eran Signed-off-by: Shani Michaeli Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx4/fw.c |3 +++ drivers/net/ethernet/mellanox/mlx4/fw.h |1 + drivers/net

Re: [PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

2013-02-07 Thread Or Gerlitz
On 07/02/2013 11:05, Bart Van Assche wrote: On 02/06/13 22:42, Vu Pham wrote: Conclusion: 1. disable the port/path long enough >35 minutes, we have dangling scsi host. 2. enable the port within 30 minute, scsi host re-establish connection, path re-instate and then scsi_host was removed (no entry

Re: [PATCH V2 for-next 2/6] IB/core: Add RSS and TSS QP groups

2013-02-12 Thread Or Gerlitz
On 11/02/2013 22:42, Hefty, Sean wrote: RSS (Receive Side Scaling) TSS (Transmit Side Scaling, better known as MQ/Multi-Queue) are common networking techniques which allow to use contemporary NICs that support multiple receive and transmit descriptor queues (multi-queue), see also Documentation/n

Re: [PATCH V2 for-next 2/6] IB/core: Add RSS and TSS QP groups

2013-02-12 Thread Or Gerlitz
On 11/02/2013 22:42, Hefty, Sean wrote: or some QP creation flag, so that every user who wants to create a QP doesn't need to figure out what a QP group is and if their QP needs to be part of one? Then you wouldn't need to define IB_QPG_NONE. another point in favor of using different/dedicat

Re: [PATCH V2 for-next 2/6] IB/core: Add RSS and TSS QP groups

2013-02-12 Thread Or Gerlitz
resending for the 3rd time, now from different address as the mail server reject both prev postings... On Mon, Feb 11, 2013 at 10:42 PM, Hefty, Sean wrote: > If I understand the interface correctly, the user calls ib_create_qp() to > create a parent QP and reserve space for all of the children.

Re: [PATCH V2 for-next 1/6] IB/ipoib: Fix ipoib_neigh hashing to use the correct daddr octets

2013-02-12 Thread Or Gerlitz
On 12/02/2013 18:33, Hefty, Sean wrote: Have you run the V2 patch through sparse? oops, I see now that the V2 patches introduced some sparse warnings, will fix for V3, thanks for spotting that over. Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a

Re: [PATCH V2 for-next 2/6] IB/core: Add RSS and TSS QP groups

2013-02-13 Thread Or Gerlitz
On 12/02/2013 20:59, Hefty, Sean wrote: My understanding of this is that there's NO changes to the wire protocols. For RSS no changes. For TSS, added a flag in the IPoIB HW address and used a reserved field of the IPoIB header, see the change log for patch #5 "IB/IPoIB: Add RSS and TSS suppo

Re: [PATCH v4 4/9] rdma/cm: Update port reservation to support AF_IB

2013-02-13 Thread Or Gerlitz
On 22/01/2013 23:56, sean.he...@intel.com wrote: The AF_IB uses a 64-bit service id (SID), which the user can control through the use of a mask. The rdma_cm will assign values to the unmasked portions of the SID based on the selected port space and port number. Something here I am not sure to

Re: [PATCH v4 7/9] rdma/cm: Add helper functions to return id address information

2013-02-13 Thread Or Gerlitz
On 22/01/2013 23:56, sean.he...@intel.com wrote: Provide inline helpers to extract source and destination address data from the rdma_cm_id. Sean, FWIW - this patch and most of patch #6 can (and worth doing) be introduced as cleanup/maintenance patches to the rdma-cm without direct relation

Re: [PATCH v4 1/9] rdma/cm: define native IB address

2013-02-13 Thread Or Gerlitz
On 11/02/2013 20:02, Hefty, Sean wrote: Define AF_IB and sockaddr_ib to allow the rdma_cm to use native IB addressing. Signed-off-by: Sean Hefty --- include/linux/socket.h |2 + include/rdma/ib.h | 89 2 files changed, 91 insertion

Re: [PATCH v4 1/9] rdma/cm: define native IB address

2013-02-13 Thread Or Gerlitz
On 22/01/2013 23:56, sean.he...@intel.com wrote: + +struct sockaddr_ib { + unsigned short int sib_family; /* AF_IB */ + __be16 sib_pkey; + __be32 sib_flowinfo; + struct ib_addr sib_addr; + __be64 si

Re: [PATCH for-next 00/10] mlx4: Add Memory Windows support

2013-02-18 Thread Or Gerlitz
On Wed, Feb 6, 2013 at 6:19 PM, Or Gerlitz wrote: > Here's a series from Shani Michaeli and Haggai Eran adds mlx4 driver > support for Memory Windows. Hi Roland, So things are warming up for the 3.9 merge window, I see that this series is marked as "new" in your patchwork

[PATCH V1 for-3.9 1/3] IB/ipoib: Fix ipoib_neigh hashing to use the correct daddr octets

2013-02-19 Thread Or Gerlitz
machines as the code there uses the flags part (octet[0]) and not the last octet of the QPN (octet[3]), fix that. The fix caused a checkpatch warning on line over 80 characters, to solve that changed the name of the temp variable that holds the daddr. Signed-off-by: Shlomo Pongratz Signed-off

[PATCH for-3.9 3/3] IB/ipoib: Don't attempt to release resources on error flow

2013-02-19 Thread Or Gerlitz
From: Itai Garbi If the ipoib client info isn't found on the _remove_one callback, we must not attempt to scan the returned null list, found by Coverity. Signed-off-by: Itai Garbi Signed-off-by: Or Gerlitz --- drivers/infiniband/ulp/ipoib/ipoib_main.c |2 ++ 1 files changed, 2 inser

[PATCH for-3.9 2/3] IB/ipoib: Add version and firmware info to ethtool reporting

2013-02-19 Thread Or Gerlitz
From: Yan Burman Implement version info as well as report firmware version and bus info of the underlying IB HW device. Signed-off-by: Yan Burman Signed-off-by: Or Gerlitz --- drivers/infiniband/ulp/ipoib/ipoib.h |2 ++ drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 19

[PATCH 0/3] IPoIB fixes for 3.9

2013-02-19 Thread Or Gerlitz
Hi Roland, Here are two small IPoIB fixes for 3.9 along with Yan's ethtool patch with which we can happily celebrate the marking of version 1.0.0 for IPoIB eight years after your initial push... Or. For Shlomo's patch this is V1, where the change from V0, http://marc.info/?l=linux-rdma&m=1360

[PATCH for-3.9 2/3] IB/iser: Avoid error prints on EAGAIN registration failures

2013-02-21 Thread Or Gerlitz
-by: Or Gerlitz --- drivers/infiniband/ulp/iser/iser_memory.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iser_memory.c b/drivers/infiniband/ulp/iser/iser_memory.c index 2033a92..79c4f35 100644 --- a/drivers/infiniband/ulp/iser

[PATCH for-3.9 3/3] IB/iser: Enable iser to work when FMRs are not supported

2013-02-21 Thread Or Gerlitz
Reuse the SG unaligned for FMR driver flow to make the initiator functional when running over driver instance which doesn't support FMRs such as mlx4 VF. Signed-off-by: Or Gerlitz Signed-off-by: Alex Tabachnik --- drivers/infiniband/ulp/iser/iser_memory.c |7 --- drivers/infiniban

[PATCH 0/3] iser updates for 3.9

2013-02-21 Thread Or Gerlitz
Hi Roland, These are the iser updates for the 3.9 merge window, two maintainance patches and one patch that allows to run over a VF (e.g in a VM). Or. Or Gerlitz (3): IB/iser: Use proper define for the commands per lun value advertized to SCSI ML IB/iser: Avoid error prints on EAGAIN

[PATCH for-3.9 1/3] IB/iser: Use proper define for the commands per lun value advertized to SCSI ML

2013-02-21 Thread Or Gerlitz
ISER_DEF_CMD_PER_LUN was meant to be ISCSI_DEF_XMIT_CMDS_MAX, not plain 128 Signed-off-by: Roi Dayan Signed-off-by: Or Gerlitz --- drivers/infiniband/ulp/iser/iscsi_iser.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h b

Re: linux-next: manual merge of the infiniband tree with Linus' tree

2013-02-22 Thread Or Gerlitz
") from the tree and commit > 4b48680b5572 ("IPoIB: Add version and firmware info to ethtool > reporting") from the infiniband tree. > > I fixed it up (using the latter version as it included the change to use > strlcpy) and can carry the fix as necessary (no action is re

Re: [PATCH for-next 00/10] mlx4: Add Memory Windows support

2013-02-22 Thread Or Gerlitz
Hi Roland, I see now that you've picked five of the patches from this series into for-next, anything which needs clarification or fixup in the other five patches? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH] IB/srp: Fail I/O requests if the transport is offline

2013-02-24 Thread Or Gerlitz
On Sun, Feb 24, 2013 at 10:59 AM, Sagi Grimberg wrote: > On 2/24/2013 10:09 AM, Bart Van Assche wrote: >> On 02/18/13 09:11, Sagi Grimberg wrote: >>> On 2/18/2013 6:06 AM, David Dillow wrote: Or, Vu, does this solve the issue you've seen? I may have time to test later this week, but not

Re: [PATCH v4 0/4] IB/srp fixes

2013-02-25 Thread Or Gerlitz
On Mon, Feb 25, 2013 at 7:32 PM, Roland Dreier wrote: > > All look good, applied for 3.9, thanks. Roland, could you add a CC to -stable so they can get to 3.8-stable too? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.or

Re: [PATCH v4 0/4] IB/srp fixes

2013-02-25 Thread Or Gerlitz
On Mon, Feb 25, 2013 at 7:36 PM, Or Gerlitz wrote: > On Mon, Feb 25, 2013 at 7:32 PM, Roland Dreier wrote: >> All look good, applied for 3.9, thanks. > Roland, could you add a CC to -stable so they can get to 3.8-stable too? Oh, I see its just there, thanks! -- To unsubscribe fr

Re: linux-next: manual merge of the infiniband tree with Linus' tree

2013-02-25 Thread Or Gerlitz
commit e448834e3545 ("mlx4_core: Enable memory windows in {INIT, QUERY}_HCA") from the infiniband tree. I fixed it up (see below) and can carry the fix as necessary (no action is required). thanks, Acked-by: Or Gerlitz -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH/RFC] IPoIB: Free ipoib neigh on path record failure so path rec queries are retried

2013-02-26 Thread Or Gerlitz
On 25/02/2013 19:46, Roland Dreier wrote: If IPoIB fails to look up a path record (eg if it tries during an SM failover when one SM is dead but the new one hasn't taken over yet), the driver ends up with a neighbour structure but no address handle (AH). There's no mechanism to recover from this:

Re: [PATCH infiniband-diags] Adding support for Debian packaging

2013-02-27 Thread Or Gerlitz
On Wed, Feb 27, 2013 at 5:47 PM, Narayan Desai wrote: > Hi Ilya. The easiest way to see packaging for a library (from an > upstream apt source) is to run [...] Ilya, You can also take a look on the upstream trees for libibverbs and libmlx4 maintained by Roland which have a debian dir, which you

Re: mlx4 module loading fail

2013-03-07 Thread Or Gerlitz
On 07/03/2013 13:18, Hudzia, Benoit wrote: I am currently experiencing some trouble with my connectx2 cards. I have been doing test with smallish server without any problem and this week I upgraded to a more beefier option. However I fail to be able setup the IB card with our current kernel.

Re: mlx4 module loading fail

2013-03-07 Thread Or Gerlitz
On 07/03/2013 18:06, Hudzia, Benoit wrote: We didn't change that code as our code is sitting above the rdma_ucm bit. ( we do not touch any of the core RDMA function or drivers, just using them). We are using the default OFED setup ( driver are loaded with the default config ) and there is

[PATCH V3 for-next 0/5] IB/IPoIB: Add multi-queue TSS and RSS support

2013-03-07 Thread Or Gerlitz
From: Shlomo Pongratz Here's V3 of the IPoIB TSS/RSS patch series, basically its very similar to V2, with fix to for one issue we stepped over while testing V2 and addressing of feedback provided by Sean on the QP groups concept. The concept of QP groups for TSS/RSS was introduced in the 2012 O

[PATCH V3 for-next 1/5] IB/core: Add RSS and TSS QP groups

2013-03-07 Thread Or Gerlitz
From: Shlomo Pongratz RSS (Receive Side Scaling) TSS (Transmit Side Scaling, better known as MQ/Multi-Queue) are common networking techniques which allow to use contemporary NICs that support multiple receive and transmit descriptor queues (multi-queue), see also Documentation/networking/scaling.

[PATCH V3 for-next 5/5] IB/ipoib: Support changing the number of RX/TX rings with ethtool

2013-03-07 Thread Or Gerlitz
From: Shlomo Pongratz The number of RX/TX rings can now be get or changed using the ethtool directives to get/set the number of channels of ETHTOOL_{G/S}CHANNELS. Added ipoib_reinit() which releases all the rings and their associated resources, and immediatly following that allocates them again

[PATCH V3 for-next 4/5] IB/ipoib: Add RSS and TSS support for datagram mode

2013-03-07 Thread Or Gerlitz
From: Shlomo Pongratz This patch add RSS (Receive Side Scaling) and TSS (multi-queue transmit) support for IPoIB. The RSS and TSS implementation utilizes the new QP groups concept. The number of RSS and TSS rings is a function of the number of cores, and the low level driver capability to suppor

[PATCH V3 for-next 2/5] IB/mlx4: Add support for RSS and TSS QP groups

2013-03-07 Thread Or Gerlitz
From: Shlomo Pongratz Depending on the mlx4 device capabilities, support the RSS IB device capability, using Topelitz or XOR hash functions according to what available with the HW. Support creating QP groups where all RX and TX QPs have contiguous QP numbers. Signed-off-by: Shlomo Pongratz ---

Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-08 Thread Or Gerlitz
On Fri, Mar 8, 2013 at 6:14 AM, Roland Dreier wrote: > Nicholas A. Bellinger wrote: > > +EXPORT_SYMBOL(iscsit_get_transport); > It's not clear to me why this needs to be exported. Who would use it > outside the core iscsi target module? Yep, as Nic noted, we're adding here an iscsi transport c

Re: mlx4 module loading fail

2013-03-08 Thread Or Gerlitz
On Thu, Mar 7, 2013 at 6:06 PM, Hudzia, Benoit wrote: > > However I did a quick test and by removing physically HALF the ram of the > server ( basically moving from 1TB to 512GB) everything works fine.. Yep, you probably hit the problem fixed by commit "mlx4_core: Allow large mlx4_buddy bitmap

Re: [PATCH] libibmad: To fix big endian problem for both 32-bit & 64-bit SPARC

2013-03-13 Thread Or Gerlitz
On 13/03/2013 14:48, Hal Rosenstock wrote: On 3/12/2013 3:36 PM, Boris Chiu wrote: >--- a/src/dump.c >+++ b/src/dump.c >@@ -46,12 +46,24 @@ > >void mad_dump_int(char *buf, int bufsz, void *val, int valsz) >{ >+/* >+ * the val pointer passed to the dump routines are always 32 bit >+ *

Re: v3.7: Unloading ib_ipoib triggers circular locking dependency complaint

2013-03-13 Thread Or Gerlitz
On 12/03/2013 15:57, Bart Van Assche wrote: On 11/26/12 09:00, Or Gerlitz wrote: On Fri, Nov 23, 2012 at 2:10 PM, Bart Van Assche wrote: Apparently unloading the ib_ipoib kernel module triggers a circular locking dependency complaint. Has anyone already been looking into this ? Yes, I see

Re: [PATCH] libibmad: Fixes for failures when not all ports of HCA are connected

2013-03-14 Thread Or Gerlitz
On 13/03/2013 21:36, Ira Weiny wrote: Furthermore, I'm reluctant to modify errno in this library. Yep, this should be avoided unless impossible... Or. It is not documented and in general is poor form. I realize that the interface does not currently allow for an alternative.:-( -- To unsubs

<    8   9   10   11   12   13   14   15   16   17   >