Re: [PATCH 05/61] clk: samsung: simplify getting .drvdata

*s3c24xx_dclk = dev_get_drvdata(dev); > > writel_relaxed(s3c24xx_dclk->reg_save, s3c24xx_dclk->base); > return 0; > Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] extcon: int3496: use proper GPIO include

On 2018년 04월 13일 10:09, Chanwoo Choi wrote: > Hi, > > On 2018년 04월 10일 21:43, Wolfram Sang wrote: >> Since commit eca0f13c836a ("extcon: int3496: Ignore incorrect >> IoRestriction for ID pin"), the driver doesn't use GPIOF_* flags >> anymore. We can thu

Re: [PATCH] extcon: int3496: use proper GPIO include

20,7 @@ > > #include > #include > -#include > +#include > #include > #include > #include > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

Dear all, I got the reviews from all maintainers related to this patch. So, I make the immutable branch on extcon.git and then send the pull request in order to prevent the possible merge conflict. Best Regards, Chanwoo Choi Samsung Electronics The following changes since commit

Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

Gently Ping. Dear Kishon, Could you please review this patch for 'drivers/phy/*'? Regards, Chanwoo Choi On 2017년 10월 12일 12:40, Chanwoo Choi wrote: > Dear Kishon, > > Could you please review this patch? > After that, I'll make the immutable brand and then

Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

Dear Kishon, Could you please review this patch? After that, I'll make the immutable brand and then send the pull request for power_supply, mfd, phy, usb and extcon framework. On 2017년 10월 10일 19:17, Chanwoo Choi wrote: > The extcon has two type of extcon devices as following. >

[PATCH v2] extcon: Split out extcon header file for consumer and provider device

he property capability of each external connector Cc: Felipe Balbi Cc: Kishon Vijay Abraham I Cc: Greg Kroah-Hartman Acked-by: Sebastian Reichel Acked-by: Chen-Yu Tsai Acked-by: Charles Keepax Acked-by: Lee Jones Signed-off-by: Chanwoo Choi --- Changes from v1: - Don't touch drivers/usb/

Re: [PATCH] extcon: Split out extcon header file for consumer and provider device

Hi, On 2017년 09월 29일 11:03, Yoshihiro Shimoda wrote: > Hi, > >> From: Chanwoo Choi >> Sent: Friday, September 29, 2017 9:02 AM >> > < snip > >> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 2 +- > < snip > >> drivers/usb/gadget/udc/

[PATCH] extcon: Split out extcon header file for consumer and provider device

he property capability of each external connector Cc: Felipe Balbi Cc: Kishon Vijay Abraham I Cc: Greg Kroah-Hartman Cc: Sebastian Reichel Cc: Lee Jones Signed-off-by: Chanwoo Choi --- drivers/extcon/extcon-adc-jack.c | 2 +- drivers/extcon/extcon-arizona.c |

Re: [PATCH v2 0/2] phy: Replace the deprecated extcon API

Hi Kishon, On 2017년 01월 10일 17:16, Chanwoo Choi wrote: > Hi Kishon, > > Could you review these patches or pick up them if there is no any comment? If there are no comments, could you apply these patches? > > On 2016년 12월 30일 13:11, Chanwoo Choi wrote: >> This pat

Re: [PATCH v2 0/6] usb: Replace the deprecated extcon API

Hi Felipe, These patches have already acked-by tag from you. Could you please apply them if there is additional comment? On 2016년 12월 30일 13:08, Chanwoo Choi wrote: > This patches just replace the deprecated extcon API without any change > of extcon operation and use the resource-m

Re: [PATCH v2 0/2] phy: Replace the deprecated extcon API

Hi Kishon, Could you review these patches or pick up them if there is no any comment? On 2016년 12월 30일 13:11, Chanwoo Choi wrote: > This patches just replace the deprecated extcon API without any change > of extcon operation and use the resource-managed function for > extcon_register

Re: [PATCH] cpufreq: Remove CONFIG_CPU_FREQ_STAT_DETAILS config option

| 1 - > arch/powerpc/configs/ppc6xx_defconfig | 1 - > arch/sh/configs/sh7785lcr_32bit_defconfig | 2 +- > drivers/cpufreq/Kconfig | 8 > drivers/cpufreq/cpufreq_stats.c | 14 -- > 11 files changed, 7 insertions(+), 31 dele

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

Hi Felipe, On 2016년 12월 30일 11:46, Chanwoo Choi wrote: > Hi Felipe, > > On 2016년 12월 02일 18:03, Felipe Balbi wrote: >> >> Hi, >> >> Chanwoo Choi writes: >>> Hi Felipe, >>> >>> On 2016년 11월 30일 19:36, Felipe Balbi wrote: >>>

[PATCH v2 2/6] usb: phy: msm: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi --- drivers/usb/phy/phy-msm-usb.c |

[PATCH v2 1/2] phy: rcar-gen3-usb2: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Signed-off-by: Chanwoo Choi Acked-by: Yoshihiro Shimoda --- drivers/phy/phy-rcar-gen3-usb2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driv

[PATCH v2 0/2] phy: Replace the deprecated extcon API

te_() -> extcon_get_state(); Changes from v1: - Rebase these patches based on v4.10-rc1. - Drop the usb/power-supply/chipidea patches. Chanwoo Choi (2): phy: rcar-gen3-usb2: Replace the deprecated extcon API phy: sun4i-usb: Replace the deprecated extcon API drivers/phy/phy-rcar-gen3-usb2

[PATCH v2 1/6] usb: dwc3: omap: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi --- drivers/usb/dwc3/dwc3-omap.c | 20 +++-

[PATCH v2 2/2] phy: sun4i-usb: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Cc: Kishon Vijay Abraham I Cc: Maxime Ripard Cc: Chen-Yu Tsai Signed-off-by: Chanwoo Choi --- drivers/phy/phy-sun4i-usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH v2 6/6] usb: renesas_usbhs: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Cc: Rob Herring Cc: Geert Uytterhoeven Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi Acked-by: Yoshihiro Shimoda --- drivers/usb/renesas_usbhs/common.c | 2 +- 1 file chan

[PATCH v2 3/6] usb: phy: omap-otg: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi --- drivers/usb/phy/phy-omap-otg.c |

[PATCH v2 4/6] usb: phy: qcom-8x16-usb: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi --- drivers/usb/phy/phy-qcom-8x16-usb.c | 13 -

[PATCH v2 5/6] usb: phy: tahvo: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi --- drivers/usb/phy/phy-tahvo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/

[PATCH v2 0/6] usb: Replace the deprecated extcon API

te_() -> extcon_get_state(); Changes from v1: - Rebase these patches based on v4.10-rc1. - Add acked-by tag from usb maintainer and reviewer. - Drop the phy/power-supply/chipidea patches. Chanwoo Choi (6): usb: dwc3: omap: Replace the extcon API usb: phy: msm: Replace the extcon API usb: phy: om

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

Hi Felipe, On 2016년 12월 02일 18:03, Felipe Balbi wrote: > > Hi, > > Chanwoo Choi writes: >> Hi Felipe, >> >> On 2016년 11월 30일 19:36, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Chanwoo Choi writes: >>>> This patch uses

Re: [PATCH 03/12] power_supply: axp288_charger: Replace the extcon API

Hi Sebastian, On 2016년 12월 07일 12:05, Sebastian Reichel wrote: > Hi Chanwoo, > > On Tue, Dec 06, 2016 at 09:26:14AM +0900, Chanwoo Choi wrote: >> Could you please review and pick the patch3/4 for power-supply driver? > > Patches look fine. As I expect the merge windo

Re: [PATCH 01/12] phy: rcar-gen3-usb2: Replace the deprecated extcon API

Hi Kishon, Could you review and pick the patch1/2 for phy driver? Best Regards, Chanwoo Choi On 2016년 11월 30일 14:57, Chanwoo Choi wrote: > This patch replaces the deprecated extcon API as following: > - extcon_set_cable_state_() -> extcon_set_state_sync() > > Signed-off-b

Re: [PATCH 03/12] power_supply: axp288_charger: Replace the extcon API

Hi Sebastian, Could you please review and pick the patch3/4 for power-supply driver? Best Regards, Chanwoo Choi On 2016년 11월 30일 14:57, Chanwoo Choi wrote: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as fol

Re: [PATCH 07/12] usb: sunxi: Uses the resource-managed extcon API when registering extcon notifier

On 2016년 12월 06일 01:32, Bin Liu wrote: > On Wed, Nov 30, 2016 at 09:45:03AM +0100, Maxime Ripard wrote: >> On Wed, Nov 30, 2016 at 02:57:35PM +0900, Chanwoo Choi wrote: >>> This patch just uses the resource-managed extcon API when registering >>> the extcon notifier. >

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

Hi Felipe, 2016-12-02 18:03 GMT+09:00 Felipe Balbi : > > Hi, > > Chanwoo Choi writes: >> Hi Felipe, >> >> On 2016년 11월 30일 19:36, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Chanwoo Choi writes: >>>> This patch uses

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

Hi Felipe, On 2016년 11월 30일 19:36, Felipe Balbi wrote: > > Hi, > > Chanwoo Choi writes: >> This patch uses the resource-managed extcon API for >> extcon_register_notifier() >> and replaces the deprecated extcon API as following: >> - extcon_ge

[PATCH 06/12] usb: dwc3: omap: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/dwc3/dwc3-omap.c | 20 +++- 1 file changed

[PATCH 02/12] phy: sun4i-usb: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Cc: Kishon Vijay Abraham I Cc: Maxime Ripard Cc: Chen-Yu Tsai Signed-off-by: Chanwoo Choi --- drivers/phy/phy-sun4i-usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH 08/12] usb: phy: msm: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/phy/phy-msm-usb.c | 33 +++-- 1 f

[PATCH 10/12] usb: phy: qcom-8x16-usb: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/phy/phy-qcom-8x16-usb.c | 13 - 1 file changed

[PATCH 12/12] usb: renesas_usbhs: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/renesas_usbhs/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/

[PATCH 04/12] power_supply: qcom_smbb: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Signed-off-by: Chanwoo Choi --- drivers/power/supply/qcom_smbb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/qcom_smbb.c b/driv

[PATCH 09/12] usb: phy: omap-otg: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/phy/phy-omap-otg.c | 24 ++-- 1 file changed

[PATCH 05/12] usb: chipdata: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/chipidea/core.c | 30 ++ 1 file chan

[PATCH 07/12] usb: sunxi: Uses the resource-managed extcon API when registering extcon notifier

This patch just uses the resource-managed extcon API when registering the extcon notifier. Signed-off-by: Chanwoo Choi --- drivers/usb/musb/sunxi.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c index

[PATCH 03/12] power_supply: axp288_charger: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/power/supply/axp288_charger.c | 51 +--

[PATCH 11/12] usb: phy: tahvo: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Signed-off-by: Chanwoo Choi --- drivers/usb/phy/phy-tahvo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/

[PATCH 00/12] extcon: Replace the deprecated extcon API

te_() -> extcon_get_state(); The each patch has not any dependency among patches. So, each maintainer could pick up each patch without any problem. Chanwoo Choi (12): phy: rcar-gen3-usb2: Replace the deprecated extcon API phy: sun4i-usb: Replace the deprecated extcon API power_supply: axp288_c

[PATCH 01/12] phy: rcar-gen3-usb2: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Signed-off-by: Chanwoo Choi --- drivers/phy/phy-rcar-gen3-usb2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/phy/phy-rcar-gen3-usb2.

[PATCH] extcon: Split out the extcon APIs for extcon provider driver

adros Cc: Charles Keepax Cc: patc...@opensource.wolfsonmicro.com Cc: linux-renesas-soc@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-...@vger.kernel.org Signed-off-by: Chanwoo Choi --- drivers/extcon/devres.c| 2 +- drivers/extcon/extcon-adc-jack.c

[PATCH] extcon: Split out the extcon APIs for extcon provider driver

adros Cc: Charles Keepax Cc: patc...@opensource.wolfsonmicro.com Cc: linux-renesas-soc@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-...@vger.kernel.org Signed-off-by: Chanwoo Choi --- drivers/extcon/devres.c | 2 +- drivers/extcon/extcon-adc-jack.c | 2 +- dr

Re: [PATCH 1/7] extcon: add missing of_node_put after calling of_parse_phandle

Hi Peter, Applied it. Regards, Chanwoo Choi 2016-07-01 18:41 GMT+09:00 Peter Chen : > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: MyungJoo Ham > Cc: Chanwoo Choi > Signed-off-by: Peter Chen >

Re: [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle

Hi Peter, 2016-07-01 18:42 GMT+09:00 Peter Chen : > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: Chanwoo Choi > Cc: MyungJoo Ham > Cc: Kyungmin Park > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski >

Re: [PATCH 3/3] phy: rcar-gen3-usb2: add extcon support

con)) > + return PTR_ERR(channel->extcon); > + > + ret = devm_extcon_dev_register(dev, channel->extcon); > + if (ret < 0) { > + dev_err(dev, "Failed to register extcon\n"); > + return ret; > + } > } > > /* devm_phy_create() will call pm_runtime_enable(dev); */ > Looks good to me about extcon usgae. Reviewed-by: Chanwoo Choi Best Regards, Chanwoo Choi