Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

/patch/10252209/ Signed-off-by: Wolfram Sang Above exchange says it all, no need to repeat. Reviewed-by: Guenter Roeck Thanks. I can relate to the policy argument, though. Regardless of this patch, I wonder if we can make it configurable from userspace. A draft: #define WDIOF_RESUME_OPTS

Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

/ Signed-off-by: Wolfram Sang Above exchange says it all, no need to repeat. Reviewed-by: Guenter Roeck --- Fabrizio: can you agree to that? The R-Car BSP team and we (the R-Car upstream team) would prefer it this way (knowing it is also not perfect). drivers/watchdog/renesas_wdt.c | 11

Re: [PATCH v2] watchdog: renesas_wdt: don't set divider while watchdog is running

On Wed, Nov 07, 2018 at 08:46:02PM +0100, Wolfram Sang wrote: > The datasheet says we must stop the timer before changing the clock > divider. This can happen when the restart handler is called while the > watchdog is running. > > Signed-off-by: Wolfram Sang Reviewed-by

Re: [PATCH] watchdog: renesas_wdt: Fix typos

On Fri, Nov 02, 2018 at 07:21:11PM +, Fabrizio Castro wrote: Do not use "," but ";" to separate instructions. > Signed-off-by: Fabrizio Castro Reviewed-by: Guenter Roeck > --- > drivers/watchdog/renesas_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+)

Re: [PATCH v2] thermal_hwmon: Fix the 'No sensors found' error after replacing the parameter NULL by the actual device

On Thu, Oct 04, 2018 at 10:29:19AM +0900, Cao Van Dong wrote: > Dear Marc-san, > > Thanks for your comment! > > >>Formerly, when registering the hwmon device, we pass NULL as the device. > >>It's not a problem. > >>Recently, the developer has replaced the parameter NULL as the device by > >>the

Re: dt-bindings: watchdog: renesas-wdt: Document r8a7744 support

y: Geert Uytterhoeven Reviewed-by: Guenter Roeck > --- > Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/renesas-wdt.txt > b/Documentation/devicetree/bindings/w

Re: [v4,2/2] dt-bindings: watchdog: renesas-wdt: Add support for R7S9210

On Mon, Sep 10, 2018 at 02:52:33PM -0500, Chris Brandt wrote: > Document support for RZ/A2 > > Signed-off-by: Chris Brandt Reviewed-by: Guenter Roeck > --- > Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [v4,1/2] watchdog: rza_wdt: Support longer timeouts

On Mon, Sep 10, 2018 at 02:52:32PM -0500, Chris Brandt wrote: > The RZ/A2 watchdog timer extends the clock source options in order to > allow for longer timeouts. > > Signed-off-by: Chris Brandt Reviewed-by: Guenter Roeck > --- > v4: > * Documented CKS_3BIT/CKS_4BIT bett

Re: [PATCH v3 1/2] watchdog: rza_wdt: Support longer timeouts

On Mon, Sep 10, 2018 at 05:36:39PM +, Chris Brandt wrote: > On Monday, September 10, 2018 1, Guenter Roeck wrote: > > > #2. If the CKS is only 4-bits, the max HW timeout is 32 seconds. (so > > > 'timeout' can never be more that a u8). > > > > &

Re: [PATCH v3 1/2] watchdog: rza_wdt: Support longer timeouts

On Mon, Sep 10, 2018 at 01:53:28PM +, Chris Brandt wrote: > On Saturday, September 08, 2018 1, Guenter Roeck wrote: > > > +#define CKS_3BIT 0x7 > > > +#define CKS_4BIT 0xF > > > > Any special reason for the value of those defines ? They are ju

Re: watchdog: renesas_wdt: convert to SPDX identifiers

On Fri, Sep 07, 2018 at 02:10:58AM +, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto > Reviewed-by: Guenter Roeck Hmmm .. any

Re: [PATCH v3 1/2] watchdog: rza_wdt: Support longer timeouts

On 09/06/2018 06:22 PM, Chris Brandt wrote: The RZ/A2 watchdog timer extends the clock source options in order to allow for longer timeouts. Signed-off-by: Chris Brandt --- v3: * Removed + 1 from DIV_ROUND_UP line * resetting to 0 if time to big did not make as much sense are resetting

Re: [PATCH] watchdog: rza_wdt: convert to SPDX identifiers

On Fri, Sep 07, 2018 at 02:11:17AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Guenter Roeck >

Re: [PATCH] watchdog: renesas_wdt: convert to SPDX identifiers

On Fri, Sep 07, 2018 at 02:10:58AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Guenter Roeck >

Re: [PATCH v2 1/2] watchdog: rza_wdt: Support longer timeouts

On Thu, Sep 06, 2018 at 11:52:47AM -0700, Guenter Roeck wrote: > On Thu, Sep 06, 2018 at 01:37:37PM -0500, Chris Brandt wrote: > > The RZ/A2 watchdog timer extends the clock source options in order to > > allow for longer timeouts. > > > > Signed-off-by: Chris Brandt

Re: [PATCH v2 1/2] watchdog: rza_wdt: Support longer timeouts

On Thu, Sep 06, 2018 at 01:37:37PM -0500, Chris Brandt wrote: > The RZ/A2 watchdog timer extends the clock source options in order to > allow for longer timeouts. > > Signed-off-by: Chris Brandt > --- > v2: > * use DIV_ROUND_UP > * use %u for pr_debug > * use of_match data to determine the size

Re: [RFC PATCH v3 1/4] watchdog: core: add mechanism to prevent removing if NOWAYOUT

On Wed, Aug 29, 2018 at 09:42:38AM +0200, Wolfram Sang wrote: > To prevent removing if NOWAYOUT, we invalidate the .remove function and > suppress the bind/unbind attributes in sysfs. These are driver > capabilities, so we need to set it up at runtime during init. To avoid > boilerplate, introduce

Re: [RFC PATCH v2 1/4] watchdog: core: add mechanism to prevent removing if NOWAYOUT

On Tue, Aug 28, 2018 at 10:07:40PM +0200, Wolfram Sang wrote: > Hi Guenter, > > > > + __driver.remove = NULL; \ > > > > Does that really do any good ? If I understand correctly, the only > > impact is that the platform driver remove function will believe that > > nothing needs to be done

Re: [RFC PATCH v2 1/4] watchdog: core: add mechanism to prevent removing if NOWAYOUT

On Tue, Aug 28, 2018 at 09:14:13PM +0200, Wolfram Sang wrote: > To prevent removing if NOWAYOUT, we invalidate the .remove function and > suppress the bind/unbind attributes in sysfs. These are driver > capabilities, so we need to set it up at runtime during init. To avoid > boilerplate, introduce

Re: [RFC PATCH] watchdog: HACK: disable bind attributes with NOWAYOUT

On 08/28/2018 03:29 AM, Wolfram Sang wrote: With NOWAYOUT, prevent bind/unbind possibilities in SYSFS. Proof-of-concept, not for upstream yet. Signed-off-by: Wolfram Sang --- So, this is really an RFC to check if something like this is considered useful or not. If so, we probably need to do

Re: [PATCH 2/2] watchdog: renesas_wdt: stop when unregistering

been opened by userspace yet. Strange scenario, yes, but sane state is much preferred anyhow. Signed-off-by: Wolfram Sang Reviewed-by: Guenter Roeck --- drivers/watchdog/renesas_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog

Re: [PATCH 1/2] watchdog: core: fix null pointer dereference when releasing cdev

ntroduce watchdog_stop_on_unregister helper") Signed-off-by: Wolfram Sang Reviewed-by: Guenter Roeck --- drivers/watchdog/watchdog_dev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c index ffbdc4642ea5..f6c24b

Re: [PATCH v2] dt-bindings: watchdog: renesas-wdt: Add support for the R8A77990 wdt

-by: Guenter Roeck Acked-by: Rob Herring The patch is queued in my tree, so there should be no need to resend it anymore. Guenter --- v2: - Add Reviewed-by, Acked-by. --- Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 + 1 file changed, 1 insertion(+) diff --git

Re: dt-bindings: watchdog: renesas-wdt: Add support for the R8A77990 wdt

On Tue, Jun 05, 2018 at 07:18:33PM +0200, Geert Uytterhoeven wrote: > From: Masaharu Hayakawa > > Document support for the Watchdog Timer (WDT) Controller in the Renesas > R-Car E3 (R8A77990) SoC. > > No driver update is needed. > > Signed-off-by: Masaharu Hayakawa > Signed-off-by: Geert

Re: dt-bindings: watchdog: renesas-wdt: Add support for the R8A77990 wdt

> Signed-off-by: Geert Uytterhoeven Reviewed-by: Guenter Roeck > --- > Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/renesas-wdt.txt > b/Documentation/devicet

Re: [PATCH 4/9] hwmon: fschmd: fix typo 'can by' to 'can be'

On 05/06/2018 04:23 AM, Wolfram Sang wrote: Signed-off-by: Wolfram Sang Applied to hwmon-next. Thanks, Guenter --- drivers/hwmon/fschmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c

Re: [PATCH v3] watchdog: renesas-wdt: Add support for the R8A77965 WDT

g <wsa+rene...@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> This one applies. Reviewed-by: Guenter Roeck <li...@roeck-us.net> Thanks! Guenter --- Change since V2: rebase to 4.17-rc3 Documentation/devicetree/bindings/watchdog/renesas-wdt.tx

Re: [v2] watchdog: renesas-wdt: Add support for the R8A77965 WDT

ebased to top-of-tree] > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> > Reviewed-by: Guenter Roeck <li...@roeck-us.net> > Reviewed-by: Simon Horman <horms+rene...@verge.net.au> >

Re: [PATCH] watchdog: renesas-wdt: Remove R-Car M2-W ES2.x from blacklist

On 04/20/2018 05:20 AM, Geert Uytterhoeven wrote: System restart triggered by watchdog time-out works fine on a Koelsch board with R-Car M2-W ES2.0. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Guenter Roeck <li...@roeck-us.net> --- Thanks to Magnus

Re: [PATCH 59/61] watchdog: simplify getting .drvdata

On Thu, Apr 19, 2018 at 04:06:29PM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Guenter Roeck &

Re: [PATCH v2] watchdog: renesas-wdt: Add support for the R8A77965 WDT

g <wsa+rene...@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Guenter Roeck <li...@roeck-us.net> --- Change since v1: s/M3N/M3-N/ (Thanks, Geert!) Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 + 1 file chang

Re: [PATCH] watchdog: renesas-wdt: Add support for WDIOF_CARDRESET

On Tue, Mar 20, 2018 at 10:36:26PM +0100, Wolfram Sang wrote: > From: Veeraiyan Chidambaram > > This patch adds the WDIOF_CARDRESET support for the Renessas platform > watchdog, to know if the board reboot is due to a watchdog reset. > > This is done via the

Re: [PATCH v8 2/3] watchdog: renesas_wdt: Add R-Car Gen2 support

nesas_wdt: Blacklist early R-Car Gen2 SoCs" from > Geert into this patch. > > Since Simon only reviewed Geert's patch, and Wolfram and Guenter only reviewed > earlier versions of this patch, I am not including their "Reviewed-by" as they > may disagree with the final resu

Re: [PATCH v7 1/3] watchdog: renesas_wdt: Add suspend/resume support

On 03/02/2018 02:45 AM, Fabrizio Castro wrote: Dear All, perhaps someone from this email thread could explain to me what's the actual (general) expectation from a system perspective (at resume) from the watchdog, because I can see pitfalls whether 1) we simply start the watchdog at resume or 2)

Re: [PATCH v7 2/3] watchdog: renesas_wdt: Add R-Car Gen2 support

by: Ramesh Shanmugasundaram > <ramesh.shanmugasunda...@bp.renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> > Reviewed-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > v6->v

Re: [PATCH v7 1/3] watchdog: renesas_wdt: Add suspend/resume support

renesas.com> Usually, on resume, we just restart the watchdog, with the expectation in mind that there may be some delay in userspace before it gets to send the next ping. Presumably that is not a concern here, so Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- >

Re: [PATCH] watchdog: renesas_wdt: adapt timer setup to recommended procedure

On Tue, Feb 27, 2018 at 05:22:56PM +0100, Wolfram Sang wrote: > > > the core gets it wrong. Just add a note to the probe function where cks is > > initialized that RWTCSRA_TME must not be set, and that RWTCSRA_TME must be > > cleared before changing the divider. > > But we would still need to

Re: [PATCH] watchdog: renesas_wdt: adapt timer setup to recommended procedure

On 02/27/2018 05:00 AM, Wolfram Sang wrote: - rwdt_write(priv, 0, RWTCSRB); - rwdt_write(priv, priv->cks, RWTCSRA); Isn't this done implicitly with the above already ? After all, priv->cks won't have RWTCSRA_TME set. Yes. The request came from a group doing some (safety?) audit

Re: [PATCH] watchdog: renesas_wdt: adapt timer setup to recommended procedure

On Mon, Feb 26, 2018 at 10:49:05PM +0100, Wolfram Sang wrote: > The datasheet says we should stop the timer before changing the clock > divider. So, let's meet that recommendation. > > Signed-off-by: Wolfram Sang > --- > drivers/watchdog/renesas_wdt.c | 9

Re: [PATCH v5 12/26] watchdog: renesas_wdt: Add R-Car Gen2 support

need to explicitly disable the > counting by clearing TME from RWTCSRA. > > Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com> > Signed-off-by: Ramesh Shanmugasundaram > <ramesh.shanmugasunda...@bp.renesas.com> Reviewed-by: Guenter Roeck <li...

Re: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler

effective handlers. Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasunda...@bp.renesas.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> --- v3->v4: * New patch spawn out from patch 12/16. The re

Re: [RFC v4 12/26] watchdog: renesas_wdt: Add R-Car Gen2 support

On 01/31/2018 10:24 AM, Fabrizio Castro wrote: Due to commits: * "ARM: shmobile: Add watchdog support", * "ARM: shmobile: rcar-gen2: Add watchdog support", and * "soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2", we now have everything we needed for the watchdog to work on Gen2

Re: [RFC v3 11/25] watchdog: renesas_wdt: Add R-Car Gen2 support

On 01/31/2018 04:13 AM, Geert Uytterhoeven wrote: Hi Fabrizio, On Wed, Jan 31, 2018 at 11:47 AM, Fabrizio Castro wrote: Subject: Re: [RFC v3 11/25] watchdog: renesas_wdt: Add R-Car Gen2 support On Tue, Jan 30, 2018 at 08:22:44PM +, Fabrizio Castro wrote:

Re: [RFC v3 11/25] watchdog: renesas_wdt: Add R-Car Gen2 support

On Tue, Jan 30, 2018 at 08:22:44PM +, Fabrizio Castro wrote: > On R-Car Gen2 and RZ/G1 the rwdt clock needs to be always ON, therefore > when suspending to RAM we need to explicitly disable the counting by > clearing TME from RWTCSRA. > Also, on some systems RWDT is the only piece of HW that

Re: [RFC 24/37] watchdog: renesas_wdt_gen2: Add Gen2 specific driver

On Thu, Jan 25, 2018 at 06:02:58PM +, Fabrizio Castro wrote: > R-Car Gen2 (and RZ/G1) platforms need some tweaking for SMP and watchdog > to coexist nicely. > This new driver is based on top of Wolfram Sang's driver > (drivers/watchdog/renesas_wdt.c), and it contains the quirks necessary > for

Re: [RFC 22/37] watchdog: renesas_wdt: Add restart support

On Thu, Jan 25, 2018 at 06:02:56PM +, Fabrizio Castro wrote: > This commit extends the driver to add restart support by implementing > the restart callback to trigger the watchdog as quickly as possible. > > Signed-off-by: Fabrizio Castro > Signed-off-by:

Re: [PATCH] dt-bindings: watchdog: renesas-wdt: Add support for the r8a77970 wdt

hoeven <geert+rene...@glider.be> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/renesas-w

Re: dt-bindings: watchdog: renesas-wdt: Add support for the r8a77995 wdt

ked-by: Simon Horman <horms+rene...@verge.net.au> > Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --g

Re: [RFC, 2/3] watchdog: renesas_wdt: make 'clk' a variable local to probe()

On Wed, Jul 26, 2017 at 11:54:38PM +0200, Wolfram Sang wrote: > It is not needed outside probe() anymore. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Guenter R

Re: [RFC,3/3] watchdog: renesas_wdt: update copyright dates

On Wed, Jul 26, 2017 at 11:54:39PM +0200, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > drivers/watchdog/renesas_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 dele

Re: [RFC, 1/3] watchdog: renesas_wdt: consistently use RuntimePM for clock management

0 1 32768 0 0 > WDT running rwdt1 1 32768 0 0 > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Guenter Roeck <

Re: [RFC PATCH 0/3] watchdog: renesas_wdt: use standard clock handling

On Mon, Aug 14, 2017 at 05:47:28PM +0200, Wolfram Sang wrote: > On Mon, Aug 14, 2017 at 08:32:30AM -0700, Guenter Roeck wrote: > > On Wed, Jul 26, 2017 at 11:54:36PM +0200, Wolfram Sang wrote: > > > As mentioned in a response to a previous patch, clock handling for Renesas >

Re: [RFC PATCH 0/3] watchdog: renesas_wdt: use standard clock handling

On Wed, Jul 26, 2017 at 11:54:36PM +0200, Wolfram Sang wrote: > As mentioned in a response to a previous patch, clock handling for Renesas > R-Car is done via RuntimePM. Patch 1 implements that consequently. Patch 2 > is a cleanup then possible and patch 3 is a trivial copyright update. > > This

Re: [PATCH] watchdog: asm9260_wdt: don't round closest with get_timeleft

On 07/17/2017 10:12 AM, Wolfram Sang wrote: We should never return more time left than there actually is. So, switch to a plain divider instead of DIV_ROUND_CLOSEST. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Guenter Roeck <li...@roe

Re: [PATCH 1/5] watchdog: renesas_wdt: avoid (theoretical) type overflow

will change but also wait a bit for more comments. I for my part don't have any. Feel free to add Reviewed-by: Guenter Roeck <li...@roeck-us.net> to the series when you resend. Thanks, Guenter

Re: [PATCH v6 3/3] ARM: dts: r7s72100: Add watchdog timer

Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Guenter Roeck <li...@roeck-us.net> --- v4: * changed from timer@ to watchdog@ v3: * added Reviewed-by v2: * changed "renesas,r7s72100-reset" to "renesas,r7s72100-wdt" * changed "renesas,wdt-reset" to &

Re: [PATCH v6 2/3] watchdog: renesas-wdt: add support for rza

On 03/04/2017 02:37 PM, Chris Brandt wrote: Describe the WDT hardware in the RZ/A series. Signed-off-by: Chris Brandt <chris.bra...@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Guenter Roeck &

Re: [PATCH v6 1/3] watchdog: add rza_wdt driver

On 03/04/2017 02:37 PM, Chris Brandt wrote: Adds a watchdog timer driver for the Renesas RZ/A Series SoCs. A reset handler is also included since a WDT overflow is the only method for restarting an RZ/A SoC. Signed-off-by: Chris Brandt <chris.bra...@renesas.com> Reviewed-by: Guenter Roe

Re: [PATCH v5 1/3] watchdog: add rza_wdt driver

On 03/03/2017 09:31 AM, Chris Brandt wrote: Adds a watchdog timer driver for the Renesas RZ/A Series SoCs. A reset handler is also included since a WDT overflow is the only method for restarting an RZ/A SoC. Signed-off-by: Chris Brandt --- v2: * removed extra lines

Re: [PATCH v4 1/3] watchdog: add rza_wdt driver

On Thu, Mar 02, 2017 at 06:22:17PM +, Chris Brandt wrote: > On Thursday, March 02, 2017, Guenter Roeck wrote: > > > > > > The rate check should probably be here to avoid situations where > > > > > > rate < 16384. > > > > > > >

Re: [PATCH v4 1/3] watchdog: add rza_wdt driver

On Thu, Mar 02, 2017 at 03:38:07PM +, Chris Brandt wrote: > Hello Guenter, > > Thank you for your review! > > > On Thursday, March 02, 2017, Guenter Roeck wrote: > > > +/* > > > + * Renesas RZ/A Series WDT Driver > > > + * > > > +

Re: [PATCH v4 1/3] watchdog: add rza_wdt driver

On Thu, Mar 02, 2017 at 05:31:18PM +, Chris Brandt wrote: > On Thursday, March 02, 2017, Guenter Roeck worte: > > > > The above two lines are unnecessary. > > > > > > OK. > > > > > > #I'll assume you mean take out just the last senten

Re: [PATCH v4 1/3] watchdog: add rza_wdt driver

On 03/02/2017 05:57 AM, Chris Brandt wrote: Adds a watchdog timer driver for the Renesas RZ/A Series SoCs. A reset handler is also included since a WDT overflow is the only method for restarting an RZ/A SoC. Signed-off-by: Chris Brandt --- drivers/watchdog/Kconfig

Re: [PATCH v2 1/3] power: reset: Add Renesas reset driver

On Wed, Feb 22, 2017 at 01:35:12PM +, Chris Brandt wrote: > Hello Geert and Guenter, > > On Thursday, February 16, 2017, Guenter Roeck wrote: > > FWIW, the watchdog subsystem should support that easily, even with 125 ms > > hardware timeout. We added that capability

Re: [PATCH v2 1/3] power: reset: Add Renesas reset driver

On 02/17/2017 12:09 AM, Geert Uytterhoeven wrote: Hi Günter, On Fri, Feb 17, 2017 at 5:45 AM, Guenter Roeck <li...@roeck-us.net> wrote: On 02/16/2017 06:00 PM, Chris Brandt wrote: On Thursday, February 16, 2017, Guenter Roeck wrote: If this WDT had a timeout longer than 125ms, I woul

Re: [PATCH v2 1/3] power: reset: Add Renesas reset driver

On 02/16/2017 06:00 PM, Chris Brandt wrote: On Thursday, February 16, 2017, Guenter Roeck wrote: Hmm, ok. Guess I don't have to understand that you can not use the watchdog driver because of the above, but implementing exactly the same functionality in a separate driver is ok. [ I am sure I am

Re: [PATCH v2 1/3] power: reset: Add Renesas reset driver

On Thu, Feb 16, 2017 at 06:40:05PM +, Chris Brandt wrote: > On Thursday, February 16, 2017, Guenter Roeck wrote: > > On Thu, Feb 16, 2017 at 12:23:18PM -0500, Chris Brandt wrote: > > > Some Renesas SoCs do not have a reset register and the only way to do a SW > > >

Re: [PATCH v2 1/3] power: reset: Add Renesas reset driver

On Thu, Feb 16, 2017 at 12:23:18PM -0500, Chris Brandt wrote: > Some Renesas SoCs do not have a reset register and the only way to do a SW > controlled reset is to use the watchdog timer. Additionally, since all the > WDT timeout options are so quick, a system reset is about the only thing > it's

Re: [PATCH v2] watchdog: softdog: make pretimeout support a compile option

y useful, so make this feature a compile time option which nees to > be enabled explicitly. This also removes the overhead if pretimeout > support is not used because it will now be compiled away (saving ~10% on > ARM32). > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineer

Re: [PATCH] watchdog: softdog: make pretimeout support a compile option

On Fri, Jan 06, 2017 at 09:41:44AM +0100, Wolfram Sang wrote: > It occured to me that the panic pretimeout governor will stall the > softdog, because it is purely software which simply halts on panic. > Testing governors with the softdog on the other hand is really useful. > So, make this feature

Re: [RFC/PATCH] linux/kernel.h: Fix DIV_ROUND_CLOSEST to support negative divisors

on why this is not already supported? If so please let me know and I can do something locally in the driver and sorry for the noise. Only reason is that I could not figure out a way to make it work. LGTM except for nitpick. Reviewed-by: Guenter Roeck <li...@roeck-us.net> include/linux/kernel.h | 10 +

Re: [PATCH 1/7] watchdog: add watchdog pretimeout framework

On Thu, May 26, 2016 at 06:41:36PM +0200, Wolfram Sang wrote: [ ... ] > > No doubt about that. I had some ideas and thought it is easier to talk > over code. If you want to rebase it, too, I'd be happy to check what you > came up with to solve the problems. I might still argue that I prefer > the

Re: [PATCH 3/7] watchdog: softdog: consistently use softdog_ prefix

On Wed, May 25, 2016 at 08:37:45AM +0200, Wolfram Sang wrote: > From: Wolfram Sang <wsa+rene...@sang-engineering.com> > > And move module_init/exit to the proper place while here. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Guente

Re: [PATCH 4/7] watchdog: softdog: remove forward declaration

On Wed, May 25, 2016 at 08:37:46AM +0200, Wolfram Sang wrote: > From: Wolfram Sang <wsa+rene...@sang-engineering.com> > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > drivers/watchdog

Re: [PATCH 5/7] watchdog: softdog: sort includes to avoid duplicates

On Wed, May 25, 2016 at 08:37:47AM +0200, Wolfram Sang wrote: > From: Wolfram Sang <wsa+rene...@sang-engineering.com> > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > drivers/watchdog/so

Re: [PATCH 6/7] watchdog: softdog: drop superfluous set_timeout callback

-engineering.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > drivers/watchdog/softdog.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/watchdog/softdog.c b/drivers/watchdog/softdog.c > index ab0e02fc81a276..5e3a30b99d4415 100644 >

Re: [PATCH 7/7] watchdog: softdog: improve coding style

On Wed, May 25, 2016 at 08:37:49AM +0200, Wolfram Sang wrote: > From: Wolfram Sang <wsa+rene...@sang-engineering.com> > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > drivers/watchd

Re: [PATCH 2/7] watchdog: softdog: use watchdog core to init timeout value

e described behaviour. While updating the init message anyhow, > shorten it while we are here; no need for versioning there as well and > the name is already given via pr_fmt. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Guenter Roeck <li..

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

On Mon, Apr 04, 2016 at 08:14:02PM +0200, Geert Uytterhoeven wrote: > Hi Günter, > > On Mon, Apr 4, 2016 at 7:52 PM, Guenter Roeck <li...@roeck-us.net> wrote: > > On Mon, Apr 04, 2016 at 07:02:45PM +0200, Geert Uytterhoeven wrote: > >> On Mon, Apr 4, 2016 at 5:25

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

On Mon, Apr 04, 2016 at 07:02:45PM +0200, Geert Uytterhoeven wrote: > Hi Günter, > > On Mon, Apr 4, 2016 at 5:25 PM, Guenter Roeck <li...@roeck-us.net> wrote: > > On Mon, Apr 04, 2016 at 05:21:44PM +0200, Geert Uytterhoeven wrote: > >> On Mon, Apr 4, 20

Re: [PATCH v2 4/4] arm64: defconfig: enable Renesas Watchdog Timer

On Fri, Apr 01, 2016 at 01:56:26PM +0200, Wolfram Sang wrote: > From: Wolfram Sang <wsa+rene...@sang-engineering.com> > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> > --- > arch/arm64/configs/d

Re: [PATCH v2 2/4] arm64: dts: r8a7795: Add RWDT node

Wolfram Sang <wsa+rene...@sang-engineering.com> Acked-by: Guenter Roeck <li...@roeck-us.net> I assume the dts patches will go through the an arm64 tree. Is this correct ? Thanks, Guenter > --- > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 8 > 1 file changed, 8 insertio

Re: [PATCH 1/4] watchdog: renesas-wdt: add driver

Hi Wolfram, On 04/01/2016 04:36 AM, Wolfram Sang wrote: Hi Guenter, +static bool nowayout = WATCHDOG_NOWAYOUT; +module_param(nowayout, bool, S_IRUGO); Sure you want this parameter readable ? No problem with me, but it is unusual, so I figure it is worth asking. No reason, will stick to

Re: [PATCH 1/4] watchdog: renesas-wdt: add driver

Hi Wolfram, On Wed, Mar 30, 2016 at 05:28:42PM +0200, Wolfram Sang wrote: > From: Wolfram Sang > > Add support for watchdogs (RWDT and SWDT) found on RCar Gen3 based SoCs > from Renesas. > > Signed-off-by: Wolfram Sang > ---