Re: [PATCH] dt-bindings: can: rcar_can: Fix R8A7796 SoC name

2018-05-05 Thread Marc Kleine-Budde
On 05/03/2018 03:02 PM, Geert Uytterhoeven wrote: > R8A7796 is R-Car M3-W. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Applied to linux-can. thnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions|

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77980 bindings

2018-04-30 Thread Marc Kleine-Budde
On 04/27/2018 08:53 PM, Sergei Shtylyov wrote: > Document the R-Car V3H (R8A77980) SoC support in the R-Car CAN-FD bindings. > > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Applied to linux-can. tnx, Marc -- Pengutronix e.K. | Ma

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings

2018-04-30 Thread Marc Kleine-Budde
>> >> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> > > Reviewed-by: Ramesh Shanmugasundaram <ramesh.shanmugasunda...@bp.renesas.com> Applied to linux-can. tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial

Re: [PATCH] can: m_can: change comparison to bitshift when dealing with a mask

2018-02-08 Thread Marc Kleine-Budde
nly build tested. Applied to can. Luckily that define is not used :) Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsger

Re: [PATCH] can: m_can: change comparison to bitshift when dealing with a mask

2018-02-08 Thread Marc Kleine-Budde
tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc D

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2018-01-26 Thread Marc Kleine-Budde
On 01/25/2018 09:53 AM, Marc Kleine-Budde wrote: > On 01/24/2018 06:22 PM, Fabrizio Castro wrote: >> thank you for Acking the patch, just wondering if this patch has any >> chance to end up in v4.16? > > I can take this via the linux-can tree, if no one else takes

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2018-01-25 Thread Marc Kleine-Budde
On 01/24/2018 06:22 PM, Fabrizio Castro wrote: > thank you for Acking the patch, just wondering if this patch has any > chance to end up in v4.16? I can take this via the linux-can tree, if no one else takes it. Marc -- Pengutronix e.K. | Marc Kleine

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2017-12-19 Thread Marc Kleine-Budde
On 12/19/2017 11:17 AM, Fabrizio Castro wrote: > Hello Marc, > > does this patch look ok to you? Yes, Acked-by: Marc Kleine-Budde <m...@pengutronix.de> Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +

Re: [PATCH] can: rcar_can: Do not print virtual addresses

2017-04-04 Thread Marc Kleine-Budde
g it. The (useful) physical address is already > printed as part of the device name. > > Fixes: fd1159318e55e901 ("can: add Renesas R-Car CAN driver") > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Thanks, applied and included in pull request. Mar -

Re: [PATCH] can: rcar_canfd: Correct order of interrupt specifiers

2016-12-01 Thread Marc Kleine-Budde
d-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Added to can-next. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht

Re: [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support

2016-11-23 Thread Marc Kleine-Budde
On 11/23/2016 03:29 PM, Simon Horman wrote: > On Wed, Nov 23, 2016 at 02:18:13PM +0100, Marc Kleine-Budde wrote: >> On 11/23/2016 01:14 PM, Chris Paterson wrote: >>> This patch series adds CAN and CAN FD support to the r8a7796. >>> >>> Based on renesas-de

Re: [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support

2016-11-23 Thread Marc Kleine-Budde
es changed, 75 insertions(+), 10 deletions(-) For all three: Acked-by: Marc Kleine-Budde <m...@pengutronix.de> Who takes this series? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West

Re: [[RESEND]PATCH v7 0/2] Add CAN FD driver support to r8a7795 SoC

2016-06-17 Thread Marc Kleine-Budde
Marc K appears to be inactive and we haven't heard from him since March. I'll take the patch. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-555

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-04-01 Thread Marc Kleine-Budde
On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote: > This patch adds support for the CAN FD controller found in Renesas R-Car > SoCs. The controller operates in CAN FD mode by default. > > CAN FD mode supports both Classical CAN & CAN FD frame formats. The > controller supports ISO

Re: [PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-15 Thread Marc Kleine-Budde
oved > check in rcar_canfd_start (as suggested by Oliver H) > (Refer: http://comments.gmane.org/gmane.linux.can/9126 & > > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg01867.html) > * Clubbed Renesas controller drivers to driver/net/

Re: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-02 Thread Marc Kleine-Budde
Ok - I haven't looked at the code in depth yet. Now it's clear, that just the tx interrupt is shared. > Sorry if I am annoying. I have tested this with two channels > transmitting & receiving at the same time and it works fine. If I am > missing lock, I would like to understand it thoroughly

Re: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-02 Thread Marc Kleine-Budde
networking subsystem may send one frame to each controller at the same time. > However, looking at it again, I should move the incrementing of head > after the "sts" handing to be apt. What do you think? With one producer (one SW instance) and one consumer (the HW) you can write

Re: [PATCH] arm64: dts: r8a7795: Add CAN support

2016-03-01 Thread Marc Kleine-Budde
00 > CAN Channel 1 - 0xe6c38000 > > Signed-off-by: Ramesh Shanmugasundaram > <ramesh.shanmugasunda...@bp.renesas.com> > --- > Hi All, > >This patch is based on linux-next (tag:next-20160225) with following patch >applied on top Who should take this patch? Marc

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
On 02/29/2016 11:00 AM, Marc Kleine-Budde wrote: > I think it's better to fix the algorithm. I'll look into it. What about: > ./can-calc-bit-timing -c 3998 rcar_can > > Bit timing parameters for rcar_can with 39.98 M

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
On 02/29/2016 10:56 AM, Ramesh Shanmugasundaram wrote: > root@salvator-x:~# can-calc-bit-timing -c 3998 rcar_can Can you send me the patches to support the rcar_can. On the linux-can ML or github pull request. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Bu

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
ll > bitrates. > > Below is an e.g. from my board for an input clock differs by 2Hz. I think it's better to fix the algorithm. I'll look into it. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 |

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
On 02/29/2016 10:21 AM, Ramesh Shanmugasundaram wrote: > Added r8a7795 SoC support. > > For smoother bit timing calculation, the rounded clock frequency is used. Why this? From my point of view this introduces a clock error. Marc -- Pengutronix e.K. | Marc Kle

Re: [PATCH can-next v2 0/2] CAN: rcar: add fallback and r8a779[234] bindings

2016-02-24 Thread Marc Kleine-Budde
aner consistent with that progressively being used > for drivers for other IP blocks used by Renesas SoCs. > > For changes since v1 see individial patch changelogs. > > Based on linux-can-next/master Applied to can-next. Thanks, Marc -- Pengutronix e.K. | Marc Klein

Re: [PATCH can-next 1/2] CAN: rcar: add gen[12] fallback compatibility strings

2016-02-22 Thread Marc Kleine-Budde
You can add one that identifies your SoC's IP core in front of it. So there's no need to modify the driver until an IP core needs different handling. In your case you'd identify the oldest SoC that implements the Gen1 IP core and use this instead of "renesas,can-gen1. Same f