Hi Shimodo-san,
Thanks for your work.
On 2019-10-03 12:58:03 +0900, Yoshihiro Shimoda wrote:
> This patch series is based on the linux-next.git / next-20191001 tag.
For the whole series,
Reviewed-by: Niklas Söderlund
>
> Changes from v3:
> - Rebase the latest linux-next.git.
&g
ate check while at it.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> v2:
> - Split off from "clk: renesas: rcar-gen3: Switch SD clocks to
> .determine_rate()".
> ---
> drivers/clk/renesas/rcar-gen3-cpg.c | 12 ---
Hi Geert,
Thanks for your work.
On 2019-08-30 15:45:11 +0200, Geert Uytterhoeven wrote:
> cpg_sd_clock_round_rate() is the sole caller of cpg_sd_clock_calc_div(),
> hence absorb the latter into the former.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
epeat the work done by
> .round_rate(), and a second time to find the corresponding divider
> entry.
>
> Just iterate once, looking for the divider that matches the passed clock
> rate.
>
> Signed-off-by: Geert Uytterhoeven
Clever :-)
Reviewed-by: Niklas Söderlund
d-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> v2:
> - New.
> ---
> drivers/clk/renesas/rcar-gen3-cpg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/renesas/rcar-gen3-cpg.c
> b/drivers/clk/renesa
- Prioritize multiplication over division, to increase accuracy.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> v2:
> - New.
> ---
> drivers/clk/renesas/rcar-gen2-cpg.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
/Documentation/devicetree/bindings/clock/emev2-renesas,emev2-smu.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/clock/emev2-clock.txt
> rename to Documentation/devicetree/bindings/clock/emev2-renesas,emev2-smu.txt
> --
> 2.11.0
>
--
Regards,
Niklas Söderlund
; Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> To be queued in renesas-devel for v5.4.
>
> drivers/soc/renesas/rcar-sysc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/soc/renesas/rcar-sysc.c b/drivers/soc/renesa
uct platform_device *pdev)
> if (ret)
> goto err_clk;
>
> - dev_info(&pdev->dev, "Added i2c controller %d, irq %d\n",
> priv->adap.nr, irq);
> + dev_info(&pdev->dev, "Added i2c controller %d, irq %d\n", priv->adap.nr,
> + priv->irq);
>
> return 0;
>
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
coded.
>
> Since commit e135303bd5bebcd2 ("device: Add dev__once variants")
> they do, so "revert" to the good practice of using a helper.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> To be queued in sh-pfc-for-v5.4.
>
h SD and
> eMMC, before and after suspend.
>
> CU
> Uli
>
>
> Ulrich Hecht (2):
> mmc: tmio: leave clock handling to PM if enabled
> mmc: tmio: remove obsolete PM workaround
Tested-by: Niklas Söderlund
>
> drivers/mmc/host/tmio_mmc_core.c | 33 ++--
; Niklas, I'd really like your feedback on this one because you did the PM
> refactorization lately.
I would like to test this too. Unfortunately I'm on the road and will be
back in the office the 23rd so I will have to postpone doing so until
then. My initial comment is that this lo
th Shimoda-sans comment on 2/2 fixed for the whole series,
Reviewed-by: Niklas Söderlund
>
> Simon Horman (2):
> dt-bindings: usb: renesas_usbhs: Rename bindings documentation file
> dt-bindings: usb: renesas_gen3: Rename bindings documentation file
>
> .../devicetree/bindings
; Signed-off-by: Simon Horman
Reviewed-by: Niklas Söderlund
> ---
> .../devicetree/bindings/watchdog/{renesas-wdt.txt => renesas,wdt.txt} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename Documentation/devicetree/bindings/watchdog/{renesas-wdt.txt =>
&g
Hi (again) Wolfram,
I now see there was a v2 of this series which addressed Geert's
comments. Sorry for missing this and replying to v1. For the whole
series,
Reviewed-by: Niklas Söderlund
On 2019-06-06 13:35:34 +0200, Wolfram Sang wrote:
> There are some more SoCs which cannot hand
eert's comments,
Reviewed-by: Niklas Söderlund
>
> drivers/mmc/host/renesas_sdhi_core.c | 19 ---
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> --
> 2.11.0
>
--
Regards,
Niklas Söderlund
re disabling module clock.
>
> So, this patch adds such delays.
>
> Signed-off-by: Yoshihiro Shimoda
> Reviewed-by: Geert Uytterhoeven
Small nit bellow, with or without that addressed.
Reviewed-by: Niklas Söderlund
> ---
> Changes from v1 (https://patchwork.kernel.
in structure.
>
> Hence cpg_mssr_is_pm_clk() can use that instead of its own copy in the
> driver-private cpg_mssr_clk_domain structure.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> To be queued in clk-renesas-for-v5.3.
>
> drivers/clk/re
e of that.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> To be queued in clk-renesas-for-v5.3.
>
> drivers/clk/renesas/renesas-cpg-mssr.c | 8 ++--
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/renesas
e of that.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> To be queued in clk-renesas-for-v5.3.
>
> drivers/clk/renesas/clk-mstp.c | 8 ++--
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/renesas/clk-mst
Hi Geert,
Thanks for your feedback.
On 2019-05-08 11:03:05 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Mon, Apr 15, 2019 at 1:10 PM Wolfram Sang wrote:
> > On Thu, Apr 11, 2019 at 12:22:40AM +0200, Niklas Söderlund wrote:
> > > Both the Renesas and Uniphier
this consistent?
>
> Thanks for your comments!
I really like how this is used, much better then SH_PFC_PIN_NAMED
approach!
I have not reviewed all renames of PIN_NUMBER() to their more
descriptive names, but did spot checks to make sure it made sens. I
trust you for the rest ;-) For t
in his thread [1] where I tried to get to the bottom of the issue. My
conclusions there might be wrong due to the issues addressed in this
patch.
Michael: Did you have Steve's patch in your tree when testing this?
1. https://patchwork.kernel.org/patch/10904263/
--
Regards,
Niklas Söderlund
gt;mtu = new_mtu;
> > - netdev_update_features(ndev);
> >
> > - return 0;
> > + return ravb_open(ndev);
>
>How about the code below instead?
>
> if (netif_running(ndev))
> ravb_close(ndev);
>
> ndev->mtu = new_mtu;
> netdev_update_features(ndev);
Is there a need to call netdev_update_features() even if the if is not
running?
>
> if (netif_running(ndev))
> return ravb_open(ndev);
>
> return 0;
>
> [...]
>
> MBR, Sergei
--
Regards,
Niklas Söderlund
ith or without the code relayout suggested by Sergei,
Reviewed-by: Niklas Söderlund
Also as he points out I used the same pattern for sh_eth while adding
MTU configuration support so a similar patch there would be nice. I'm
happy to see the fix to allow for changing the MTU when the devi
Hello,
On 2019-04-26 11:55:11 +0200, Simon Horman wrote:
> On Wed, Apr 24, 2019 at 09:10:56AM +0200, Geert Uytterhoeven wrote:
> > Hi Niklas,
> >
> > On Thu, Apr 18, 2019 at 10:12 AM Niklas Söderlund
> > wrote:
> > > On 2019-04-18 09:15:14 +0200, Simon H
Hi Laurent and Simon,
On 2019-04-20 02:30:49 +0300, Laurent Pinchart wrote:
> Hi Niklas,
>
> On Wed, Mar 13, 2019 at 02:46:28PM +0100, Niklas Söderlund wrote:
> > On 2019-03-13 11:51:18 +0100, Simon Horman wrote:
> > > The ports node of vin4 only has one sub-node and
rmal_set_trips(void *devdata, int low, int high)
> @@ -440,7 +442,7 @@ static int rcar_gen3_thermal_probe(struct platform_device
> *pdev)
> priv->tscs[i] = tsc;
>
> priv->thermal_init(tsc);
> - rcar_gen3_thermal_calc_coefs(&tsc->coef, ptat, thcode[i],
> + rcar_gen3_thermal_calc_coefs(tsc, ptat, thcode[i],
>*rcar_gen3_ths_tj_1);
>
> zone = devm_thermal_zone_of_sensor_register(dev, i, tsc,
> --
> 1.9.1
>
--
Regards,
Niklas Söderlund
+440,8 @@ static int rcar_gen3_thermal_probe(struct platform_device
> *pdev)
> priv->tscs[i] = tsc;
>
> priv->thermal_init(tsc);
> - rcar_gen3_thermal_calc_coefs(&tsc->coef, ptat, thcode[i]);
> + rcar_gen3_thermal_calc_coefs(&tsc->coef, ptat, thcode[i],
> + *rcar_gen3_ths_tj_1);
>
> zone = devm_thermal_zone_of_sensor_register(dev, i, tsc,
>
> &rcar_gen3_tz_of_ops);
> --
> 1.9.1
>
--
Regards,
Niklas Söderlund
;
I confirm that the calculations here are correct, but hard to read ;-)
With the rename about how about.
if (priv->chip->gen3) {
if (priv->ctemp < 24)
tmp = MCELSIUS(((priv->ctemp * 55) - 720) / 10);
else
tmp = MCELSIUS((priv->ctemp * 5) - 60);
} else {
tmp = MCELSIUS((priv->ctemp * 5) - 65);
}
> mutex_unlock(&priv->lock);
>
> if ((tmp < MCELSIUS(-45)) || (tmp > MCELSIUS(125))) {
> --
> 2.11.0
>
--
Regards,
Niklas Söderlund
Hi Steve,
On 2019-04-17 16:30:53 -0700, Steve Longerbeam wrote:
>
>
> On 4/17/19 12:26 PM, Niklas Söderlund wrote:
> > Hi Steve,
> >
> > On 2019-04-17 10:56:55 -0700, Steve Longerbeam wrote:
> > > Hi Nklas,
> > >
> > > On 4/16
Hi Steve,
On 2019-04-17 10:56:55 -0700, Steve Longerbeam wrote:
> Hi Nklas,
>
> On 4/16/19 4:59 PM, Steve Longerbeam wrote:
> > Hi Niklas,
> >
> > On 4/16/19 4:50 PM, Niklas Söderlund wrote:
> > > Hi Steve,
> > >
> > > Thanks for your work
priv, FLD_REG, fld);
> +
> rcsi2_write(priv, VCDT_REG, vcdt);
> if (vcdt2)
> rcsi2_write(priv, VCDT2_REG, vcdt2);
> @@ -591,7 +618,7 @@ static int rcsi2_s_stream(struct v4l2_subdev *sd, int
> enable)
> if (enable && priv->stream_count == 0) {
> pm_runtime_get_sync(priv->dev);
>
> - ret = rcsi2_start(priv);
> + ret = rcsi2_start(priv, nextsd);
> if (ret) {
> pm_runtime_put(priv->dev);
> goto out;
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
The helpers rvin_power_{on,off} deals with both VIN and the parallel
subdevice power. This makes it hard to merge the Gen2 and Gen3
open/release functions. Move the VIN power handling directly to the
open/release functions to prepare for the merge.
Signed-off-by: Niklas Söderlund
---
drivers
The format is already synced when the subdevice is bound, there is no
need to do do it every time the video device is opened.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 25 -
1 file changed, 25 deletions(-)
diff --git a/drivers/media
The two power helpers are now only dealing with the parallel subdevice,
merge them into a single rvin_power_parallel() helper to reduce code
duplication.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 20 +---
1 file changed, 5 insertions
The function no longer serve a purpose as most tasks it performed have
been refactored, fold what remains it into the only caller.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 21 -
1 file changed, 4 insertions(+), 17 deletions(-)
diff
The driver do not implement runtime resume and suspend function so there
is little point in trying to call them. This is a leftover from the
drivers soc_camera beginnings.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 5 -
1 file changed, 5 deletions
After the rework of the Gen2 file operations it's now trivial to merge
the Gen2 and Gen3 versions.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 96 -
1 file changed, 16 insertions(+), 80 deletions(-)
diff --git a/drivers/media/pla
media controller way of looking at things ;-)
After refactoring out a lot of code left over from the Gen2 mode which
stems from the drivers origin in soc_camera it became apparent that a
lot of code could me removed my merging the two sets.
Tested on both Gen2 and Gen3 no regressions found.
Niklas
Runtime PM is already enable unconditionally when the driver is probed
and disabled when it's removed. There is no point in doing it again for
Gen2 when opening and closing the video device.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 7 +--
1
The user should be allowed to break waiting for the lock when opening
the video device.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c
b/drivers
Hi Eugeniu,
On 2019-04-12 16:12:05 +0200, Eugeniu Rosca wrote:
> Hi Niklas,
>
> On Thu, Apr 11, 2019 at 10:42:37PM +0200, Niklas Söderlund wrote:
> > Hi Eugenie,
> >
> > On 2019-04-11 22:28:19 +0200, Eugeniu Rosca wrote:
> > > Hi Niklas,
> > >
&g
his function while suspend
> to reduce the energy consumption.
>
> Signed-off-by: Hoan Nguyen An
Nice clean commit and matches the datasheet,
Reviewed-by: Niklas Söderlund
Interrupts fire both before and after suspending as expected,
Tested-by: Niklas Söderlund
>
rs/thermal/rcar_gen3_thermal.c
> > b/drivers/thermal/rcar_gen3_thermal.c
> > index 88fa41c..de6f244 100644
> > --- a/drivers/thermal/rcar_gen3_thermal.c
> > +++ b/drivers/thermal/rcar_gen3_thermal.c
> > @@ -63,6 +63,15 @@
> >
> > #define TSC_MAX_NUM3
> >
> > +static int tj_2;
>
> We need to avoid global variables. There can be multiple
> instances of this driver. (Although they will all get the same
> value for tj_2.
>
> Perhaps it can be added to struct rcar_gen3_thermal_tsc?
>
> ...
--
Regards,
Niklas Söderlund
s I do not know. Do you think it would be worth following-up on
> internally?
I'm no expert on this but I think it could be educational to learn why
not the full range is used. Still this might be correct so I don't want
to block this patch based on my ignorance.
--
Regards,
Niklas Söderlund
/dts/r8a77470.dtsi| 608
> +++++
> drivers/gpu/drm/rcar-du/rcar_lvds.c| 1 +
> 9 files changed, 616 insertions(+)
>
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
On 2019-04-11 10:49:37 +0200, Simon Horman wrote:
> On Wed, Apr 10, 2019 at 08:26:57PM +0200, Niklas Söderlund wrote:
> > From: Hiroyuki Yokoyama
> >
> > Update copyright and string for Gen3.
> >
> > Signed-off-by: Hiroyuki Yokoyama
> > Signed-off-by: Ni
other resources are switched on.
Reported-by: Geert Uytterhoeven
Signed-off-by: Niklas Söderlund
---
drivers/mmc/host/renesas_sdhi_core.c | 6 ++
drivers/mmc/host/tmio_mmc.c | 5 +
drivers/mmc/host/tmio_mmc_core.c | 11 +--
drivers/mmc/host/uniphier-sd.c | 3
From: Hiroyuki Yokoyama
Update copyright and string for Gen3.
Signed-off-by: Hiroyuki Yokoyama
Signed-off-by: Niklas Söderlund
---
drivers/dma/sh/rcar-dmac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
index
&sysc R8A77470_PD_ALWAYS_ON>;
> + resets = <&cpg 810>;
> + status = "disabled";
> + };
> +
> sdhi0: sd@ee10 {
> compatible = "renesas,sdhi-r8a77470",
>"renesas,rcar-gen2-sdhi";
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
e_defconfig and multi_v7_defconfig.
>
> Note that kernels built from these configs cannot be booted by stock
> APE6EVM U-Boot, due to kernel size.
For the whole series,
Reviewed-by: Niklas Söderlund
>
> Thanks!
>
> Geert Uytterhoeven (2):
> ARM: shmobile: defconfig: E
Hi Geert,
Thanks for your work, you are a life saver :-)
On 2019-03-20 20:45:22 +0100, Geert Uytterhoeven wrote:
> Describe the 128 MiB CFI NOR FLASH, which contains the boot loader and
> its environment.
>
> Signed-off-by: Geert Uytterhoeven
Tested-by: Niklas Söderlund
>
w I read the code, nice catch.
Reviewed-by: Niklas Söderlund
> ---
>
> This patch depends on "[RFT] mmc: renesas_sdhi: limit block count to 16 bit
> for
> old revisions" [1]. This one, however, is not backed by a bug report but just
> found by code review. I woul
- Make sure the device is runtime-resumed when disabling interrupts in
> .remove().
Thanks for this change, it was educational for me to review.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> I don't think it's worth splitting off
Hi Geert,
Thanks for your work.
On 2019-03-20 11:44:46 +0100, Geert Uytterhoeven wrote:
> - The IPSR field is meant for documentation only,
> - The function name refers to the pin function, not to the IPSR field.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Nikl
Hi Wolfram,
Thanks for your work.
On 2019-03-14 23:54:41 +0100, Wolfram Sang wrote:
> Mostly year updates, but one addition as well.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Niklas Söderlund
> ---
>
> I checked the git history to back up these changes to the best of my
t;1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> -
> + port {
> vin4_in: endpoint {
> remote-endpoint = <&adv7180_out>;
> };
> --
> 2.11.0
>
--
Regards,
Niklas Söderlund
tches my understanding of reserved
addresses in the specification, feel free to add for the whole series
Reviewed-by: Niklas Söderlund
>
>
> Wolfram Sang (2):
> tools: i2ctransfer: man: mention -a everywhere
> tools: restrict all addresses defined by the standard
>
>
The compatible value renesas,rcar-gen3-csi2 was used while prototyping
the R-Car CSI-2 driver but was removed before the driver was merged.
Fixes: e961ab42e034d469 ("arm64: dts: renesas: r8a774c0: Add VIN and CSI-2
device nodes")
Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/d
Cc: Phil Edworthy
> Cc: Simon Horman
> Cc: Wolfram Sang
> Cc: linux-renesas-soc@vger.kernel.org
> To: linux-...@vger.kernel.org
Reviewed-by: Niklas Söderlund
> ---
> drivers/pci/controller/pcie-rcar.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> d
on Horman
> Cc: Wolfram Sang
> Cc: linux-renesas-soc@vger.kernel.org
> To: linux-...@vger.kernel.org
Reviewed-by: Niklas Söderlund
> ---
> drivers/pci/controller/pcie-rcar.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/co
mething? What scenario do you see where this can fail?
>
> strscpy(mdev->driver_name, KBUILD_MODNAME, sizeof(mdev->driver_name));
> strscpy(mdev->model, match->compatible, sizeof(mdev->model));
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
Latest datasheet (rev 1.50) clarifies that the FLD register should be
set after LINKCNT.
Signed-off-by: Niklas Söderlund
Reviewed-by: Ulrich Hecht
Reviewed-by: Kieran Bingham
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Latest information from hardware engineers reveals that H3 ES2 and ES3
behave differently when working with link speeds bellow 250 Mpbs.
Add a SoC match for H3 ES2.* and use the correct startup sequence.
Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
---
drivers/media/platform
The latest datasheet (rev 1.50) updates the start procedure for V3M and
E3. Update the driver to match these changes.
Signed-off-by: Niklas Söderlund
Reviewed-by: Ulrich Hecht
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
Hi,
This series update the driver to match changes in the latest datasheet
(rev 1.50). All changes are related to register setup when starting the
stream.
This series depends on [PATCH v2] rcar-csi2: Propagate the FLD signal
for NTSC and PAL.
Niklas Söderlund (3):
rcar-csi2: Update V3M and
should be set to 0 when dealing with non-interlaced
field formats.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
---
Hi,
This patch depends on [PATCH v2 0/2] rcar-csi2: Use standby mode
The resets property will become mandatory to operate the device, list it
as such. All device tree source files have always included the reset
property so making it mandatory will not introduce any regressions.
While at it improve the description for the clocks property.
Signed-off-by: Niklas
from
rcsi2_s_stream() into the existing helper functions.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/Kconfig | 1 +
drivers/media/platform/rcar-vin/rcar-csi2.c | 69 +
2 files changed, 43 insertions(+), 27 deletions(-)
diff --git a/drivers/media
Hi,
This small series updates rcar-csi2 to use the standby mode described in
later versions of the datasheet.
* Changes since v1
- Break up enter and exit of standby mode in two separate functions.
- Add "select RESET_CONTROLLER" to Kconfig.
Niklas Söderlund (2):
dt-bindings: rcar-
Hi Hans,
Thanks for your feedback.
On 2019-03-08 15:12:15 +0100, Hans Verkuil wrote:
> On 2/16/19 11:57 PM, Niklas Söderlund wrote:
> > Allow the hardware to to do proper field detection for interlaced field
> > formats by implementing s_std() and g_std(). Depending on which vid
Hi Simon,
On 2019-03-08 13:02:33 +0100, Simon Horman wrote:
> On Wed, Mar 06, 2019 at 06:45:56PM +0100, Geert Uytterhoeven wrote:
> > Hi Niklas,
> >
> > On Wed, Mar 6, 2019 at 4:14 PM Niklas Söderlund
> > wrote:
> > > The compatible value renesas,rcar-
ating the CSI-2 and VIN
> to Niklas.
I be more then happy to collect patches for R-Car VIN and CSI-2 and send
PRs for them to you Hans. Would that work for you Hans?
--
Regards,
Niklas Söderlund
Hi Laurent,
On 2019-03-07 02:26:45 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> On Thu, Mar 07, 2019 at 01:22:36AM +0100, Niklas Söderlund wrote:
> > On 2019-03-07 02:13:18 +0200, Laurent Pinchart wrote:
> > > On Sat, Feb 16, 2019 at 11:57:58PM +0100, Niklas Söderlund
Hi Kieran,
Thanks for your feedback.
On 2019-02-18 11:19:50 +, Kieran Bingham wrote:
> Hi Niklas,
>
> On 18/02/2019 10:03, Niklas Söderlund wrote:
> > Latest datasheet (rev 1.50) clarifies that the FLD register should be
> > set after LINKCNT.
> >
> >
Hi Kieran,
Thanks for your feedback.
On 2019-02-18 11:01:51 +, Kieran Bingham wrote:
> Hi Niklas,
>
> On 18/02/2019 10:03, Niklas Söderlund wrote:
> > Latest information from hardware engineers reveals that H3 ES2 and ES3
> > of behaves differently when working with l
Hi Ulrich,
Thanks for your feedback.
On 2019-02-18 12:12:19 +0100, Ulrich Hecht wrote:
>
> > On February 18, 2019 at 11:03 AM Niklas Söderlund
> > wrote:
> >
> >
> > Latest information from hardware engineers reveals that H3 ES2 and ES3
> > of beh
Hi Laurent,
Thanks for your feedback.
On 2019-03-07 02:13:18 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Sat, Feb 16, 2019 at 11:57:58PM +0100, Niklas Söderlund wrote:
> > Allow the hardware to to do proper field detection for interlaced
Hi Geert,
Thanks for your feedback.
On 2019-02-18 10:07:04 +0100, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Sun, Feb 17, 2019 at 8:54 AM Niklas Söderlund
> wrote:
> > Later versions of the datasheet updates the reset procedure to more
> > closely resemble the
Hi Sergei,
Thanks for your feedback.
On 2019-02-17 11:47:28 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 17.02.2019 1:57, Niklas Söderlund wrote:
>
> > Allow the hardware to to do proper field detection for interlaced field
> > formats by implementing s_std() and g_s
>
> What am I doing wrong?
You answered your own question in a later mail, thanks for that ;-)
>
> On Sat, Feb 16, 2019 at 11:57:58PM +0100, Niklas Söderlund wrote:
> > Allow the hardware to to do proper field detection for interlaced field
> > formats by implementing
Hi Jacopo,
Thanks for your feedback.
On 2019-02-17 20:41:24 +0100, Jacopo Mondi wrote:
> Hi Niklas,
>ah, ups, this was maybe the patch the other one I just reviewed was
>based on... sorry, I missed this one :)
:-)
>
> On Sat, Feb 16, 2019 at 11:56:38PM +0100, Niklas
Hi Geert,
On 2019-03-06 18:45:56 +0100, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Wed, Mar 6, 2019 at 4:14 PM Niklas Söderlund
> wrote:
> > The compatible value renesas,rcar-gen3-csi2 was used while prototyping
> > the R-Car CSI-2 driver but was removed befo
On 2019-03-06 14:04:35 +0100, Simon Horman wrote:
> On Wed, Mar 06, 2019 at 12:47:36PM +0100, Niklas Söderlund wrote:
> > Hi Simon,
> >
> > On 2019-02-25 11:09:54 +0100, Simon Horman wrote:
> > [snip]
> > > Thanks, applied with the subject prefix updated
The compatible value renesas,rcar-gen3-csi2 was used while prototyping
the R-Car CSI-2 driver but was removed before the driver was merged.
Remove the only occurrence of the compatible value which manage to make
it upstream.
Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/dts/renesas
Hi Simon,
On 2019-02-25 11:09:54 +0100, Simon Horman wrote:
[snip]
> Thanks, applied with the subject prefix updated to
>
> "arm64: dts: renesas: ebisu:"
You took patch 1/2 from this series but not 2/2. Was that intentional?
--
Regards,
Niklas Söderlund
cpg_core_clk parsing and unmarshalling contained in a
> single function (rcar_gen3_cpg_clk_register()).
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> To be queued in clk-renesas-for-v5.2.
>
> drivers/clk/renesas/rcar-gen3-cpg.c | 12
Hi Geert,
Thanks for your patch.
On 2019-03-01 10:38:31 +0100, Geert Uytterhoeven wrote:
> devm_ioremap_resource() already prints an error message on failure, so
> there is no need to repeat that.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
&
from the documentation.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Niklas Söderlund
> ---
> README | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/README b/README
> index 17920ee663c8..0d5a6967d7f5 100644
> --- a/README
> +++ b/README
> @@ -45,
something is not right. For obvious reasons
it's not possible to recover from all errors (video source disconnected
for example) but in such cases the user is at least informed of the
error and the same behavior of the stopped data flow is retained.
Signed-off-by: Niklas Söderlund
---
drivers/
Latest datasheet (rev 1.50) clarifies that the FLD register should be
set after LINKCNT.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c
b/drivers
Latest information from hardware engineers reveals that H3 ES2 and ES3
of behaves differently when working with link speeds bellow 250 Mpbs.
Add a SoC match for H3 ES2.* and use the correct startup sequence.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 39
The latest datasheet (rev 1.50) updates the start procedure for V3M and
E3. Update the driver to match these changes.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media
Hi,
This series update the driver to match changes in the latest datasheet
(rev 1.50). All changes are related to register setup when starting the
stream.
Niklas Söderlund (3):
rcar-csi2: Update V3M and E3 start procedure
rcar-csi2: Update start procedure for H3 ES2
rcar-csi2: Move
Hi Kieran,
On 2019-02-17 22:27:27 +, Kieran Bingham wrote:
> Hi Niklas,
>
> On 13/02/2019 22:07, Niklas Söderlund wrote:
> > Changes to v4l2-fwnode in commit [1] triggered a lockdep warning in
> > rcar-vin. The first attempt to solve this warning in the rcar-vin driver
&
From: Takeshi Kihara
The register address used for the reg property of the adv7482 node in
other Renesas device trees are decimal not hex, change this for Ebisu to
align it with the others.
Signed-off-by: Takeshi Kihara
[Niklas: rewrite commit message]
Signed-off-by: Niklas Söderlund
From: Takeshi Kihara
Both VIN4 and VIN5 are connected to CSI40 and can be configured at
runtime to use the single video source connected to CSI40. Enable VIN5
to allow it to be used in this fashion.
Signed-off-by: Takeshi Kihara
[Niklas: rewrite commit message]
Signed-off-by: Niklas Söderlund
Hi,
This series corrects two minor issues in the Ebisu's device tree related
to video capture. 1/2 aligns how other Renesas device trees represent
register addresses for the ports in the adv7482 node while 2/2 enables
VIN5 which is usable on the SoC but was disabled.
Patches are only compile t
clear
that FLD register should be set to 0 when dealing with none interlaced
field formats.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 33 +++--
1 file changed, 30 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/rcar-vin
1 - 100 of 1858 matches
Mail list logo
