Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 367 +++
1 file changed, 367 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 6ffab2da07cb9d67..7c25be6b5af3eea8 100644
--- a
. https://patchwork.linuxtv.org/patch/49476/
Kieran Bingham (1):
arm64: dts: renesas: salvator-common: Add ADV7482 support
Niklas Söderlund (6):
arm64: dts: renesas: r8a7795: add VIN and CSI-2 nodes
arm64: dts: renesas: r8a7795-es1: add CSI-2 node
arm64: dts: renesas: r8a7796: add VIN and CSI-2
-by: Niklas Söderlund
Acked-by: Rob Herring
Acked-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
Reviewed-by: Jacopo Mondi
---
* Changes since v14.
- Added compatible string for R8A77965 and R8A77970.
- s/Port 0/port@0/
- s/Port 1/port@1/
- s/Endpoint 0/endpoint@0/
* Changes since v13
- Add
_SINK].flags = MEDIA_PAD_FL_SINK;
+ for (i = RCAR_CSI2_SOURCE_VC0; i < NR_OF_RCAR_CSI2_PAD; i++)
+ priv->pads[i].flags = MEDIA_PAD_FL_SOURCE;
+
+ ret = media_entity_pads_init(&priv->subdev.entity, NR_OF_RCAR_CSI2_PAD,
+pri
after review comments and to add r8a7796 support.
- Add get_fmt handler.
- Fix media bus format error s/YUYV8/UYVY8/
Changes since v1:
- Drop dependency on a pad aware s_stream operation.
- Use the DT bindings format "renesas,-", thanks Geert
for pointing this out.
Niklas S
3-N later.
>
> Fix the grammar in all copies at once.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
Not sure a review tag from the one who made the grammar errors in the
first place is worth much... :-)
> ---
> To be queued in sh-pfc-for-v4.18.
>
Hi Jacopo,
Thanks for your feedback.
On 2018-05-14 15:14:48 +0200, Jacopo Mondi wrote:
> Hi Niklas,
>thanks for the patch
>
> On Sun, May 13, 2018 at 09:19:17PM +0200, Niklas Söderlund wrote:
> > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver
> >
Hi Jacopo,
On 2018-05-14 09:39:34 +0200, Jacopo Mondi wrote:
> Hi Niklas,
>
> On Sun, May 13, 2018 at 02:57:55PM +0200, Niklas Söderlund wrote:
> > Hi Jacopo,
> >
> > Thanks for your patch.
> >
> > On 2018-05-11 12:00:02 +0200, Jacopo Mondi wrote:
>
Hi again,
On 2018-05-14 11:49:00 +0200, Niklas Söderlund wrote:
> Hi Laurent,
>
> On 2018-05-14 05:49:41 +0300, Laurent Pinchart wrote:
>
> [snip]
>
> > > > +&vin4 {
> > > > + pinctrl-0 = <&vin4_pins>;
> > > > +
remote subdevice is not looking at its remote
endpoint for bus parameters not considered by the rcar-vin driver?
The thing is that the rcar-vin driver only looks at the remote endpoint
for these properties and ignores the on its local endpoint. Maybe some
v4l2 framework change is needed here to make sure the bus properties are
the same on both endpoints of a link. But I fear such a change would
break a lot of stuff.
--
Regards,
Niklas Söderlund
RCAR_CSI2_SOURCE_VC0; i < NR_OF_RCAR_CSI2_PAD; i++)
+ priv->pads[i].flags = MEDIA_PAD_FL_SOURCE;
+
+ ret = media_entity_pads_init(&priv->subdev.entity, NR_OF_RCAR_CSI2_PAD,
+priv->pads);
+ if (ret)
+ goto error;
+
+ pm_runtime_enable(&pdev->dev);
+
+ ret = v4l2_async_register_subdev(&priv->subdev);
+ if (ret < 0)
+ goto error;
+
+ dev_info(priv->dev, "%d lanes found\n", priv->lanes);
+
+ return 0;
+
+error:
+ v4l2_async_notifier_unregister(&priv->notifier);
+ v4l2_async_notifier_cleanup(&priv->notifier);
+
+ return ret;
+}
+
+static int rcsi2_remove(struct platform_device *pdev)
+{
+ struct rcar_csi2 *priv = platform_get_drvdata(pdev);
+
+ v4l2_async_notifier_unregister(&priv->notifier);
+ v4l2_async_notifier_cleanup(&priv->notifier);
+ v4l2_async_unregister_subdev(&priv->subdev);
+
+ pm_runtime_disable(&pdev->dev);
+
+ return 0;
+}
+
+static struct platform_driver __refdata rcar_csi2_pdrv = {
+ .remove = rcsi2_remove,
+ .probe = rcsi2_probe,
+ .driver = {
+ .name = "rcar-csi2",
+ .of_match_table = rcar_csi2_of_table,
+ },
+};
+
+module_platform_driver(rcar_csi2_pdrv);
+
+MODULE_AUTHOR("Niklas Söderlund ");
+MODULE_DESCRIPTION("Renesas R-Car MIPI CSI-2 receiver");
+MODULE_LICENSE("GPL");
--
2.17.0
-by: Niklas Söderlund
Acked-by: Rob Herring
Acked-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
---
* Changes since v14.
- Added compatible string for R8A77965 and R8A77970.
- s/Port 0/port@0/
- s/Port 1/port@1/
- s/Endpoint 0/endpoint@0/
* Changes since v13
- Add Laurent'
iew comments and to add r8a7796 support.
- Add get_fmt handler.
- Fix media bus format error s/YUYV8/UYVY8/
Changes since v1:
- Drop dependency on a pad aware s_stream operation.
- Use the DT bindings format "renesas,-", thanks Geert
for pointing this out.
Niklas Söderlund (2):
rcar
Hi Laurent,
On 2018-04-28 19:01:37 +0300, Laurent Pinchart wrote:
> Hi Niklas,
>
> On Friday, 27 April 2018 02:28:32 EEST Niklas Söderlund wrote:
> > On 2018-04-27 00:30:25 +0300, Laurent Pinchart wrote:
> > > On Thursday, 26 April 2018 23:21:21 EEST Niklas Söderlund wro
Add the SoC specific information for Renesas r8a77965.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-core.c | 48 +
1 file changed, 48 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar-core.c
b/drivers/media/platform/rcar-vin/rcar
Signed-off-by: Niklas Söderlund
---
Documentation/devicetree/bindings/media/rcar_vin.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt
b/Documentation/devicetree/bindings/media/rcar_vin.txt
index a19517e1c669eb35..c2c57dcf73f4851b
Hi Simon,
Thanks for your patch.
On 2018-05-09 20:45:58 +0200, Simon Horman wrote:
> The example vin port node does not have an address and thus does not
> need address-cells or address size-properties.
>
> Signed-off-by: Simon Horman
Acked-by: Niklas Söderlund
> ---
&
eal as the VIN driver don't use these properties so
no functional change should come of this but still a difference.
Over all I'm happy with this change but before I add my tag I would like
to understand why it differs from the Gen2 configuration for the adv7612
properties.
Also on a side not it is possible with hardware switches on the board
switch the VIN4 source to a completely different pipeline CVBS connector
-> adv7180 -> VIN4. But I think it's best we keep the HDMI as default as
this seems to be how the boards are shipped. But maybe mentioning this
in the commit message would not hurt if you end-up resending the patch.
> +
> + remote-endpoint = <&adv7612_out>;
> + };
> + };
> + };
> +};
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
Niklas,
>
> As you reviewed the rest of the series I'm wondering if you're planning
> to review this patch too.
Yes, I did not have schematics for D3 on hand when reviewing the rest of
the series. Will review it now that I do, thanks for the ping :-)
--
Regards,
Niklas Söderlund
Hi Simon,
On 2018-05-13 10:19:13 +0200, Simon Horman wrote:
> On Fri, May 11, 2018 at 04:00:29PM +0200, Niklas Söderlund wrote:
> > Signed-off-by: Niklas Söderlund
> > ---
> > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 99 ---
> > 1 file c
Signed-off-by: Niklas Söderlund
---
drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 77 +++
1 file changed, 77 insertions(+)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
index cea9d0599c1281a7..0c786fd78011376a 100644
--- a/drivers
Hi Kieran,
Thanks for your feedback.
On 2018-05-12 09:04:18 +0100, Kieran Bingham wrote:
> Hi Niklas, Laurent,
>
> Thanks for the updated patch and detailed investigation to get this right.
>
> On 11/05/18 15:04, Niklas Söderlund wrote:
> > From: Laurent Pinchart
> &
ted format resulting in the DMA engine not properly stopping
before writing outside the buffer.
This series reverts the incorrect fix in 1/2 and applies a correct one
in 2/2. I think this should be picked up for v4.18.
* Changes since v1
- Add commit message to 1/2.
Niklas Söderlund (2):
Revert "
: 5e7c623632fcf8f5 ("media: rcar-vin: use different v4l2 operations in
media controller mode")
Reported-by: Jacopo Mondi
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar
reverts commit 015060cb7795eac34454696cc9c9f8b76926a401.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-dma.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c
b/drivers/media/platform
: 5e7c623632fcf8f5 ("media: rcar-vin: use different v4l2 operations in
media controller mode")
Reported-by: Jacopo Mondi
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar
This reverts commit 015060cb7795eac34454696cc9c9f8b76926a401.
---
drivers/media/platform/rcar-vin/rcar-dma.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c
b/drivers/media/platform/rcar-vin/rcar-dma.c
index b41b
requested format resulting in the DMA engine not properly stopping
before writing outside the buffer.
This series reverts the incorrect fix in 1/2 and applies a correct one
in 2/2. I think this should be picked up for v4.18.
Niklas Söderlund (2):
Revert "media: rcar-vin: enable field tog
: Update AFE fixed pixel rate]
Signed-off-by: Niklas Söderlund
---
* Changes since v1
- Update AFE fixed pixel rate.
---
drivers/media/i2c/adv748x/adv748x-afe.c | 12 ++--
drivers/media/i2c/adv748x/adv748x-hdmi.c | 8 +---
2 files changed, 7 insertions(+), 13 deletions(-)
diff
Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 99 ---
1 file changed, 90 insertions(+), 9 deletions(-)
Hi Simon,
I have only tested i2c4 and the adv7482 which is connected there. But it
seemed silly to post this patch without enable all
Hi again,
On 2018-05-11 13:10:37 +0200, Niklas Söderlund wrote:
> Hi Jacopo,
>
> Thanks for your work.
>
> On 2018-05-11 11:59:40 +0200, Jacopo Mondi wrote:
> > The crop_scale routine uses the crop rectangle memebers to configure the
> > VIN clipping rectangle. When
Hi Jacopo,
Thanks for your work.
On 2018-05-11 12:00:01 +0200, Jacopo Mondi wrote:
> Describe VIN4 interface for R-Car D3 R8A77995 SoC.
>
> Signed-off-by: Jacopo Mondi
Acked-by: Niklas Söderlund
> ---
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++
>
Hi Jacopo,
Thanks for your work.
On 2018-05-11 12:00:00 +0200, Jacopo Mondi wrote:
> Add compatible string for R-Car D3 R8A7795 to list of SoCs supported by
> rcar-vin driver.
>
> Signed-off-by: Jacopo Mondi
Acked-by: Niklas Söderlund
> ---
> Documentation/devicet
/dev/$capture_vin --file=$out/frame-#.bin $*
>
> strings $out/frame*.bin | head | wc -l
> md5sum $out/frame*.bin
> -for f in $out/frame*.bin ; do $base/convert.sh $f $size ; done;
> +for f in $out/frame*.bin ; do $base/convert.sh $f $size $convert_format;
> done;
As state
Hi Jacopo,
Thanks for your work.
On 2018-05-11 12:00:39 +0200, Jacopo Mondi wrote:
> Accept the destination image format as thrid parameter of the convert
> function.
>
> Signed-off-by: Jacopo Mondi
Acked-by: Niklas Söderlund
> ---
> convert.sh | 3 ++-
> 1 file change
;m happy with the digital property in board.sh. Or maybe we
should start the renaming process of s/digital/parallel/ as it was a
really bad name on my behalf to begin with. In any case.
Acked-by: Niklas Söderlund
> ---
> gen3-links.sh | 14 ++
> 1 file changed, 10
e" 0 "$csi20name" 1 "$vin"
> }
> +
> +# HDMI input from ADV7612 (D3 Draak)
> +mc_propagate_hdmi_digital() {
> +vin="$1"
> +vdev=$($mediactl -d $mdev -e "$vin" )
> +
> +media-ctl -v -d $mdev -V "'$hdminame':1 [fmt:RGB888_1X24/640x480
> field:none]"
> +yavta -f XBGR32 -s 640x480 --field none $vdev
> +}
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
deo/video4linux/video*)
>
> +capture_vin="${vin0}"
> +
> vinname0="VIN0 output"
> vinname1="VIN1 output"
> vinname2="VIN2 output"
> @@ -121,6 +135,23 @@ case $info in
>
> txanam
rvin_write(vin, vin->crop.top, VNSLPRC_REG);
> - rvin_write(vin, vin->crop.top + vin->crop.height - 1,
> -VNELPRC_REG);
> + rvin_write(vin, height - 1, VNELPRC_REG);
> break;
> }
>
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
n_dev *vin)
> {
> int ret;
>
> - /* All our sources are CSI-2 */
> - vin->mbus_cfg.type = V4L2_MBUS_CSI2;
> - vin->mbus_cfg.flags = 0;
> -
> vin->pad.flags = MEDIA_PAD_FL_SINK;
> ret = media_entity_pads_init(&vin->vdev.entity, 1, &vin->pad);
> if (ret)
> diff --git a/drivers/media/platform/rcar-vin/rcar-vin.h
> b/drivers/media/platform/rcar-vin/rcar-vin.h
> index c2aef78..a63f3c6 100644
> --- a/drivers/media/platform/rcar-vin/rcar-vin.h
> +++ b/drivers/media/platform/rcar-vin/rcar-vin.h
> @@ -52,6 +52,19 @@ enum rvin_csi_id {
> };
>
> /**
> + * enum rvin_port_id
> + *
> + * List the available VIN port functions.
> + *
> + * RVIN_PORT_DIGITAL - Input port for digital video connection
> + * RVIN_PORT_CSI2- Input port for CSI-2 video connection
> + */
> +enum rvin_port_id {
> + RVIN_PORT_DIGITAL,
> + RVIN_PORT_CSI2
> +};
This enum is never used in the patch-set is it used later by a different
patch-set or a left over from refactoring?
> +
> +/**
> * STOPPED - No operation in progress
> * RUNNING - Operation in progress have buffers
> * STOPPING - Stopping operation
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
o be used. But for the change
itself.
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/platform/rcar-vin/rcar-core.c | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-core.c
> b/drivers/media/platform/rcar-vin/
Hi Laurent,
On 2018-05-05 12:48:58 +0300, Laurent Pinchart wrote:
> Hi Niklas,
>
> On Saturday, 5 May 2018 01:58:10 EEST Niklas Söderlund wrote:
> > On 2018-04-25 01:36:42 +0200, Niklas Söderlund wrote:
> > > On 2018-04-21 15:44:44 +0300, Laurent Pinchart wrote:
&
Hi Laurent,
On 2018-04-25 01:36:42 +0200, Niklas Söderlund wrote:
> Hi Laurent,
>
> Thanks for your patch.
>
> On 2018-04-21 15:44:44 +0300, Laurent Pinchart wrote:
> > The pixel rate, as reported by the V4L2_CID_PIXEL_RATE control, must
> > include both horizontal
Hi Dan,
Thanks for your report. A proposed fix to this is available [1],
awaiting inclusion in the media-tree :-)
1. https://patchwork.linuxtv.org/patch/49025/
On 2018-05-03 15:36:30 +0300, Dan Carpenter wrote:
> Hello Niklas Söderlund,
>
> The patch 3bb4c3bc85bf: "media: rcar-
fier: GPL-2.0
> > +/*
> > + * Driver for Renesas R-Car MIPI CSI-2 Receiver
> > + *
> > + * Copyright (C) 2018 Renesas Electronics Corp.
> > + */
[snip]
> > +MODULE_AUTHOR("Niklas Söderlund ");
> > +MODULE_DESCRIPTION("Renesas R-Car
al version of the driver. Fix
> it.
>
> Cc: Nobuhiro Iwamatsu
> Cc: Kieran Bingham
> Cc: Sergei Shtylyov
> Cc: Niklas Söderlund
> Cc: Wolfram Sang
> Signed-off-by: Laurent Pinchart
Acked-by: Niklas Söderlund
--
Regards,
Niklas Söderlund
Hi Laurent,
Thanks for your feedback.
On 2018-04-27 00:30:25 +0300, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Thursday, 26 April 2018 23:21:21 EEST Niklas Söderlund wrote:
> > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver
&
-by: Niklas Söderlund
Acked-by: Rob Herring
Acked-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
---
* Changes since v13
- Add Laurent's tag.
---
.../bindings/media/renesas,rcar-csi2.txt | 99 +++
MAINTAINERS | 1 +
2 files changed
_SOURCE;
+
+ ret = media_entity_pads_init(&priv->subdev.entity, NR_OF_RCAR_CSI2_PAD,
+priv->pads);
+ if (ret)
+ goto error;
+
+ pm_runtime_enable(&pdev->dev);
+
+ ret = v4l2_async_register_subdev(&priv->subdev);
+ if (ret < 0)
+ goto error;
+
+ dev_info(priv->dev, "%d lanes found\n", priv->lanes);
+
+ return 0;
+
+error:
+ v4l2_async_notifier_unregister(&priv->notifier);
+ v4l2_async_notifier_cleanup(&priv->notifier);
+
+ return ret;
+}
+
+static int rcar_csi2_remove(struct platform_device *pdev)
+{
+ struct rcar_csi2 *priv = platform_get_drvdata(pdev);
+
+ v4l2_async_notifier_unregister(&priv->notifier);
+ v4l2_async_notifier_cleanup(&priv->notifier);
+ v4l2_async_unregister_subdev(&priv->subdev);
+
+ pm_runtime_disable(&pdev->dev);
+
+ return 0;
+}
+
+static struct platform_driver __refdata rcar_csi2_pdrv = {
+ .remove = rcar_csi2_remove,
+ .probe = rcar_csi2_probe,
+ .driver = {
+ .name = "rcar-csi2",
+ .of_match_table = rcar_csi2_of_table,
+ },
+};
+
+module_platform_driver(rcar_csi2_pdrv);
+
+MODULE_AUTHOR("Niklas Söderlund ");
+MODULE_DESCRIPTION("Renesas R-Car MIPI CSI-2 receiver");
+MODULE_LICENSE("GPL");
--
2.17.0
l pads as this is needed by the new rcar-vin driver.
- Update DT bindings after review comments and to add r8a7796 support.
- Add get_fmt handler.
- Fix media bus format error s/YUYV8/UYVY8/
Changes since v1:
- Drop dependency on a pad aware s_stream operation.
- Use the DT bindings format "ren
Based on previous work by Ryo Kataoka .
Signed-off-by: Niklas Söderlund
---
Hi Simon,
The compatibility string 'renesas,r8a77965-thermal' is accepted but not
yet picked up, see '[PATCH v2 0/2] thermal: rcar_gen3_thermal: add
r8a77965 support'.
* Changes since v1
- Reb
Hi,
This series adds DT documentation and driver support to the
rcar-gen3-thermal driver for r8a77965.
See each patch for individual changelog.
Niklas Söderlund (2):
dt-bindings: thermal: rcar-gen3-thermal: add r8a77965
thermal: rcar_gen3_thermal: add r8a77965 support
.../devicetree
Based on previous work by Ryo Kataoka .
Signed-off-by: Niklas Söderlund
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Simon Horman
Reviewed-by: Rob Herring
---
* Changes since v1
- s/H3 and M3-W, M3-N/H3, M3-W and M3-N/
- Add review tags.
---
.../devicetree/bindings/thermal/rcar-gen3
Signed-off-by: Niklas Söderlund
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Simon Horman
---
drivers/thermal/rcar_gen3_thermal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/rcar_gen3_thermal.c
b/drivers/thermal/rcar_gen3_thermal.c
index 561a0a332208504a
Replace the hardcoded power domain indices by R8A77965_PD_* symbols.
Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 95 ---
1 file changed, 48 insertions(+), 47 deletions(-)
Hi Simon,
This is based on top of your trees devel branch from
of
> >> c18bb396d3d261eb ("Merge
> >> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net")
> >
> > I can confirm that with the patch bellow I can no longer produce the
> > problem. Thanks!
>
> Thanks for testing
> Do you mind if I add
>
Hi Geert,
Thanks for your feedback.
On 2018-04-25 09:25:56 +0200, Geert Uytterhoeven wrote:
> On Wed, Apr 25, 2018 at 1:45 AM, Niklas Söderlund
> wrote:
> > Store the group pointer before disassociating the VIN from the group.
>
> s/get/put/ in one-line summary?
Yes, sill
Hi Simon,
Thanks for your feedback.
On 2018-04-25 09:18:51 +0200, Simon Horman wrote:
> On Wed, Apr 25, 2018 at 01:45:06AM +0200, Niklas Söderlund wrote:
> > Store the group pointer before disassociating the VIN from the group.
> >
> > Fixes: 3bb4c3bc85bf77a7 ("
addressed and for the whole series:
Reviewed-by: Niklas Söderlund
>
> Signed-off-by: Simon Horman
> ---
> arch/arm/boot/dts/emev2-kzm9d.dts | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts
> b/arch/arm/boot/dts/emev2-kzm9
Hi Vincent,
Thanks for all your help.
On 2018-04-26 12:31:33 +0200, Vincent Guittot wrote:
> Hi Niklas,
>
> Le Thursday 26 Apr 2018 à 00:56:03 (+0200), Niklas Söderlund a écrit :
> > Hi Vincent,
> >
> > Here are the result, sorry for the delay.
> >
> >
e the capture
buffer.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-dma.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c
b/drivers/media/platform/rcar-vin/rcar-dma.c
index ac07f99e351
By setting VNMC_YCAL rcar-vin can support input video in
MEDIA_BUS_FMT_UYVY8_1X16 format.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-core.c | 1 +
drivers/media/platform/rcar-vin/rcar-dma.c | 5 +
2 files changed, 6 insertions(+)
diff --git a/drivers/media
Store the group pointer before disassociating the VIN from the group.
Fixes: 3bb4c3bc85bf77a7 ("media: rcar-vin: add group allocator functions")
Reported-by: Colin Ian King
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-core.c | 12 +++-
1 file
The compatible string "renesas,rcar-gen3-vin" was added before the
Gen3 driver code was added but it's not possible to use. Each SoC in the
Gen3 series require SoC specific knowledge in the driver to function.
Remove it before it is added to any device tree descriptions.
Signed
pixel rate for analog sources, mandated by the ADV748x to be
> 28.63636 MHz.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Niklas Söderlund
This patch uncovered a calculation error in rcar-csi2 which compensated
for the removing of the blanking in the adv748x, thanks for that! Goo
Hi Rob,
On 2018-04-24 09:28:41 -0500, Rob Herring wrote:
> On Tue, Apr 17, 2018 at 10:49:58PM +0200, Niklas Söderlund wrote:
> > From: Niklas Söderlund
> >
> > The datasheet have been expanded with more registers and the DT files
> > have been updated with the new si
From: Niklas Söderlund
Based on previous work by Ryo Kataoka .
Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 59 +++
1 file changed, 59 insertions(+)
Hi Simon,
This patch depends on '[PATCH 0/2] thermal: rcar_gen3_thermal: add
r8a
From: Niklas Söderlund
Signed-off-by: Niklas Söderlund
---
drivers/thermal/rcar_gen3_thermal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/rcar_gen3_thermal.c
b/drivers/thermal/rcar_gen3_thermal.c
index 561a0a332208504a..c04182e1518cd613 100644
--- a/drivers/thermal
From: Niklas Söderlund
Hi,
This series adds DT documentation and driver support to the
rcar-gen3-thermal driver for r8a77965.
Niklas Söderlund (2):
dt-bindings: thermal: rcar-gen3-thermal: add r8a77965
thermal: rcar_gen3_thermal: add r8a77965 support
.../devicetree/bindings/thermal/rcar
From: Niklas Söderlund
Based on previous work by Ryo Kataoka .
Signed-off-by: Niklas Söderlund
---
.../devicetree/bindings/thermal/rcar-gen3-thermal.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3
From: Niklas Söderlund
Hi,
This series updates the constants used to convert the register values to
degrease. It is based on feedback from the hardware team communicated
through BSP patches and updated datasheets. :-)
Hien Dang (1):
thermal: rcar_gen3_thermal: Update calculation formula
From: Niklas Söderlund
Change the upper limit to clamp the high temperature value to 120C when
setting trip points.
Signed-off-by: Niklas Söderlund
---
drivers/thermal/rcar_gen3_thermal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal
From: Hien Dang
Due to hardware evaluation result,
Max temperature is changed from 96 to 116 degree Celsius.
Also, calculation formula and pseudo FUSE values are changed accordingly.
Signed-off-by: Dien Pham
Signed-off-by: Hien Dang
Signed-off-by: Niklas Söderlund
---
drivers/thermal
From: Niklas Söderlund
Hi Simon,
This series decrease the hysteresis from 2C to 1C for the two boards we
have described upstream. They have no dependencies and are ready to be
accepted if the review is in favor of them.
Niklas Söderlund (2):
arm64: dts: renesas: r8a7795: decrease
From: Niklas Söderlund
To incorporate more tests by the hardware team decrease the hysteresis
value to 1C.
Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas
From: Niklas Söderlund
To incorporate more tests by the hardware team decrease the hysteresis
value to 1C.
Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas
From: Niklas Söderlund
The datasheet have been expanded with more registers and the DT files
have been updated with the new size. This change updates the example so
writing new DT files can use the enchanted driver which uses the new
registers.
Signed-off-by: Niklas Söderlund
Hi Jacopo,
On 2018-04-16 01:16:35 +0200, Niklas Söderlund wrote:
[snip]
> > > +
> > > + /* Set frequency range if we have it */
> > > + if (priv->info->csi0clkfreqrange)
> > > + rcar_csi2_write(priv, CSI0CLKFCPR_REG,
> > > +
ne (VIN?) would
have to parse the full graph in DT and somehow with subdevice support
helpers to traverse the DT port to MC pad mapping using helpers that do
not exist yet (and are hard to use if the remote subdevice driver is not
loaded) to build a full view of the pipeline and return -EPIPE if not
all entities are present in the media graph :-)
[snip]
> > +static int rcar_csi2_parse_v4l2(struct rcar_csi2 *priv,
> > + struct v4l2_fwnode_endpoint *vep)
> > +{
> > + unsigned int i;
> > +
> > + /* Only port 0 endpoint 0 is valid */
> > + if (vep->base.port || vep->base.id)
> > + return -ENOTCONN;
> > +
> > + if (vep->bus_type != V4L2_MBUS_CSI2) {
> > + dev_err(priv->dev, "Unsupported bus: 0x%x\n", vep->bus_type);
> > + return -EINVAL;
> > + }
> > +
> > + priv->lanes = vep->bus.mipi_csi2.num_data_lanes;
> > + if (priv->lanes != 1 && priv->lanes != 2 && priv->lanes != 4) {
>
> Is this an HW limitation? Like the 'data_lanes' comment, if it is,
> shouldn't you mention in bindings that the accepted lane numbers is
> limited to the [1,2,4] values.
Yes, see chapter 25.4.8 Lane Setting.
[snip]
>
> No serious issues though. So when fixed/clarified feel free to append my
> Reviewed-by tag, if relevant at all.
Thanks! I feel I managed to address all of your review comments but
would still like your confirmation for me to add your tag. Thanks again
for the review!
--
Regards,
Niklas Söderlund
> > + return 0;
> > +
> > +error:
> > + v4l2_async_notifier_unregister(&priv->notifier);
> > + v4l2_async_notifier_cleanup(&priv->notifier);
> > +
> > + return ret;
> > +}
>
> [snip]
>
> With these small issues fixed and Kieran's and Maxime's comments addressed as
> you see fit,
>
> Reviewed-by: Laurent Pinchart
Thanks, I will hold of adding it until you indicate if you are OK with
the one comment I'm not fully agreeing with you on.
--
Regards,
Niklas Söderlund
and I no longer need to write to a register.
3. In remove() I call pm_runtime_disable().
Am I missing something obvious here?
--
Regards,
Niklas Söderlund
> phycnt |= (1 << priv->lanes) - 1;
>
> If Niklas is fine with that, I like it too.
I'm fine what that thanks for the suggestion Geert!
--
Regards,
Niklas Söderlund
Hi Maxime,
Thanks for your feedback.
On 2018-03-29 13:30:39 +0200, Maxime Ripard wrote:
> Hi Niklas,
>
> On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote:
> > + switch (priv->lanes) {
> > + case 1:
> > + phycnt = PHYC
0..c0c2a763151bc928
> > > --- /dev/null
> > > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> > > @@ -0,0 +1,884 @@
> > > +// SPDX-License-Identifier: GPL-2.0+
>
> Do you intend making it GPL-2.0+ or did you mean GPL-2.0 ?
Wops I intended to make it GPL-2.0 thanks for catching this.
--
Regards,
Niklas Söderlund
Hi Kieran,
Thanks for your feedback.
On 2018-03-13 23:23:49 +0100, Kieran Bingham wrote:
> Hi Niklas
>
> Thank you for this patch ...
> I know it has been a lot of work getting this and the VIN together!
>
> On 13/02/18 00:01, Niklas Söderlund wrote:
> > A V4L2 drive
Add the SoC specific information for Renesas r8a77970.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/rcar-core.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/media/platform
Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/Kconfig | 2 +-
drivers/media/platform/rcar-vin/rcar-core.c | 120
Add the SoC specific information for Renesas r8a7796.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/rcar-core.c | 44 +
1 file changed, 44 insertions(+)
diff --git a/drivers/media
le a new link
due to hardware constrains the link_notifier callback will return
-EMLINK.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
* Changes since v12
- Add review tag from Laurent.
* Changes since v11
- Fixed spelling
- Updated comment to cla
The procedure to start or stop streaming using the non-MC single
subdevice and the MC graph and multiple subdevices are quite different.
Create a new function to abstract which method is used based on which
mode the driver is running in and add logic to start the MC graph.
Signed-off-by: Niklas
the notifier belonging to the last probed VIN.
Once all CSI-2 subdevices in this notifier are bound proceed to register
all VIN video devices of the group and crate media device links between
all CSI-2 and VIN entities according to the SoC specific routing
configuration.
Signed-off-by: Niklas
The rcar-vin driver needs to be part of a media controller to support
Gen3. Give each VIN instance a unique name so it can be referenced from
userspace.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 2
data structure and registers a media device.
Consecutive VINs insert themself into the global group.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/rcar-core.c | 174 +++-
drivers/media/platform
Each Gen3 SoC has a limited set of predefined routing possibilities for
which CSI-2 device and channel can be routed to which VIN instance.
Prepare to store this information in the struct rvin_info.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
comment.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 20 ++--
drivers/media/platform/rcar-vin/rcar-vin.h | 4
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers
fixed values.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c
b/dr
without directly
interacting with the source subdevice.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
* Changes since v13
- Add review from Laurent.
* Changes since v11
- Fixed error labels name in rvin_mc_open().
---
drivers/media/platform/rcar
struct
rvin_info which will control which mode to use.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 6 +-
drivers/media/platform/rcar-vin/rcar-vin.h | 2 ++
2 files changed, 7 insertions(+), 1
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
---
* Changes since v13
- Do not set the VNCSI_IFMD_DES2 bit in the VNCSI_IFMD register as that
bit have been removed from later versions of the datasheet.
---
drivers/media/platform/rcar-vin/rcar-
Bus configuration will once the driver is extended to support Gen3
contain information not specific to only the directly connected parallel
subdevice. Move it to struct rvin_dev to show it's not always coupled
to the parallel subdevice.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Ve
401 - 500 of 1858 matches
Mail list logo
