Re: [PATCH] gpio: Add helpers to determin direction of gpiods

2017-12-13 Thread Wolfram Sang
> > You need to fix the kerneldoc for 'gpiod_get_direction", too. It still > > mentions GPIOF_DIR_*. > > More places? I can't find them! drivers/gpio/gpiolib.c Line 198 in both 4.15-rc3 and linux-next. Or as I said, the kerneldoc of gpiod_get_direction ;) > Together with Geert's comments I

Re: [PATCH] gpio: Add helpers to determin direction of gpiods

2017-12-13 Thread Linus Walleij
On Tue, Dec 12, 2017 at 11:42 PM, Wolfram Sang wrote: >> Documentation/gpio/consumer.txt | 14 +++--- > > You need to fix the kerneldoc for 'gpiod_get_direction", too. It still > mentions GPIOF_DIR_*. More places? I can't find them! I thought the patch removed that

Re: [PATCH] gpio: Add helpers to determin direction of gpiods

2017-12-12 Thread Wolfram Sang
Hey Linus, thanks for doing this. On Sun, Dec 10, 2017 at 01:23:40AM +0100, Linus Walleij wrote: > The gpiod_get_direction() returns 1 for input and 0 for output > but it's pretty hard to remember which one is which and generally > unintuitive and messy to provide #defines so let's simply add >