nel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v5.2-tag1
>
> for you to fetch changes up to 0a042b355e60269ad30725b5b5ca68fc5371a8df:
>
> pinctrl: sh-pfc: r8a77965: Add I2C{0,3,5} pins, groups and functions
> (2019-04-04 12:02:50 +0200)
Pulled into my devel branch for v5
27;s your pick.
If you send me a pull request pronto I will pull it in.
Yours,
Linus Walleij
-by and ACKs
- Fold in Hoan's fix
- Resend
We are always a bit fuzzy around the edges with carrying ACKs etc
forward for new revisions. Surely that is fine with this minor
revision for ACPI.
Yours,
Linus Walleij
3-N support has been merged for v4.17.
> Document the missing device tree bindings.
>
> v1 -> v2:
> - Add Simon and Rob Reviewed-by tags
Patch applied.
Yours,
Linus Walleij
On Thu, Apr 19, 2018 at 4:05 PM, Wolfram Sang
wrote:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang
Acked-by: Linus Walleij
Sorry for slow reply.
Yours,
Linus Walleij
t;
> Signed-off-by: Wolfram Sang
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
g
>> ---
>>
>> Build tested only. buildbot is happy. Please apply individually.
>
>
> for gpio-omap.c:
> Reviewed-by: Grygorii Strashko
Hm I only see the responses not the actual patch, I guess I will find it
sooner or later.
Wolfram: if I don't find it, poke me with something sharp so I get to apply it.
Yours,
Linus Walleij
r single interrupt hardware.
>
> ACPI companion code provided by Hoan Tran . This was tested
> on X-Gene by Hoan.
>
> Signed-off-by: Phil Edworthy
> Reviewed-by: Rob Herring
> Acked-by: Lee Jones
Patch applied for v4.18 with Hoan's ACK.
Yours,
Linus Walleij
:54 +0200)
Pulled into the pinctrl devel branch and pushed to the testbuilders!
Thanks a lot for the excellent work (as usual from Renesas!)
Yours,
Linus Walleij
On Fri, May 11, 2018 at 5:13 AM, Yoshihiro Shimoda
wrote:
> Add compatible string for R-Car E3 (r8a77990) in gpio-rcar.
>
> Signed-off-by: Yoshihiro Shimoda
Quite uncontroversial so, patch applied with Simon's
ACK.
Yours,
Linus Walleij
eds changing?
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=devel&id=e6ca26abd37606ba4864f20c85d3fe4a2173b93f
Sorry for not knowing by heart what was applied or when, it's
just too much for me sometimes.
Yours,
Linus Walleij
also fixes a problem introduced with error checking when calling
> platform_get_irq().
>
> Signed-off-by: Phil Edworthy
OK this patch applied!
Yours,
Linus Walleij
4:43:49 +0200)
Pulled into my "devel" branch for v4.18, thanks!
Yours,
Linus Walleij
; adding support for 1 interupt per port A GPIO. v5 was applied, then some
> other feedback came afterwards.
>
> However, in my haste I managed to drop the changes made to dwapb_port_property
> struct. This patch includes those missing changes.
>
> Signed-off-by: Phil Edworthy
Patch applied!
Yours,
Linus Walleij
Fixes: b7e78170efd4 ("PCI: versatile: Add DT-based ARM Versatile PB PCIe host
> driver")
> Fixes: 5f6b6ccdbe1c ("PCI: xgene: Add APM X-Gene PCIe driver")
> Fixes: 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller
> support")
> Signed-off-by: Sergei Shtylyov
> Cc: sta...@vger.kernel.org
Nice, clean and thorough fix!
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
issipate power throught the pull-up resistor), so please queue
this as a fix and also tag for stable.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
ENGTH from all pins.
>
> Fixes: b92ac66a1819602b ("pinctrl: sh-pfc: Add R8A77970 PFC support")
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Simon Horman
> Reviewed-by: Sergei Shtylyov
> Reviewed-by: Geert Uytterhoeven
Patch applied directly for fixes per Geert's suggestion.
Yours,
Linus Walleij
ranch, thanks for excellent work as usual!
Yours,
Linus Walleij
On Thu, Jul 12, 2018 at 11:31 AM Geert Uytterhoeven
wrote:
> Allow gpiolib to read back the current I/O direction configuration by
> implementing the .get_direction() callback.
>
> Signed-off-by: Geert Uytterhoeven
Patch applied with the tags!
Yours,
Linus Walleij
On Mon, Jul 23, 2018 at 10:26 PM Wolfram Sang
wrote:
> And don't reimplement in the driver.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
On Wed, Jul 25, 2018 at 10:20 PM Wolfram Sang wrote:
> > That all being said, I think this patch is still useful as is.
>
> Linus, do you have time to comment on this?
This looks like a good solution to me.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
o-reserved-ranges: See gpio.txt
Maybe you could add an extra example using the reserved ranges?
Yours,
Linus Walleij
uires every driver in the kernel to pass in a valid parent device
representing the OF node. And there are so many hairy corner cases
where they don't.
Yours,
Linus Walleij
On Tue, Aug 7, 2018 at 9:21 AM Biju Das wrote:
> Add a check for unused gpios to avoid chip->request() call to client
> driver for unused gpios.
>
> Signed-off-by: Biju Das
> Reviewed-by: Fabrizio Castro
Patch applied with Geert's ACK.
Yours,
Linus Walleij
On Mon, Aug 13, 2018 at 3:58 PM Biju Das wrote:
> This patch series aims to add PFC support for RZ/G2M SoC.
Looks good to me, Geert will queue the patches when he's happy.
Yours,
Linus Walleij
by: Biju Das
Patch applied with Geert's review tag.
Yours,
Linus Walleij
On Tue, Aug 7, 2018 at 10:03 AM Biju Das wrote:
> Update the DT bindings documentation with the optional gpio-reserved-ranges
> properties.
>
> Signed-off-by: Biju Das
> Reviewed-by: Fabrizio Castro
Patch applied with the ACKs.
Yours,
Linus Walleij
nel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v4.20-tag1
>
> for you to fetch changes up to 2ed03c835d6f4dbe9f0d093187825d1c0e2e9b39:
>
> pinctrl: sh-pfc: r8a77990: Add DU pins, groups and function (2018-08-30
> 14:17:20 +0200)
Pulled into pinctrl "devel" branch, thanks!
Yours,
Linus Walleij
On Sun, Jan 21, 2018 at 1:12 PM Wolfram Sang
wrote:
> The ';' was missing. And cosmetic: there was a space too much.
>
> Signed-off-by: Wolfram Sang
> Reviewed-by: Niklas Söderlund
> ---
>
> No changes since V2, only Niklas' tag added.
Patch applied with Geert's ACK.
Yours,
Linus Walleij
On Tue, Sep 11, 2018 at 2:04 PM Geert Uytterhoeven wrote:
> On Sun, Jul 29, 2018 at 11:33 PM Linus Walleij
> wrote:> > On Wed, Jul 25, 2018 at 10:20 PM Wolfram Sang
> wrote:
> > > > That all being said, I think this patch is still useful as is.
> > >
>
On Fri, Sep 21, 2018 at 5:41 PM Biju Das wrote:
> Renesas RZ/G1N (R8A7744) SoC GPIO blocks are identical to the R-Car Gen2
> family. Add support for its GPIO controllers.
>
> Signed-off-by: Biju Das
> Reviewed-by: Fabrizio Castro
Patch applied with the ACKs.
Yours,
Linus Walleij
-28 09:49:15 +0200)
Pulled into my "devel" branch now, thanks!
Yours,
Linus Walleij
tory at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v4.20-tag3
>
> for you to fetch changes up to ef26d96023a4c34b1bcc4294f570df2b63a1b952:
Pulled into the pinctrl "devel" branch, thanks!
Yours,
Linus Walleij
?
Sadly there is sometimes more than one way to do things
around here :/
Geert will know what is best.
Yours,
Linus Walleij
Acked-by: Linus Walleij
Yours,
Linus Walleij
>
> Signed-off-by: Geert Uytterhoeven
Patch applied.
Yours,
Linus Walleij
early, instead of
> jumping to an out-of-sight label.
>
> Signed-off-by: Geert Uytterhoeven
Patch applied.
Yours,
Linus Walleij
nstead.
Yours,
Linus Walleij
nel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v5.3-tag1
>
> for you to fetch changes up to 992968d78626031a264d847e25f8f9810b9a1b50:
>
> pinctrl: sh-pfc: Remove obsolete SH_PFC_PIN_NAMED*() macros (2019-06-04
> 11:19:25 +0200)
Pulled to my "devel" branch as
e what to do with this.
Can all the pinctrl patches be applied independently of the other
changes so Geert can apply and send me those patches in his pull
requests?
Yours,
Linus Walleij
nel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v5.4-tag1
>
> for you to fetch changes up to 625efea83a7c37d281c6a90526813a1366929d24:
>
> pinctrl: rza1: Use devm_platform_ioremap_resource() helper (2019-08-09
> 09:34:45 +0200)
Pulled into my "devel" branch, thanks!
Yours,
Linus Walleij
pinctrl "devel" branch, thanks!
Yours,
Linus Walleij
ed for v5.4 with the ACKs.
Yours,
Linus Walleij
On Wed, Oct 16, 2019 at 10:07 PM Rob Herring wrote:
> Convert V3 host bridge to use the common
> pci_parse_request_of_pci_ranges().
>
> Cc: Linus Walleij
> Cc: Lorenzo Pieralisi
> Cc: Andrew Murray
> Cc: Bjorn Helgaas
> Signed-off-by: Rob Herring
> ---
> v2:
temporary list handling.
>
> Cc: Lorenzo Pieralisi
> Cc: Bjorn Helgaas
> Signed-off-by: Rob Herring
> ---
> v2:
> - Fix 'mem' initial value to 1
> - Remove temporary resource list
Acked-by: Linus Walleij
Yours,
Linus Walleij
elgaas
> Signed-off-by: Rob Herring
> ---
> v2:
> - New patch to fix build failure on some arches.
Always wondered how to do this right, now I can fix other stuff!
Acked-by: Linus Walleij
Yours,
Linus Walleij
> Cc: Lorenzo Pieralisi
> Cc: Bjorn Helgaas
> Signed-off-by: Rob Herring
Acked-by: Linus Walleij
Yours,
Linus Walleij
lisi
> Cc: Bjorn Helgaas
> Reviewed-by: Andrew Murray
> Signed-off-by: Rob Herring
Acked-by: Linus Walleij
Yours,
Linus Walleij
d into the pinctrl devel branch, thanks!
Yours,
Linus Walleij
t; i, &pinfunc);
> ...
It makes sense. Just make sure to move users over to use the helpers.
Yours,
Linus Walleij
formal with DT bindings. The GPIO bindings are just over the top
with BNF notation in its formalism. Dunno what is best here :/
Yours,
Linus Walleij
nput and output buffers have to be manually enabled.
>
> output-enable is just syntactic sugar to specify that a pin shall
> operate in output mode, ignoring the provided argument.
> This pairs with input-enable pin configuration option.
>
> Signed-off-by: Jacopo Mondi
Patch appl
e for a merge in the early
v4.12 kernel cycle.
Yours,
Linus Walleij
> Cc: linux-g...@vger.kernel.org
> Cc: Geert Uytterhoeven
> Cc: Linus Walleij
(...)
> +#include
Only use
#include
It should be enough.
With that:
Reviewed-by: Linus Walleij
I guess you plan to merge this through MFD?
Yours,
Linus Walleij
://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v4.12-tag3
>
> for you to fetch changes up to 5f4c8cafe1148f8a91287072815df8f0b66f0e5c:
>
> pinctrl: sh-pfc: r8a7794: Swap ATA signals (2017-04-05 09:41:29 +0200)
Thanks, pulled into my devel branch for v4.12.
Yours,
Linus Walleij
> Cc: linux-g...@vger.kernel.org
> Cc: Geert Uytterhoeven
> Cc: Linus Walleij
> Reviewed-by: Linus Walleij
> ---
> V2: Use linux/gpio/driver.h instead of linux/gpio.h
Reviewed-by: Linus Walleij
Are you merging this through MFD?
Yours,
Linus Walleij
> Cc: linux-g...@vger.kernel.org
> Cc: Geert Uytterhoeven
> Cc: Linus Walleij
> Reviewed-by: Linus Walleij
> ---
> V2: Use linux/gpio/driver.h instead of linux/gpio.h
I applied this for v4.12 to bring down the number of deps in
v4.13. The guarding symbol makes it not compile
+#define PIN_CONF_UNPACK(pinconf) ((pinconf) & 0xffUL)
>
> Perhaps this should be moved to pinconf-generic.h, to make sure it stays
> up-to-date?
I agree. Use the generic macros.
If further processing is needed, make a static inline to discard config flags
etc.
Yours,
Linus Walleij
config & 0xffUL);
}
static inline u32 pinconf_to_config_argument(unsigned long config)
{
return (u32) ((config >> 8) & 0xffUL);
}
Why can't you use this in your code instead of macros?
We generally prefer static inlines over macros because they are easier
to read.
Yours,
Linus Walleij
Z?
Hopefully you can find the answer from Renesas hardware dept.
You can certainly call it whatever the datasheet calls it
in your driver #defines but for the DT bindings we would
ideally have the physical world things.
Yours,
Linus Walleij
ly someone inside Renesas can answer this question.
Yours,
Linus Walleij
things. For example we have
a linux,input binding for connecting keypresses to certain Linux input
codes. That is really grayzone, but very useful.
Yours,
Linus Walleij
oticed when sending pull requests.. let's see if it stays in or
I will have to revert it for more discussion.
Sorry for being so flimsy at times, I guess I'm overloaded.
Yours,
Linus Walleij
On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko
wrote:
> Linus, for me it looks like better to revert that change, until we
> will have clear picture why existing configuration parameters can't
> work.
Yeah I'll revert the binding for fixes.
Yours,
Linus Walleij
as,bi-directional;
renesas,output-enable;
following the Qualcomm pattern in that case.
But let's see if something else comes out of this discussion.
Yours,
Linus Walleij
On Fri, May 5, 2017 at 2:45 PM, Chris Brandt wrote:
> On Friday, May 05, 2017, Linus Walleij wrote:
>> > This is the part of the whole "DT is for hardware description only" that
>> doesn't really make sense to me.
>>
>> OK yeah we do hardware descrip
and should use a DT property.
Yours,
Linus Walleij
gone in the next hardware generation, right?
Then the right place for it is in the quirky driver for the quirky
first-generation
hardware.
Yours,
Linus Walleij
I'm just overloaded. I sent that revert to Torvalds today.
> I can send another version of that patch with
> only 'output-enable' if you wish.
That's what we want.
> Once we reach consesus, I can then send v6 of our pin controller driver
> based on that.
OK sounds like a plan.
Sorry for the mess, I'm just trying to get this right :/
Yours,
Linus Walleij
Pulled to my pinctrl devel branch.
Yours,
Linus Walleij
having to make a decision. In
particular, if somebody tells you "choose (a) or (b), we really need you
to decide on this", you're in trouble as a manager. The people you
manage had better know the details better than you, so if they come to
you for a technical decision, you're screwed. You're clearly not
competent to make that decision for them.
(It goes on, it's the best part of the entire Documentation/* dir in my
opinion, please take the time to read it in full.)
So: what do you guys, using this feature, and Andy, who raised serious
concerns, think is the right binding? That is what *I* need to know.
Yours,
Linus Walleij
"RZ-G1M" to "RZ/G1M"
Patch applied with the ACKs.
Yours,
Linus Walleij
f the line as a whole.
We might need even more documentation because this is really
confusing.
But for now it lets drivers work, which is nice.
Rough consensus and running code should be our guide.
Yours,
Linus Walleij
lled in for devel.
It's late, but you all worked hard to make this happen so we should
be liberal, also it is a new driver.
Yours,
Linus Walleij
n an error code,
> but returns NULL on failure.
>
> However, as devm_ioremap_resource() verifies the validity of the passed
> resource pointer anyway, the check can just be removed.
>
> Reported-by: Stephen Rothwell
> Fixes: 5a49b644b3075f88 ("pinctrl: Renesas RZ/A1 pin and gpio controller")
> Signed-off-by: Geert Uytterhoeven
Patch applied.
Yours,
Linus Walleij
gt; Also deprecate renesas,gpio-rcar as its name is more generic than its
> implementation.
>
> Signed-off-by: Simon Horman
Totally uncontroversial DT binding changes so patch applied for next
with Geert's review tag.
Yours,
Linus Walleij
fc-for-v4.14.
All look good to me.
Yours,
Linus Walleij
he's happy with them.
Yours,
Linus Walleij
On Tue, Jul 18, 2017 at 11:43 PM, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring
> Cc: L
it.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v4.10-tag1
Pulled to my devel branch.
Thanks!
Yours,
Linus Walleij
we generally need a way to access LEDs as resources with
foo-leds = <&led_foo>; in the device tree just like we can get GPIOs and I
hope someone is working on that for this thing... triggers is such a hack.
Yours,
Linus Walleij
le in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v4.10-tag2
Pulled into the pin control tree, thanks a lot!
Yours,
Linus Walleij
itable here.
I fixed the patch in-tree to use ARCH_EMEV2 instead.
Thanks!
Yours,
Linus Walleij
is fine. I'm a bit dubious about [1] given that it consumes more CPU
> cycles without any benefit as far as I can see. Maybe I can't see far enough
> though, Linus Walleij could prove me wrong :-)
This was changed mainly for maintainability and code readability.
Lots of subsystems have
Patch applied with the ACKs.
Yours,
Linus Walleij
r SD-Card CD & WP, gpio7 for keys and regulators).
>
> Signed-off-by: Geert Uytterhoeven
> [Niklas: s/gpio_to_priv(chip)/gpiochip_get_data(chip)/]
> Signed-off-by: Niklas Söderlund
Patch applied.
Yours,
Linus Walleij
p_add(gpio_chip);
Use devm_gpiochip_add_data() providing struct rz_gpio_priv * as
data.
> +static int rz_gpio_remove(struct platform_device *pdev)
> +{
> + struct rz_gpio_priv *p = platform_get_drvdata(pdev);
> +
> + gpiochip_remove(&p->gpio_chip);
> + return 0;
> +}
And with the devm_gpiochip_add_data() you don't even need
this remove().
Yours,
Linus Walleij
al flags.
> Or do you guys have any better ideas?
Not really. So you mean revert the previous patch and apply something
like this instead?
Yours,
Linus Walleij
viewing the old version.
Oh well. The comments still apply.
Yours,
Linus Walleij
it.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
> tags/sh-pfc-for-v4.11-tag1
>
> for you to fetch changes up to 0e4e4999aac16641f47699e8929693b83a7a4d64:
Pulled this in and pushed the branch to the build servers,
thanks!
Yours,
Linus Walleij
LL, p->io[REG_PM], 0);
if (ret)
return ret;
This might need some flags or I screwed something up, but I'm
convinced you can use GENERIC_GPIO like this.
The generic accessors also sets the value before switching
direction.
If you're uncertain about the sematics, read drivers/gpio/gpio-mmio.c.
> + gpio_chip->request = rz_gpio_request;
> + gpio_chip->free = rz_gpio_free;
> + gpio_chip->label = dev_name(&pdev->dev);
> + gpio_chip->parent = &pdev->dev;
> + gpio_chip->owner = THIS_MODULE;
> + gpio_chip->base = -1;
> + gpio_chip->ngpio = ret == 0 ? args.args[2] : RZ_GPIOS_PER_PORT;
bgpio_init() will have already set this up to 16 (RZ_GPIOS_PER_PORT)
as we pass width 2 bytes.
Yours,
Linus Walleij
On Wed, Jan 18, 2017 at 3:06 PM, Geert Uytterhoeven
wrote:
> Hi Linus,
>
> On Wed, Jan 18, 2017 at 2:58 PM, Linus Walleij
> wrote:
>>> + gpio_chip->request = rz_gpio_request;
>>> + gpio_chip->free = rz_gpio_free;
>>> +
On Thu, Jan 19, 2017 at 10:36 AM, Geert Uytterhoeven
wrote:
> On Thu, Jan 19, 2017 at 10:27 AM, Linus Walleij
> wrote:
>> On Wed, Jan 18, 2017 at 3:06 PM, Geert Uytterhoeven
>> wrote:
>>> On Wed, Jan 18, 2017 at 2:58 PM, Linus Walleij
>>> wro
ree in a nice
way, which makes it relevant for him to have a look as well, if he has
time.
Yours,
Linus Walleij
100)
Pulled into the pinctrl devel branch for v4.11.
Yours,
Linus Walleij
urs,
Linus Walleij
my devel branch in the pinctrl tree.
Thanks!
Linus Walleij
signed int
> selector,
> + unsigned int group)
Please name it rza1_set_mux() to correspond with the ops field.
Yours,
Linus Walleij
ay "ah I know this".
The fact that historically all the early adopters of pinctrl in device tree
have these funky custom bindings is unfortunate but just something
that we need to live with.
Yours,
Linus Walleij
l to move it into a new subdir if many
new drivers start popping in anyway.
Right now I see the use of renesas,pins as the only big blocker,
I would much like it to use just pins = <>;
Yours,
Linus Walleij
101 - 200 of 277 matches
Mail list logo
